Uh oh!
There was an error while loading. Please reload this page.
UI: Add Expand/Collapse all to XComs page - #56083
Merged
pierrejeambrun merged 4 commits intoOct 1, 2025
Merged
Conversation
KatalKavya96
requested review from
bbovenzi, jscheffl, pierrejeambrun, ryanahamilton and shubhamraj-git
as code ownersSeptember 24, 2025 22:24
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
KatalKavya96
commented
Sep 26, 2025
ContributorAuthor
@RoyLee1224 Sure i will re apply all changes that are unrelated and removed. Thanks for the review |
Uh oh!
There was an error while loading. Please reload this page.
bbovenzi
approved these changes
Sep 29, 2025
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 1, 2025
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes (cherry picked from commit 9c96500) Co-authored-by: Kavya Katal <KAVYAKATAL09@GMAIL.COM>
Contributor
Backport successfully created: v3-1-test
|
pierrejeambrun pushed a commit
that referenced
this pull request
Oct 1, 2025
KatalKavya96
commented
Oct 1, 2025
ContributorAuthor
Thanks a lot @bbovenzi , @pierrejeambrun , and @RoyLee1224 for reviewing and giving your time on this PR. Really appreciate the feedback and guidance that helped get this in smoothly. |
dabla pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
* UI: Add Expand/Collapse all to XComs page * Restored few changes * Fixing lint issue * Made suggested Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI: Restore “Expand/Collapse all” on XComs page
closes: #56061
What’s changed
Added Expand all / Collapse all controls to the XComs page toolbar, matching the Audit Logs page.
Plumbed a boolean open state (via Chakra’s useDisclosure) into the XComs table and forwarded it to each row’s value renderer.
Updated XComEntry to accept an optional open prop and pass collapsed: !open to RenderedJsonField so JSON objects/arrays expand or collapse globally.
Kept scalar values rendering as plain text; added lightweight URL auto-linking for better readability.
Rationale
Implementation notes
No API or backend changes.
Reused existing i18n keys from Audit Logs for button labels (auditLog.actions.expandAllExtra, auditLog.actions.collapseAllExtra).
No changes to table sorting, pagination, or filters.
Demo Video
Screen.Recording.2025-09-25.at.3.52.47.AM.mov