Skip to content

UI: Fix Grid for cleared runs when tasks were removed - #56085

Merged
bbovenzi merged 1 commit into
apache:mainfrom
astronomer:fix-grid-removed-ti-visibility
Oct 1, 2025
Merged

UI: Fix Grid for cleared runs when tasks were removed#56085
bbovenzi merged 1 commit into
apache:mainfrom
astronomer:fix-grid-removed-ti-visibility

Conversation

@ephraimbuddy

@ephraimbuddyephraimbuddy commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Ensure removed/historical tasks from selected runs are visible in Grid even if they no longer exist in the current DAG version.

We now:

  • Include synthetic leaf nodes for task_ids present in TIs but missing from the serialized DAG in both grid/structure and grid/ti_summaries.
  • Aggregate TI states for these synthetic nodes

Add tests covering structure and TI summaries for removed tasks.

Screenshot 2025-09-25 at 00 40 03

@boring-cyborgboring-cyborgBot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Sep 24, 2025
@ephraimbuddy
ephraimbuddyforce-pushed the fix-grid-removed-ti-visibility branch 2 times, most recently from eddaea7 to 9aa8e19CompareSeptember 25, 2025 07:38
ephraimbuddy
ephraimbuddy commented Sep 25, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/core_api/routes/ui/grid.py
@ephraimbuddy

ephraimbuddy commented Sep 25, 2025

Copy link
Copy Markdown
ContributorAuthor

Here, the entire tasks were renamed and cleared to rerun. Now UI shows complete story of that in grid too
Screenshot 2025-09-25 at 10 07 16

@ephraimbuddy
UI: Fix Grid for cleared runs when tasks were removed
f107472
Ensure removed/historical tasks from selected runs are visible in
Grid even if they no longer exist in the current DAG version.
We now:
- Include synthetic leaf nodes for task_ids present in TIs but
missing from the serialized DAG in both grid/structure and grid/ti_summaries.
- Aggregate TI states for these synthetic nodes
Add tests covering structure and TI summaries for removed tasks.
@ephraimbuddy
ephraimbuddyforce-pushed the fix-grid-removed-ti-visibility branch from 9aa8e19 to f107472CompareSeptember 30, 2025 12:45
dstandish
dstandish reviewed Sep 30, 2025
View reviewed changes
Comment threadairflow-core/src/airflow/api_fastapi/core_api/routes/ui/grid.py
@dstandish

dstandish commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Just curious, how do we end up with tasks not in serdag now? In airlfow 3 seems should not really be possible?

@pierrejeambrun

pierrejeambrun commented Oct 1, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Just curious, how do we end up with tasks not in serdag now? In airlfow 3 seems should not really be possible?

Synthetic nodes based on TI table for the selected run that are not part of the structure anymore ? (we have an entry in the TI table but nothing in no node in the serialized dag structure to match)

@bbovenzibbovenzi added this to the Airflow 3.1.1 milestone Oct 1, 2025
@bbovenzi
bbovenzi merged commit 77fae41 into apache:mainOct 1, 2025
112 checks passed
@bbovenzi
bbovenzi deleted the fix-grid-removed-ti-visibility branch October 1, 2025 14:28
github-actionsBot pushed a commit that referenced this pull request Oct 1, 2025
@ephraimbuddyYour friendly bot
[v3-1-test] UI: Fix Grid for cleared runs when tasks were removed (#5…
37f1cc0
…6085)
Ensure removed/historical tasks from selected runs are visible in
Grid even if they no longer exist in the current DAG version.
We now:
- Include synthetic leaf nodes for task_ids present in TIs but
missing from the serialized DAG in both grid/structure and grid/ti_summaries.
- Aggregate TI states for these synthetic nodes
Add tests covering structure and TI summaries for removed tasks.
(cherry picked from commit 77fae41)
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
@github-actions

github-actionsBot commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-1-test

StatusBranchResult
✅v3-1-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Oct 1, 2025
@ephraimbuddyYour friendly bot
[v3-1-test] UI: Fix Grid for cleared runs when tasks were removed (ap…
aeaa487
…ache#56085)
Ensure removed/historical tasks from selected runs are visible in
Grid even if they no longer exist in the current DAG version.
We now:
- Include synthetic leaf nodes for task_ids present in TIs but
missing from the serialized DAG in both grid/structure and grid/ti_summaries.
- Aggregate TI states for these synthetic nodes
Add tests covering structure and TI summaries for removed tasks.
(cherry picked from commit 77fae41)
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
pierrejeambrun pushed a commit that referenced this pull request Oct 8, 2025
@ephraimbuddy@pierrejeambrun
[v3-1-test] UI: Fix Grid for cleared runs when tasks were removed (#5…
e2ebc42
…6085)
Ensure removed/historical tasks from selected runs are visible in
Grid even if they no longer exist in the current DAG version.
We now:
- Include synthetic leaf nodes for task_ids present in TIs but
missing from the serialized DAG in both grid/structure and grid/ti_summaries.
- Aggregate TI states for these synthetic nodes
Add tests covering structure and TI summaries for removed tasks.
(cherry picked from commit 77fae41)
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
dabla pushed a commit to dabla/airflow that referenced this pull request Oct 12, 2025
@ephraimbuddy@dabla
UI: Fix Grid for cleared runs when tasks were removed (apache#56085)
c3aeba3
Ensure removed/historical tasks from selected runs are visible in
Grid even if they no longer exist in the current DAG version.
We now:
- Include synthetic leaf nodes for task_ids present in TIs but
missing from the serialized DAG in both grid/structure and grid/ti_summaries.
- Aggregate TI states for these synthetic nodes
Add tests covering structure and TI summaries for removed tasks.
potiuk pushed a commit that referenced this pull request Oct 13, 2025
@ephraimbuddy@potiuk
[v3-1-test] UI: Fix Grid for cleared runs when tasks were removed (#5…
1f715ac
…6085)
Ensure removed/historical tasks from selected runs are visible in
Grid even if they no longer exist in the current DAG version.
We now:
- Include synthetic leaf nodes for task_ids present in TIs but
missing from the serialized DAG in both grid/structure and grid/ti_summaries.
- Aggregate TI states for these synthetic nodes
Add tests covering structure and TI summaries for removed tasks.
(cherry picked from commit 77fae41)
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
potiuk pushed a commit that referenced this pull request Oct 13, 2025
@ephraimbuddy@potiuk
[v3-1-test] UI: Fix Grid for cleared runs when tasks were removed (#5…
19fd4ae
…6085)
Ensure removed/historical tasks from selected runs are visible in
Grid even if they no longer exist in the current DAG version.
We now:
- Include synthetic leaf nodes for task_ids present in TIs but
missing from the serialized DAG in both grid/structure and grid/ti_summaries.
- Aggregate TI states for these synthetic nodes
Add tests covering structure and TI summaries for removed tasks.
(cherry picked from commit 77fae41)
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
pierrejeambrun pushed a commit that referenced this pull request Oct 13, 2025
@ephraimbuddy@pierrejeambrun
[v3-1-test] UI: Fix Grid for cleared runs when tasks were removed (#5…
6eaddc4
…6085)
Ensure removed/historical tasks from selected runs are visible in
Grid even if they no longer exist in the current DAG version.
We now:
- Include synthetic leaf nodes for task_ids present in TIs but
missing from the serialized DAG in both grid/structure and grid/ti_summaries.
- Aggregate TI states for these synthetic nodes
Add tests covering structure and TI summaries for removed tasks.
(cherry picked from commit 77fae41)
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
pierrejeambrun pushed a commit that referenced this pull request Oct 13, 2025
@github-actions@ephraimbuddy
[v3-1-test] UI: Fix Grid for cleared runs when tasks were removed (#5…
26e7b27
…6085) (#56297)
Ensure removed/historical tasks from selected runs are visible in
Grid even if they no longer exist in the current DAG version.
We now:
- Include synthetic leaf nodes for task_ids present in TIs but
missing from the serialized DAG in both grid/structure and grid/ti_summaries.
- Aggregate TI states for these synthetic nodes
Add tests covering structure and TI summaries for removed tasks.
(cherry picked from commit 77fae41)
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
@potiukpotiuk mentioned this pull request Nov 8, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzibbovenzibbovenzi approved these changes
@bugraoz93bugraoz93bugraoz93 approved these changes
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@dstandishdstandishdstandish approved these changes
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamilton
@jscheffljschefflAwaiting requested review from jscheffl
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@jason810496jason810496Awaiting requested review from jason810496jason810496 is a code owner

Assignees

No one assigned

Labels

area:APIAirflow's REST/HTTP APIarea:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

Airflow 3.1.1

Development

Successfully merging this pull request may close these issues.

5 participants

@ephraimbuddy@dstandish@pierrejeambrun@bbovenzi@bugraoz93