Replace defaultValue with value in TaskTrySelect by vedantmamgain · Pull Request #56141 · apache/airflow

vedantmamgain · 2025-09-26T14:01:20Z

Changed the Select component to use the controlled 'value' prop instead of 'defaultValue'
for try number selection, ensuring the selected value updates correctly with state changes.

This ensures that the stale <select> gets updated just like <option>

closes: 55830

Test Plan

Locally reproduced the bug and ensured that with the fix the <select> isn't stale anymore.

Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes.

boring-cyborg · 2025-09-26T14:01:23Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

bbovenzi · 2025-09-29T21:14:47Z

Makes sense. Do you mind running pnpm lint && pnpm format to fix the linting issues with prop ordering?

Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

vedantmamgain · 2025-09-30T12:55:24Z

Makes sense. Do you mind running pnpm lint && pnpm format to fix the linting issues with prop ordering?

Done :)

vedantmamgain · 2025-09-30T12:57:47Z

@bbovenzi looks like you've need to approve again after I updated from main.

vedantmamgain · 2025-09-30T13:41:23Z

@bbovenzi Another query but do the maintainers merge the pr themselves or can we do it as well ?

pierrejeambrun · 2025-09-30T15:14:05Z

Another query but do the maintainers merge the pr themselves or can we do it as well ?

Only Maintainers with write permissions to the project are able to merge PRs

vedantmamgain · 2025-09-30T15:38:52Z

Another query but do the maintainers merge the pr themselves or can we do it as well ?
Only Maintainers with write permissions to the project are able to merge PRs

Got it thanks for the clarification, the tests have passed now.

boring-cyborg · 2025-09-30T15:55:22Z

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>

github-actions · 2025-09-30T15:56:17Z

Backport successfully created: v3-1-test

Status	Branch	Result
✅	v3-1-test

…#56258) * Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>

* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

vedantmamgain · 2025-09-26T14:01:20Z

Changed the Select component to use the controlled 'value' prop instead of 'defaultValue'
for try number selection, ensuring the selected value updates correctly with state changes.

This ensures that the stale <select> gets updated just like <option>

closes: 55830

Test Plan

Locally reproduced the bug and ensured that with the fix the <select> isn't stale anymore.

Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes.

boring-cyborg · 2025-09-26T14:01:23Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

bbovenzi · 2025-09-29T21:14:47Z

Makes sense. Do you mind running pnpm lint && pnpm format to fix the linting issues with prop ordering?

Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

vedantmamgain · 2025-09-30T12:55:24Z

Makes sense. Do you mind running pnpm lint && pnpm format to fix the linting issues with prop ordering?

Done :)

vedantmamgain · 2025-09-30T12:57:47Z

@bbovenzi looks like you've need to approve again after I updated from main.

vedantmamgain · 2025-09-30T13:41:23Z

@bbovenzi Another query but do the maintainers merge the pr themselves or can we do it as well ?

pierrejeambrun · 2025-09-30T15:14:05Z

Another query but do the maintainers merge the pr themselves or can we do it as well ?

Only Maintainers with write permissions to the project are able to merge PRs

vedantmamgain · 2025-09-30T15:38:52Z

Another query but do the maintainers merge the pr themselves or can we do it as well ?
Only Maintainers with write permissions to the project are able to merge PRs

Got it thanks for the clarification, the tests have passed now.

boring-cyborg · 2025-09-30T15:55:22Z

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>

github-actions · 2025-09-30T15:56:17Z

Backport successfully created: v3-1-test

Status	Branch	Result
✅	v3-1-test

…#56258) * Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>

* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

vedantmamgain · 2025-09-26T14:01:20Z

Changed the Select component to use the controlled 'value' prop instead of 'defaultValue'
for try number selection, ensuring the selected value updates correctly with state changes.

This ensures that the stale <select> gets updated just like <option>

closes: 55830

Test Plan

Locally reproduced the bug and ensured that with the fix the <select> isn't stale anymore.

Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes.

boring-cyborg · 2025-09-26T14:01:23Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

bbovenzi · 2025-09-29T21:14:47Z

Makes sense. Do you mind running pnpm lint && pnpm format to fix the linting issues with prop ordering?

Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

vedantmamgain · 2025-09-30T12:55:24Z

Makes sense. Do you mind running pnpm lint && pnpm format to fix the linting issues with prop ordering?

Done :)

vedantmamgain · 2025-09-30T12:57:47Z

@bbovenzi looks like you've need to approve again after I updated from main.

vedantmamgain · 2025-09-30T13:41:23Z

@bbovenzi Another query but do the maintainers merge the pr themselves or can we do it as well ?

pierrejeambrun · 2025-09-30T15:14:05Z

Another query but do the maintainers merge the pr themselves or can we do it as well ?

Only Maintainers with write permissions to the project are able to merge PRs

vedantmamgain · 2025-09-30T15:38:52Z

Another query but do the maintainers merge the pr themselves or can we do it as well ?
Only Maintainers with write permissions to the project are able to merge PRs

Got it thanks for the clarification, the tests have passed now.

boring-cyborg · 2025-09-30T15:55:22Z

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>

github-actions · 2025-09-30T15:56:17Z

Backport successfully created: v3-1-test

Status	Branch	Result
✅	v3-1-test

…#56258) * Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>

* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

vedantmamgain · 2025-09-26T14:01:20Z

Changed the Select component to use the controlled 'value' prop instead of 'defaultValue'
for try number selection, ensuring the selected value updates correctly with state changes.

This ensures that the stale <select> gets updated just like <option>

closes: 55830

Test Plan

Locally reproduced the bug and ensured that with the fix the <select> isn't stale anymore.

Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes.

boring-cyborg · 2025-09-26T14:01:23Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

bbovenzi · 2025-09-29T21:14:47Z

Makes sense. Do you mind running pnpm lint && pnpm format to fix the linting issues with prop ordering?

Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

vedantmamgain · 2025-09-30T12:55:24Z

Makes sense. Do you mind running pnpm lint && pnpm format to fix the linting issues with prop ordering?

Done :)

vedantmamgain · 2025-09-30T12:57:47Z

@bbovenzi looks like you've need to approve again after I updated from main.

vedantmamgain · 2025-09-30T13:41:23Z

@bbovenzi Another query but do the maintainers merge the pr themselves or can we do it as well ?

pierrejeambrun · 2025-09-30T15:14:05Z

Another query but do the maintainers merge the pr themselves or can we do it as well ?

Only Maintainers with write permissions to the project are able to merge PRs

vedantmamgain · 2025-09-30T15:38:52Z

Another query but do the maintainers merge the pr themselves or can we do it as well ?
Only Maintainers with write permissions to the project are able to merge PRs

Got it thanks for the clarification, the tests have passed now.

boring-cyborg · 2025-09-30T15:55:22Z

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>

github-actions · 2025-09-30T15:56:17Z

Backport successfully created: v3-1-test

Status	Branch	Result
✅	v3-1-test

…#56258) * Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>

* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

vedantmamgain · 2025-09-26T14:01:20Z

Changed the Select component to use the controlled 'value' prop instead of 'defaultValue'
for try number selection, ensuring the selected value updates correctly with state changes.

This ensures that the stale <select> gets updated just like <option>

closes: 55830

Test Plan

Locally reproduced the bug and ensured that with the fix the <select> isn't stale anymore.

Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes.

boring-cyborg · 2025-09-26T14:01:23Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

bbovenzi · 2025-09-29T21:14:47Z

Makes sense. Do you mind running pnpm lint && pnpm format to fix the linting issues with prop ordering?

Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

vedantmamgain · 2025-09-30T12:55:24Z

Makes sense. Do you mind running pnpm lint && pnpm format to fix the linting issues with prop ordering?

Done :)

vedantmamgain · 2025-09-30T12:57:47Z

@bbovenzi looks like you've need to approve again after I updated from main.

vedantmamgain · 2025-09-30T13:41:23Z

@bbovenzi Another query but do the maintainers merge the pr themselves or can we do it as well ?

pierrejeambrun · 2025-09-30T15:14:05Z

Another query but do the maintainers merge the pr themselves or can we do it as well ?

Only Maintainers with write permissions to the project are able to merge PRs

vedantmamgain · 2025-09-30T15:38:52Z

Another query but do the maintainers merge the pr themselves or can we do it as well ?
Only Maintainers with write permissions to the project are able to merge PRs

Got it thanks for the clarification, the tests have passed now.

boring-cyborg · 2025-09-30T15:55:22Z

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>

github-actions · 2025-09-30T15:56:17Z

Backport successfully created: v3-1-test

Status	Branch	Result
✅	v3-1-test

…#56258) * Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>

* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

vedantmamgain · 2025-09-26T14:01:20Z

Changed the Select component to use the controlled 'value' prop instead of 'defaultValue'
for try number selection, ensuring the selected value updates correctly with state changes.

This ensures that the stale <select> gets updated just like <option>

closes: 55830

Test Plan

Locally reproduced the bug and ensured that with the fix the <select> isn't stale anymore.

Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes.

boring-cyborg · 2025-09-26T14:01:23Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

bbovenzi · 2025-09-29T21:14:47Z

Makes sense. Do you mind running pnpm lint && pnpm format to fix the linting issues with prop ordering?

Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

vedantmamgain · 2025-09-30T12:55:24Z

Makes sense. Do you mind running pnpm lint && pnpm format to fix the linting issues with prop ordering?

Done :)

vedantmamgain · 2025-09-30T12:57:47Z

@bbovenzi looks like you've need to approve again after I updated from main.

vedantmamgain · 2025-09-30T13:41:23Z

@bbovenzi Another query but do the maintainers merge the pr themselves or can we do it as well ?

pierrejeambrun · 2025-09-30T15:14:05Z

Another query but do the maintainers merge the pr themselves or can we do it as well ?

Only Maintainers with write permissions to the project are able to merge PRs

vedantmamgain · 2025-09-30T15:38:52Z

Another query but do the maintainers merge the pr themselves or can we do it as well ?
Only Maintainers with write permissions to the project are able to merge PRs

Got it thanks for the clarification, the tests have passed now.

boring-cyborg · 2025-09-30T15:55:22Z

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>

github-actions · 2025-09-30T15:56:17Z

Backport successfully created: v3-1-test

Status	Branch	Result
✅	v3-1-test

…#56258) * Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>

* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

vedantmamgain · 2025-09-26T14:01:20Z

Changed the Select component to use the controlled 'value' prop instead of 'defaultValue'
for try number selection, ensuring the selected value updates correctly with state changes.

This ensures that the stale <select> gets updated just like <option>

closes: 55830

Test Plan

Locally reproduced the bug and ensured that with the fix the <select> isn't stale anymore.

Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes.

boring-cyborg · 2025-09-26T14:01:23Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

bbovenzi · 2025-09-29T21:14:47Z

Makes sense. Do you mind running pnpm lint && pnpm format to fix the linting issues with prop ordering?

Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

vedantmamgain · 2025-09-30T12:55:24Z

Makes sense. Do you mind running pnpm lint && pnpm format to fix the linting issues with prop ordering?

Done :)

vedantmamgain · 2025-09-30T12:57:47Z

@bbovenzi looks like you've need to approve again after I updated from main.

vedantmamgain · 2025-09-30T13:41:23Z

@bbovenzi Another query but do the maintainers merge the pr themselves or can we do it as well ?

pierrejeambrun · 2025-09-30T15:14:05Z

Another query but do the maintainers merge the pr themselves or can we do it as well ?

Only Maintainers with write permissions to the project are able to merge PRs

vedantmamgain · 2025-09-30T15:38:52Z

Another query but do the maintainers merge the pr themselves or can we do it as well ?
Only Maintainers with write permissions to the project are able to merge PRs

Got it thanks for the clarification, the tests have passed now.

boring-cyborg · 2025-09-30T15:55:22Z

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>

github-actions · 2025-09-30T15:56:17Z

Backport successfully created: v3-1-test

Status	Branch	Result
✅	v3-1-test

…#56258) * Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>

* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

Replace defaultValue with value in TaskTrySelect
e315ac4
Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes.

boring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label Sep 26, 2025

vedantmamgain marked this pull request as ready for review September 26, 2025 14:06

vedantmamgain requested review from bbovenzi, jscheffl, pierrejeambrun, ryanahamilton and shubhamraj-git as code owners September 26, 2025 14:06

vedantmamgain mentioned this pull request Sep 26, 2025
Task Attempt Selection dropdown out of sync with state visible in the options itself #55830
Closed
1 task

bbovenzi added this to the Airflow 3.1.1 milestone Sep 29, 2025

vedantmamgain added 2 commits September 30, 2025 18:20

fix: Reorder props in TaskTrySelect for linting compliance
fec8f20
Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.

Merge branch 'main' into vedant/default-value-fix
1ec0dbe

bbovenzi approved these changes Sep 30, 2025
View reviewed changes

Merge branch 'main' into vedant/default-value-fix
f517c9b

Merge branch 'main' into vedant/default-value-fix
dd679d5

pierrejeambrun approved these changes Sep 30, 2025
View reviewed changes

pierrejeambrun added the backport-to-v3-1-test label Sep 30, 2025

pierrejeambrun merged commit 3f7991f into apache:mainSep 30, 2025
103 of 104 checks passed

pierrejeambrun added the type:bug-fix Changelog: Bug Fixes label Sep 30, 2025

potiuk mentioned this pull request Nov 8, 2025
Add missing translations for PL for 3.1.3 #58076
Merged