Uh oh!
There was an error while loading. Please reload this page.
Fix systemd service files issues - #57126
Conversation
This commit addresses multiple bugs in systemd service files reported in issue apache#53706: 1. Fix incorrect command in airflow-api.service - Changed 'airflow api' to 'airflow api-server' (correct CLI command) 2. Standardize environment configuration approach - Changed airflow-api.service and airflow-triggerer.service to use EnvironmentFile=/etc/sysconfig/airflow instead of inline Environment - This provides consistency with other services and allows admins flexibility to manage custom environment variables centrally 3. Fix service dependencies - Added proper After= and Wants= clauses for database and message queue services (postgresql, mysql, redis, rabbitmq) to airflow-api.service and airflow-triggerer.service - Services now wait for required dependencies before starting 4. Additional bug fixes discovered during review - airflow-flower.service: Removed duplicate ExecStart line - airflow-kerberos.service: Fixed command from 'kerberos' to 'airflow kerberos' 5. Consistency improvements - Added Type=simple and RestartSec=5s to airflow-api.service and airflow-triggerer.service for consistency with other services All systemd service files now follow the same configuration pattern, making them easier to maintain and more reliable during system startup. Fixesapache#53706
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for the fix. Interesting, from what I see this would have never worked.
I am not a systemd expert but from pure reading this looks like LGTM. Another pair of eyes might be good.
Uh oh!
There was an error while loading. Please reload this page.
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This commit addresses multiple bugs in systemd service files reported in issue #53706: 1. Fix incorrect command in airflow-api.service - Changed 'airflow api' to 'airflow api-server' (correct CLI command) 2. Standardize environment configuration approach - Changed airflow-api.service and airflow-triggerer.service to use EnvironmentFile=/etc/sysconfig/airflow instead of inline Environment - This provides consistency with other services and allows admins flexibility to manage custom environment variables centrally 3. Fix service dependencies - Added proper After= and Wants= clauses for database and message queue services (postgresql, mysql, redis, rabbitmq) to airflow-api.service and airflow-triggerer.service - Services now wait for required dependencies before starting 4. Additional bug fixes discovered during review - airflow-flower.service: Removed duplicate ExecStart line - airflow-kerberos.service: Fixed command from 'kerberos' to 'airflow kerberos' 5. Consistency improvements - Added Type=simple and RestartSec=5s to airflow-api.service and airflow-triggerer.service for consistency with other services All systemd service files now follow the same configuration pattern, making them easier to maintain and more reliable during system startup. Fixes#53706 (cherry picked from commit b370160) Co-authored-by: Ashir Alam <alamashir@gmail.com>
This commit addresses multiple bugs in systemd service files reported in issue #53706: 1. Fix incorrect command in airflow-api.service - Changed 'airflow api' to 'airflow api-server' (correct CLI command) 2. Standardize environment configuration approach - Changed airflow-api.service and airflow-triggerer.service to use EnvironmentFile=/etc/sysconfig/airflow instead of inline Environment - This provides consistency with other services and allows admins flexibility to manage custom environment variables centrally 3. Fix service dependencies - Added proper After= and Wants= clauses for database and message queue services (postgresql, mysql, redis, rabbitmq) to airflow-api.service and airflow-triggerer.service - Services now wait for required dependencies before starting 4. Additional bug fixes discovered during review - airflow-flower.service: Removed duplicate ExecStart line - airflow-kerberos.service: Fixed command from 'kerberos' to 'airflow kerberos' 5. Consistency improvements - Added Type=simple and RestartSec=5s to airflow-api.service and airflow-triggerer.service for consistency with other services All systemd service files now follow the same configuration pattern, making them easier to maintain and more reliable during system startup. Fixes#53706 (cherry picked from commit b370160) Co-authored-by: Ashir Alam <alamashir@gmail.com>
This commit addresses multiple bugs in systemd service files reported in issue #53706:
Fix incorrect command in airflow-api.service
Standardize environment configuration approach
Fix service dependencies
Additional bug fixes discovered during review
Consistency improvements
All systemd service files now follow the same configuration pattern, making them easier to maintain and more reliable during system startup.
Fixes#53706
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.