Uh oh!
There was an error while loading. Please reload this page.
Extract prek hooks for Providers - #57250
Conversation
Uh oh!
There was an error while loading. Please reload this page.
c597fdd to
e2a77dbComparepotiuk
commented
Oct 25, 2025
Static checks to fix ... but I love it :) |
potiuk
commented
Oct 25, 2025
BTW. There might be some code in breeze that finds providers by looking at the sub-folders of "providers" but it might also do it for files .. so maybe some breeze update is needed. |
jscheffl
commented
Oct 25, 2025
I am on it just need to complete some other duties in parallel... stay tuned... |
potiuk
commented
Oct 25, 2025
No. Looks good. Seems we are always using "rglob" and finding something ("provider.yaml" or "integration" folder). |
Uh oh!
There was an error while loading. Please reload this page.
gopidesupavan
left a comment
There was a problem hiding this comment.
LGTM , nice to see separation :)
e2a77db to
22ae396CompareUh oh!
There was an error while loading. Please reload this page.
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 045fbc5 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
* Extract prek hooks for Providers * Ups in path * Fix breeze script to consider running also in non repo root * Fix prek script to consider running also in non repo root * Fix prek script to consider running also in non repo root (cherry picked from commit 045fbc5) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
* Extract prek hooks for Providers * Ups in path * Fix breeze script to consider running also in non repo root * Fix prek script to consider running also in non repo root * Fix prek script to consider running also in non repo root (cherry picked from commit 045fbc5) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
* Extract prek hooks for Providers * Ups in path * Fix breeze script to consider running also in non repo root * Fix prek script to consider running also in non repo root * Fix prek script to consider running also in non repo root (cherry picked from commit 045fbc5) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
potiuk
commented
Oct 25, 2025
Backport #57260 |
Following #57181 this is now a batch for all prek hooks that are "just" solely for providers to split out from root:
As prek is supporting monorepo now and go SDK was the front-runner, provider root is now the next piece that with this PR is proposed to be split-out from global pre-commit hook list into the provider space.