') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Enable ruff PLW0129 rule by jscheffl · Pull Request #57516 · apache/airflow · GitHub
Skip to content

Enable ruff PLW0129 rule - #57516

Merged
jscheffl merged 4 commits into
apache:mainfrom
jscheffl:feature/add-ruff-plw0129-rule
Oct 31, 2025
Merged

Enable ruff PLW0129 rule#57516
jscheffl merged 4 commits into
apache:mainfrom
jscheffl:feature/add-ruff-plw0129-rule

Conversation

@jscheffl

@jscheffljscheffl commented Oct 29, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

While implementing #57294 I realized that a couple of more ruff PLW rules might be interesting, this PR enables PLW0129

See also https://docs.astral.sh/ruff/rules/#warning-plw

@boring-cyborgboring-cyborgBot added area:providers provider:amazon AWS/Amazon - related issues provider:apache-spark provider:apache-livy provider:cncf-kubernetes Kubernetes (k8s) provider related issues provider:google Google (including GCP) related issues labels Oct 29, 2025
@jscheffljscheffl mentioned this pull request Oct 29, 2025
Closed
2 tasks
hussein-awala
hussein-awala approved these changes Oct 29, 2025
View reviewed changes

@hussein-awalahussein-awala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks helpful, lgtm

@jscheffl
jschefflforce-pushed the feature/add-ruff-plw0129-rule branch from 8fdbc73 to a59c75cCompareOctober 29, 2025 23:32
@jscheffl
jschefflforce-pushed the feature/add-ruff-plw0129-rule branch from a59c75c to 3b3408bCompareOctober 30, 2025 21:25
@jscheffl
jscheffl merged commit aedf953 into apache:mainOct 31, 2025
208 checks passed
jscheffl added a commit to jscheffl/airflow that referenced this pull request Oct 31, 2025
@jscheffl
Enable ruff PLW0129 rule (apache#57516)
b2022ee
* Enable ruff PLW0129 rule
* Fix pytests
* Fix pytests as working in logs changed
* Fix pytests as working in logs changed
jscheffl added a commit that referenced this pull request Oct 31, 2025
@jscheffl
[v3-1-test] Enable ruff PLW0602 rule (#57588) (#57638)
efbd210
* Enable ruff PLW0602 rule (#57588)
(cherry picked from commit d52c4fb)
* Enable ruff PLW0129 rule (#57516)
* Enable ruff PLW0129 rule
* Fix pytests
* Fix pytests as working in logs changed
* Fix pytests as working in logs changed
* [v3-1-test] Enable ruff PLW0602 rule (#57588)
(cherry picked from commit d52c4fb)
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
ephraimbuddy pushed a commit that referenced this pull request Nov 3, 2025
@jscheffl@ephraimbuddy
[v3-1-test] Enable ruff PLW0602 rule (#57588) (#57638)
cd4c21f
* Enable ruff PLW0602 rule (#57588)
(cherry picked from commit d52c4fb)
* Enable ruff PLW0129 rule (#57516)
* Enable ruff PLW0129 rule
* Fix pytests
* Fix pytests as working in logs changed
* Fix pytests as working in logs changed
* [v3-1-test] Enable ruff PLW0602 rule (#57588)
(cherry picked from commit d52c4fb)
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
ephraimbuddy pushed a commit that referenced this pull request Nov 4, 2025
@jscheffl@ephraimbuddy
[v3-1-test] Enable ruff PLW0602 rule (#57588) (#57638)
84a3816
* Enable ruff PLW0602 rule (#57588)
(cherry picked from commit d52c4fb)
* Enable ruff PLW0129 rule (#57516)
* Enable ruff PLW0129 rule
* Fix pytests
* Fix pytests as working in logs changed
* Fix pytests as working in logs changed
* [v3-1-test] Enable ruff PLW0602 rule (#57588)
(cherry picked from commit d52c4fb)
Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
CopilotAI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
@jscheffl
Enable ruff PLW0129 rule (apache#57516)
cd9c005
* Enable ruff PLW0129 rule
* Fix pytests
* Fix pytests as working in logs changed
* Fix pytests as working in logs changed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hussein-awalahussein-awalahussein-awala approved these changes
@jedcunninghamjedcunninghamAwaiting requested review from jedcunninghamjedcunningham is a code owner
@eladkaleladkalAwaiting requested review from eladkal
@o-nikolaso-nikolasAwaiting requested review from o-nikolaso-nikolas is a code owner

Assignees

No one assigned

Labels

area:providersprovider:amazonAWS/Amazon - related issuesprovider:apache-livyprovider:apache-sparkprovider:cncf-kubernetesKubernetes (k8s) provider related issuesprovider:googleGoogle (including GCP) related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jscheffl@hussein-awala