Skip to content

Enable ruff PLW1509 rule#57659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 2 commits into from
Nov 6, 2025
Merged

Enable ruff PLW1509 rule #57659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d351ee2
Enable ruff PLW1509 rule
jscheffl Oct 31, 2025
8b2504c
Fix pytests
jscheffl Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions providers/standard/src/airflow/providers/standard/hooks/subprocess.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,14 +77,6 @@ def run_command(
"""
self.log.info("Tmp dir root location: %s", gettempdir())
with working_directory(cwd=cwd) as cwd:

def pre_exec():
# Restore default signal disposition and invoke setsid
for sig in ("SIGPIPE", "SIGXFZ", "SIGXFSZ"):
if hasattr(signal, sig):
signal.signal(getattr(signal, sig), signal.SIG_DFL)
os.setsid()

self.log.info("Running command: %s", command)

self.sub_process = Popen(
Expand All@@ -93,7 +85,8 @@ def pre_exec():
stderr=STDOUT,
cwd=cwd,
env=env if env or env == {} else os.environ,
preexec_fn=pre_exec,
start_new_session=True,
restore_signals=True,
)

self.log.info("Output:")
Expand Down
3 changes: 1 addition & 2 deletions providers/standard/src/airflow/providers/standard/sensors/bash.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
# under the License.
from __future__ import annotations

import os
from collections.abc import Sequence
from subprocess import PIPE, STDOUT, Popen
from tempfile import NamedTemporaryFile, TemporaryDirectory, gettempdir
Expand DownExpand Up@@ -89,7 +88,7 @@ def poke(self, context: Context):
close_fds=True,
cwd=tmp_dir,
env=self.env,
preexec_fn=os.setsid,
start_new_session=True,
) as resp:
if resp.stdout:
self.log.info("Output:")
Expand Down
3 changes: 2 additions & 1 deletion providers/standard/tests/unit/standard/hooks/test_subprocess.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,8 @@ def test_should_exec_subprocess(self, mock_popen, mock_temporary_directory):
["bash", "-c", 'echo "stdout"'],
cwd="/tmp/airflowtmpcatcat",
env={},
preexec_fn=mock.ANY,
restore_signals=True,
start_new_session=True,
stderr=STDOUT,
stdout=PIPE,
)
Expand Down
2 changes: 1 addition & 1 deletion providers/teradata/src/airflow/providers/teradata/hooks/bteq.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -263,7 +263,7 @@ def execute_bteq_script_at_local(
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
shell=True,
preexec_fn=os.setsid,
start_new_session=True,
)
encode_bteq_script = bteq_script.encode(str(temp_file_read_encoding or "UTF-8"))
stdout_data, _ = process.communicate(input=encode_bteq_script)
Expand Down
2 changes: 1 addition & 1 deletion providers/teradata/tests/unit/teradata/hooks/test_bteq.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ def test_execute_bteq_script_at_local_success(
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
shell=True,
preexec_fn=os.setsid,
start_new_session=True,
)
assert ret_code == 0

Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -610,6 +610,7 @@ extend-select = [
"PLW1501", # {mode} is not a valid mode for open
"PLW1507", # Shallow copy of os.environ via copy.copy(os.environ)
"PLW1508", # Invalid type for environment variable default; expected str or None
"PLW1509", # preexec_fn argument is unsafe when using threads
"PLW1510", # subprocess.run without explicit check argument
"PLW1641", # Object does not implement __hash__ method
# Per rule enables
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Enable ruff PLW1509 rule by jscheffl · Pull Request #57659 · apache/airflow · GitHub
Skip to content
Enable ruff PLW1509 rule#57659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

jscheffl
merged 2 commits into

from

Nov 6, 2025
 Merged


Enable ruff PLW1509 rule
#57659
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d351ee2

Enable ruff PLW1509 rule


jscheffl Oct 31, 2025
8b2504c

Fix pytests


jscheffl Nov 1, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 2 additions & 9 deletions
providers/standard/src/airflow/providers/standard/hooks/subprocess.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -77,14 +77,6 @@ def run_command(
 """
 self.log.info("Tmp dir root location: %s", gettempdir())
 with working_directory(cwd=cwd) as cwd:

 def pre_exec():
 # Restore default signal disposition and invoke setsid
 for sig in ("SIGPIPE", "SIGXFZ", "SIGXFSZ"):
 if hasattr(signal, sig):
 signal.signal(getattr(signal, sig), signal.SIG_DFL)
 os.setsid()

 self.log.info("Running command: %s", command)

 self.sub_process = Popen(
Expand All@@ -93,7 +85,8 @@ def pre_exec():
 stderr=STDOUT,
 cwd=cwd,
 env=env if env or env == {} else os.environ,
 preexec_fn=pre_exec,
 start_new_session=True,
 restore_signals=True,
 )

 self.log.info("Output:")
Expand Down

3 changes: 1 addition & 2 deletions
providers/standard/src/airflow/providers/standard/sensors/bash.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
# under the License.
from __future__ import annotations

import os
from collections.abc import Sequence
from subprocess import PIPE, STDOUT, Popen
from tempfile import NamedTemporaryFile, TemporaryDirectory, gettempdir
Expand DownExpand Up@@ -89,7 +88,7 @@ def poke(self, context: Context):
 close_fds=True,
 cwd=tmp_dir,
 env=self.env,
preexec_fn=os.setsid,
start_new_session=True,
 ) as resp:
 if resp.stdout:
 self.log.info("Output:")
Expand Down

3 changes: 2 additions & 1 deletion
providers/standard/tests/unit/standard/hooks/test_subprocess.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,8 @@ def test_should_exec_subprocess(self, mock_popen, mock_temporary_directory):
 ["bash", "-c", 'echo "stdout"'],
 cwd="/tmp/airflowtmpcatcat",
 env={},
 preexec_fn=mock.ANY,
 restore_signals=True,
 start_new_session=True,
 stderr=STDOUT,
 stdout=PIPE,
 )
Expand Down

2 changes: 1 addition & 1 deletion
providers/teradata/src/airflow/providers/teradata/hooks/bteq.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -263,7 +263,7 @@ def execute_bteq_script_at_local(
 stdout=subprocess.PIPE,
 stderr=subprocess.STDOUT,
 shell=True,
preexec_fn=os.setsid,
start_new_session=True,
 )
 encode_bteq_script = bteq_script.encode(str(temp_file_read_encoding or "UTF-8"))
 stdout_data, _ = process.communicate(input=encode_bteq_script)
Expand Down

2 changes: 1 addition & 1 deletion
providers/teradata/tests/unit/teradata/hooks/test_bteq.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ def test_execute_bteq_script_at_local_success(
 stdout=subprocess.PIPE,
 stderr=subprocess.STDOUT,
 shell=True,
preexec_fn=os.setsid,
start_new_session=True,
 )
 assert ret_code == 0

Expand Down

1 change: 1 addition & 0 deletions
pyproject.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -610,6 +610,7 @@ extend-select = [
 "PLW1501", # {mode} is not a valid mode for open
 "PLW1507", # Shallow copy of os.environ via copy.copy(os.environ)
 "PLW1508", # Invalid type for environment variable default; expected str or None
 "PLW1509", # preexec_fn argument is unsafe when using threads
 "PLW1510", # subprocess.run without explicit check argument
 "PLW1641", # Object does not implement __hash__ method
 # Per rule enables
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable ruff PLW1509 rule by jscheffl · Pull Request #57659 · apache/airflow · GitHub
Skip to content
Enable ruff PLW1509 rule#57659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

jscheffl
merged 2 commits into

from

Nov 6, 2025
 Merged


Enable ruff PLW1509 rule
#57659
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d351ee2

Enable ruff PLW1509 rule


jscheffl Oct 31, 2025
8b2504c

Fix pytests


jscheffl Nov 1, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 2 additions & 9 deletions
providers/standard/src/airflow/providers/standard/hooks/subprocess.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -77,14 +77,6 @@ def run_command(
 """
 self.log.info("Tmp dir root location: %s", gettempdir())
 with working_directory(cwd=cwd) as cwd:

 def pre_exec():
 # Restore default signal disposition and invoke setsid
 for sig in ("SIGPIPE", "SIGXFZ", "SIGXFSZ"):
 if hasattr(signal, sig):
 signal.signal(getattr(signal, sig), signal.SIG_DFL)
 os.setsid()

 self.log.info("Running command: %s", command)

 self.sub_process = Popen(
Expand All@@ -93,7 +85,8 @@ def pre_exec():
 stderr=STDOUT,
 cwd=cwd,
 env=env if env or env == {} else os.environ,
 preexec_fn=pre_exec,
 start_new_session=True,
 restore_signals=True,
 )

 self.log.info("Output:")
Expand Down

3 changes: 1 addition & 2 deletions
providers/standard/src/airflow/providers/standard/sensors/bash.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
# under the License.
from __future__ import annotations

import os
from collections.abc import Sequence
from subprocess import PIPE, STDOUT, Popen
from tempfile import NamedTemporaryFile, TemporaryDirectory, gettempdir
Expand DownExpand Up@@ -89,7 +88,7 @@ def poke(self, context: Context):
 close_fds=True,
 cwd=tmp_dir,
 env=self.env,
preexec_fn=os.setsid,
start_new_session=True,
 ) as resp:
 if resp.stdout:
 self.log.info("Output:")
Expand Down

3 changes: 2 additions & 1 deletion
providers/standard/tests/unit/standard/hooks/test_subprocess.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,8 @@ def test_should_exec_subprocess(self, mock_popen, mock_temporary_directory):
 ["bash", "-c", 'echo "stdout"'],
 cwd="/tmp/airflowtmpcatcat",
 env={},
 preexec_fn=mock.ANY,
 restore_signals=True,
 start_new_session=True,
 stderr=STDOUT,
 stdout=PIPE,
 )
Expand Down

2 changes: 1 addition & 1 deletion
providers/teradata/src/airflow/providers/teradata/hooks/bteq.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -263,7 +263,7 @@ def execute_bteq_script_at_local(
 stdout=subprocess.PIPE,
 stderr=subprocess.STDOUT,
 shell=True,
preexec_fn=os.setsid,
start_new_session=True,
 )
 encode_bteq_script = bteq_script.encode(str(temp_file_read_encoding or "UTF-8"))
 stdout_data, _ = process.communicate(input=encode_bteq_script)
Expand Down

2 changes: 1 addition & 1 deletion
providers/teradata/tests/unit/teradata/hooks/test_bteq.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ def test_execute_bteq_script_at_local_success(
 stdout=subprocess.PIPE,
 stderr=subprocess.STDOUT,
 shell=True,
preexec_fn=os.setsid,
start_new_session=True,
 )
 assert ret_code == 0

Expand Down

1 change: 1 addition & 0 deletions
pyproject.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -610,6 +610,7 @@ extend-select = [
 "PLW1501", # {mode} is not a valid mode for open
 "PLW1507", # Shallow copy of os.environ via copy.copy(os.environ)
 "PLW1508", # Invalid type for environment variable default; expected str or None
 "PLW1509", # preexec_fn argument is unsafe when using threads
 "PLW1510", # subprocess.run without explicit check argument
 "PLW1641", # Object does not implement __hash__ method
 # Per rule enables
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable ruff PLW1509 rule by jscheffl · Pull Request #57659 · apache/airflow · GitHub
Skip to content
Enable ruff PLW1509 rule#57659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

jscheffl
merged 2 commits into

from

Nov 6, 2025
 Merged


Enable ruff PLW1509 rule
#57659
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d351ee2

Enable ruff PLW1509 rule


jscheffl Oct 31, 2025
8b2504c

Fix pytests


jscheffl Nov 1, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 2 additions & 9 deletions
providers/standard/src/airflow/providers/standard/hooks/subprocess.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -77,14 +77,6 @@ def run_command(
 """
 self.log.info("Tmp dir root location: %s", gettempdir())
 with working_directory(cwd=cwd) as cwd:

 def pre_exec():
 # Restore default signal disposition and invoke setsid
 for sig in ("SIGPIPE", "SIGXFZ", "SIGXFSZ"):
 if hasattr(signal, sig):
 signal.signal(getattr(signal, sig), signal.SIG_DFL)
 os.setsid()

 self.log.info("Running command: %s", command)

 self.sub_process = Popen(
Expand All@@ -93,7 +85,8 @@ def pre_exec():
 stderr=STDOUT,
 cwd=cwd,
 env=env if env or env == {} else os.environ,
 preexec_fn=pre_exec,
 start_new_session=True,
 restore_signals=True,
 )

 self.log.info("Output:")
Expand Down

3 changes: 1 addition & 2 deletions
providers/standard/src/airflow/providers/standard/sensors/bash.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
# under the License.
from __future__ import annotations

import os
from collections.abc import Sequence
from subprocess import PIPE, STDOUT, Popen
from tempfile import NamedTemporaryFile, TemporaryDirectory, gettempdir
Expand DownExpand Up@@ -89,7 +88,7 @@ def poke(self, context: Context):
 close_fds=True,
 cwd=tmp_dir,
 env=self.env,
preexec_fn=os.setsid,
start_new_session=True,
 ) as resp:
 if resp.stdout:
 self.log.info("Output:")
Expand Down

3 changes: 2 additions & 1 deletion
providers/standard/tests/unit/standard/hooks/test_subprocess.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,8 @@ def test_should_exec_subprocess(self, mock_popen, mock_temporary_directory):
 ["bash", "-c", 'echo "stdout"'],
 cwd="/tmp/airflowtmpcatcat",
 env={},
 preexec_fn=mock.ANY,
 restore_signals=True,
 start_new_session=True,
 stderr=STDOUT,
 stdout=PIPE,
 )
Expand Down

2 changes: 1 addition & 1 deletion
providers/teradata/src/airflow/providers/teradata/hooks/bteq.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -263,7 +263,7 @@ def execute_bteq_script_at_local(
 stdout=subprocess.PIPE,
 stderr=subprocess.STDOUT,
 shell=True,
preexec_fn=os.setsid,
start_new_session=True,
 )
 encode_bteq_script = bteq_script.encode(str(temp_file_read_encoding or "UTF-8"))
 stdout_data, _ = process.communicate(input=encode_bteq_script)
Expand Down

2 changes: 1 addition & 1 deletion
providers/teradata/tests/unit/teradata/hooks/test_bteq.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ def test_execute_bteq_script_at_local_success(
 stdout=subprocess.PIPE,
 stderr=subprocess.STDOUT,
 shell=True,
preexec_fn=os.setsid,
start_new_session=True,
 )
 assert ret_code == 0

Expand Down

1 change: 1 addition & 0 deletions
pyproject.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -610,6 +610,7 @@ extend-select = [
 "PLW1501", # {mode} is not a valid mode for open
 "PLW1507", # Shallow copy of os.environ via copy.copy(os.environ)
 "PLW1508", # Invalid type for environment variable default; expected str or None
 "PLW1509", # preexec_fn argument is unsafe when using threads
 "PLW1510", # subprocess.run without explicit check argument
 "PLW1641", # Object does not implement __hash__ method
 # Per rule enables
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Enable ruff PLW1509 rule by jscheffl · Pull Request #57659 · apache/airflow · GitHub
Skip to content
Enable ruff PLW1509 rule#57659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

jscheffl
merged 2 commits into

from

Nov 6, 2025
 Merged


Enable ruff PLW1509 rule
#57659
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d351ee2

Enable ruff PLW1509 rule


jscheffl Oct 31, 2025
8b2504c

Fix pytests


jscheffl Nov 1, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 2 additions & 9 deletions
providers/standard/src/airflow/providers/standard/hooks/subprocess.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -77,14 +77,6 @@ def run_command(
 """
 self.log.info("Tmp dir root location: %s", gettempdir())
 with working_directory(cwd=cwd) as cwd:

 def pre_exec():
 # Restore default signal disposition and invoke setsid
 for sig in ("SIGPIPE", "SIGXFZ", "SIGXFSZ"):
 if hasattr(signal, sig):
 signal.signal(getattr(signal, sig), signal.SIG_DFL)
 os.setsid()

 self.log.info("Running command: %s", command)

 self.sub_process = Popen(
Expand All@@ -93,7 +85,8 @@ def pre_exec():
 stderr=STDOUT,
 cwd=cwd,
 env=env if env or env == {} else os.environ,
 preexec_fn=pre_exec,
 start_new_session=True,
 restore_signals=True,
 )

 self.log.info("Output:")
Expand Down

3 changes: 1 addition & 2 deletions
providers/standard/src/airflow/providers/standard/sensors/bash.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
# under the License.
from __future__ import annotations

import os
from collections.abc import Sequence
from subprocess import PIPE, STDOUT, Popen
from tempfile import NamedTemporaryFile, TemporaryDirectory, gettempdir
Expand DownExpand Up@@ -89,7 +88,7 @@ def poke(self, context: Context):
 close_fds=True,
 cwd=tmp_dir,
 env=self.env,
preexec_fn=os.setsid,
start_new_session=True,
 ) as resp:
 if resp.stdout:
 self.log.info("Output:")
Expand Down

3 changes: 2 additions & 1 deletion
providers/standard/tests/unit/standard/hooks/test_subprocess.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,8 @@ def test_should_exec_subprocess(self, mock_popen, mock_temporary_directory):
 ["bash", "-c", 'echo "stdout"'],
 cwd="/tmp/airflowtmpcatcat",
 env={},
 preexec_fn=mock.ANY,
 restore_signals=True,
 start_new_session=True,
 stderr=STDOUT,
 stdout=PIPE,
 )
Expand Down

2 changes: 1 addition & 1 deletion
providers/teradata/src/airflow/providers/teradata/hooks/bteq.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -263,7 +263,7 @@ def execute_bteq_script_at_local(
 stdout=subprocess.PIPE,
 stderr=subprocess.STDOUT,
 shell=True,
preexec_fn=os.setsid,
start_new_session=True,
 )
 encode_bteq_script = bteq_script.encode(str(temp_file_read_encoding or "UTF-8"))
 stdout_data, _ = process.communicate(input=encode_bteq_script)
Expand Down

2 changes: 1 addition & 1 deletion
providers/teradata/tests/unit/teradata/hooks/test_bteq.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ def test_execute_bteq_script_at_local_success(
 stdout=subprocess.PIPE,
 stderr=subprocess.STDOUT,
 shell=True,
preexec_fn=os.setsid,
start_new_session=True,
 )
 assert ret_code == 0

Expand Down

1 change: 1 addition & 0 deletions
pyproject.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -610,6 +610,7 @@ extend-select = [
 "PLW1501", # {mode} is not a valid mode for open
 "PLW1507", # Shallow copy of os.environ via copy.copy(os.environ)
 "PLW1508", # Invalid type for environment variable default; expected str or None
 "PLW1509", # preexec_fn argument is unsafe when using threads
 "PLW1510", # subprocess.run without explicit check argument
 "PLW1641", # Object does not implement __hash__ method
 # Per rule enables
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable ruff PLW1509 rule by jscheffl · Pull Request #57659 · apache/airflow · GitHub
Skip to content
Enable ruff PLW1509 rule#57659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

jscheffl
merged 2 commits into

from

Nov 6, 2025
 Merged


Enable ruff PLW1509 rule
#57659
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d351ee2

Enable ruff PLW1509 rule


jscheffl Oct 31, 2025
8b2504c

Fix pytests


jscheffl Nov 1, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 2 additions & 9 deletions
providers/standard/src/airflow/providers/standard/hooks/subprocess.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -77,14 +77,6 @@ def run_command(
 """
 self.log.info("Tmp dir root location: %s", gettempdir())
 with working_directory(cwd=cwd) as cwd:

 def pre_exec():
 # Restore default signal disposition and invoke setsid
 for sig in ("SIGPIPE", "SIGXFZ", "SIGXFSZ"):
 if hasattr(signal, sig):
 signal.signal(getattr(signal, sig), signal.SIG_DFL)
 os.setsid()

 self.log.info("Running command: %s", command)

 self.sub_process = Popen(
Expand All@@ -93,7 +85,8 @@ def pre_exec():
 stderr=STDOUT,
 cwd=cwd,
 env=env if env or env == {} else os.environ,
 preexec_fn=pre_exec,
 start_new_session=True,
 restore_signals=True,
 )

 self.log.info("Output:")
Expand Down

3 changes: 1 addition & 2 deletions
providers/standard/src/airflow/providers/standard/sensors/bash.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
# under the License.
from __future__ import annotations

import os
from collections.abc import Sequence
from subprocess import PIPE, STDOUT, Popen
from tempfile import NamedTemporaryFile, TemporaryDirectory, gettempdir
Expand DownExpand Up@@ -89,7 +88,7 @@ def poke(self, context: Context):
 close_fds=True,
 cwd=tmp_dir,
 env=self.env,
preexec_fn=os.setsid,
start_new_session=True,
 ) as resp:
 if resp.stdout:
 self.log.info("Output:")
Expand Down

3 changes: 2 additions & 1 deletion
providers/standard/tests/unit/standard/hooks/test_subprocess.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,8 @@ def test_should_exec_subprocess(self, mock_popen, mock_temporary_directory):
 ["bash", "-c", 'echo "stdout"'],
 cwd="/tmp/airflowtmpcatcat",
 env={},
 preexec_fn=mock.ANY,
 restore_signals=True,
 start_new_session=True,
 stderr=STDOUT,
 stdout=PIPE,
 )
Expand Down

2 changes: 1 addition & 1 deletion
providers/teradata/src/airflow/providers/teradata/hooks/bteq.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -263,7 +263,7 @@ def execute_bteq_script_at_local(
 stdout=subprocess.PIPE,
 stderr=subprocess.STDOUT,
 shell=True,
preexec_fn=os.setsid,
start_new_session=True,
 )
 encode_bteq_script = bteq_script.encode(str(temp_file_read_encoding or "UTF-8"))
 stdout_data, _ = process.communicate(input=encode_bteq_script)
Expand Down

2 changes: 1 addition & 1 deletion
providers/teradata/tests/unit/teradata/hooks/test_bteq.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ def test_execute_bteq_script_at_local_success(
 stdout=subprocess.PIPE,
 stderr=subprocess.STDOUT,
 shell=True,
preexec_fn=os.setsid,
start_new_session=True,
 )
 assert ret_code == 0

Expand Down

1 change: 1 addition & 0 deletions
pyproject.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -610,6 +610,7 @@ extend-select = [
 "PLW1501", # {mode} is not a valid mode for open
 "PLW1507", # Shallow copy of os.environ via copy.copy(os.environ)
 "PLW1508", # Invalid type for environment variable default; expected str or None
 "PLW1509", # preexec_fn argument is unsafe when using threads
 "PLW1510", # subprocess.run without explicit check argument
 "PLW1641", # Object does not implement __hash__ method
 # Per rule enables
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable ruff PLW1509 rule by jscheffl · Pull Request #57659 · apache/airflow · GitHub
Skip to content
Enable ruff PLW1509 rule#57659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

jscheffl
merged 2 commits into

from

Nov 6, 2025
 Merged


Enable ruff PLW1509 rule
#57659
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d351ee2

Enable ruff PLW1509 rule


jscheffl Oct 31, 2025
8b2504c

Fix pytests


jscheffl Nov 1, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 2 additions & 9 deletions
providers/standard/src/airflow/providers/standard/hooks/subprocess.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -77,14 +77,6 @@ def run_command(
 """
 self.log.info("Tmp dir root location: %s", gettempdir())
 with working_directory(cwd=cwd) as cwd:

 def pre_exec():
 # Restore default signal disposition and invoke setsid
 for sig in ("SIGPIPE", "SIGXFZ", "SIGXFSZ"):
 if hasattr(signal, sig):
 signal.signal(getattr(signal, sig), signal.SIG_DFL)
 os.setsid()

 self.log.info("Running command: %s", command)

 self.sub_process = Popen(
Expand All@@ -93,7 +85,8 @@ def pre_exec():
 stderr=STDOUT,
 cwd=cwd,
 env=env if env or env == {} else os.environ,
 preexec_fn=pre_exec,
 start_new_session=True,
 restore_signals=True,
 )

 self.log.info("Output:")
Expand Down

3 changes: 1 addition & 2 deletions
providers/standard/src/airflow/providers/standard/sensors/bash.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
# under the License.
from __future__ import annotations

import os
from collections.abc import Sequence
from subprocess import PIPE, STDOUT, Popen
from tempfile import NamedTemporaryFile, TemporaryDirectory, gettempdir
Expand DownExpand Up@@ -89,7 +88,7 @@ def poke(self, context: Context):
 close_fds=True,
 cwd=tmp_dir,
 env=self.env,
preexec_fn=os.setsid,
start_new_session=True,
 ) as resp:
 if resp.stdout:
 self.log.info("Output:")
Expand Down

3 changes: 2 additions & 1 deletion
providers/standard/tests/unit/standard/hooks/test_subprocess.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,8 @@ def test_should_exec_subprocess(self, mock_popen, mock_temporary_directory):
 ["bash", "-c", 'echo "stdout"'],
 cwd="/tmp/airflowtmpcatcat",
 env={},
 preexec_fn=mock.ANY,
 restore_signals=True,
 start_new_session=True,
 stderr=STDOUT,
 stdout=PIPE,
 )
Expand Down

2 changes: 1 addition & 1 deletion
providers/teradata/src/airflow/providers/teradata/hooks/bteq.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -263,7 +263,7 @@ def execute_bteq_script_at_local(
 stdout=subprocess.PIPE,
 stderr=subprocess.STDOUT,
 shell=True,
preexec_fn=os.setsid,
start_new_session=True,
 )
 encode_bteq_script = bteq_script.encode(str(temp_file_read_encoding or "UTF-8"))
 stdout_data, _ = process.communicate(input=encode_bteq_script)
Expand Down

2 changes: 1 addition & 1 deletion
providers/teradata/tests/unit/teradata/hooks/test_bteq.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ def test_execute_bteq_script_at_local_success(
 stdout=subprocess.PIPE,
 stderr=subprocess.STDOUT,
 shell=True,
preexec_fn=os.setsid,
start_new_session=True,
 )
 assert ret_code == 0

Expand Down

1 change: 1 addition & 0 deletions
pyproject.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -610,6 +610,7 @@ extend-select = [
 "PLW1501", # {mode} is not a valid mode for open
 "PLW1507", # Shallow copy of os.environ via copy.copy(os.environ)
 "PLW1508", # Invalid type for environment variable default; expected str or None
 "PLW1509", # preexec_fn argument is unsafe when using threads
 "PLW1510", # subprocess.run without explicit check argument
 "PLW1641", # Object does not implement __hash__ method
 # Per rule enables
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Enable ruff PLW1509 rule by jscheffl · Pull Request #57659 · apache/airflow · GitHub
Skip to content
Enable ruff PLW1509 rule#57659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

jscheffl
merged 2 commits into

from

Nov 6, 2025
 Merged


Enable ruff PLW1509 rule
#57659
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
d351ee2

Enable ruff PLW1509 rule


jscheffl Oct 31, 2025
8b2504c

Fix pytests


jscheffl Nov 1, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


11 changes: 2 additions & 9 deletions
providers/standard/src/airflow/providers/standard/hooks/subprocess.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -77,14 +77,6 @@ def run_command(
 """
 self.log.info("Tmp dir root location: %s", gettempdir())
 with working_directory(cwd=cwd) as cwd:

 def pre_exec():
 # Restore default signal disposition and invoke setsid
 for sig in ("SIGPIPE", "SIGXFZ", "SIGXFSZ"):
 if hasattr(signal, sig):
 signal.signal(getattr(signal, sig), signal.SIG_DFL)
 os.setsid()

 self.log.info("Running command: %s", command)

 self.sub_process = Popen(
Expand All@@ -93,7 +85,8 @@ def pre_exec():
 stderr=STDOUT,
 cwd=cwd,
 env=env if env or env == {} else os.environ,
 preexec_fn=pre_exec,
 start_new_session=True,
 restore_signals=True,
 )

 self.log.info("Output:")
Expand Down

3 changes: 1 addition & 2 deletions
providers/standard/src/airflow/providers/standard/sensors/bash.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@
# under the License.
from __future__ import annotations

import os
from collections.abc import Sequence
from subprocess import PIPE, STDOUT, Popen
from tempfile import NamedTemporaryFile, TemporaryDirectory, gettempdir
Expand DownExpand Up@@ -89,7 +88,7 @@ def poke(self, context: Context):
 close_fds=True,
 cwd=tmp_dir,
 env=self.env,
preexec_fn=os.setsid,
start_new_session=True,
 ) as resp:
 if resp.stdout:
 self.log.info("Output:")
Expand Down

3 changes: 2 additions & 1 deletion
providers/standard/tests/unit/standard/hooks/test_subprocess.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -97,7 +97,8 @@ def test_should_exec_subprocess(self, mock_popen, mock_temporary_directory):
 ["bash", "-c", 'echo "stdout"'],
 cwd="/tmp/airflowtmpcatcat",
 env={},
 preexec_fn=mock.ANY,
 restore_signals=True,
 start_new_session=True,
 stderr=STDOUT,
 stdout=PIPE,
 )
Expand Down

2 changes: 1 addition & 1 deletion
providers/teradata/src/airflow/providers/teradata/hooks/bteq.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -263,7 +263,7 @@ def execute_bteq_script_at_local(
 stdout=subprocess.PIPE,
 stderr=subprocess.STDOUT,
 shell=True,
preexec_fn=os.setsid,
start_new_session=True,
 )
 encode_bteq_script = bteq_script.encode(str(temp_file_read_encoding or "UTF-8"))
 stdout_data, _ = process.communicate(input=encode_bteq_script)
Expand Down

2 changes: 1 addition & 1 deletion
providers/teradata/tests/unit/teradata/hooks/test_bteq.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -150,7 +150,7 @@ def test_execute_bteq_script_at_local_success(
 stdout=subprocess.PIPE,
 stderr=subprocess.STDOUT,
 shell=True,
preexec_fn=os.setsid,
start_new_session=True,
 )
 assert ret_code == 0

Expand Down

1 change: 1 addition & 0 deletions
pyproject.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -610,6 +610,7 @@ extend-select = [
 "PLW1501", # {mode} is not a valid mode for open
 "PLW1507", # Shallow copy of os.environ via copy.copy(os.environ)
 "PLW1508", # Invalid type for environment variable default; expected str or None
 "PLW1509", # preexec_fn argument is unsafe when using threads
 "PLW1510", # subprocess.run without explicit check argument
 "PLW1641", # Object does not implement __hash__ method
 # Per rule enables
Expand Down
Loading