Uh oh!
There was an error while loading. Please reload this page.
Enable ruff PLW1510 rule - #57660
Merged
Merged
Conversation
jscheffl
requested review from
amoghrajesh, ashb, bugraoz93, dstandish, eladkal, ephraimbuddy, gopidesupavan, hussein-awala, jason810496, jedcunningham, kaxil, o-nikolas and potiuk
as code ownersOctober 31, 2025 22:20
bugraoz93
approved these changes
Oct 31, 2025
eladkal
approved these changes
Nov 1, 2025
jason810496
approved these changes
Nov 1, 2025
jschefflforce-pushed
the
feature/add-ruff-plw1510-rule
branch
from
November 1, 2025 09:10
8ad5e8d to
dc6fbc3CompareUh oh!
There was an error while loading. Please reload this page.
Contributor
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker a79d8db v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
jscheffl added a commit
to jscheffl/airflow
that referenced
this pull request
Nov 1, 2025
* Enable ruff PLW1510 rule * Exclude prek check for run_command (cherry picked from commit a79d8db) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
jscheffl added a commit
that referenced
this pull request
Nov 1, 2025
ephraimbuddy pushed a commit
that referenced
this pull request
Nov 3, 2025
ephraimbuddy pushed a commit
that referenced
this pull request
Nov 4, 2025
CopilotAI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
* Enable ruff PLW1510 rule * Exclude prek check for run_command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implementing #57294 I realized that a couple of more ruff PLW rules might be interesting, this PR enables PLW1510
See also https://docs.astral.sh/ruff/rules/#warning-plw