Skip to content

Fix MyPy type error in dagrun.py - #58025

Merged
vincbeck merged 1 commit into
apache:mainfrom
arnoldmr01:bugfix/mypy-type-error-dagrun
Nov 24, 2025
Merged

Fix MyPy type error in dagrun.py#58025
vincbeck merged 1 commit into
apache:mainfrom
arnoldmr01:bugfix/mypy-type-error-dagrun

Conversation

@arnoldmr01

Copy link
Copy Markdown
Contributor

related: #56735

螢幕擷取畫面 2025-11-06 094225

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@arnoldmr01
arnoldmr01force-pushed the bugfix/mypy-type-error-dagrun branch 2 times, most recently from 9b1ba1f to d3d7f8aCompareNovember 7, 2025 08:05
@arnoldmr01
arnoldmr01force-pushed the bugfix/mypy-type-error-dagrun branch from d3d7f8a to e17aa56CompareNovember 7, 2025 22:45
@arnoldmr01

Copy link
Copy Markdown
ContributorAuthor

@vincbeck Sorry for bother you, but I still cannot figure out what's going on with those failure tests. It seemed like something wrong with the Fernet key.

@arnoldmr01
arnoldmr01force-pushed the bugfix/mypy-type-error-dagrun branch from e17aa56 to 8f07540CompareNovember 10, 2025 22:47
Comment threadairflow-core/src/airflow/models/dagrun.py
Comment threadairflow-core/src/airflow/models/dagrun.py Outdated
Comment threadairflow-core/src/airflow/models/dagrun.py Outdated
@arnoldmr01
arnoldmr01force-pushed the bugfix/mypy-type-error-dagrun branch 2 times, most recently from 2a1e3e7 to 90e6600CompareNovember 12, 2025 05:45
Comment threadairflow-core/src/airflow/models/dagrun.py Outdated
@arnoldmr01
arnoldmr01force-pushed the bugfix/mypy-type-error-dagrun branch 2 times, most recently from b680d3e to 6f91371CompareNovember 12, 2025 09:33
Comment threadairflow-core/src/airflow/models/dagrun.py Outdated
@arnoldmr01
arnoldmr01force-pushed the bugfix/mypy-type-error-dagrun branch from 6f91371 to ddf1f1aCompareNovember 13, 2025 18:03
@arnoldmr01
arnoldmr01force-pushed the bugfix/mypy-type-error-dagrun branch from ddf1f1a to ff467e7CompareNovember 20, 2025 07:20
@vincbeck
vincbeck merged commit 5640594 into apache:mainNov 24, 2025
63 checks passed
CopilotAI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@arnoldmr01@potiuk@uranusjr@Dev-iL@vincbeck