Skip to content

Fix bug on the state and run_type filter for Dag Runs page - #58093

Merged
bbovenzi merged 9 commits into
apache:mainfrom
Pei-Cheng-Yu:fix-dag_run-filter-error-with-all_state
Nov 20, 2025
Merged

Fix bug on the state and run_type filter for Dag Runs page#58093
bbovenzi merged 9 commits into
apache:mainfrom
Pei-Cheng-Yu:fix-dag_run-filter-error-with-all_state

Conversation

@Pei-Cheng-Yu

@Pei-Cheng-YuPei-Cheng-Yu commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

WHY

related: #53043
While working on the Task Instances counterpart( #56920 just for ref ), I encountered a similar issue with the “All” option.
On the Dag Runs page, selecting All for State and/or Run Type currently sends values that the backend interprets as real filters, which leads to an error. The "All" option should clear the filter, instead of sends values as filters option

picture:
error param dag-run
image
error run type

error run type all option

HOW

The filter logic now clears the value for the filter itself rather than passing it as a filter value , without affecting other active filters.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label Nov 9, 2025
@guan404ming
guan404mingforce-pushed the fix-dag_run-filter-error-with-all_state branch from b6aebba to be85bf5CompareNovember 9, 2025 16:35
@guan404ming

guan404ming commented Nov 12, 2025

Copy link
Copy Markdown
Member

Could you help resolve the static check error? Thanks!

@Pei-Cheng-Yu
Pei-Cheng-Yuforce-pushed the fix-dag_run-filter-error-with-all_state branch from be85bf5 to 916ae85CompareNovember 12, 2025 07:45
@Pei-Cheng-Yu

Pei-Cheng-Yu commented Nov 12, 2025

Copy link
Copy Markdown
ContributorAuthor

HI @guan404ming, thanks for the review. I have resolved the static check error.

guan404ming
guan404ming approved these changes Nov 14, 2025
View reviewed changes

@guan404mingguan404ming left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

@Pei-Cheng-Yu

Pei-Cheng-Yu commented Nov 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Hi @guan404ming, thank you for the approval!
Just checking in — is there anything else I should do before it can be merged? Totally no rush!
Just making sure I’m not missing anything. Really appreciate your help!

@bbovenzibbovenzi added this to the Airflow 3.1.4 milestone Nov 20, 2025
@bbovenzi
bbovenzi merged commit 9e7b36e into apache:mainNov 20, 2025
60 checks passed
@ephraimbuddyephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Dec 1, 2025
CopilotAI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
@Pei-Cheng-Yu
Fix bug on the state and run_type filter for Dag Runs page (apache#58093
f0a7531
)
* fix bug on the state and run_type filter for Dag Runs page
* fix format
* fix too long file
* fixing static problem
* fix too long file
* fix format problem
* fix format
* fix format
* remove eslint-disable max-lines
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
@Pei-Cheng-Yu@itayweb
Fix bug on the state and run_type filter for Dag Runs page (apache#58093
0906ef2
)
* fix bug on the state and run_type filter for Dag Runs page
* fix format
* fix too long file
* fixing static problem
* fix too long file
* fix format problem
* fix format
* fix format
* remove eslint-disable max-lines
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzibbovenzibbovenzi approved these changes
@guan404mingguan404mingguan404ming approved these changes
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner

Assignees

No one assigned

Labels

area:UIRelated to UI/UX. For Frontend Developers.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Milestone

Airflow 3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Pei-Cheng-Yu@guan404ming@bbovenzi@ephraimbuddy
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix bug on the state and run_type filter for Dag Runs page by Pei-Cheng-Yu · Pull Request #58093 · apache/airflow · GitHub
Skip to content
Fix bug on the state and run_type filter for Dag Runs page - #58093
Merged
bbovenzi merged 9 commits into
apache:mainfrom 
Pei-Cheng-Yu:fix-dag_run-filter-error-with-all_state
Nov 20, 2025
Merged
Fix bug on the state and run_type filter for Dag Runs page#58093
bbovenzi merged 9 commits into
apache:mainfrom 
Pei-Cheng-Yu:fix-dag_run-filter-error-with-all_state
Conversation
@Pei-Cheng-Yu
@Pei-Cheng-YuPei-Cheng-Yu
commented
Nov 9, 2025

Copy link


Copy Markdown

Contributor
WHY
related: #53043

While working on the Task Instances counterpart( #56920 just for ref ), I encountered a similar issue with the “All” option.

On the Dag Runs page, selecting All for State and/or Run Type currently sends values that the backend interprets as real filters, which leads to an error. The "All" option should clear the filter, instead of sends values as filters option
picture:
error param dag-run
image
error run type
error run type all option
HOW
The filter logic now clears the value for the filter itself rather than passing it as a filter value , without affecting other active filters.
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@boring-cyborgboring-cyborgBot
added
the 
area:UI
Related to UI/UX. For Frontend Developers.
label
Nov 9, 2025
@guan404ming
guan404mingforce-pushed
the
fix-dag_run-filter-error-with-all_state
branch
from
b6aebba to
be85bf5CompareNovember 9, 2025 16:35
@guan404ming
guan404ming
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
Could you help resolve the static check error? Thanks!
@Pei-Cheng-Yu
Pei-Cheng-Yuforce-pushed
the
fix-dag_run-filter-error-with-all_state
branch
from
be85bf5 to
916ae85CompareNovember 12, 2025 07:45
@Pei-Cheng-Yu
Pei-Cheng-Yu
commented
Nov 12, 2025

Copy link


Copy Markdown

ContributorAuthor
HI @guan404ming, thanks for the review. I have resolved the static check error.
guan404ming
guan404ming
approved these changes
Nov 14, 2025
View reviewed changes
@guan404mingguan404ming
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update
@Pei-Cheng-Yu
Pei-Cheng-Yu
commented
Nov 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Hi @guan404ming, thank you for the approval!

Just checking in — is there anything else I should do before it can be merged? Totally no rush!

Just making sure I’m not missing anything. Really appreciate your help!
@bbovenzibbovenzi
added this to the Airflow 3.1.4 milestone
Nov 20, 2025
@bbovenzi
bbovenzi
merged commit 9e7b36e
into
apache:mainNov 20, 2025

60 checks passed

@ephraimbuddyephraimbuddy
added
the 
type:bug-fix
Changelog: Bug Fixes
label
Dec 1, 2025
CopilotAI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
@Pei-Cheng-Yu
Fix bug on the state and run_type filter for Dag Runs page (apache#58093
f0a7531
)
* fix bug on the state and run_type filter for Dag Runs page
* fix format
* fix too long file
* fixing static problem
* fix too long file
* fix format problem
* fix format
* fix format
* remove eslint-disable max-lines
itayweb pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
@Pei-Cheng-Yu@itayweb
Fix bug on the state and run_type filter for Dag Runs page (apache#58093
0906ef2
)
* fix bug on the state and run_type filter for Dag Runs page
* fix format
* fix too long file
* fixing static problem
* fix too long file
* fix format problem
* fix format
* fix format
* remove eslint-disable max-lines
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@bbovenzibbovenzibbovenzi approved these changes
@guan404mingguan404mingguan404ming approved these changes
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner

Assignees


No one assigned


Labels

area:UIRelated to UI/UX. For Frontend Developers.type:bug-fixChangelog: Bug Fixes

Projects


None yet


Milestone

Airflow 3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Pei-Cheng-Yu@guan404ming@bbovenzi@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix bug on the state and run_type filter for Dag Runs page by Pei-Cheng-Yu · Pull Request #58093 · apache/airflow · GitHub
Skip to content
Fix bug on the state and run_type filter for Dag Runs page - #58093
Merged
bbovenzi merged 9 commits into
apache:mainfrom 
Pei-Cheng-Yu:fix-dag_run-filter-error-with-all_state
Nov 20, 2025
Merged
Fix bug on the state and run_type filter for Dag Runs page#58093
bbovenzi merged 9 commits into
apache:mainfrom 
Pei-Cheng-Yu:fix-dag_run-filter-error-with-all_state
Conversation
@Pei-Cheng-Yu
@Pei-Cheng-YuPei-Cheng-Yu
commented
Nov 9, 2025

Copy link


Copy Markdown

Contributor
WHY
related: #53043

While working on the Task Instances counterpart( #56920 just for ref ), I encountered a similar issue with the “All” option.

On the Dag Runs page, selecting All for State and/or Run Type currently sends values that the backend interprets as real filters, which leads to an error. The "All" option should clear the filter, instead of sends values as filters option
picture:
error param dag-run
image
error run type
error run type all option
HOW
The filter logic now clears the value for the filter itself rather than passing it as a filter value , without affecting other active filters.
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@boring-cyborgboring-cyborgBot
added
the 
area:UI
Related to UI/UX. For Frontend Developers.
label
Nov 9, 2025
@guan404ming
guan404mingforce-pushed
the
fix-dag_run-filter-error-with-all_state
branch
from
b6aebba to
be85bf5CompareNovember 9, 2025 16:35
@guan404ming
guan404ming
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
Could you help resolve the static check error? Thanks!
@Pei-Cheng-Yu
Pei-Cheng-Yuforce-pushed
the
fix-dag_run-filter-error-with-all_state
branch
from
be85bf5 to
916ae85CompareNovember 12, 2025 07:45
@Pei-Cheng-Yu
Pei-Cheng-Yu
commented
Nov 12, 2025

Copy link


Copy Markdown

ContributorAuthor
HI @guan404ming, thanks for the review. I have resolved the static check error.
guan404ming
guan404ming
approved these changes
Nov 14, 2025
View reviewed changes
@guan404mingguan404ming
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update
@Pei-Cheng-Yu
Pei-Cheng-Yu
commented
Nov 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Hi @guan404ming, thank you for the approval!

Just checking in — is there anything else I should do before it can be merged? Totally no rush!

Just making sure I’m not missing anything. Really appreciate your help!
@bbovenzibbovenzi
added this to the Airflow 3.1.4 milestone
Nov 20, 2025
@bbovenzi
bbovenzi
merged commit 9e7b36e
into
apache:mainNov 20, 2025

60 checks passed

@ephraimbuddyephraimbuddy
added
the 
type:bug-fix
Changelog: Bug Fixes
label
Dec 1, 2025
CopilotAI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
@Pei-Cheng-Yu
Fix bug on the state and run_type filter for Dag Runs page (apache#58093
f0a7531
)
* fix bug on the state and run_type filter for Dag Runs page
* fix format
* fix too long file
* fixing static problem
* fix too long file
* fix format problem
* fix format
* fix format
* remove eslint-disable max-lines
itayweb pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
@Pei-Cheng-Yu@itayweb
Fix bug on the state and run_type filter for Dag Runs page (apache#58093
0906ef2
)
* fix bug on the state and run_type filter for Dag Runs page
* fix format
* fix too long file
* fixing static problem
* fix too long file
* fix format problem
* fix format
* fix format
* remove eslint-disable max-lines
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@bbovenzibbovenzibbovenzi approved these changes
@guan404mingguan404mingguan404ming approved these changes
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner

Assignees


No one assigned


Labels

area:UIRelated to UI/UX. For Frontend Developers.type:bug-fixChangelog: Bug Fixes

Projects


None yet


Milestone

Airflow 3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Pei-Cheng-Yu@guan404ming@bbovenzi@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix bug on the state and run_type filter for Dag Runs page by Pei-Cheng-Yu · Pull Request #58093 · apache/airflow · GitHub
Skip to content
Fix bug on the state and run_type filter for Dag Runs page - #58093
Merged
bbovenzi merged 9 commits into
apache:mainfrom 
Pei-Cheng-Yu:fix-dag_run-filter-error-with-all_state
Nov 20, 2025
Merged
Fix bug on the state and run_type filter for Dag Runs page#58093
bbovenzi merged 9 commits into
apache:mainfrom 
Pei-Cheng-Yu:fix-dag_run-filter-error-with-all_state
Conversation
@Pei-Cheng-Yu
@Pei-Cheng-YuPei-Cheng-Yu
commented
Nov 9, 2025

Copy link


Copy Markdown

Contributor
WHY
related: #53043

While working on the Task Instances counterpart( #56920 just for ref ), I encountered a similar issue with the “All” option.

On the Dag Runs page, selecting All for State and/or Run Type currently sends values that the backend interprets as real filters, which leads to an error. The "All" option should clear the filter, instead of sends values as filters option
picture:
error param dag-run
image
error run type
error run type all option
HOW
The filter logic now clears the value for the filter itself rather than passing it as a filter value , without affecting other active filters.
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@boring-cyborgboring-cyborgBot
added
the 
area:UI
Related to UI/UX. For Frontend Developers.
label
Nov 9, 2025
@guan404ming
guan404mingforce-pushed
the
fix-dag_run-filter-error-with-all_state
branch
from
b6aebba to
be85bf5CompareNovember 9, 2025 16:35
@guan404ming
guan404ming
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
Could you help resolve the static check error? Thanks!
@Pei-Cheng-Yu
Pei-Cheng-Yuforce-pushed
the
fix-dag_run-filter-error-with-all_state
branch
from
be85bf5 to
916ae85CompareNovember 12, 2025 07:45
@Pei-Cheng-Yu
Pei-Cheng-Yu
commented
Nov 12, 2025

Copy link


Copy Markdown

ContributorAuthor
HI @guan404ming, thanks for the review. I have resolved the static check error.
guan404ming
guan404ming
approved these changes
Nov 14, 2025
View reviewed changes
@guan404mingguan404ming
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update
@Pei-Cheng-Yu
Pei-Cheng-Yu
commented
Nov 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Hi @guan404ming, thank you for the approval!

Just checking in — is there anything else I should do before it can be merged? Totally no rush!

Just making sure I’m not missing anything. Really appreciate your help!
@bbovenzibbovenzi
added this to the Airflow 3.1.4 milestone
Nov 20, 2025
@bbovenzi
bbovenzi
merged commit 9e7b36e
into
apache:mainNov 20, 2025

60 checks passed

@ephraimbuddyephraimbuddy
added
the 
type:bug-fix
Changelog: Bug Fixes
label
Dec 1, 2025
CopilotAI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
@Pei-Cheng-Yu
Fix bug on the state and run_type filter for Dag Runs page (apache#58093
f0a7531
)
* fix bug on the state and run_type filter for Dag Runs page
* fix format
* fix too long file
* fixing static problem
* fix too long file
* fix format problem
* fix format
* fix format
* remove eslint-disable max-lines
itayweb pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
@Pei-Cheng-Yu@itayweb
Fix bug on the state and run_type filter for Dag Runs page (apache#58093
0906ef2
)
* fix bug on the state and run_type filter for Dag Runs page
* fix format
* fix too long file
* fixing static problem
* fix too long file
* fix format problem
* fix format
* fix format
* remove eslint-disable max-lines
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@bbovenzibbovenzibbovenzi approved these changes
@guan404mingguan404mingguan404ming approved these changes
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner

Assignees


No one assigned


Labels

area:UIRelated to UI/UX. For Frontend Developers.type:bug-fixChangelog: Bug Fixes

Projects


None yet


Milestone

Airflow 3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Pei-Cheng-Yu@guan404ming@bbovenzi@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Fix bug on the state and run_type filter for Dag Runs page by Pei-Cheng-Yu · Pull Request #58093 · apache/airflow · GitHub
Skip to content
Fix bug on the state and run_type filter for Dag Runs page - #58093
Merged
bbovenzi merged 9 commits into
apache:mainfrom 
Pei-Cheng-Yu:fix-dag_run-filter-error-with-all_state
Nov 20, 2025
Merged
Fix bug on the state and run_type filter for Dag Runs page#58093
bbovenzi merged 9 commits into
apache:mainfrom 
Pei-Cheng-Yu:fix-dag_run-filter-error-with-all_state
Conversation
@Pei-Cheng-Yu
@Pei-Cheng-YuPei-Cheng-Yu
commented
Nov 9, 2025

Copy link


Copy Markdown

Contributor
WHY
related: #53043

While working on the Task Instances counterpart( #56920 just for ref ), I encountered a similar issue with the “All” option.

On the Dag Runs page, selecting All for State and/or Run Type currently sends values that the backend interprets as real filters, which leads to an error. The "All" option should clear the filter, instead of sends values as filters option
picture:
error param dag-run
image
error run type
error run type all option
HOW
The filter logic now clears the value for the filter itself rather than passing it as a filter value , without affecting other active filters.
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@boring-cyborgboring-cyborgBot
added
the 
area:UI
Related to UI/UX. For Frontend Developers.
label
Nov 9, 2025
@guan404ming
guan404mingforce-pushed
the
fix-dag_run-filter-error-with-all_state
branch
from
b6aebba to
be85bf5CompareNovember 9, 2025 16:35
@guan404ming
guan404ming
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
Could you help resolve the static check error? Thanks!
@Pei-Cheng-Yu
Pei-Cheng-Yuforce-pushed
the
fix-dag_run-filter-error-with-all_state
branch
from
be85bf5 to
916ae85CompareNovember 12, 2025 07:45
@Pei-Cheng-Yu
Pei-Cheng-Yu
commented
Nov 12, 2025

Copy link


Copy Markdown

ContributorAuthor
HI @guan404ming, thanks for the review. I have resolved the static check error.
guan404ming
guan404ming
approved these changes
Nov 14, 2025
View reviewed changes
@guan404mingguan404ming
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update
@Pei-Cheng-Yu
Pei-Cheng-Yu
commented
Nov 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Hi @guan404ming, thank you for the approval!

Just checking in — is there anything else I should do before it can be merged? Totally no rush!

Just making sure I’m not missing anything. Really appreciate your help!
@bbovenzibbovenzi
added this to the Airflow 3.1.4 milestone
Nov 20, 2025
@bbovenzi
bbovenzi
merged commit 9e7b36e
into
apache:mainNov 20, 2025

60 checks passed

@ephraimbuddyephraimbuddy
added
the 
type:bug-fix
Changelog: Bug Fixes
label
Dec 1, 2025
CopilotAI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
@Pei-Cheng-Yu
Fix bug on the state and run_type filter for Dag Runs page (apache#58093
f0a7531
)
* fix bug on the state and run_type filter for Dag Runs page
* fix format
* fix too long file
* fixing static problem
* fix too long file
* fix format problem
* fix format
* fix format
* remove eslint-disable max-lines
itayweb pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
@Pei-Cheng-Yu@itayweb
Fix bug on the state and run_type filter for Dag Runs page (apache#58093
0906ef2
)
* fix bug on the state and run_type filter for Dag Runs page
* fix format
* fix too long file
* fixing static problem
* fix too long file
* fix format problem
* fix format
* fix format
* remove eslint-disable max-lines
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@bbovenzibbovenzibbovenzi approved these changes
@guan404mingguan404mingguan404ming approved these changes
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner

Assignees


No one assigned


Labels

area:UIRelated to UI/UX. For Frontend Developers.type:bug-fixChangelog: Bug Fixes

Projects


None yet


Milestone

Airflow 3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Pei-Cheng-Yu@guan404ming@bbovenzi@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix bug on the state and run_type filter for Dag Runs page by Pei-Cheng-Yu · Pull Request #58093 · apache/airflow · GitHub
Skip to content
Fix bug on the state and run_type filter for Dag Runs page - #58093
Merged
bbovenzi merged 9 commits into
apache:mainfrom 
Pei-Cheng-Yu:fix-dag_run-filter-error-with-all_state
Nov 20, 2025
Merged
Fix bug on the state and run_type filter for Dag Runs page#58093
bbovenzi merged 9 commits into
apache:mainfrom 
Pei-Cheng-Yu:fix-dag_run-filter-error-with-all_state
Conversation
@Pei-Cheng-Yu
@Pei-Cheng-YuPei-Cheng-Yu
commented
Nov 9, 2025

Copy link


Copy Markdown

Contributor
WHY
related: #53043

While working on the Task Instances counterpart( #56920 just for ref ), I encountered a similar issue with the “All” option.

On the Dag Runs page, selecting All for State and/or Run Type currently sends values that the backend interprets as real filters, which leads to an error. The "All" option should clear the filter, instead of sends values as filters option
picture:
error param dag-run
image
error run type
error run type all option
HOW
The filter logic now clears the value for the filter itself rather than passing it as a filter value , without affecting other active filters.
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@boring-cyborgboring-cyborgBot
added
the 
area:UI
Related to UI/UX. For Frontend Developers.
label
Nov 9, 2025
@guan404ming
guan404mingforce-pushed
the
fix-dag_run-filter-error-with-all_state
branch
from
b6aebba to
be85bf5CompareNovember 9, 2025 16:35
@guan404ming
guan404ming
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
Could you help resolve the static check error? Thanks!
@Pei-Cheng-Yu
Pei-Cheng-Yuforce-pushed
the
fix-dag_run-filter-error-with-all_state
branch
from
be85bf5 to
916ae85CompareNovember 12, 2025 07:45
@Pei-Cheng-Yu
Pei-Cheng-Yu
commented
Nov 12, 2025

Copy link


Copy Markdown

ContributorAuthor
HI @guan404ming, thanks for the review. I have resolved the static check error.
guan404ming
guan404ming
approved these changes
Nov 14, 2025
View reviewed changes
@guan404mingguan404ming
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update
@Pei-Cheng-Yu
Pei-Cheng-Yu
commented
Nov 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Hi @guan404ming, thank you for the approval!

Just checking in — is there anything else I should do before it can be merged? Totally no rush!

Just making sure I’m not missing anything. Really appreciate your help!
@bbovenzibbovenzi
added this to the Airflow 3.1.4 milestone
Nov 20, 2025
@bbovenzi
bbovenzi
merged commit 9e7b36e
into
apache:mainNov 20, 2025

60 checks passed

@ephraimbuddyephraimbuddy
added
the 
type:bug-fix
Changelog: Bug Fixes
label
Dec 1, 2025
CopilotAI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
@Pei-Cheng-Yu
Fix bug on the state and run_type filter for Dag Runs page (apache#58093
f0a7531
)
* fix bug on the state and run_type filter for Dag Runs page
* fix format
* fix too long file
* fixing static problem
* fix too long file
* fix format problem
* fix format
* fix format
* remove eslint-disable max-lines
itayweb pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
@Pei-Cheng-Yu@itayweb
Fix bug on the state and run_type filter for Dag Runs page (apache#58093
0906ef2
)
* fix bug on the state and run_type filter for Dag Runs page
* fix format
* fix too long file
* fixing static problem
* fix too long file
* fix format problem
* fix format
* fix format
* remove eslint-disable max-lines
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@bbovenzibbovenzibbovenzi approved these changes
@guan404mingguan404mingguan404ming approved these changes
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner

Assignees


No one assigned


Labels

area:UIRelated to UI/UX. For Frontend Developers.type:bug-fixChangelog: Bug Fixes

Projects


None yet


Milestone

Airflow 3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Pei-Cheng-Yu@guan404ming@bbovenzi@ephraimbuddy

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Fix bug on the state and run_type filter for Dag Runs page by Pei-Cheng-Yu · Pull Request #58093 · apache/airflow · GitHub
Skip to content
Fix bug on the state and run_type filter for Dag Runs page - #58093
Merged
bbovenzi merged 9 commits into
apache:mainfrom 
Pei-Cheng-Yu:fix-dag_run-filter-error-with-all_state
Nov 20, 2025
Merged
Fix bug on the state and run_type filter for Dag Runs page#58093
bbovenzi merged 9 commits into
apache:mainfrom 
Pei-Cheng-Yu:fix-dag_run-filter-error-with-all_state
Conversation
@Pei-Cheng-Yu
@Pei-Cheng-YuPei-Cheng-Yu
commented
Nov 9, 2025

Copy link


Copy Markdown

Contributor
WHY
related: #53043

While working on the Task Instances counterpart( #56920 just for ref ), I encountered a similar issue with the “All” option.

On the Dag Runs page, selecting All for State and/or Run Type currently sends values that the backend interprets as real filters, which leads to an error. The "All" option should clear the filter, instead of sends values as filters option
picture:
error param dag-run
image
error run type
error run type all option
HOW
The filter logic now clears the value for the filter itself rather than passing it as a filter value , without affecting other active filters.
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@boring-cyborgboring-cyborgBot
added
the 
area:UI
Related to UI/UX. For Frontend Developers.
label
Nov 9, 2025
@guan404ming
guan404mingforce-pushed
the
fix-dag_run-filter-error-with-all_state
branch
from
b6aebba to
be85bf5CompareNovember 9, 2025 16:35
@guan404ming
guan404ming
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
Could you help resolve the static check error? Thanks!
@Pei-Cheng-Yu
Pei-Cheng-Yuforce-pushed
the
fix-dag_run-filter-error-with-all_state
branch
from
be85bf5 to
916ae85CompareNovember 12, 2025 07:45
@Pei-Cheng-Yu
Pei-Cheng-Yu
commented
Nov 12, 2025

Copy link


Copy Markdown

ContributorAuthor
HI @guan404ming, thanks for the review. I have resolved the static check error.
guan404ming
guan404ming
approved these changes
Nov 14, 2025
View reviewed changes
@guan404mingguan404ming
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update
@Pei-Cheng-Yu
Pei-Cheng-Yu
commented
Nov 19, 2025

Copy link


Copy Markdown

ContributorAuthor
Hi @guan404ming, thank you for the approval!

Just checking in — is there anything else I should do before it can be merged? Totally no rush!

Just making sure I’m not missing anything. Really appreciate your help!
@bbovenzibbovenzi
added this to the Airflow 3.1.4 milestone
Nov 20, 2025
@bbovenzi
bbovenzi
merged commit 9e7b36e
into
apache:mainNov 20, 2025

60 checks passed

@ephraimbuddyephraimbuddy
added
the 
type:bug-fix
Changelog: Bug Fixes
label
Dec 1, 2025
CopilotAI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
@Pei-Cheng-Yu
Fix bug on the state and run_type filter for Dag Runs page (apache#58093
f0a7531
)
* fix bug on the state and run_type filter for Dag Runs page
* fix format
* fix too long file
* fixing static problem
* fix too long file
* fix format problem
* fix format
* fix format
* remove eslint-disable max-lines
itayweb pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
@Pei-Cheng-Yu@itayweb
Fix bug on the state and run_type filter for Dag Runs page (apache#58093
0906ef2
)
* fix bug on the state and run_type filter for Dag Runs page
* fix format
* fix too long file
* fixing static problem
* fix too long file
* fix format problem
* fix format
* fix format
* remove eslint-disable max-lines
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@bbovenzibbovenzibbovenzi approved these changes
@guan404mingguan404mingguan404ming approved these changes
@pierrejeambrunpierrejeambrunAwaiting requested review from pierrejeambrunpierrejeambrun is a code owner
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner

Assignees


No one assigned


Labels

area:UIRelated to UI/UX. For Frontend Developers.type:bug-fixChangelog: Bug Fixes

Projects


None yet


Milestone

Airflow 3.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Pei-Cheng-Yu@guan404ming@bbovenzi@ephraimbuddy