Uh oh!
There was an error while loading. Please reload this page.
Move deadline_alerts into their own table for UI integration - #58248
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ramitkataria
commented
Nov 13, 2025
I just briefly looked at callback related changes but will try to take a more thorough look later if I get a chance |
Lee-W
left a comment
There was a problem hiding this comment.
I took a quick look and left a few questions. will take a deeper look when I have the chance. Thanks!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
91e1fde to
3c3f91eCompare7cf9d50 to
4f30bddCompareferruzzi
commented
Nov 25, 2025
Some of those commits were trial and error so I'm cleaning up the commits and clearing ou5t some unnecessary changes. |
4590d4b to
b44390cCompare
ephraimbuddy
left a comment
There was a problem hiding this comment.
We need to be careful in updating the deadline alert through the serdag to avoid updating the wrong version since we now have dag versioning.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
5b0f528 to
130fbebCompare130fbeb to
2ee570fCompareUh oh!
There was an error while loading. Please reload this page.
Moves the DeadlineAlert definitions out of the serialized_dag and into their own table in order to make UI integration easier for @bbovenzi.
I kn ow I tagged a lot of you. This is my biggest migration to date so I'd appreciate extra eyes on the SQL queries in particular. I put together a very extensive manual testing plan that consists of "paste this command into the terminal and you should see this output" steps for testing upgrading and downgrading with and without the COMPRESS_SERIALIZED_DAGS flag enabled. Double-checking that those testing commands are valid would also be a great help.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.