Uh oh!
There was an error while loading. Please reload this page.
Sync v3-1-stable with v3-1-test to release 3.1.4rc2 - #59192
Merged
Conversation
ephraimbuddy
requested review from
XD-DENG, amoghrajesh, ashb, bbovenzi, bolkedebruin, bugraoz93, eladkal, gopidesupavan, jason810496, jedcunningham, jscheffl, kaxil, pierrejeambrun, potiuk, rawwar, ryanahamilton, shubhamraj-git and vincbeck
as code ownersDecember 8, 2025 09:46
ephraimbuddy
commented
Dec 8, 2025
ContributorAuthor
Please don't merge, I will do so through the command line |
amoghrajesh
approved these changes
Dec 8, 2025
ephraimbuddyforce-pushed
the
changes-3.1.4rc2
branch
from
December 8, 2025 11:20
7cee2fb to
376cb76Comparevatsrahul1001
approved these changes
Dec 8, 2025
ephraimbuddy
marked this pull request as draft
December 8, 2025 12:07
ashb
reviewed
Dec 8, 2025
Uh oh!
There was an error while loading. Please reload this page.
ephraimbuddyforce-pushed
the
changes-3.1.4rc2
branch
from
December 8, 2025 15:00
376cb76 to
f49f18bCompareephraimbuddy
marked this pull request as ready for review
December 8, 2025 15:00
bugraoz93
approved these changes
Dec 8, 2025
pierrejeambrun
approved these changes
Dec 8, 2025
ephraimbuddyforce-pushed
the
changes-3.1.4rc2
branch
from
December 8, 2025 15:12
f49f18b to
08056ceCompare…unordered dicts (#59091) (#59175) Dags using operators with dictionary values in template_fields (such as env_vars) were getting different hashes on each parse, even when the actual dictionary content was unchanged. This happened because serialize_template_field converts dictionaries to string using str(), which preserves insertion order. When dictionary ordering varies between parses (e.g., when env_vars comes from os.environ.copy()), the string representation differs, causing inconsistent hashing. Prevents unnecessary Dag updates and reprocessing when only dictionary ordering differs in template fields. (cherry picked from commit d46a9d1) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
(cherry picked from commit d0e6222)
(cherry picked from commit d7174df)
ephraimbuddyforce-pushed
the
changes-3.1.4rc2
branch
from
December 8, 2025 16:43
08056ce to
60f6b2cComparepotiuk
approved these changes
Dec 8, 2025
Uh oh!
There was an error while loading. Please reload this page.
potiuk
commented
Dec 8, 2025
Member
Was #58987 reverted permanently in main or only here? |
potiuk
commented
Dec 8, 2025
Member
Ah @ephraimbuddy -> also #59212 should be added |
ephraimbuddy
commented
Dec 8, 2025
ContributorAuthor
Only in test branch |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time for
3.1.4rc2