Skip to content

Remove global in configuration.py - #59819

Merged
jscheffl merged 1 commit into
apache:mainfrom
jscheffl:bugfix/remove-global-from-configuration
Dec 27, 2025
Merged

Remove global in configuration.py#59819
jscheffl merged 1 commit into
apache:mainfrom
jscheffl:bugfix/remove-global-from-configuration

Conversation

@jscheffl

Copy link
Copy Markdown
Contributor

Another small increment to remove global statements for PR #58116

This removes (most of the) global statements from configuration.py where the JWT and FERNET key were hold, smelled a bit like a public interfaces which it should not. Using a private container class to prevent usage of global variables.

The leftover AIRFLOW_HOME is marked deprecated so in this case I'd rather exclude from future PLW0603 checks

global is evil.

Comment threadairflow-core/src/airflow/configuration.py
@jscheffljscheffl added full tests needed We need to run full set of tests for this PR to merge all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs labels Dec 26, 2025
@jscheffl
jscheffl marked this pull request as ready for review December 26, 2025 13:35
@jscheffl
jschefflforce-pushed the bugfix/remove-global-from-configuration branch from 336bbeb to bb130beCompareDecember 26, 2025 21:49
@jscheffljscheffl changed the title Exclude check for global in configuration.pyRemove global in configuration.pyDec 26, 2025
Comment threadairflow-core/src/airflow/configuration.py
@jscheffl
jscheffl merged commit 0343763 into apache:mainDec 27, 2025
209 checks passed
amoghrajesh pushed a commit to astronomer/airflow that referenced this pull request Dec 29, 2025
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Jan 2, 2026
stegololz pushed a commit to stegololz/airflow that referenced this pull request Jan 9, 2026
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

all versionsIf set, the CI build will be forced to use all versions of Python/K8S/DBsfull tests neededWe need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jscheffl@potiuk