Uh oh!
There was an error while loading. Please reload this page.
Remove global from plugins_manager - #59851
Merged
potiuk merged 7 commits intoDec 28, 2025
Merged
Conversation
potiuk
reviewed
Dec 27, 2025
Uh oh!
There was an error while loading. Please reload this page.
potiuk
commented
Dec 27, 2025
Member
Why the .js changes? |
jscheffl
commented
Dec 27, 2025
ContributorAuthor
Somehow the Prek plugin for JS compiler kicked-in after the small PY changes in FAB... not sure why. Seems some signature change... |
potiuk
commented
Dec 27, 2025
Member
This one changed: And it matches "www" of the provider: We should probably make it a bit more selective when we switch to |
jschefflforce-pushed
the
bugfix/remove-global-from-plugins-manager
branch
from
December 27, 2025 22:34
c3227c5 to
a1b9d32Comparejschefflforce-pushed
the
bugfix/remove-global-from-plugins-manager
branch
from
December 28, 2025 17:35
491484a to
4f7dea5Comparejscheffl
marked this pull request as ready for review
December 28, 2025 17:37
jscheffl
requested review from
amoghrajesh, ashb, bugraoz93, kaxil and vincbeck
as code ownersDecember 28, 2025 17:37
jscheffl
requested review from
bolkedebruin, ephraimbuddy, jason810496, pierrejeambrun, rawwar and shubhamraj-git
as code ownersDecember 28, 2025 17:37
jscheffl
commented
Dec 28, 2025
ContributorAuthor
Changes the config in this PR now as the JS changes generated false alarms and this bothered me. Ready for review now! |
Uh oh!
There was an error while loading. Please reload this page.
54 tasks
Subham-KRLX pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Jan 2, 2026
* Remove global from plaungs_manager * Further rework and cleanup * Prevent re-build of Fab assets, change exclusions * Fixes * Fixes * Fixes * Fixes
stegololz pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
* Remove global from plaungs_manager * Further rework and cleanup * Prevent re-build of Fab assets, change exclusions * Fixes * Fixes * Fixes * Fixes
jhgoebbert pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
* Remove global from plaungs_manager * Further rework and cleanup * Prevent re-build of Fab assets, change exclusions * Fixes * Fixes * Fixes * Fixes
Subham-KRLX pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Mar 4, 2026
* Remove global from plaungs_manager * Further rework and cleanup * Prevent re-build of Fab assets, change exclusions * Fixes * Fixes * Fixes * Fixes
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
* Remove global from plaungs_manager * Further rework and cleanup * Prevent re-build of Fab assets, change exclusions * Fixes * Fixes * Fixes * Fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another small (in this case rather medium complex) increment to remove global statements for PR #58116
This removes global statements from plugins_manager.py where the a lot of state was hold in variables used with
globaland then a lot of code way relying to access these globals. Smelled a like a public interface and needed a bit of refactoring in other parts of the core to use proper access methods. Using new access methods withget_...()for all access with functools.cache() to prevent usage of global variables. All non external used methods marked as private to ensure it is not implicitly getting to be a public interface.globalis evil.