Skip to content

Assorted SQLA2/Mypy fixes - #60094

Merged
potiuk merged 8 commits into
apache:mainfrom
Dev-iL:2601/sqla2_mypy_assorted
Jan 4, 2026
Merged

Assorted SQLA2/Mypy fixes#60094
potiuk merged 8 commits into
apache:mainfrom
Dev-iL:2601/sqla2_mypy_assorted

Conversation

@Dev-iL

@Dev-iLDev-iL commented Jan 4, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Context:

https://github.com/apache/airflow/actions/runs/20681629287/job/59376845610?pr=59218#step:7:1199
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845598?pr=59218#step:7:4224

airflow-core/src/airflow/models/trigger.py:130: error: Incompatible types in assignment (expression has type "str | None", variable has type "SQLCoreOperations[str] | str") [assignment]
self.queue = queue
^~~~~
airflow-core/src/airflow/models/trigger.py:487: error: Incompatible types in assignment (expression has type "float | int | dict[Any, Any] | list[Any] | str | tuple[Any, ...] | set[Any] | None",
variable has type "SQLCoreOperations[dict[Any, Any] | None] | dict[Any, Any] | None") [assignment]
task_instance.next_kwargs = serialize(next_kwargs)
^~~~~~~~~~~~~~~~~~~~~~
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: error: Unsupported operand types for >= ("int" and "None") [operator]
exceeds = active_non_backfill_runs >= dag_model.max_active_runs
^
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: note: Right operand is of type "int | None"
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:38: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
create_engine = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:39: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
inspect = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:40: error: Incompatible types in assignment (expression has type "None", variable has type "Callable[[str | URL], URL]") [assignment]
make_url = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Cannot assign to a type [misc]
ArgumentError = Exception
^~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[ArgumentError]") [assignment]
ArgumentError = Exception
^~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Cannot assign to a type [misc]
NoSuchModuleError = Exception
^~~~~~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[NoSuchModuleError]") [assignment]
NoSuchModuleError = Exception
^~~~~~~~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Cannot assign to a type [misc]
URL = None
^~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Incompatible types in assignment (expression has type "None", variable has type "type[URL]") [assignment]
URL = None
^~~~
providers/standard/tests/unit/standard/operators/test_hitl.py:263: error: Incompatible types in assignment (expression has type "UUID", variable has type "str") [assignment]
expected_ti_id = UUID(ti.id)
^~~~~~~~~~~
providers/openlineage/tests/unit/openlineage/plugins/test_listener.py:211: error: Argument "dag_version_id" to "create_task_instance" has incompatible type "str | None"; expected "UUID" [arg-type]
dag_version_id=dagrun.created_dag_version_id,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Cannot assign to a type [misc]
URL = create_engine = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type "type[URL]") [assignment]
URL = create_engine = None
^
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type overloaded function) [assignment]
URL = create_engine = None
^~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Cannot assign to a type [misc]
URL = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Incompatible types in assignment (expression has type
"None", variable has type "type[URL]") [assignment]
URL = None
^~~~

Related: #59218, #59895

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Dev-iL
Dev-iLforce-pushed the 2601/sqla2_mypy_assorted branch from b7f802a to b27b427CompareJanuary 4, 2026 09:34
@Dev-iL
Dev-iL requested a review from o-nikolas as a code ownerJanuary 4, 2026 09:34
@Dev-iL

Dev-iL commented Jan 4, 2026•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

cc @potiuk@Prab-27@vincbeck

@potiuk
potiuk merged commit a971bcc into apache:mainJan 4, 2026
99 checks passed
@potiuk

potiuk commented Jan 4, 2026

Copy link
Copy Markdown
Member

thanks. Yeah .. we should move to sqla2 asap to stop getting those creeping in.

@Dev-iL
Dev-iL deleted the 2601/sqla2_mypy_assorted branch January 4, 2026 21:58
stegololz pushed a commit to stegololz/airflow that referenced this pull request Jan 9, 2026
@Dev-iL@stegololz
Assorted SQLA2/Mypy fixes (apache#60094)
b846f80
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
@Dev-iL@jhgoebbert
Assorted SQLA2/Mypy fixes (apache#60094)
9c45cad
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
@Dev-iL@Subham-KRLX
Assorted SQLA2/Mypy fixes (apache#60094)
1c73031
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
@Dev-iL@Ankurdeewan
Assorted SQLA2/Mypy fixes (apache#60094)
46abab4
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@mobuchowskimobuchowskiAwaiting requested review from mobuchowskimobuchowski is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@o-nikolaso-nikolasAwaiting requested review from o-nikolaso-nikolas is a code owner

Assignees

No one assigned

Labels

area:providersarea:Schedulerincluding HA (high availability) schedulerarea:task-sdkarea:Triggererprovider:common-sqlprovider:exasolprovider:openlineageAIP-53provider:standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dev-iL@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Assorted SQLA2/Mypy fixes by Dev-iL · Pull Request #60094 · apache/airflow · GitHub
Skip to content
Assorted SQLA2/Mypy fixes - #60094
Merged
potiuk merged 8 commits into
apache:mainfrom 
Dev-iL:2601/sqla2_mypy_assorted
Jan 4, 2026
Merged
Assorted SQLA2/Mypy fixes#60094
potiuk merged 8 commits into
apache:mainfrom 
Dev-iL:2601/sqla2_mypy_assorted
Conversation
@Dev-iL
@Dev-iLDev-iL
commented
Jan 4, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Context:
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845610?pr=59218#step:7:1199
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845598?pr=59218#step:7:4224
airflow-core/src/airflow/models/trigger.py:130: error: Incompatible types in assignment (expression has type "str | None", variable has type "SQLCoreOperations[str] | str") [assignment]
self.queue = queue
^~~~~
airflow-core/src/airflow/models/trigger.py:487: error: Incompatible types in assignment (expression has type "float | int | dict[Any, Any] | list[Any] | str | tuple[Any, ...] | set[Any] | None",
variable has type "SQLCoreOperations[dict[Any, Any] | None] | dict[Any, Any] | None") [assignment]
task_instance.next_kwargs = serialize(next_kwargs)
^~~~~~~~~~~~~~~~~~~~~~
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: error: Unsupported operand types for >= ("int" and "None") [operator]
exceeds = active_non_backfill_runs >= dag_model.max_active_runs
^
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: note: Right operand is of type "int | None"
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:38: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
create_engine = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:39: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
inspect = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:40: error: Incompatible types in assignment (expression has type "None", variable has type "Callable[[str | URL], URL]") [assignment]
make_url = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Cannot assign to a type [misc]
ArgumentError = Exception
^~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[ArgumentError]") [assignment]
ArgumentError = Exception
^~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Cannot assign to a type [misc]
NoSuchModuleError = Exception
^~~~~~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[NoSuchModuleError]") [assignment]
NoSuchModuleError = Exception
^~~~~~~~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Cannot assign to a type [misc]
URL = None
^~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Incompatible types in assignment (expression has type "None", variable has type "type[URL]") [assignment]
URL = None
^~~~
providers/standard/tests/unit/standard/operators/test_hitl.py:263: error: Incompatible types in assignment (expression has type "UUID", variable has type "str") [assignment]
expected_ti_id = UUID(ti.id)
^~~~~~~~~~~
providers/openlineage/tests/unit/openlineage/plugins/test_listener.py:211: error: Argument "dag_version_id" to "create_task_instance" has incompatible type "str | None"; expected "UUID" [arg-type]
dag_version_id=dagrun.created_dag_version_id,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Cannot assign to a type [misc]
URL = create_engine = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type "type[URL]") [assignment]
URL = create_engine = None
^
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type overloaded function) [assignment]
URL = create_engine = None
^~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Cannot assign to a type [misc]
URL = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Incompatible types in assignment (expression has type
"None", variable has type "type[URL]") [assignment]
URL = None
^~~~

Related: #59218, #59895
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@Dev-iL
Dev-iLforce-pushed
the
2601/sqla2_mypy_assorted
branch
from
b7f802a to
b27b427CompareJanuary 4, 2026 09:34
@Dev-iL
Dev-iL
requested a review
from o-nikolas
as a code ownerJanuary 4, 2026 09:34
@Dev-iL
Dev-iL
commented
Jan 4, 2026•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
cc @potiuk@Prab-27@vincbeck
@potiuk
potiuk
merged commit a971bcc
into
apache:mainJan 4, 2026

99 checks passed

@potiuk
potiuk
commented
Jan 4, 2026

Copy link


Copy Markdown

Member
thanks. Yeah .. we should move to sqla2 asap to stop getting those creeping in.
@Dev-iL
Dev-iL
deleted the

2601/sqla2_mypy_assorted

branch
January 4, 2026 21:58
stegololz pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
@Dev-iL@stegololz
Assorted SQLA2/Mypy fixes (apache#60094)
b846f80
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
jhgoebbert pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
@Dev-iL@jhgoebbert
Assorted SQLA2/Mypy fixes (apache#60094)
9c45cad
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Subham-KRLX pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Mar 4, 2026
@Dev-iL@Subham-KRLX
Assorted SQLA2/Mypy fixes (apache#60094)
1c73031
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
@Dev-iL@Ankurdeewan
Assorted SQLA2/Mypy fixes (apache#60094)
46abab4
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@mobuchowskimobuchowskiAwaiting requested review from mobuchowskimobuchowski is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@o-nikolaso-nikolasAwaiting requested review from o-nikolaso-nikolas is a code owner

Assignees


No one assigned


Labels

area:providersarea:Schedulerincluding HA (high availability) schedulerarea:task-sdkarea:Triggererprovider:common-sqlprovider:exasolprovider:openlineageAIP-53provider:standard

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Dev-iL@potiuk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Assorted SQLA2/Mypy fixes by Dev-iL · Pull Request #60094 · apache/airflow · GitHub
Skip to content
Assorted SQLA2/Mypy fixes - #60094
Merged
potiuk merged 8 commits into
apache:mainfrom 
Dev-iL:2601/sqla2_mypy_assorted
Jan 4, 2026
Merged
Assorted SQLA2/Mypy fixes#60094
potiuk merged 8 commits into
apache:mainfrom 
Dev-iL:2601/sqla2_mypy_assorted
Conversation
@Dev-iL
@Dev-iLDev-iL
commented
Jan 4, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Context:
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845610?pr=59218#step:7:1199
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845598?pr=59218#step:7:4224
airflow-core/src/airflow/models/trigger.py:130: error: Incompatible types in assignment (expression has type "str | None", variable has type "SQLCoreOperations[str] | str") [assignment]
self.queue = queue
^~~~~
airflow-core/src/airflow/models/trigger.py:487: error: Incompatible types in assignment (expression has type "float | int | dict[Any, Any] | list[Any] | str | tuple[Any, ...] | set[Any] | None",
variable has type "SQLCoreOperations[dict[Any, Any] | None] | dict[Any, Any] | None") [assignment]
task_instance.next_kwargs = serialize(next_kwargs)
^~~~~~~~~~~~~~~~~~~~~~
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: error: Unsupported operand types for >= ("int" and "None") [operator]
exceeds = active_non_backfill_runs >= dag_model.max_active_runs
^
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: note: Right operand is of type "int | None"
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:38: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
create_engine = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:39: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
inspect = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:40: error: Incompatible types in assignment (expression has type "None", variable has type "Callable[[str | URL], URL]") [assignment]
make_url = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Cannot assign to a type [misc]
ArgumentError = Exception
^~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[ArgumentError]") [assignment]
ArgumentError = Exception
^~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Cannot assign to a type [misc]
NoSuchModuleError = Exception
^~~~~~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[NoSuchModuleError]") [assignment]
NoSuchModuleError = Exception
^~~~~~~~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Cannot assign to a type [misc]
URL = None
^~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Incompatible types in assignment (expression has type "None", variable has type "type[URL]") [assignment]
URL = None
^~~~
providers/standard/tests/unit/standard/operators/test_hitl.py:263: error: Incompatible types in assignment (expression has type "UUID", variable has type "str") [assignment]
expected_ti_id = UUID(ti.id)
^~~~~~~~~~~
providers/openlineage/tests/unit/openlineage/plugins/test_listener.py:211: error: Argument "dag_version_id" to "create_task_instance" has incompatible type "str | None"; expected "UUID" [arg-type]
dag_version_id=dagrun.created_dag_version_id,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Cannot assign to a type [misc]
URL = create_engine = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type "type[URL]") [assignment]
URL = create_engine = None
^
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type overloaded function) [assignment]
URL = create_engine = None
^~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Cannot assign to a type [misc]
URL = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Incompatible types in assignment (expression has type
"None", variable has type "type[URL]") [assignment]
URL = None
^~~~

Related: #59218, #59895
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@Dev-iL
Dev-iLforce-pushed
the
2601/sqla2_mypy_assorted
branch
from
b7f802a to
b27b427CompareJanuary 4, 2026 09:34
@Dev-iL
Dev-iL
requested a review
from o-nikolas
as a code ownerJanuary 4, 2026 09:34
@Dev-iL
Dev-iL
commented
Jan 4, 2026•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
cc @potiuk@Prab-27@vincbeck
@potiuk
potiuk
merged commit a971bcc
into
apache:mainJan 4, 2026

99 checks passed

@potiuk
potiuk
commented
Jan 4, 2026

Copy link


Copy Markdown

Member
thanks. Yeah .. we should move to sqla2 asap to stop getting those creeping in.
@Dev-iL
Dev-iL
deleted the

2601/sqla2_mypy_assorted

branch
January 4, 2026 21:58
stegololz pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
@Dev-iL@stegololz
Assorted SQLA2/Mypy fixes (apache#60094)
b846f80
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
jhgoebbert pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
@Dev-iL@jhgoebbert
Assorted SQLA2/Mypy fixes (apache#60094)
9c45cad
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Subham-KRLX pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Mar 4, 2026
@Dev-iL@Subham-KRLX
Assorted SQLA2/Mypy fixes (apache#60094)
1c73031
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
@Dev-iL@Ankurdeewan
Assorted SQLA2/Mypy fixes (apache#60094)
46abab4
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@mobuchowskimobuchowskiAwaiting requested review from mobuchowskimobuchowski is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@o-nikolaso-nikolasAwaiting requested review from o-nikolaso-nikolas is a code owner

Assignees


No one assigned


Labels

area:providersarea:Schedulerincluding HA (high availability) schedulerarea:task-sdkarea:Triggererprovider:common-sqlprovider:exasolprovider:openlineageAIP-53provider:standard

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Dev-iL@potiuk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Assorted SQLA2/Mypy fixes by Dev-iL · Pull Request #60094 · apache/airflow · GitHub
Skip to content
Assorted SQLA2/Mypy fixes - #60094
Merged
potiuk merged 8 commits into
apache:mainfrom 
Dev-iL:2601/sqla2_mypy_assorted
Jan 4, 2026
Merged
Assorted SQLA2/Mypy fixes#60094
potiuk merged 8 commits into
apache:mainfrom 
Dev-iL:2601/sqla2_mypy_assorted
Conversation
@Dev-iL
@Dev-iLDev-iL
commented
Jan 4, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Context:
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845610?pr=59218#step:7:1199
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845598?pr=59218#step:7:4224
airflow-core/src/airflow/models/trigger.py:130: error: Incompatible types in assignment (expression has type "str | None", variable has type "SQLCoreOperations[str] | str") [assignment]
self.queue = queue
^~~~~
airflow-core/src/airflow/models/trigger.py:487: error: Incompatible types in assignment (expression has type "float | int | dict[Any, Any] | list[Any] | str | tuple[Any, ...] | set[Any] | None",
variable has type "SQLCoreOperations[dict[Any, Any] | None] | dict[Any, Any] | None") [assignment]
task_instance.next_kwargs = serialize(next_kwargs)
^~~~~~~~~~~~~~~~~~~~~~
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: error: Unsupported operand types for >= ("int" and "None") [operator]
exceeds = active_non_backfill_runs >= dag_model.max_active_runs
^
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: note: Right operand is of type "int | None"
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:38: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
create_engine = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:39: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
inspect = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:40: error: Incompatible types in assignment (expression has type "None", variable has type "Callable[[str | URL], URL]") [assignment]
make_url = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Cannot assign to a type [misc]
ArgumentError = Exception
^~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[ArgumentError]") [assignment]
ArgumentError = Exception
^~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Cannot assign to a type [misc]
NoSuchModuleError = Exception
^~~~~~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[NoSuchModuleError]") [assignment]
NoSuchModuleError = Exception
^~~~~~~~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Cannot assign to a type [misc]
URL = None
^~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Incompatible types in assignment (expression has type "None", variable has type "type[URL]") [assignment]
URL = None
^~~~
providers/standard/tests/unit/standard/operators/test_hitl.py:263: error: Incompatible types in assignment (expression has type "UUID", variable has type "str") [assignment]
expected_ti_id = UUID(ti.id)
^~~~~~~~~~~
providers/openlineage/tests/unit/openlineage/plugins/test_listener.py:211: error: Argument "dag_version_id" to "create_task_instance" has incompatible type "str | None"; expected "UUID" [arg-type]
dag_version_id=dagrun.created_dag_version_id,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Cannot assign to a type [misc]
URL = create_engine = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type "type[URL]") [assignment]
URL = create_engine = None
^
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type overloaded function) [assignment]
URL = create_engine = None
^~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Cannot assign to a type [misc]
URL = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Incompatible types in assignment (expression has type
"None", variable has type "type[URL]") [assignment]
URL = None
^~~~

Related: #59218, #59895
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@Dev-iL
Dev-iLforce-pushed
the
2601/sqla2_mypy_assorted
branch
from
b7f802a to
b27b427CompareJanuary 4, 2026 09:34
@Dev-iL
Dev-iL
requested a review
from o-nikolas
as a code ownerJanuary 4, 2026 09:34
@Dev-iL
Dev-iL
commented
Jan 4, 2026•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
cc @potiuk@Prab-27@vincbeck
@potiuk
potiuk
merged commit a971bcc
into
apache:mainJan 4, 2026

99 checks passed

@potiuk
potiuk
commented
Jan 4, 2026

Copy link


Copy Markdown

Member
thanks. Yeah .. we should move to sqla2 asap to stop getting those creeping in.
@Dev-iL
Dev-iL
deleted the

2601/sqla2_mypy_assorted

branch
January 4, 2026 21:58
stegololz pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
@Dev-iL@stegololz
Assorted SQLA2/Mypy fixes (apache#60094)
b846f80
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
jhgoebbert pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
@Dev-iL@jhgoebbert
Assorted SQLA2/Mypy fixes (apache#60094)
9c45cad
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Subham-KRLX pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Mar 4, 2026
@Dev-iL@Subham-KRLX
Assorted SQLA2/Mypy fixes (apache#60094)
1c73031
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
@Dev-iL@Ankurdeewan
Assorted SQLA2/Mypy fixes (apache#60094)
46abab4
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@mobuchowskimobuchowskiAwaiting requested review from mobuchowskimobuchowski is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@o-nikolaso-nikolasAwaiting requested review from o-nikolaso-nikolas is a code owner

Assignees


No one assigned


Labels

area:providersarea:Schedulerincluding HA (high availability) schedulerarea:task-sdkarea:Triggererprovider:common-sqlprovider:exasolprovider:openlineageAIP-53provider:standard

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Dev-iL@potiuk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Assorted SQLA2/Mypy fixes by Dev-iL · Pull Request #60094 · apache/airflow · GitHub
Skip to content
Assorted SQLA2/Mypy fixes - #60094
Merged
potiuk merged 8 commits into
apache:mainfrom 
Dev-iL:2601/sqla2_mypy_assorted
Jan 4, 2026
Merged
Assorted SQLA2/Mypy fixes#60094
potiuk merged 8 commits into
apache:mainfrom 
Dev-iL:2601/sqla2_mypy_assorted
Conversation
@Dev-iL
@Dev-iLDev-iL
commented
Jan 4, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Context:
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845610?pr=59218#step:7:1199
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845598?pr=59218#step:7:4224
airflow-core/src/airflow/models/trigger.py:130: error: Incompatible types in assignment (expression has type "str | None", variable has type "SQLCoreOperations[str] | str") [assignment]
self.queue = queue
^~~~~
airflow-core/src/airflow/models/trigger.py:487: error: Incompatible types in assignment (expression has type "float | int | dict[Any, Any] | list[Any] | str | tuple[Any, ...] | set[Any] | None",
variable has type "SQLCoreOperations[dict[Any, Any] | None] | dict[Any, Any] | None") [assignment]
task_instance.next_kwargs = serialize(next_kwargs)
^~~~~~~~~~~~~~~~~~~~~~
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: error: Unsupported operand types for >= ("int" and "None") [operator]
exceeds = active_non_backfill_runs >= dag_model.max_active_runs
^
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: note: Right operand is of type "int | None"
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:38: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
create_engine = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:39: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
inspect = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:40: error: Incompatible types in assignment (expression has type "None", variable has type "Callable[[str | URL], URL]") [assignment]
make_url = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Cannot assign to a type [misc]
ArgumentError = Exception
^~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[ArgumentError]") [assignment]
ArgumentError = Exception
^~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Cannot assign to a type [misc]
NoSuchModuleError = Exception
^~~~~~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[NoSuchModuleError]") [assignment]
NoSuchModuleError = Exception
^~~~~~~~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Cannot assign to a type [misc]
URL = None
^~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Incompatible types in assignment (expression has type "None", variable has type "type[URL]") [assignment]
URL = None
^~~~
providers/standard/tests/unit/standard/operators/test_hitl.py:263: error: Incompatible types in assignment (expression has type "UUID", variable has type "str") [assignment]
expected_ti_id = UUID(ti.id)
^~~~~~~~~~~
providers/openlineage/tests/unit/openlineage/plugins/test_listener.py:211: error: Argument "dag_version_id" to "create_task_instance" has incompatible type "str | None"; expected "UUID" [arg-type]
dag_version_id=dagrun.created_dag_version_id,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Cannot assign to a type [misc]
URL = create_engine = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type "type[URL]") [assignment]
URL = create_engine = None
^
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type overloaded function) [assignment]
URL = create_engine = None
^~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Cannot assign to a type [misc]
URL = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Incompatible types in assignment (expression has type
"None", variable has type "type[URL]") [assignment]
URL = None
^~~~

Related: #59218, #59895
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@Dev-iL
Dev-iLforce-pushed
the
2601/sqla2_mypy_assorted
branch
from
b7f802a to
b27b427CompareJanuary 4, 2026 09:34
@Dev-iL
Dev-iL
requested a review
from o-nikolas
as a code ownerJanuary 4, 2026 09:34
@Dev-iL
Dev-iL
commented
Jan 4, 2026•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
cc @potiuk@Prab-27@vincbeck
@potiuk
potiuk
merged commit a971bcc
into
apache:mainJan 4, 2026

99 checks passed

@potiuk
potiuk
commented
Jan 4, 2026

Copy link


Copy Markdown

Member
thanks. Yeah .. we should move to sqla2 asap to stop getting those creeping in.
@Dev-iL
Dev-iL
deleted the

2601/sqla2_mypy_assorted

branch
January 4, 2026 21:58
stegololz pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
@Dev-iL@stegololz
Assorted SQLA2/Mypy fixes (apache#60094)
b846f80
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
jhgoebbert pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
@Dev-iL@jhgoebbert
Assorted SQLA2/Mypy fixes (apache#60094)
9c45cad
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Subham-KRLX pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Mar 4, 2026
@Dev-iL@Subham-KRLX
Assorted SQLA2/Mypy fixes (apache#60094)
1c73031
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
@Dev-iL@Ankurdeewan
Assorted SQLA2/Mypy fixes (apache#60094)
46abab4
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@mobuchowskimobuchowskiAwaiting requested review from mobuchowskimobuchowski is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@o-nikolaso-nikolasAwaiting requested review from o-nikolaso-nikolas is a code owner

Assignees


No one assigned


Labels

area:providersarea:Schedulerincluding HA (high availability) schedulerarea:task-sdkarea:Triggererprovider:common-sqlprovider:exasolprovider:openlineageAIP-53provider:standard

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Dev-iL@potiuk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Assorted SQLA2/Mypy fixes by Dev-iL · Pull Request #60094 · apache/airflow · GitHub
Skip to content
Assorted SQLA2/Mypy fixes - #60094
Merged
potiuk merged 8 commits into
apache:mainfrom 
Dev-iL:2601/sqla2_mypy_assorted
Jan 4, 2026
Merged
Assorted SQLA2/Mypy fixes#60094
potiuk merged 8 commits into
apache:mainfrom 
Dev-iL:2601/sqla2_mypy_assorted
Conversation
@Dev-iL
@Dev-iLDev-iL
commented
Jan 4, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Context:
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845610?pr=59218#step:7:1199
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845598?pr=59218#step:7:4224
airflow-core/src/airflow/models/trigger.py:130: error: Incompatible types in assignment (expression has type "str | None", variable has type "SQLCoreOperations[str] | str") [assignment]
self.queue = queue
^~~~~
airflow-core/src/airflow/models/trigger.py:487: error: Incompatible types in assignment (expression has type "float | int | dict[Any, Any] | list[Any] | str | tuple[Any, ...] | set[Any] | None",
variable has type "SQLCoreOperations[dict[Any, Any] | None] | dict[Any, Any] | None") [assignment]
task_instance.next_kwargs = serialize(next_kwargs)
^~~~~~~~~~~~~~~~~~~~~~
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: error: Unsupported operand types for >= ("int" and "None") [operator]
exceeds = active_non_backfill_runs >= dag_model.max_active_runs
^
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: note: Right operand is of type "int | None"
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:38: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
create_engine = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:39: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
inspect = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:40: error: Incompatible types in assignment (expression has type "None", variable has type "Callable[[str | URL], URL]") [assignment]
make_url = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Cannot assign to a type [misc]
ArgumentError = Exception
^~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[ArgumentError]") [assignment]
ArgumentError = Exception
^~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Cannot assign to a type [misc]
NoSuchModuleError = Exception
^~~~~~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[NoSuchModuleError]") [assignment]
NoSuchModuleError = Exception
^~~~~~~~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Cannot assign to a type [misc]
URL = None
^~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Incompatible types in assignment (expression has type "None", variable has type "type[URL]") [assignment]
URL = None
^~~~
providers/standard/tests/unit/standard/operators/test_hitl.py:263: error: Incompatible types in assignment (expression has type "UUID", variable has type "str") [assignment]
expected_ti_id = UUID(ti.id)
^~~~~~~~~~~
providers/openlineage/tests/unit/openlineage/plugins/test_listener.py:211: error: Argument "dag_version_id" to "create_task_instance" has incompatible type "str | None"; expected "UUID" [arg-type]
dag_version_id=dagrun.created_dag_version_id,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Cannot assign to a type [misc]
URL = create_engine = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type "type[URL]") [assignment]
URL = create_engine = None
^
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type overloaded function) [assignment]
URL = create_engine = None
^~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Cannot assign to a type [misc]
URL = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Incompatible types in assignment (expression has type
"None", variable has type "type[URL]") [assignment]
URL = None
^~~~

Related: #59218, #59895
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@Dev-iL
Dev-iLforce-pushed
the
2601/sqla2_mypy_assorted
branch
from
b7f802a to
b27b427CompareJanuary 4, 2026 09:34
@Dev-iL
Dev-iL
requested a review
from o-nikolas
as a code ownerJanuary 4, 2026 09:34
@Dev-iL
Dev-iL
commented
Jan 4, 2026•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
cc @potiuk@Prab-27@vincbeck
@potiuk
potiuk
merged commit a971bcc
into
apache:mainJan 4, 2026

99 checks passed

@potiuk
potiuk
commented
Jan 4, 2026

Copy link


Copy Markdown

Member
thanks. Yeah .. we should move to sqla2 asap to stop getting those creeping in.
@Dev-iL
Dev-iL
deleted the

2601/sqla2_mypy_assorted

branch
January 4, 2026 21:58
stegololz pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
@Dev-iL@stegololz
Assorted SQLA2/Mypy fixes (apache#60094)
b846f80
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
jhgoebbert pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
@Dev-iL@jhgoebbert
Assorted SQLA2/Mypy fixes (apache#60094)
9c45cad
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Subham-KRLX pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Mar 4, 2026
@Dev-iL@Subham-KRLX
Assorted SQLA2/Mypy fixes (apache#60094)
1c73031
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
@Dev-iL@Ankurdeewan
Assorted SQLA2/Mypy fixes (apache#60094)
46abab4
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@mobuchowskimobuchowskiAwaiting requested review from mobuchowskimobuchowski is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@o-nikolaso-nikolasAwaiting requested review from o-nikolaso-nikolas is a code owner

Assignees


No one assigned


Labels

area:providersarea:Schedulerincluding HA (high availability) schedulerarea:task-sdkarea:Triggererprovider:common-sqlprovider:exasolprovider:openlineageAIP-53provider:standard

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Dev-iL@potiuk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Assorted SQLA2/Mypy fixes by Dev-iL · Pull Request #60094 · apache/airflow · GitHub
Skip to content
Assorted SQLA2/Mypy fixes - #60094
Merged
potiuk merged 8 commits into
apache:mainfrom 
Dev-iL:2601/sqla2_mypy_assorted
Jan 4, 2026
Merged
Assorted SQLA2/Mypy fixes#60094
potiuk merged 8 commits into
apache:mainfrom 
Dev-iL:2601/sqla2_mypy_assorted
Conversation
@Dev-iL
@Dev-iLDev-iL
commented
Jan 4, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Context:
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845610?pr=59218#step:7:1199
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845598?pr=59218#step:7:4224
airflow-core/src/airflow/models/trigger.py:130: error: Incompatible types in assignment (expression has type "str | None", variable has type "SQLCoreOperations[str] | str") [assignment]
self.queue = queue
^~~~~
airflow-core/src/airflow/models/trigger.py:487: error: Incompatible types in assignment (expression has type "float | int | dict[Any, Any] | list[Any] | str | tuple[Any, ...] | set[Any] | None",
variable has type "SQLCoreOperations[dict[Any, Any] | None] | dict[Any, Any] | None") [assignment]
task_instance.next_kwargs = serialize(next_kwargs)
^~~~~~~~~~~~~~~~~~~~~~
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: error: Unsupported operand types for >= ("int" and "None") [operator]
exceeds = active_non_backfill_runs >= dag_model.max_active_runs
^
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: note: Right operand is of type "int | None"
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:38: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
create_engine = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:39: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
inspect = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:40: error: Incompatible types in assignment (expression has type "None", variable has type "Callable[[str | URL], URL]") [assignment]
make_url = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Cannot assign to a type [misc]
ArgumentError = Exception
^~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[ArgumentError]") [assignment]
ArgumentError = Exception
^~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Cannot assign to a type [misc]
NoSuchModuleError = Exception
^~~~~~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[NoSuchModuleError]") [assignment]
NoSuchModuleError = Exception
^~~~~~~~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Cannot assign to a type [misc]
URL = None
^~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Incompatible types in assignment (expression has type "None", variable has type "type[URL]") [assignment]
URL = None
^~~~
providers/standard/tests/unit/standard/operators/test_hitl.py:263: error: Incompatible types in assignment (expression has type "UUID", variable has type "str") [assignment]
expected_ti_id = UUID(ti.id)
^~~~~~~~~~~
providers/openlineage/tests/unit/openlineage/plugins/test_listener.py:211: error: Argument "dag_version_id" to "create_task_instance" has incompatible type "str | None"; expected "UUID" [arg-type]
dag_version_id=dagrun.created_dag_version_id,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Cannot assign to a type [misc]
URL = create_engine = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type "type[URL]") [assignment]
URL = create_engine = None
^
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type overloaded function) [assignment]
URL = create_engine = None
^~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Cannot assign to a type [misc]
URL = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Incompatible types in assignment (expression has type
"None", variable has type "type[URL]") [assignment]
URL = None
^~~~

Related: #59218, #59895
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@Dev-iL
Dev-iLforce-pushed
the
2601/sqla2_mypy_assorted
branch
from
b7f802a to
b27b427CompareJanuary 4, 2026 09:34
@Dev-iL
Dev-iL
requested a review
from o-nikolas
as a code ownerJanuary 4, 2026 09:34
@Dev-iL
Dev-iL
commented
Jan 4, 2026•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
cc @potiuk@Prab-27@vincbeck
@potiuk
potiuk
merged commit a971bcc
into
apache:mainJan 4, 2026

99 checks passed

@potiuk
potiuk
commented
Jan 4, 2026

Copy link


Copy Markdown

Member
thanks. Yeah .. we should move to sqla2 asap to stop getting those creeping in.
@Dev-iL
Dev-iL
deleted the

2601/sqla2_mypy_assorted

branch
January 4, 2026 21:58
stegololz pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
@Dev-iL@stegololz
Assorted SQLA2/Mypy fixes (apache#60094)
b846f80
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
jhgoebbert pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
@Dev-iL@jhgoebbert
Assorted SQLA2/Mypy fixes (apache#60094)
9c45cad
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Subham-KRLX pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Mar 4, 2026
@Dev-iL@Subham-KRLX
Assorted SQLA2/Mypy fixes (apache#60094)
1c73031
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
@Dev-iL@Ankurdeewan
Assorted SQLA2/Mypy fixes (apache#60094)
46abab4
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@mobuchowskimobuchowskiAwaiting requested review from mobuchowskimobuchowski is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@o-nikolaso-nikolasAwaiting requested review from o-nikolaso-nikolas is a code owner

Assignees


No one assigned


Labels

area:providersarea:Schedulerincluding HA (high availability) schedulerarea:task-sdkarea:Triggererprovider:common-sqlprovider:exasolprovider:openlineageAIP-53provider:standard

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Dev-iL@potiuk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Assorted SQLA2/Mypy fixes by Dev-iL · Pull Request #60094 · apache/airflow · GitHub
Skip to content
Assorted SQLA2/Mypy fixes - #60094
Merged
potiuk merged 8 commits into
apache:mainfrom 
Dev-iL:2601/sqla2_mypy_assorted
Jan 4, 2026
Merged
Assorted SQLA2/Mypy fixes#60094
potiuk merged 8 commits into
apache:mainfrom 
Dev-iL:2601/sqla2_mypy_assorted
Conversation
@Dev-iL
@Dev-iLDev-iL
commented
Jan 4, 2026•

edited

Loading

Copy link


Copy Markdown

Collaborator
Context:
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845610?pr=59218#step:7:1199
https://github.com/apache/airflow/actions/runs/20681629287/job/59376845598?pr=59218#step:7:4224
airflow-core/src/airflow/models/trigger.py:130: error: Incompatible types in assignment (expression has type "str | None", variable has type "SQLCoreOperations[str] | str") [assignment]
self.queue = queue
^~~~~
airflow-core/src/airflow/models/trigger.py:487: error: Incompatible types in assignment (expression has type "float | int | dict[Any, Any] | list[Any] | str | tuple[Any, ...] | set[Any] | None",
variable has type "SQLCoreOperations[dict[Any, Any] | None] | dict[Any, Any] | None") [assignment]
task_instance.next_kwargs = serialize(next_kwargs)
^~~~~~~~~~~~~~~~~~~~~~
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: error: Unsupported operand types for >= ("int" and "None") [operator]
exceeds = active_non_backfill_runs >= dag_model.max_active_runs
^
airflow-core/src/airflow/jobs/scheduler_job_runner.py:3037: note: Right operand is of type "int | None"
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:38: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
create_engine = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:39: error: Incompatible types in assignment (expression has type "None", variable has type overloaded function) [assignment]
inspect = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:40: error: Incompatible types in assignment (expression has type "None", variable has type "Callable[[str | URL], URL]") [assignment]
make_url = None
^~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Cannot assign to a type [misc]
ArgumentError = Exception
^~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:41: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[ArgumentError]") [assignment]
ArgumentError = Exception
^~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Cannot assign to a type [misc]
NoSuchModuleError = Exception
^~~~~~~~~~~~~~~~~
providers/common/sql/src/airflow/providers/common/sql/hooks/sql.py:42: error: Incompatible types in assignment (expression has type "type[Exception]", variable has type "type[NoSuchModuleError]") [assignment]
NoSuchModuleError = Exception
^~~~~~~~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Cannot assign to a type [misc]
URL = None
^~~
providers/exasol/src/airflow/providers/exasol/hooks/exasol.py:31: error: Incompatible types in assignment (expression has type "None", variable has type "type[URL]") [assignment]
URL = None
^~~~
providers/standard/tests/unit/standard/operators/test_hitl.py:263: error: Incompatible types in assignment (expression has type "UUID", variable has type "str") [assignment]
expected_ti_id = UUID(ti.id)
^~~~~~~~~~~
providers/openlineage/tests/unit/openlineage/plugins/test_listener.py:211: error: Argument "dag_version_id" to "create_task_instance" has incompatible type "str | None"; expected "UUID" [arg-type]
dag_version_id=dagrun.created_dag_version_id,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Cannot assign to a type [misc]
URL = create_engine = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type "type[URL]") [assignment]
URL = create_engine = None
^
providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py:30: error: Incompatible types in assignment (expression has
type "None", variable has type overloaded function) [assignment]
URL = create_engine = None
^~~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Cannot assign to a type [misc]
URL = None
^~~
providers/amazon/src/airflow/providers/amazon/aws/hooks/athena_sql.py:28: error: Incompatible types in assignment (expression has type
"None", variable has type "type[URL]") [assignment]
URL = None
^~~~

Related: #59218, #59895
^ Add meaningful description above

Read the Pull Request Guidelines for more information.

In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.

In case of a new dependency, check compliance with the ASF 3rd Party License Policy.

In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
@Dev-iL
Dev-iLforce-pushed
the
2601/sqla2_mypy_assorted
branch
from
b7f802a to
b27b427CompareJanuary 4, 2026 09:34
@Dev-iL
Dev-iL
requested a review
from o-nikolas
as a code ownerJanuary 4, 2026 09:34
@Dev-iL
Dev-iL
commented
Jan 4, 2026•

edited

Loading

Copy link


Copy Markdown

CollaboratorAuthor
cc @potiuk@Prab-27@vincbeck
@potiuk
potiuk
merged commit a971bcc
into
apache:mainJan 4, 2026

99 checks passed

@potiuk
potiuk
commented
Jan 4, 2026

Copy link


Copy Markdown

Member
thanks. Yeah .. we should move to sqla2 asap to stop getting those creeping in.
@Dev-iL
Dev-iL
deleted the

2601/sqla2_mypy_assorted

branch
January 4, 2026 21:58
stegololz pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
@Dev-iL@stegololz
Assorted SQLA2/Mypy fixes (apache#60094)
b846f80
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
jhgoebbert pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
@Dev-iL@jhgoebbert
Assorted SQLA2/Mypy fixes (apache#60094)
9c45cad
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Subham-KRLX pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Mar 4, 2026
@Dev-iL@Subham-KRLX
Assorted SQLA2/Mypy fixes (apache#60094)
1c73031
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
@Dev-iL@Ankurdeewan
Assorted SQLA2/Mypy fixes (apache#60094)
46abab4
* SQLA2: Fix mypy violation in trigger.py
* SQLA2: fix mypy violation in scheduler_job_runner.py
* SQLA2: fix mypy violation (missing type hint) in test_hitl.py
* SQLA2: fix mypy violation in exasol
* SQLA2: fix mypy violations in the common provider's sql hook
* SQLA2: fix mypy violation in openlineage/.../test_listener.py
* SQLA2: fix mypy violations in the amazon provider
* mypy: add overload annotations to serde.serialize
This solves a mypy violation in triggerer.py
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
@mobuchowskimobuchowskiAwaiting requested review from mobuchowskimobuchowski is a code owner
@XD-DENGXD-DENGAwaiting requested review from XD-DENGXD-DENG is a code owner
@o-nikolaso-nikolasAwaiting requested review from o-nikolaso-nikolas is a code owner

Assignees


No one assigned


Labels

area:providersarea:Schedulerincluding HA (high availability) schedulerarea:task-sdkarea:Triggererprovider:common-sqlprovider:exasolprovider:openlineageAIP-53provider:standard

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Dev-iL@potiuk