') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Update files in prevent deprecated sqlalchemy prek hook by Prab-27 · Pull Request #60692 · apache/airflow · GitHub
Skip to content

Update files in prevent deprecated sqlalchemy prek hook - #60692

Merged
shahar1 merged 2 commits into
apache:mainfrom
Prab-27:update-prek-hook-files
Jan 31, 2026
Merged

Update files in prevent deprecated sqlalchemy prek hook #60692
shahar1 merged 2 commits into
apache:mainfrom
Prab-27:update-prek-hook-files

Conversation

@Prab-27

@Prab-27Prab-27 commented Jan 17, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Related : here
and here

closes : #59402 and #45461

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Prab-27
Prab-27force-pushed the update-prek-hook-files branch from 77f297c to eaa3b01CompareJanuary 20, 2026 13:05
@Prab-27
Prab-27 marked this pull request as ready for review January 20, 2026 13:06
@Prab-27
Prab-27force-pushed the update-prek-hook-files branch from eaa3b01 to bcd9190CompareJanuary 20, 2026 13:46
@Prab-27

Prab-27 commented Jan 20, 2026

Copy link
Copy Markdown
ContributorAuthor

I only included modules that have python files , Do I need to chnage any module that are not using SQLAlchemy - sessions ?

@shahar1
shahar1force-pushed the update-prek-hook-files branch from bcd9190 to d9336d7CompareJanuary 31, 2026 09:57
@Prab-27

Prab-27 commented Jan 31, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Thanks @shahar1 for approval !

Some Tests are failing .... Looking into it !

@shahar1

shahar1 commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

Thanks @shahar1 for approval !

Some Tests are failing .... Looking into it !

Anytime :)
Not sure if it's related to these changes though, probably related to the existing ci/cd issues reported on the Slack channel.

@Prab-27

Prab-27 commented Jan 31, 2026

Copy link
Copy Markdown
ContributorAuthor

@shahar1 , Yes !! That's true

@shahar1
shahar1force-pushed the update-prek-hook-files branch from d9336d7 to 96babf2CompareJanuary 31, 2026 13:30
@shahar1

shahar1 commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

@shahar1 , Yes !! That's true

I think it should have been fixed.
Rebased, hopefully it will pass this time.

@Prab-27

Prab-27 commented Jan 31, 2026

Copy link
Copy Markdown
ContributorAuthor

All green !!!

@shahar1
shahar1 merged commit bc22a99 into apache:mainJan 31, 2026
71 checks passed
@github-actions

github-actionsBot commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

StatusBranchResult
❌v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker bc22a99 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

morelgeorge pushed a commit to morelgeorge/airflow that referenced this pull request Feb 1, 2026
@Prab-27@morelgeorge
Update files in prevent deprecated sqlalchemy prek hook (apache#60692)
f155560
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
@Prab-27Shashwati
Update files in prevent deprecated sqlalchemy prek hook (apache#60692)
53fd252
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
@Prab-27@jason810496
Update files in prevent deprecated sqlalchemy prek hook (apache#60692)
f4d141a
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
@Prab-27@jhgoebbert
Update files in prevent deprecated sqlalchemy prek hook (apache#60692)
53e0f6d
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
@Prab-27@choo121600
Update files in prevent deprecated sqlalchemy prek hook (apache#60692)
f107636
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
@Prab-27@Subham-KRLX
Update files in prevent deprecated sqlalchemy prek hook (apache#60692)
9012bda
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
@Prab-27@Ankurdeewan
Update files in prevent deprecated sqlalchemy prek hook (apache#60692)
d60dfbb
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahar1shahar1shahar1 approved these changes

Assignees

No one assigned

Labels

area:dev-tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove deprecated Query usage and update to SQLAlchemy2.0 style

2 participants

@Prab-27@shahar1