Skip to content

Fix slow log scrolling for large task logs - #60806

Merged
pierrejeambrun merged 2 commits into
apache:mainfrom
guan404ming:fix-log-scroll-performance
Jan 21, 2026
Merged

Fix slow log scrolling for large task logs#60806
pierrejeambrun merged 2 commits into
apache:mainfrom
guan404ming:fix-log-scroll-performance

Conversation

@guan404ming

@guan404mingguan404ming commented Jan 20, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Related Issue

Ref #54447
Closes#51788

Why

Scrolling to the end of large log files was slow because the virtualizer had to compute positions for all rows. This fix:

How

  • Use scrollToOffset with direct offset calculation for instant jumps
  • Add useLocation hook so clicking a log line highlights it reactively
  • Extract scroll utilities to utils.ts
Screen.Recording.2026-01-20.at.12.46.05.PM.mov
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    Claude Code
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 20, 2026
@guan404ming
guan404mingforce-pushed the fix-log-scroll-performance branch 2 times, most recently from 7779ef4 to faf2e1aCompareJanuary 20, 2026 04:49
@guan404ming
guan404ming marked this pull request as ready for review January 20, 2026 05:53
pierrejeambrun
pierrejeambrun reviewed Jan 20, 2026
View reviewed changes

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, would be great to have this scroll to bottom / top fixed!

Just a few comments, but tested locally and working as expected, we just need to trim down the PR to focus on this part only while we figure out the rest.

Comment thread.gitignore Outdated
Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx Outdated
@guan404ming
guan404mingforce-pushed the fix-log-scroll-performance branch from faf2e1a to 983b18cCompareJanuary 20, 2026 16:40
bbovenzi
bbovenzi reviewed Jan 20, 2026
View reviewed changes
Comment threadairflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/utils.ts Outdated
@guan404ming
guan404mingforce-pushed the fix-log-scroll-performance branch from 983b18c to dec55fbCompareJanuary 21, 2026 02:45
@guan404ming
guan404mingforce-pushed the fix-log-scroll-performance branch from dec55fb to fecf46aCompareJanuary 21, 2026 02:47
@pierrejeambrun
pierrejeambrun merged commit 4766f9c into apache:mainJan 21, 2026
77 checks passed
pierrejeambrun pushed a commit to astronomer/airflow that referenced this pull request Jan 21, 2026
@guan404ming@pierrejeambrun
Fix slow log scrolling for large task logs (apache#60806)
e241a52
* Fix slow log scrolling for large task logs
* Trim to focus on scroll top/bottom
(cherry picked from commit 4766f9c)
@pierrejeambrun

pierrejeambrun commented Jan 21, 2026

Copy link
Copy Markdown
Member

Manual backport #60875

@guan404ming
guan404ming deleted the fix-log-scroll-performance branch January 21, 2026 15:01
@guan404ming

guan404ming commented Jan 21, 2026

Copy link
Copy Markdown
MemberAuthor

Thanks!

pierrejeambrun added a commit that referenced this pull request Jan 21, 2026
@pierrejeambrun@guan404ming
Fix slow log scrolling for large task logs (#60806) (#60875)
f21d199
* Fix slow log scrolling for large task logs
* Trim to focus on scroll top/bottom
(cherry picked from commit 4766f9c)
Co-authored-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
suii2210 pushed a commit to suii2210/airflow that referenced this pull request Jan 26, 2026
@guan404ming@suii2210
Fix slow log scrolling for large task logs (apache#60806)
663bb07
* Fix slow log scrolling for large task logs
* Trim to focus on scroll top/bottom
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
@guan404ming@shreyas-dev
Fix slow log scrolling for large task logs (apache#60806)
fd3fe5b
* Fix slow log scrolling for large task logs
* Trim to focus on scroll top/bottom
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
@guan404ming@jhgoebbert
Fix slow log scrolling for large task logs (apache#60806)
7fd6ff9
* Fix slow log scrolling for large task logs
* Trim to focus on scroll top/bottom
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
@guan404ming@choo121600
Fix slow log scrolling for large task logs (apache#60806)
2cc2a2c
* Fix slow log scrolling for large task logs
* Trim to focus on scroll top/bottom
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
@guan404ming@Subham-KRLX
Fix slow log scrolling for large task logs (apache#60806)
6b110c3
* Fix slow log scrolling for large task logs
* Trim to focus on scroll top/bottom
@pierrejeambrunpierrejeambrun mentioned this pull request Mar 5, 2026
Closed
1 task
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
@guan404ming@Ankurdeewan
Fix slow log scrolling for large task logs (apache#60806)
2ad6d40
* Fix slow log scrolling for large task logs
* Trim to focus on scroll top/bottom
@eladkaleladkal mentioned this pull request May 15, 2026
Open
This was referenced Aug 24, 2026
Closed
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzibbovenzibbovenzi approved these changes
@pierrejeambrunpierrejeambrunpierrejeambrun approved these changes
@ryanahamiltonryanahamiltonAwaiting requested review from ryanahamiltonryanahamilton is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@vatsrahul1001vatsrahul1001Awaiting requested review from vatsrahul1001vatsrahul1001 is a code owner
@choo121600choo121600Awaiting requested review from choo121600choo121600 is a code owner

Assignees

No one assigned

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scrolling in logs does not work properly.

3 participants

@guan404ming@pierrejeambrun@bbovenzi