Skip to content

Add UvicornMonitor for zero-downtime API server worker recycling - #60919

Closed
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling
Closed

Add UvicornMonitor for zero-downtime API server worker recycling#60919
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling

Conversation

@kaxil

@kaxilkaxil commented Jan 22, 2026

Copy link
Copy Markdown
Member

Alternate/complement to #60804

Why

API server workers accumulate memory over time. Airflow 2 had GunicornMonitor with rolling restarts - spawn new workers, health check them, then kill old ones. This was lost when we switched to uvicorn.

Uvicorn's built-in limit_max_requests doesn't help here - it kills old workers before spawning new ones, causing downtime.

What

New UvicornMonitor class that does rolling restarts:

[n workers] → spawn batch → [n + batch workers] → health check → kill old batch → [n workers]

Enabled via config:

[api]worker_refresh_interval = 1800 # seconds, 0 = disabled (default)worker_refresh_batch_size = 1

Gotchas (vs GunicornMonitor)

Single-worker mode: Gunicorn always uses master/worker architecture even with workers=1 (master + 1 worker), so signals always work. Uvicorn with workers=1 runs in single-process mode with no supervisor, so SIGTTIN/SIGTTOU are ignored. Workaround: start with 2 workers and scale down after startup. Works, but briefly has 2 workers during refresh cycles.

Uvicorn kills newest worker, not oldest: Gunicorn kills the oldest worker on SIGTTOU (workers.pop(0) sorted by age). Uvicorn kills the newest (processes.pop() - LIFO). This would kill our fresh healthy workers instead of the old ones. Fixed by sending SIGTERM directly to specific old PIDs instead of using SIGTTOU.

No memory sharing between workers: Unlike Gunicorn (which uses preload + fork for copy-on-write memory sharing), uvicorn's multiprocess mode spawns independent workers that each load everything separately. This means:

  • Each worker has its own copy of all loaded modules, configurations, and cached data
  • Total memory usage scales linearly with worker count (N workers = ~N× memory)

This is an inherent limitation of uvicorn's multiprocessing approach vs gunicorn's preload+fork model.

Testing

# Start API server with worker recycling enabledexport AIRFLOW__API__WORKER_REFRESH_INTERVAL=60
airflow api-server --workers 2
# Watch logs for rolling restart messages:# "Starting worker refresh: current workers PIDs [1001, 1002]"# "Spawned new workers: PIDs [1003]"# "Killing old workers: PIDs [1001]"# "Worker refresh completed: new PIDs [1003] replaced old PIDs [1001]"

Related

Implement rolling worker restarts for the API server using uvicorn's
SIGTTIN/SIGTTOU signal-based worker management. This provides feature
parity with Airflow 2's GunicornMonitor while maintaining zero downtime.
Key features:
- Rolling restart pattern: spawn new workers before killing old ones
- Health check verification before killing old workers
- Automatic rollback if new workers fail health checks
- Configurable refresh interval and batch size
New configuration options:
- worker_refresh_interval: Seconds between refresh cycles (default: 0/disabled)
- worker_refresh_batch_size: Workers to refresh at a time (default: 1)
This addresses memory accumulation in long-running API server workers
by periodically recycling them while ensuring continuous availability.
version_added: 3.2.0
type: integer
example: ~
default: "0"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use some more robust default here?

I guess we could have min 2 workers by default and have rolling restarts enabled by default, and refresh interval set to some default, reasonable value (say 1hr).

While it increases memory used as explained in the PR description, it is far more robust for "out-of-the-box" installation, and if users would like to save memory by limiting it to 1, they still should be able to do so (and then we could disable the uvicorn restarts altogether). I think it's more important to have "robust non leaking, gently restarting" by default, rather than "potentially leaking smaller initial memory".

Since Fast API recommendation is 1 worker per Pod - we could also recommend to the users - in the same docs - to use the rolling restarts of deployment instead those restarts that are handled by Uvicorn monitor. And we could add description to the number of workers paraneter, that setting it to 1 is ok as long as you have more than one instance of api-server and implement refreshing rolling restart outside of Airlfow. This way, the users who would like to change it to 1 (and read the docs that is) - would know that they also need to take care about potential leaks.

There are even some ways to do it automatically - which we could implement in our Helm Chart as an option potentially:

https://stackoverflow.com/questions/67423919/k8s-cronjob-rolling-restart-every-day

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah certainly an option.

@kaxil

Copy link
Copy Markdown
MemberAuthor

Closing this in favor of #60940

@kaxilkaxil closed this Jan 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add UvicornMonitor for zero-downtime API server worker recycling by kaxil · Pull Request #60919 · apache/airflow · GitHub
Skip to content

Add UvicornMonitor for zero-downtime API server worker recycling - #60919

Closed
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling
Closed

Add UvicornMonitor for zero-downtime API server worker recycling#60919
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling

Conversation

@kaxil

@kaxilkaxil commented Jan 22, 2026

Copy link
Copy Markdown
Member

Alternate/complement to #60804

Why

API server workers accumulate memory over time. Airflow 2 had GunicornMonitor with rolling restarts - spawn new workers, health check them, then kill old ones. This was lost when we switched to uvicorn.

Uvicorn's built-in limit_max_requests doesn't help here - it kills old workers before spawning new ones, causing downtime.

What

New UvicornMonitor class that does rolling restarts:

[n workers] → spawn batch → [n + batch workers] → health check → kill old batch → [n workers]

Enabled via config:

[api]worker_refresh_interval = 1800 # seconds, 0 = disabled (default)worker_refresh_batch_size = 1

Gotchas (vs GunicornMonitor)

Single-worker mode: Gunicorn always uses master/worker architecture even with workers=1 (master + 1 worker), so signals always work. Uvicorn with workers=1 runs in single-process mode with no supervisor, so SIGTTIN/SIGTTOU are ignored. Workaround: start with 2 workers and scale down after startup. Works, but briefly has 2 workers during refresh cycles.

Uvicorn kills newest worker, not oldest: Gunicorn kills the oldest worker on SIGTTOU (workers.pop(0) sorted by age). Uvicorn kills the newest (processes.pop() - LIFO). This would kill our fresh healthy workers instead of the old ones. Fixed by sending SIGTERM directly to specific old PIDs instead of using SIGTTOU.

No memory sharing between workers: Unlike Gunicorn (which uses preload + fork for copy-on-write memory sharing), uvicorn's multiprocess mode spawns independent workers that each load everything separately. This means:

  • Each worker has its own copy of all loaded modules, configurations, and cached data
  • Total memory usage scales linearly with worker count (N workers = ~N× memory)

This is an inherent limitation of uvicorn's multiprocessing approach vs gunicorn's preload+fork model.

Testing

# Start API server with worker recycling enabledexport AIRFLOW__API__WORKER_REFRESH_INTERVAL=60
airflow api-server --workers 2
# Watch logs for rolling restart messages:# "Starting worker refresh: current workers PIDs [1001, 1002]"# "Spawned new workers: PIDs [1003]"# "Killing old workers: PIDs [1001]"# "Worker refresh completed: new PIDs [1003] replaced old PIDs [1001]"

Related

Implement rolling worker restarts for the API server using uvicorn's
SIGTTIN/SIGTTOU signal-based worker management. This provides feature
parity with Airflow 2's GunicornMonitor while maintaining zero downtime.
Key features:
- Rolling restart pattern: spawn new workers before killing old ones
- Health check verification before killing old workers
- Automatic rollback if new workers fail health checks
- Configurable refresh interval and batch size
New configuration options:
- worker_refresh_interval: Seconds between refresh cycles (default: 0/disabled)
- worker_refresh_batch_size: Workers to refresh at a time (default: 1)
This addresses memory accumulation in long-running API server workers
by periodically recycling them while ensuring continuous availability.
version_added: 3.2.0
type: integer
example: ~
default: "0"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use some more robust default here?

I guess we could have min 2 workers by default and have rolling restarts enabled by default, and refresh interval set to some default, reasonable value (say 1hr).

While it increases memory used as explained in the PR description, it is far more robust for "out-of-the-box" installation, and if users would like to save memory by limiting it to 1, they still should be able to do so (and then we could disable the uvicorn restarts altogether). I think it's more important to have "robust non leaking, gently restarting" by default, rather than "potentially leaking smaller initial memory".

Since Fast API recommendation is 1 worker per Pod - we could also recommend to the users - in the same docs - to use the rolling restarts of deployment instead those restarts that are handled by Uvicorn monitor. And we could add description to the number of workers paraneter, that setting it to 1 is ok as long as you have more than one instance of api-server and implement refreshing rolling restart outside of Airlfow. This way, the users who would like to change it to 1 (and read the docs that is) - would know that they also need to take care about potential leaks.

There are even some ways to do it automatically - which we could implement in our Helm Chart as an option potentially:

https://stackoverflow.com/questions/67423919/k8s-cronjob-rolling-restart-every-day

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah certainly an option.

@kaxil

Copy link
Copy Markdown
MemberAuthor

Closing this in favor of #60940

@kaxilkaxil closed this Jan 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add UvicornMonitor for zero-downtime API server worker recycling by kaxil · Pull Request #60919 · apache/airflow · GitHub
Skip to content

Add UvicornMonitor for zero-downtime API server worker recycling - #60919

Closed
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling
Closed

Add UvicornMonitor for zero-downtime API server worker recycling#60919
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling

Conversation

@kaxil

@kaxilkaxil commented Jan 22, 2026

Copy link
Copy Markdown
Member

Alternate/complement to #60804

Why

API server workers accumulate memory over time. Airflow 2 had GunicornMonitor with rolling restarts - spawn new workers, health check them, then kill old ones. This was lost when we switched to uvicorn.

Uvicorn's built-in limit_max_requests doesn't help here - it kills old workers before spawning new ones, causing downtime.

What

New UvicornMonitor class that does rolling restarts:

[n workers] → spawn batch → [n + batch workers] → health check → kill old batch → [n workers]

Enabled via config:

[api]worker_refresh_interval = 1800 # seconds, 0 = disabled (default)worker_refresh_batch_size = 1

Gotchas (vs GunicornMonitor)

Single-worker mode: Gunicorn always uses master/worker architecture even with workers=1 (master + 1 worker), so signals always work. Uvicorn with workers=1 runs in single-process mode with no supervisor, so SIGTTIN/SIGTTOU are ignored. Workaround: start with 2 workers and scale down after startup. Works, but briefly has 2 workers during refresh cycles.

Uvicorn kills newest worker, not oldest: Gunicorn kills the oldest worker on SIGTTOU (workers.pop(0) sorted by age). Uvicorn kills the newest (processes.pop() - LIFO). This would kill our fresh healthy workers instead of the old ones. Fixed by sending SIGTERM directly to specific old PIDs instead of using SIGTTOU.

No memory sharing between workers: Unlike Gunicorn (which uses preload + fork for copy-on-write memory sharing), uvicorn's multiprocess mode spawns independent workers that each load everything separately. This means:

  • Each worker has its own copy of all loaded modules, configurations, and cached data
  • Total memory usage scales linearly with worker count (N workers = ~N× memory)

This is an inherent limitation of uvicorn's multiprocessing approach vs gunicorn's preload+fork model.

Testing

# Start API server with worker recycling enabledexport AIRFLOW__API__WORKER_REFRESH_INTERVAL=60
airflow api-server --workers 2
# Watch logs for rolling restart messages:# "Starting worker refresh: current workers PIDs [1001, 1002]"# "Spawned new workers: PIDs [1003]"# "Killing old workers: PIDs [1001]"# "Worker refresh completed: new PIDs [1003] replaced old PIDs [1001]"

Related

Implement rolling worker restarts for the API server using uvicorn's
SIGTTIN/SIGTTOU signal-based worker management. This provides feature
parity with Airflow 2's GunicornMonitor while maintaining zero downtime.
Key features:
- Rolling restart pattern: spawn new workers before killing old ones
- Health check verification before killing old workers
- Automatic rollback if new workers fail health checks
- Configurable refresh interval and batch size
New configuration options:
- worker_refresh_interval: Seconds between refresh cycles (default: 0/disabled)
- worker_refresh_batch_size: Workers to refresh at a time (default: 1)
This addresses memory accumulation in long-running API server workers
by periodically recycling them while ensuring continuous availability.
version_added: 3.2.0
type: integer
example: ~
default: "0"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use some more robust default here?

I guess we could have min 2 workers by default and have rolling restarts enabled by default, and refresh interval set to some default, reasonable value (say 1hr).

While it increases memory used as explained in the PR description, it is far more robust for "out-of-the-box" installation, and if users would like to save memory by limiting it to 1, they still should be able to do so (and then we could disable the uvicorn restarts altogether). I think it's more important to have "robust non leaking, gently restarting" by default, rather than "potentially leaking smaller initial memory".

Since Fast API recommendation is 1 worker per Pod - we could also recommend to the users - in the same docs - to use the rolling restarts of deployment instead those restarts that are handled by Uvicorn monitor. And we could add description to the number of workers paraneter, that setting it to 1 is ok as long as you have more than one instance of api-server and implement refreshing rolling restart outside of Airlfow. This way, the users who would like to change it to 1 (and read the docs that is) - would know that they also need to take care about potential leaks.

There are even some ways to do it automatically - which we could implement in our Helm Chart as an option potentially:

https://stackoverflow.com/questions/67423919/k8s-cronjob-rolling-restart-every-day

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah certainly an option.

@kaxil

Copy link
Copy Markdown
MemberAuthor

Closing this in favor of #60940

@kaxilkaxil closed this Jan 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add UvicornMonitor for zero-downtime API server worker recycling by kaxil · Pull Request #60919 · apache/airflow · GitHub
Skip to content

Add UvicornMonitor for zero-downtime API server worker recycling - #60919

Closed
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling
Closed

Add UvicornMonitor for zero-downtime API server worker recycling#60919
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling

Conversation

@kaxil

@kaxilkaxil commented Jan 22, 2026

Copy link
Copy Markdown
Member

Alternate/complement to #60804

Why

API server workers accumulate memory over time. Airflow 2 had GunicornMonitor with rolling restarts - spawn new workers, health check them, then kill old ones. This was lost when we switched to uvicorn.

Uvicorn's built-in limit_max_requests doesn't help here - it kills old workers before spawning new ones, causing downtime.

What

New UvicornMonitor class that does rolling restarts:

[n workers] → spawn batch → [n + batch workers] → health check → kill old batch → [n workers]

Enabled via config:

[api]worker_refresh_interval = 1800 # seconds, 0 = disabled (default)worker_refresh_batch_size = 1

Gotchas (vs GunicornMonitor)

Single-worker mode: Gunicorn always uses master/worker architecture even with workers=1 (master + 1 worker), so signals always work. Uvicorn with workers=1 runs in single-process mode with no supervisor, so SIGTTIN/SIGTTOU are ignored. Workaround: start with 2 workers and scale down after startup. Works, but briefly has 2 workers during refresh cycles.

Uvicorn kills newest worker, not oldest: Gunicorn kills the oldest worker on SIGTTOU (workers.pop(0) sorted by age). Uvicorn kills the newest (processes.pop() - LIFO). This would kill our fresh healthy workers instead of the old ones. Fixed by sending SIGTERM directly to specific old PIDs instead of using SIGTTOU.

No memory sharing between workers: Unlike Gunicorn (which uses preload + fork for copy-on-write memory sharing), uvicorn's multiprocess mode spawns independent workers that each load everything separately. This means:

  • Each worker has its own copy of all loaded modules, configurations, and cached data
  • Total memory usage scales linearly with worker count (N workers = ~N× memory)

This is an inherent limitation of uvicorn's multiprocessing approach vs gunicorn's preload+fork model.

Testing

# Start API server with worker recycling enabledexport AIRFLOW__API__WORKER_REFRESH_INTERVAL=60
airflow api-server --workers 2
# Watch logs for rolling restart messages:# "Starting worker refresh: current workers PIDs [1001, 1002]"# "Spawned new workers: PIDs [1003]"# "Killing old workers: PIDs [1001]"# "Worker refresh completed: new PIDs [1003] replaced old PIDs [1001]"

Related

Implement rolling worker restarts for the API server using uvicorn's
SIGTTIN/SIGTTOU signal-based worker management. This provides feature
parity with Airflow 2's GunicornMonitor while maintaining zero downtime.
Key features:
- Rolling restart pattern: spawn new workers before killing old ones
- Health check verification before killing old workers
- Automatic rollback if new workers fail health checks
- Configurable refresh interval and batch size
New configuration options:
- worker_refresh_interval: Seconds between refresh cycles (default: 0/disabled)
- worker_refresh_batch_size: Workers to refresh at a time (default: 1)
This addresses memory accumulation in long-running API server workers
by periodically recycling them while ensuring continuous availability.
version_added: 3.2.0
type: integer
example: ~
default: "0"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use some more robust default here?

I guess we could have min 2 workers by default and have rolling restarts enabled by default, and refresh interval set to some default, reasonable value (say 1hr).

While it increases memory used as explained in the PR description, it is far more robust for "out-of-the-box" installation, and if users would like to save memory by limiting it to 1, they still should be able to do so (and then we could disable the uvicorn restarts altogether). I think it's more important to have "robust non leaking, gently restarting" by default, rather than "potentially leaking smaller initial memory".

Since Fast API recommendation is 1 worker per Pod - we could also recommend to the users - in the same docs - to use the rolling restarts of deployment instead those restarts that are handled by Uvicorn monitor. And we could add description to the number of workers paraneter, that setting it to 1 is ok as long as you have more than one instance of api-server and implement refreshing rolling restart outside of Airlfow. This way, the users who would like to change it to 1 (and read the docs that is) - would know that they also need to take care about potential leaks.

There are even some ways to do it automatically - which we could implement in our Helm Chart as an option potentially:

https://stackoverflow.com/questions/67423919/k8s-cronjob-rolling-restart-every-day

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah certainly an option.

@kaxil

Copy link
Copy Markdown
MemberAuthor

Closing this in favor of #60940

@kaxilkaxil closed this Jan 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Add UvicornMonitor for zero-downtime API server worker recycling by kaxil · Pull Request #60919 · apache/airflow · GitHub
Skip to content

Add UvicornMonitor for zero-downtime API server worker recycling - #60919

Closed
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling
Closed

Add UvicornMonitor for zero-downtime API server worker recycling#60919
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling

Conversation

@kaxil

@kaxilkaxil commented Jan 22, 2026

Copy link
Copy Markdown
Member

Alternate/complement to #60804

Why

API server workers accumulate memory over time. Airflow 2 had GunicornMonitor with rolling restarts - spawn new workers, health check them, then kill old ones. This was lost when we switched to uvicorn.

Uvicorn's built-in limit_max_requests doesn't help here - it kills old workers before spawning new ones, causing downtime.

What

New UvicornMonitor class that does rolling restarts:

[n workers] → spawn batch → [n + batch workers] → health check → kill old batch → [n workers]

Enabled via config:

[api]worker_refresh_interval = 1800 # seconds, 0 = disabled (default)worker_refresh_batch_size = 1

Gotchas (vs GunicornMonitor)

Single-worker mode: Gunicorn always uses master/worker architecture even with workers=1 (master + 1 worker), so signals always work. Uvicorn with workers=1 runs in single-process mode with no supervisor, so SIGTTIN/SIGTTOU are ignored. Workaround: start with 2 workers and scale down after startup. Works, but briefly has 2 workers during refresh cycles.

Uvicorn kills newest worker, not oldest: Gunicorn kills the oldest worker on SIGTTOU (workers.pop(0) sorted by age). Uvicorn kills the newest (processes.pop() - LIFO). This would kill our fresh healthy workers instead of the old ones. Fixed by sending SIGTERM directly to specific old PIDs instead of using SIGTTOU.

No memory sharing between workers: Unlike Gunicorn (which uses preload + fork for copy-on-write memory sharing), uvicorn's multiprocess mode spawns independent workers that each load everything separately. This means:

  • Each worker has its own copy of all loaded modules, configurations, and cached data
  • Total memory usage scales linearly with worker count (N workers = ~N× memory)

This is an inherent limitation of uvicorn's multiprocessing approach vs gunicorn's preload+fork model.

Testing

# Start API server with worker recycling enabledexport AIRFLOW__API__WORKER_REFRESH_INTERVAL=60
airflow api-server --workers 2
# Watch logs for rolling restart messages:# "Starting worker refresh: current workers PIDs [1001, 1002]"# "Spawned new workers: PIDs [1003]"# "Killing old workers: PIDs [1001]"# "Worker refresh completed: new PIDs [1003] replaced old PIDs [1001]"

Related

Implement rolling worker restarts for the API server using uvicorn's
SIGTTIN/SIGTTOU signal-based worker management. This provides feature
parity with Airflow 2's GunicornMonitor while maintaining zero downtime.
Key features:
- Rolling restart pattern: spawn new workers before killing old ones
- Health check verification before killing old workers
- Automatic rollback if new workers fail health checks
- Configurable refresh interval and batch size
New configuration options:
- worker_refresh_interval: Seconds between refresh cycles (default: 0/disabled)
- worker_refresh_batch_size: Workers to refresh at a time (default: 1)
This addresses memory accumulation in long-running API server workers
by periodically recycling them while ensuring continuous availability.
version_added: 3.2.0
type: integer
example: ~
default: "0"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use some more robust default here?

I guess we could have min 2 workers by default and have rolling restarts enabled by default, and refresh interval set to some default, reasonable value (say 1hr).

While it increases memory used as explained in the PR description, it is far more robust for "out-of-the-box" installation, and if users would like to save memory by limiting it to 1, they still should be able to do so (and then we could disable the uvicorn restarts altogether). I think it's more important to have "robust non leaking, gently restarting" by default, rather than "potentially leaking smaller initial memory".

Since Fast API recommendation is 1 worker per Pod - we could also recommend to the users - in the same docs - to use the rolling restarts of deployment instead those restarts that are handled by Uvicorn monitor. And we could add description to the number of workers paraneter, that setting it to 1 is ok as long as you have more than one instance of api-server and implement refreshing rolling restart outside of Airlfow. This way, the users who would like to change it to 1 (and read the docs that is) - would know that they also need to take care about potential leaks.

There are even some ways to do it automatically - which we could implement in our Helm Chart as an option potentially:

https://stackoverflow.com/questions/67423919/k8s-cronjob-rolling-restart-every-day

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah certainly an option.

@kaxil

Copy link
Copy Markdown
MemberAuthor

Closing this in favor of #60940

@kaxilkaxil closed this Jan 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add UvicornMonitor for zero-downtime API server worker recycling by kaxil · Pull Request #60919 · apache/airflow · GitHub
Skip to content

Add UvicornMonitor for zero-downtime API server worker recycling - #60919

Closed
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling
Closed

Add UvicornMonitor for zero-downtime API server worker recycling#60919
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling

Conversation

@kaxil

@kaxilkaxil commented Jan 22, 2026

Copy link
Copy Markdown
Member

Alternate/complement to #60804

Why

API server workers accumulate memory over time. Airflow 2 had GunicornMonitor with rolling restarts - spawn new workers, health check them, then kill old ones. This was lost when we switched to uvicorn.

Uvicorn's built-in limit_max_requests doesn't help here - it kills old workers before spawning new ones, causing downtime.

What

New UvicornMonitor class that does rolling restarts:

[n workers] → spawn batch → [n + batch workers] → health check → kill old batch → [n workers]

Enabled via config:

[api]worker_refresh_interval = 1800 # seconds, 0 = disabled (default)worker_refresh_batch_size = 1

Gotchas (vs GunicornMonitor)

Single-worker mode: Gunicorn always uses master/worker architecture even with workers=1 (master + 1 worker), so signals always work. Uvicorn with workers=1 runs in single-process mode with no supervisor, so SIGTTIN/SIGTTOU are ignored. Workaround: start with 2 workers and scale down after startup. Works, but briefly has 2 workers during refresh cycles.

Uvicorn kills newest worker, not oldest: Gunicorn kills the oldest worker on SIGTTOU (workers.pop(0) sorted by age). Uvicorn kills the newest (processes.pop() - LIFO). This would kill our fresh healthy workers instead of the old ones. Fixed by sending SIGTERM directly to specific old PIDs instead of using SIGTTOU.

No memory sharing between workers: Unlike Gunicorn (which uses preload + fork for copy-on-write memory sharing), uvicorn's multiprocess mode spawns independent workers that each load everything separately. This means:

  • Each worker has its own copy of all loaded modules, configurations, and cached data
  • Total memory usage scales linearly with worker count (N workers = ~N× memory)

This is an inherent limitation of uvicorn's multiprocessing approach vs gunicorn's preload+fork model.

Testing

# Start API server with worker recycling enabledexport AIRFLOW__API__WORKER_REFRESH_INTERVAL=60
airflow api-server --workers 2
# Watch logs for rolling restart messages:# "Starting worker refresh: current workers PIDs [1001, 1002]"# "Spawned new workers: PIDs [1003]"# "Killing old workers: PIDs [1001]"# "Worker refresh completed: new PIDs [1003] replaced old PIDs [1001]"

Related

Implement rolling worker restarts for the API server using uvicorn's
SIGTTIN/SIGTTOU signal-based worker management. This provides feature
parity with Airflow 2's GunicornMonitor while maintaining zero downtime.
Key features:
- Rolling restart pattern: spawn new workers before killing old ones
- Health check verification before killing old workers
- Automatic rollback if new workers fail health checks
- Configurable refresh interval and batch size
New configuration options:
- worker_refresh_interval: Seconds between refresh cycles (default: 0/disabled)
- worker_refresh_batch_size: Workers to refresh at a time (default: 1)
This addresses memory accumulation in long-running API server workers
by periodically recycling them while ensuring continuous availability.
version_added: 3.2.0
type: integer
example: ~
default: "0"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use some more robust default here?

I guess we could have min 2 workers by default and have rolling restarts enabled by default, and refresh interval set to some default, reasonable value (say 1hr).

While it increases memory used as explained in the PR description, it is far more robust for "out-of-the-box" installation, and if users would like to save memory by limiting it to 1, they still should be able to do so (and then we could disable the uvicorn restarts altogether). I think it's more important to have "robust non leaking, gently restarting" by default, rather than "potentially leaking smaller initial memory".

Since Fast API recommendation is 1 worker per Pod - we could also recommend to the users - in the same docs - to use the rolling restarts of deployment instead those restarts that are handled by Uvicorn monitor. And we could add description to the number of workers paraneter, that setting it to 1 is ok as long as you have more than one instance of api-server and implement refreshing rolling restart outside of Airlfow. This way, the users who would like to change it to 1 (and read the docs that is) - would know that they also need to take care about potential leaks.

There are even some ways to do it automatically - which we could implement in our Helm Chart as an option potentially:

https://stackoverflow.com/questions/67423919/k8s-cronjob-rolling-restart-every-day

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah certainly an option.

@kaxil

Copy link
Copy Markdown
MemberAuthor

Closing this in favor of #60940

@kaxilkaxil closed this Jan 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add UvicornMonitor for zero-downtime API server worker recycling by kaxil · Pull Request #60919 · apache/airflow · GitHub
Skip to content

Add UvicornMonitor for zero-downtime API server worker recycling - #60919

Closed
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling
Closed

Add UvicornMonitor for zero-downtime API server worker recycling#60919
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling

Conversation

@kaxil

@kaxilkaxil commented Jan 22, 2026

Copy link
Copy Markdown
Member

Alternate/complement to #60804

Why

API server workers accumulate memory over time. Airflow 2 had GunicornMonitor with rolling restarts - spawn new workers, health check them, then kill old ones. This was lost when we switched to uvicorn.

Uvicorn's built-in limit_max_requests doesn't help here - it kills old workers before spawning new ones, causing downtime.

What

New UvicornMonitor class that does rolling restarts:

[n workers] → spawn batch → [n + batch workers] → health check → kill old batch → [n workers]

Enabled via config:

[api]worker_refresh_interval = 1800 # seconds, 0 = disabled (default)worker_refresh_batch_size = 1

Gotchas (vs GunicornMonitor)

Single-worker mode: Gunicorn always uses master/worker architecture even with workers=1 (master + 1 worker), so signals always work. Uvicorn with workers=1 runs in single-process mode with no supervisor, so SIGTTIN/SIGTTOU are ignored. Workaround: start with 2 workers and scale down after startup. Works, but briefly has 2 workers during refresh cycles.

Uvicorn kills newest worker, not oldest: Gunicorn kills the oldest worker on SIGTTOU (workers.pop(0) sorted by age). Uvicorn kills the newest (processes.pop() - LIFO). This would kill our fresh healthy workers instead of the old ones. Fixed by sending SIGTERM directly to specific old PIDs instead of using SIGTTOU.

No memory sharing between workers: Unlike Gunicorn (which uses preload + fork for copy-on-write memory sharing), uvicorn's multiprocess mode spawns independent workers that each load everything separately. This means:

  • Each worker has its own copy of all loaded modules, configurations, and cached data
  • Total memory usage scales linearly with worker count (N workers = ~N× memory)

This is an inherent limitation of uvicorn's multiprocessing approach vs gunicorn's preload+fork model.

Testing

# Start API server with worker recycling enabledexport AIRFLOW__API__WORKER_REFRESH_INTERVAL=60
airflow api-server --workers 2
# Watch logs for rolling restart messages:# "Starting worker refresh: current workers PIDs [1001, 1002]"# "Spawned new workers: PIDs [1003]"# "Killing old workers: PIDs [1001]"# "Worker refresh completed: new PIDs [1003] replaced old PIDs [1001]"

Related

Implement rolling worker restarts for the API server using uvicorn's
SIGTTIN/SIGTTOU signal-based worker management. This provides feature
parity with Airflow 2's GunicornMonitor while maintaining zero downtime.
Key features:
- Rolling restart pattern: spawn new workers before killing old ones
- Health check verification before killing old workers
- Automatic rollback if new workers fail health checks
- Configurable refresh interval and batch size
New configuration options:
- worker_refresh_interval: Seconds between refresh cycles (default: 0/disabled)
- worker_refresh_batch_size: Workers to refresh at a time (default: 1)
This addresses memory accumulation in long-running API server workers
by periodically recycling them while ensuring continuous availability.
version_added: 3.2.0
type: integer
example: ~
default: "0"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use some more robust default here?

I guess we could have min 2 workers by default and have rolling restarts enabled by default, and refresh interval set to some default, reasonable value (say 1hr).

While it increases memory used as explained in the PR description, it is far more robust for "out-of-the-box" installation, and if users would like to save memory by limiting it to 1, they still should be able to do so (and then we could disable the uvicorn restarts altogether). I think it's more important to have "robust non leaking, gently restarting" by default, rather than "potentially leaking smaller initial memory".

Since Fast API recommendation is 1 worker per Pod - we could also recommend to the users - in the same docs - to use the rolling restarts of deployment instead those restarts that are handled by Uvicorn monitor. And we could add description to the number of workers paraneter, that setting it to 1 is ok as long as you have more than one instance of api-server and implement refreshing rolling restart outside of Airlfow. This way, the users who would like to change it to 1 (and read the docs that is) - would know that they also need to take care about potential leaks.

There are even some ways to do it automatically - which we could implement in our Helm Chart as an option potentially:

https://stackoverflow.com/questions/67423919/k8s-cronjob-rolling-restart-every-day

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah certainly an option.

@kaxil

Copy link
Copy Markdown
MemberAuthor

Closing this in favor of #60940

@kaxilkaxil closed this Jan 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Add UvicornMonitor for zero-downtime API server worker recycling by kaxil · Pull Request #60919 · apache/airflow · GitHub
Skip to content

Add UvicornMonitor for zero-downtime API server worker recycling - #60919

Closed
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling
Closed

Add UvicornMonitor for zero-downtime API server worker recycling#60919
kaxil wants to merge 1 commit into
apache:mainfrom
astronomer:uvicorn-cycling

Conversation

@kaxil

@kaxilkaxil commented Jan 22, 2026

Copy link
Copy Markdown
Member

Alternate/complement to #60804

Why

API server workers accumulate memory over time. Airflow 2 had GunicornMonitor with rolling restarts - spawn new workers, health check them, then kill old ones. This was lost when we switched to uvicorn.

Uvicorn's built-in limit_max_requests doesn't help here - it kills old workers before spawning new ones, causing downtime.

What

New UvicornMonitor class that does rolling restarts:

[n workers] → spawn batch → [n + batch workers] → health check → kill old batch → [n workers]

Enabled via config:

[api]worker_refresh_interval = 1800 # seconds, 0 = disabled (default)worker_refresh_batch_size = 1

Gotchas (vs GunicornMonitor)

Single-worker mode: Gunicorn always uses master/worker architecture even with workers=1 (master + 1 worker), so signals always work. Uvicorn with workers=1 runs in single-process mode with no supervisor, so SIGTTIN/SIGTTOU are ignored. Workaround: start with 2 workers and scale down after startup. Works, but briefly has 2 workers during refresh cycles.

Uvicorn kills newest worker, not oldest: Gunicorn kills the oldest worker on SIGTTOU (workers.pop(0) sorted by age). Uvicorn kills the newest (processes.pop() - LIFO). This would kill our fresh healthy workers instead of the old ones. Fixed by sending SIGTERM directly to specific old PIDs instead of using SIGTTOU.

No memory sharing between workers: Unlike Gunicorn (which uses preload + fork for copy-on-write memory sharing), uvicorn's multiprocess mode spawns independent workers that each load everything separately. This means:

  • Each worker has its own copy of all loaded modules, configurations, and cached data
  • Total memory usage scales linearly with worker count (N workers = ~N× memory)

This is an inherent limitation of uvicorn's multiprocessing approach vs gunicorn's preload+fork model.

Testing

# Start API server with worker recycling enabledexport AIRFLOW__API__WORKER_REFRESH_INTERVAL=60
airflow api-server --workers 2
# Watch logs for rolling restart messages:# "Starting worker refresh: current workers PIDs [1001, 1002]"# "Spawned new workers: PIDs [1003]"# "Killing old workers: PIDs [1001]"# "Worker refresh completed: new PIDs [1003] replaced old PIDs [1001]"

Related

Implement rolling worker restarts for the API server using uvicorn's
SIGTTIN/SIGTTOU signal-based worker management. This provides feature
parity with Airflow 2's GunicornMonitor while maintaining zero downtime.
Key features:
- Rolling restart pattern: spawn new workers before killing old ones
- Health check verification before killing old workers
- Automatic rollback if new workers fail health checks
- Configurable refresh interval and batch size
New configuration options:
- worker_refresh_interval: Seconds between refresh cycles (default: 0/disabled)
- worker_refresh_batch_size: Workers to refresh at a time (default: 1)
This addresses memory accumulation in long-running API server workers
by periodically recycling them while ensuring continuous availability.
version_added: 3.2.0
type: integer
example: ~
default: "0"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use some more robust default here?

I guess we could have min 2 workers by default and have rolling restarts enabled by default, and refresh interval set to some default, reasonable value (say 1hr).

While it increases memory used as explained in the PR description, it is far more robust for "out-of-the-box" installation, and if users would like to save memory by limiting it to 1, they still should be able to do so (and then we could disable the uvicorn restarts altogether). I think it's more important to have "robust non leaking, gently restarting" by default, rather than "potentially leaking smaller initial memory".

Since Fast API recommendation is 1 worker per Pod - we could also recommend to the users - in the same docs - to use the rolling restarts of deployment instead those restarts that are handled by Uvicorn monitor. And we could add description to the number of workers paraneter, that setting it to 1 is ok as long as you have more than one instance of api-server and implement refreshing rolling restart outside of Airlfow. This way, the users who would like to change it to 1 (and read the docs that is) - would know that they also need to take care about potential leaks.

There are even some ways to do it automatically - which we could implement in our Helm Chart as an option potentially:

https://stackoverflow.com/questions/67423919/k8s-cronjob-rolling-restart-every-day

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah certainly an option.

@kaxil

Copy link
Copy Markdown
MemberAuthor

Closing this in favor of #60940

@kaxilkaxil closed this Jan 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kaxil@potiuk