Disable use of LogTemplate table by default by potiuk · Pull Request #61880 · apache/airflow

potiuk · 2026-02-13T20:30:38Z

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default.

Was generative AI tooling used to co-author this PR?

Yes (please specify the tool below)

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

gopidesupavan · 2026-02-13T21:05:04Z

+ elasticsearch_id=airflow_conf.get(
+ "elasticsearch",
+ "log_id_template",
+ fallback="{dag_id}-{task_id}-{run_id}-{map_index}-{try_number}",


is this needs to be {{ }}. like this?

Not really - that's a string that is already default - the {{ is only needed when we read it from config and where it is processed first by Jinja template. But yeah - I will double check if this works as expected (also this fallback is not going to be used most likely - it's only in case the code is run before ProvidersManager discovery - because once providers manager processes it, there is a default defined from provider.yaml.

jscheffl

Cool!

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

potiuk · 2026-02-14T11:41:43Z

Fixed tests - also added more tests with / without configuration set.

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

apache#61880

potiuk · 2026-02-13T20:30:38Z

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default.

Was generative AI tooling used to co-author this PR?

Yes (please specify the tool below)

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

gopidesupavan · 2026-02-13T21:05:04Z

+ elasticsearch_id=airflow_conf.get(
+ "elasticsearch",
+ "log_id_template",
+ fallback="{dag_id}-{task_id}-{run_id}-{map_index}-{try_number}",


is this needs to be {{ }}. like this?

Not really - that's a string that is already default - the {{ is only needed when we read it from config and where it is processed first by Jinja template. But yeah - I will double check if this works as expected (also this fallback is not going to be used most likely - it's only in case the code is run before ProvidersManager discovery - because once providers manager processes it, there is a default defined from provider.yaml.

jscheffl

Cool!

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

potiuk · 2026-02-14T11:41:43Z

Fixed tests - also added more tests with / without configuration set.

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

apache#61880

potiuk · 2026-02-13T20:30:38Z

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default.

Was generative AI tooling used to co-author this PR?

Yes (please specify the tool below)

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

gopidesupavan · 2026-02-13T21:05:04Z

+ elasticsearch_id=airflow_conf.get(
+ "elasticsearch",
+ "log_id_template",
+ fallback="{dag_id}-{task_id}-{run_id}-{map_index}-{try_number}",


is this needs to be {{ }}. like this?

Not really - that's a string that is already default - the {{ is only needed when we read it from config and where it is processed first by Jinja template. But yeah - I will double check if this works as expected (also this fallback is not going to be used most likely - it's only in case the code is run before ProvidersManager discovery - because once providers manager processes it, there is a default defined from provider.yaml.

jscheffl

Cool!

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

potiuk · 2026-02-14T11:41:43Z

Fixed tests - also added more tests with / without configuration set.

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

apache#61880

potiuk · 2026-02-13T20:30:38Z

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default.

Was generative AI tooling used to co-author this PR?

Yes (please specify the tool below)

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

gopidesupavan · 2026-02-13T21:05:04Z

+ elasticsearch_id=airflow_conf.get(
+ "elasticsearch",
+ "log_id_template",
+ fallback="{dag_id}-{task_id}-{run_id}-{map_index}-{try_number}",


is this needs to be {{ }}. like this?

Not really - that's a string that is already default - the {{ is only needed when we read it from config and where it is processed first by Jinja template. But yeah - I will double check if this works as expected (also this fallback is not going to be used most likely - it's only in case the code is run before ProvidersManager discovery - because once providers manager processes it, there is a default defined from provider.yaml.

jscheffl

Cool!

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

potiuk · 2026-02-14T11:41:43Z

Fixed tests - also added more tests with / without configuration set.

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

apache#61880

potiuk · 2026-02-13T20:30:38Z

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default.

Was generative AI tooling used to co-author this PR?

Yes (please specify the tool below)

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

gopidesupavan · 2026-02-13T21:05:04Z

+ elasticsearch_id=airflow_conf.get(
+ "elasticsearch",
+ "log_id_template",
+ fallback="{dag_id}-{task_id}-{run_id}-{map_index}-{try_number}",


is this needs to be {{ }}. like this?

Not really - that's a string that is already default - the {{ is only needed when we read it from config and where it is processed first by Jinja template. But yeah - I will double check if this works as expected (also this fallback is not going to be used most likely - it's only in case the code is run before ProvidersManager discovery - because once providers manager processes it, there is a default defined from provider.yaml.

jscheffl

Cool!

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

potiuk · 2026-02-14T11:41:43Z

Fixed tests - also added more tests with / without configuration set.

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

apache#61880

potiuk · 2026-02-13T20:30:38Z

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default.

Was generative AI tooling used to co-author this PR?

Yes (please specify the tool below)

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

gopidesupavan · 2026-02-13T21:05:04Z

+ elasticsearch_id=airflow_conf.get(
+ "elasticsearch",
+ "log_id_template",
+ fallback="{dag_id}-{task_id}-{run_id}-{map_index}-{try_number}",


is this needs to be {{ }}. like this?

Not really - that's a string that is already default - the {{ is only needed when we read it from config and where it is processed first by Jinja template. But yeah - I will double check if this works as expected (also this fallback is not going to be used most likely - it's only in case the code is run before ProvidersManager discovery - because once providers manager processes it, there is a default defined from provider.yaml.

jscheffl

Cool!

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

potiuk · 2026-02-14T11:41:43Z

Fixed tests - also added more tests with / without configuration set.

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

apache#61880

potiuk · 2026-02-13T20:30:38Z

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default.

Was generative AI tooling used to co-author this PR?

Yes (please specify the tool below)

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

gopidesupavan · 2026-02-13T21:05:04Z

+ elasticsearch_id=airflow_conf.get(
+ "elasticsearch",
+ "log_id_template",
+ fallback="{dag_id}-{task_id}-{run_id}-{map_index}-{try_number}",


is this needs to be {{ }}. like this?

Not really - that's a string that is already default - the {{ is only needed when we read it from config and where it is processed first by Jinja template. But yeah - I will double check if this works as expected (also this fallback is not going to be used most likely - it's only in case the code is run before ProvidersManager discovery - because once providers manager processes it, there is a default defined from provider.yaml.

jscheffl

Cool!

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

potiuk · 2026-02-14T11:41:43Z

Fixed tests - also added more tests with / without configuration set.

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

apache#61880

potiuk · 2026-02-13T20:30:38Z

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default.

Was generative AI tooling used to co-author this PR?

Yes (please specify the tool below)

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.
For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

gopidesupavan · 2026-02-13T21:05:04Z

+ elasticsearch_id=airflow_conf.get(
+ "elasticsearch",
+ "log_id_template",
+ fallback="{dag_id}-{task_id}-{run_id}-{map_index}-{try_number}",


is this needs to be {{ }}. like this?

Not really - that's a string that is already default - the {{ is only needed when we read it from config and where it is processed first by Jinja template. But yeah - I will double check if this works as expected (also this fallback is not going to be used most likely - it's only in case the code is run before ProvidersManager discovery - because once providers manager processes it, there is a default defined from provider.yaml.

jscheffl

Cool!

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

potiuk · 2026-02-14T11:41:43Z

Fixed tests - also added more tests with / without configuration set.

Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

apache#61880

potiuk force-pushed the disable-log-template-history branch from bac7d55 to 2926beaCompare February 13, 2026 20:36

potiuk marked this pull request as ready for review February 13, 2026 20:36

potiuk requested review from XD-DENG, ashb and kaxil as code owners February 13, 2026 20:36

potiuk force-pushed the disable-log-template-history branch 2 times, most recently from 3d9cbcb to 23f8827Compare February 13, 2026 20:37

potiuk requested review from amoghrajesh and gopidesupavan February 13, 2026 20:47

potiuk added this to the Airflow 2.11.1 milestone Feb 13, 2026

gopidesupavan reviewed Feb 13, 2026
View reviewed changes

Comment threadairflow/config_templates/config.yml Outdated

gopidesupavan approved these changes Feb 13, 2026
View reviewed changes

jscheffl approved these changes Feb 13, 2026
View reviewed changes

Disable use of LogTemplate table by default
0962b09
Accessing the database when rendering log template might introduce unnecesary risks to execute code in webserver and we should disable it by default. Update airflow/config_templates/config.yml Co-authored-by: GPK <gopidesupavan@gmail.com>

potiuk force-pushed the disable-log-template-history branch from e1a37cf to 0962b09Compare February 14, 2026 11:41

potiuk merged commit b337a54 into apache:v2-11-testFeb 14, 2026
66 checks passed

potiuk deleted the disable-log-template-history branch February 14, 2026 12:26

potiuk mentioned this pull request Feb 17, 2026
Status of testing of Apache Airflow 2.11.1rc2 (and Fab Provider 1.5.4rc1) #62056
Closed
26 tasks

harshith-212 added a commit to acceldata-io/airflow that referenced this pull request Mar 9, 2026
Disable use of LogTemplate table by default
96c9e56
apache#61880

harshith-212 added a commit to acceldata-io/airflow that referenced this pull request Mar 17, 2026
Disable use of LogTemplate table by default
aa308ea
apache#61880

harshith-212 added a commit to acceldata-io/airflow that referenced this pull request Mar 17, 2026
Disable use of LogTemplate table by default
6aa11cd
apache#61880

harshith-212 added a commit to acceldata-io/airflow that referenced this pull request Apr 14, 2026
Disable use of LogTemplate table by default
817d2b7
apache#61880

odp-ops pushed a commit to acceldata-io/airflow that referenced this pull request May 4, 2026
Disable use of LogTemplate table by default
22f5ef5
apache#61880

jason810496 mentioned this pull request Jul 7, 2026
Drop the LogTemplate DB model #69520
Closed
1 task