Skip to content

[AIRFLOW-XXX] Update Alembic autogenerator to pass pylint - #6216

Merged
ashb merged 1 commit into
apache:masterfrom
ashb:alembic-templates
Oct 1, 2019
Merged

[AIRFLOW-XXX] Update Alembic autogenerator to pass pylint#6216
ashb merged 1 commit into
apache:masterfrom
ashb:alembic-templates

Conversation

@ashb

@ashbashb commented Sep 30, 2019

Copy link
Copy Markdown
Member

Make sure you have checked all steps below.

Jira

  • No Jira

Description

  • Update the template alembic uses for creating migrations to pass (or at least be closer to passing) pylint checks

@ashb
ashb requested review from mik-laj and potiukSeptember 30, 2019 09:09
@codecov-io

codecov-io commented Sep 30, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6216 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #6216 +/- ##
==========================================
- Coverage 80.02% 80.01% -0.02% 
==========================================
Files 610 610 Lines 35176 35176 ==========================================
- Hits 28151 28147 -4 - Misses 7025 7029 +4
Impacted FilesCoverage Δ
airflow/contrib/operators/ssh_operator.py82.5% <0%> (-1.25%)⬇️
airflow/utils/dag_processing.py56.37% <0%> (-0.52%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844bbad...bd98130. Read the comment docs.

@potiukpotiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Should we split it to two separate commits? Filtering out of Flask Appbuilder tables should be separate commit I think.

@ashb

ashb commented Sep 30, 2019

Copy link
Copy Markdown
MemberAuthor

Nit: Should we split it to two separate commits? Filtering out of Flask Appbuilder tables should be separate commit I think.

Good call, will do as two separate PRs. Done, other PR #6221

@ashb
ashbforce-pushed the alembic-templates branch from b8c58fa to bd98130CompareOctober 1, 2019 09:48
@ashb
ashb merged commit 3a90d78 into apache:masterOct 1, 2019
@ashb
ashb deleted the alembic-templates branch October 1, 2019 11:40
@ashbashb mentioned this pull request Oct 18, 2019
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ashb@codecov-io@potiuk