Revert "Fix race condition in auth manager initialization" - #62404

Merged
pierrejeambrun merged 1 commit into
mainfrom
revert-62214-fix/thread-safe-auth-manager-init
Feb 24, 2026
Merged

Revert "Fix race condition in auth manager initialization"#62404
pierrejeambrun merged 1 commit into
mainfrom
revert-62214-fix/thread-safe-auth-manager-init

Conversation

@pierrejeambrun

@pierrejeambrunpierrejeambrun commented Feb 24, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Reverts #62214

I'm having trouble starting breeze with the Fab auth manager because of this change.

I believe this is creating a problem because get_application_builder is actually also called by the fastapi fab provider routes. (generating token, login / login, create users etc...).

So every time we call the fab provider fastapi API, we clear the global fastapi APP and the _return_appbuilder.

Then calling a core api fastapi endpiont will try to re-init the APP, before the overrides are initialized.

 File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 999, in exec_module
File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/main.py", line 46, in <module>
app = cached_app(apps=os.environ.get("AIRFLOW_API_APPS", "all"))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 115, in cached_app
return create_app(apps=apps)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/utils/providers_configuration_loader.py", line 54, in wrapped_function
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 102, in create_app
init_flask_plugins(app)
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/core_api/app.py", line 145, in init_flask_plugins
flask_app = create_app(enable_plugins=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/app.py", line 96, in create_app
init_appbuilder(flask_app, enable_plugins=enable_plugins)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 599, in init_appbuilder
return AirflowAppBuilder(
^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 156, in __init__
self.init_app(app, session)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 208, in init_app
self._add_admin_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 304, in _add_admin_views
auth_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py", line 618, in register_views
self.security_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 440, in register_views
if self.auth_user_registration:
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 754, in auth_user_registration
return current_app.config["AUTH_USER_REGISTRATION"]
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'AUTH_USER_REGISTRATION'

@boring-cyborgboring-cyborgBot added area:API Airflow's REST/HTTP API area:providers provider:fab provider:google Google (including GCP) related issues provider:keycloak labels Feb 24, 2026
@pierrejeambrun

pierrejeambrun commented Feb 24, 2026

Copy link
Copy Markdown
MemberAuthor

Let me try to fix it without reverting first.

@jason810496

jason810496 commented Feb 24, 2026

Copy link
Copy Markdown
Member

Let me try to fix it without reverting first.

Maybe #62214 (comment) was right?

@pierrejeambrun

pierrejeambrun commented Feb 24, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

I think it's safer to revert, the change like this is not backward compatible between old fab providers version and the new one. Basically core caching is breaking fab providers in this current state.

@pierrejeambrun
pierrejeambrun merged commit e2bb922 into mainFeb 24, 2026
215 of 252 checks passed
@pierrejeambrun
pierrejeambrun deleted the revert-62214-fix/thread-safe-auth-manager-init branch February 24, 2026 12:58
@kimyoungi99kimyoungi99 mentioned this pull request Feb 24, 2026
Merged
@vincbeckvincbeck mentioned this pull request Mar 10, 2026
Closed
81 tasks
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
@pierrejeambrun@dominikhei
Revert "Fix race condition in auth manager initialization (apache#62214…
18e1dae
…)" (apache#62404)
This reverts commit 5c9171a.
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
@pierrejeambrun@Ankurdeewan
Revert "Fix race condition in auth manager initialization (apache#62214…
dc9e611
…)" (apache#62404)
This reverts commit 5c9171a.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason810496jason810496jason810496 approved these changes
@vincbeckvincbeckAwaiting requested review from vincbeckvincbeck is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shahar1shahar1Awaiting requested review from shahar1shahar1 is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@choo121600choo121600Awaiting requested review from choo121600choo121600 is a code owner

Assignees

No one assigned

Labels

area:APIAirflow's REST/HTTP APIarea:providersprovider:fabprovider:googleGoogle (including GCP) related issuesprovider:keycloak

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pierrejeambrun@jason810496
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Revert "Fix race condition in auth manager initialization" - #62404
Merged
pierrejeambrun merged 1 commit into
mainfrom 
revert-62214-fix/thread-safe-auth-manager-init
Feb 24, 2026
Merged
Revert "Fix race condition in auth manager initialization"#62404
pierrejeambrun merged 1 commit into
mainfrom 
revert-62214-fix/thread-safe-auth-manager-init
Conversation
@pierrejeambrun
@pierrejeambrunpierrejeambrun
commented
Feb 24, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Reverts #62214
I'm having trouble starting breeze with the Fab auth manager because of this change.
I believe this is creating a problem because get_application_builder is actually also called by the fastapi fab provider routes. (generating token, login / login, create users etc...).
So every time we call the fab provider fastapi API, we clear the global fastapi APP and the _return_appbuilder.
Then calling a core api fastapi endpiont will try to re-init the APP, before the overrides are initialized.
 File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 999, in exec_module
File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/main.py", line 46, in <module>
app = cached_app(apps=os.environ.get("AIRFLOW_API_APPS", "all"))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 115, in cached_app
return create_app(apps=apps)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/utils/providers_configuration_loader.py", line 54, in wrapped_function
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 102, in create_app
init_flask_plugins(app)
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/core_api/app.py", line 145, in init_flask_plugins
flask_app = create_app(enable_plugins=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/app.py", line 96, in create_app
init_appbuilder(flask_app, enable_plugins=enable_plugins)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 599, in init_appbuilder
return AirflowAppBuilder(
^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 156, in __init__
self.init_app(app, session)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 208, in init_app
self._add_admin_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 304, in _add_admin_views
auth_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py", line 618, in register_views
self.security_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 440, in register_views
if self.auth_user_registration:
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 754, in auth_user_registration
return current_app.config["AUTH_USER_REGISTRATION"]
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'AUTH_USER_REGISTRATION'

@boring-cyborgboring-cyborgBot
added

area:API
Airflow's REST/HTTP API
area:providers

provider:fab

provider:google
Google (including GCP) related issues
provider:keycloak

labels
Feb 24, 2026
@pierrejeambrun
pierrejeambrun
commented
Feb 24, 2026

Copy link


Copy Markdown

MemberAuthor
Let me try to fix it without reverting first.
@jason810496
jason810496
commented
Feb 24, 2026

Copy link


Copy Markdown

Member
Let me try to fix it without reverting first.
Maybe #62214 (comment) was right?
@pierrejeambrun
pierrejeambrun
commented
Feb 24, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I think it's safer to revert, the change like this is not backward compatible between old fab providers version and the new one. Basically core caching is breaking fab providers in this current state.
@pierrejeambrun
pierrejeambrun
merged commit e2bb922
into
mainFeb 24, 2026

215 of 252 checks passed

@pierrejeambrun
pierrejeambrun
deleted the

revert-62214-fix/thread-safe-auth-manager-init

branch
February 24, 2026 12:58
@kimyoungi99kimyoungi99
mentioned this pull request
Feb 24, 2026
 Merged

@vincbeckvincbeck
mentioned this pull request
Mar 10, 2026

Closed

81 tasks
dominikhei pushed a commit
to dominikhei/airflow
that referenced
this pull request
Mar 11, 2026
@pierrejeambrun@dominikhei
Revert "Fix race condition in auth manager initialization (apache#62214…
18e1dae
…)" (apache#62404)
This reverts commit 5c9171a.
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
@pierrejeambrun@Ankurdeewan
Revert "Fix race condition in auth manager initialization (apache#62214…
dc9e611
…)" (apache#62404)
This reverts commit 5c9171a.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jason810496jason810496jason810496 approved these changes
@vincbeckvincbeckAwaiting requested review from vincbeckvincbeck is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shahar1shahar1Awaiting requested review from shahar1shahar1 is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@choo121600choo121600Awaiting requested review from choo121600choo121600 is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP APIarea:providersprovider:fabprovider:googleGoogle (including GCP) related issuesprovider:keycloak

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@pierrejeambrun@jason810496

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Revert "Fix race condition in auth manager initialization" - #62404
Merged
pierrejeambrun merged 1 commit into
mainfrom 
revert-62214-fix/thread-safe-auth-manager-init
Feb 24, 2026
Merged
Revert "Fix race condition in auth manager initialization"#62404
pierrejeambrun merged 1 commit into
mainfrom 
revert-62214-fix/thread-safe-auth-manager-init
Conversation
@pierrejeambrun
@pierrejeambrunpierrejeambrun
commented
Feb 24, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Reverts #62214
I'm having trouble starting breeze with the Fab auth manager because of this change.
I believe this is creating a problem because get_application_builder is actually also called by the fastapi fab provider routes. (generating token, login / login, create users etc...).
So every time we call the fab provider fastapi API, we clear the global fastapi APP and the _return_appbuilder.
Then calling a core api fastapi endpiont will try to re-init the APP, before the overrides are initialized.
 File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 999, in exec_module
File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/main.py", line 46, in <module>
app = cached_app(apps=os.environ.get("AIRFLOW_API_APPS", "all"))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 115, in cached_app
return create_app(apps=apps)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/utils/providers_configuration_loader.py", line 54, in wrapped_function
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 102, in create_app
init_flask_plugins(app)
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/core_api/app.py", line 145, in init_flask_plugins
flask_app = create_app(enable_plugins=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/app.py", line 96, in create_app
init_appbuilder(flask_app, enable_plugins=enable_plugins)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 599, in init_appbuilder
return AirflowAppBuilder(
^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 156, in __init__
self.init_app(app, session)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 208, in init_app
self._add_admin_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 304, in _add_admin_views
auth_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py", line 618, in register_views
self.security_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 440, in register_views
if self.auth_user_registration:
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 754, in auth_user_registration
return current_app.config["AUTH_USER_REGISTRATION"]
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'AUTH_USER_REGISTRATION'

@boring-cyborgboring-cyborgBot
added

area:API
Airflow's REST/HTTP API
area:providers

provider:fab

provider:google
Google (including GCP) related issues
provider:keycloak

labels
Feb 24, 2026
@pierrejeambrun
pierrejeambrun
commented
Feb 24, 2026

Copy link


Copy Markdown

MemberAuthor
Let me try to fix it without reverting first.
@jason810496
jason810496
commented
Feb 24, 2026

Copy link


Copy Markdown

Member
Let me try to fix it without reverting first.
Maybe #62214 (comment) was right?
@pierrejeambrun
pierrejeambrun
commented
Feb 24, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I think it's safer to revert, the change like this is not backward compatible between old fab providers version and the new one. Basically core caching is breaking fab providers in this current state.
@pierrejeambrun
pierrejeambrun
merged commit e2bb922
into
mainFeb 24, 2026

215 of 252 checks passed

@pierrejeambrun
pierrejeambrun
deleted the

revert-62214-fix/thread-safe-auth-manager-init

branch
February 24, 2026 12:58
@kimyoungi99kimyoungi99
mentioned this pull request
Feb 24, 2026
 Merged

@vincbeckvincbeck
mentioned this pull request
Mar 10, 2026

Closed

81 tasks
dominikhei pushed a commit
to dominikhei/airflow
that referenced
this pull request
Mar 11, 2026
@pierrejeambrun@dominikhei
Revert "Fix race condition in auth manager initialization (apache#62214…
18e1dae
…)" (apache#62404)
This reverts commit 5c9171a.
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
@pierrejeambrun@Ankurdeewan
Revert "Fix race condition in auth manager initialization (apache#62214…
dc9e611
…)" (apache#62404)
This reverts commit 5c9171a.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jason810496jason810496jason810496 approved these changes
@vincbeckvincbeckAwaiting requested review from vincbeckvincbeck is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shahar1shahar1Awaiting requested review from shahar1shahar1 is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@choo121600choo121600Awaiting requested review from choo121600choo121600 is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP APIarea:providersprovider:fabprovider:googleGoogle (including GCP) related issuesprovider:keycloak

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@pierrejeambrun@jason810496

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Revert "Fix race condition in auth manager initialization" - #62404
Merged
pierrejeambrun merged 1 commit into
mainfrom 
revert-62214-fix/thread-safe-auth-manager-init
Feb 24, 2026
Merged
Revert "Fix race condition in auth manager initialization"#62404
pierrejeambrun merged 1 commit into
mainfrom 
revert-62214-fix/thread-safe-auth-manager-init
Conversation
@pierrejeambrun
@pierrejeambrunpierrejeambrun
commented
Feb 24, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Reverts #62214
I'm having trouble starting breeze with the Fab auth manager because of this change.
I believe this is creating a problem because get_application_builder is actually also called by the fastapi fab provider routes. (generating token, login / login, create users etc...).
So every time we call the fab provider fastapi API, we clear the global fastapi APP and the _return_appbuilder.
Then calling a core api fastapi endpiont will try to re-init the APP, before the overrides are initialized.
 File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 999, in exec_module
File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/main.py", line 46, in <module>
app = cached_app(apps=os.environ.get("AIRFLOW_API_APPS", "all"))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 115, in cached_app
return create_app(apps=apps)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/utils/providers_configuration_loader.py", line 54, in wrapped_function
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 102, in create_app
init_flask_plugins(app)
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/core_api/app.py", line 145, in init_flask_plugins
flask_app = create_app(enable_plugins=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/app.py", line 96, in create_app
init_appbuilder(flask_app, enable_plugins=enable_plugins)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 599, in init_appbuilder
return AirflowAppBuilder(
^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 156, in __init__
self.init_app(app, session)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 208, in init_app
self._add_admin_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 304, in _add_admin_views
auth_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py", line 618, in register_views
self.security_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 440, in register_views
if self.auth_user_registration:
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 754, in auth_user_registration
return current_app.config["AUTH_USER_REGISTRATION"]
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'AUTH_USER_REGISTRATION'

@boring-cyborgboring-cyborgBot
added

area:API
Airflow's REST/HTTP API
area:providers

provider:fab

provider:google
Google (including GCP) related issues
provider:keycloak

labels
Feb 24, 2026
@pierrejeambrun
pierrejeambrun
commented
Feb 24, 2026

Copy link


Copy Markdown

MemberAuthor
Let me try to fix it without reverting first.
@jason810496
jason810496
commented
Feb 24, 2026

Copy link


Copy Markdown

Member
Let me try to fix it without reverting first.
Maybe #62214 (comment) was right?
@pierrejeambrun
pierrejeambrun
commented
Feb 24, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I think it's safer to revert, the change like this is not backward compatible between old fab providers version and the new one. Basically core caching is breaking fab providers in this current state.
@pierrejeambrun
pierrejeambrun
merged commit e2bb922
into
mainFeb 24, 2026

215 of 252 checks passed

@pierrejeambrun
pierrejeambrun
deleted the

revert-62214-fix/thread-safe-auth-manager-init

branch
February 24, 2026 12:58
@kimyoungi99kimyoungi99
mentioned this pull request
Feb 24, 2026
 Merged

@vincbeckvincbeck
mentioned this pull request
Mar 10, 2026

Closed

81 tasks
dominikhei pushed a commit
to dominikhei/airflow
that referenced
this pull request
Mar 11, 2026
@pierrejeambrun@dominikhei
Revert "Fix race condition in auth manager initialization (apache#62214…
18e1dae
…)" (apache#62404)
This reverts commit 5c9171a.
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
@pierrejeambrun@Ankurdeewan
Revert "Fix race condition in auth manager initialization (apache#62214…
dc9e611
…)" (apache#62404)
This reverts commit 5c9171a.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jason810496jason810496jason810496 approved these changes
@vincbeckvincbeckAwaiting requested review from vincbeckvincbeck is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shahar1shahar1Awaiting requested review from shahar1shahar1 is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@choo121600choo121600Awaiting requested review from choo121600choo121600 is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP APIarea:providersprovider:fabprovider:googleGoogle (including GCP) related issuesprovider:keycloak

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@pierrejeambrun@jason810496

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Revert "Fix race condition in auth manager initialization" - #62404
Merged
pierrejeambrun merged 1 commit into
mainfrom 
revert-62214-fix/thread-safe-auth-manager-init
Feb 24, 2026
Merged
Revert "Fix race condition in auth manager initialization"#62404
pierrejeambrun merged 1 commit into
mainfrom 
revert-62214-fix/thread-safe-auth-manager-init
Conversation
@pierrejeambrun
@pierrejeambrunpierrejeambrun
commented
Feb 24, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Reverts #62214
I'm having trouble starting breeze with the Fab auth manager because of this change.
I believe this is creating a problem because get_application_builder is actually also called by the fastapi fab provider routes. (generating token, login / login, create users etc...).
So every time we call the fab provider fastapi API, we clear the global fastapi APP and the _return_appbuilder.
Then calling a core api fastapi endpiont will try to re-init the APP, before the overrides are initialized.
 File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 999, in exec_module
File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/main.py", line 46, in <module>
app = cached_app(apps=os.environ.get("AIRFLOW_API_APPS", "all"))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 115, in cached_app
return create_app(apps=apps)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/utils/providers_configuration_loader.py", line 54, in wrapped_function
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 102, in create_app
init_flask_plugins(app)
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/core_api/app.py", line 145, in init_flask_plugins
flask_app = create_app(enable_plugins=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/app.py", line 96, in create_app
init_appbuilder(flask_app, enable_plugins=enable_plugins)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 599, in init_appbuilder
return AirflowAppBuilder(
^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 156, in __init__
self.init_app(app, session)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 208, in init_app
self._add_admin_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 304, in _add_admin_views
auth_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py", line 618, in register_views
self.security_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 440, in register_views
if self.auth_user_registration:
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 754, in auth_user_registration
return current_app.config["AUTH_USER_REGISTRATION"]
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'AUTH_USER_REGISTRATION'

@boring-cyborgboring-cyborgBot
added

area:API
Airflow's REST/HTTP API
area:providers

provider:fab

provider:google
Google (including GCP) related issues
provider:keycloak

labels
Feb 24, 2026
@pierrejeambrun
pierrejeambrun
commented
Feb 24, 2026

Copy link


Copy Markdown

MemberAuthor
Let me try to fix it without reverting first.
@jason810496
jason810496
commented
Feb 24, 2026

Copy link


Copy Markdown

Member
Let me try to fix it without reverting first.
Maybe #62214 (comment) was right?
@pierrejeambrun
pierrejeambrun
commented
Feb 24, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I think it's safer to revert, the change like this is not backward compatible between old fab providers version and the new one. Basically core caching is breaking fab providers in this current state.
@pierrejeambrun
pierrejeambrun
merged commit e2bb922
into
mainFeb 24, 2026

215 of 252 checks passed

@pierrejeambrun
pierrejeambrun
deleted the

revert-62214-fix/thread-safe-auth-manager-init

branch
February 24, 2026 12:58
@kimyoungi99kimyoungi99
mentioned this pull request
Feb 24, 2026
 Merged

@vincbeckvincbeck
mentioned this pull request
Mar 10, 2026

Closed

81 tasks
dominikhei pushed a commit
to dominikhei/airflow
that referenced
this pull request
Mar 11, 2026
@pierrejeambrun@dominikhei
Revert "Fix race condition in auth manager initialization (apache#62214…
18e1dae
…)" (apache#62404)
This reverts commit 5c9171a.
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
@pierrejeambrun@Ankurdeewan
Revert "Fix race condition in auth manager initialization (apache#62214…
dc9e611
…)" (apache#62404)
This reverts commit 5c9171a.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jason810496jason810496jason810496 approved these changes
@vincbeckvincbeckAwaiting requested review from vincbeckvincbeck is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shahar1shahar1Awaiting requested review from shahar1shahar1 is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@choo121600choo121600Awaiting requested review from choo121600choo121600 is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP APIarea:providersprovider:fabprovider:googleGoogle (including GCP) related issuesprovider:keycloak

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@pierrejeambrun@jason810496

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Revert "Fix race condition in auth manager initialization" - #62404
Merged
pierrejeambrun merged 1 commit into
mainfrom 
revert-62214-fix/thread-safe-auth-manager-init
Feb 24, 2026
Merged
Revert "Fix race condition in auth manager initialization"#62404
pierrejeambrun merged 1 commit into
mainfrom 
revert-62214-fix/thread-safe-auth-manager-init
Conversation
@pierrejeambrun
@pierrejeambrunpierrejeambrun
commented
Feb 24, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Reverts #62214
I'm having trouble starting breeze with the Fab auth manager because of this change.
I believe this is creating a problem because get_application_builder is actually also called by the fastapi fab provider routes. (generating token, login / login, create users etc...).
So every time we call the fab provider fastapi API, we clear the global fastapi APP and the _return_appbuilder.
Then calling a core api fastapi endpiont will try to re-init the APP, before the overrides are initialized.
 File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 999, in exec_module
File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/main.py", line 46, in <module>
app = cached_app(apps=os.environ.get("AIRFLOW_API_APPS", "all"))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 115, in cached_app
return create_app(apps=apps)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/utils/providers_configuration_loader.py", line 54, in wrapped_function
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 102, in create_app
init_flask_plugins(app)
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/core_api/app.py", line 145, in init_flask_plugins
flask_app = create_app(enable_plugins=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/app.py", line 96, in create_app
init_appbuilder(flask_app, enable_plugins=enable_plugins)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 599, in init_appbuilder
return AirflowAppBuilder(
^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 156, in __init__
self.init_app(app, session)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 208, in init_app
self._add_admin_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 304, in _add_admin_views
auth_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py", line 618, in register_views
self.security_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 440, in register_views
if self.auth_user_registration:
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 754, in auth_user_registration
return current_app.config["AUTH_USER_REGISTRATION"]
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'AUTH_USER_REGISTRATION'

@boring-cyborgboring-cyborgBot
added

area:API
Airflow's REST/HTTP API
area:providers

provider:fab

provider:google
Google (including GCP) related issues
provider:keycloak

labels
Feb 24, 2026
@pierrejeambrun
pierrejeambrun
commented
Feb 24, 2026

Copy link


Copy Markdown

MemberAuthor
Let me try to fix it without reverting first.
@jason810496
jason810496
commented
Feb 24, 2026

Copy link


Copy Markdown

Member
Let me try to fix it without reverting first.
Maybe #62214 (comment) was right?
@pierrejeambrun
pierrejeambrun
commented
Feb 24, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I think it's safer to revert, the change like this is not backward compatible between old fab providers version and the new one. Basically core caching is breaking fab providers in this current state.
@pierrejeambrun
pierrejeambrun
merged commit e2bb922
into
mainFeb 24, 2026

215 of 252 checks passed

@pierrejeambrun
pierrejeambrun
deleted the

revert-62214-fix/thread-safe-auth-manager-init

branch
February 24, 2026 12:58
@kimyoungi99kimyoungi99
mentioned this pull request
Feb 24, 2026
 Merged

@vincbeckvincbeck
mentioned this pull request
Mar 10, 2026

Closed

81 tasks
dominikhei pushed a commit
to dominikhei/airflow
that referenced
this pull request
Mar 11, 2026
@pierrejeambrun@dominikhei
Revert "Fix race condition in auth manager initialization (apache#62214…
18e1dae
…)" (apache#62404)
This reverts commit 5c9171a.
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
@pierrejeambrun@Ankurdeewan
Revert "Fix race condition in auth manager initialization (apache#62214…
dc9e611
…)" (apache#62404)
This reverts commit 5c9171a.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jason810496jason810496jason810496 approved these changes
@vincbeckvincbeckAwaiting requested review from vincbeckvincbeck is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shahar1shahar1Awaiting requested review from shahar1shahar1 is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@choo121600choo121600Awaiting requested review from choo121600choo121600 is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP APIarea:providersprovider:fabprovider:googleGoogle (including GCP) related issuesprovider:keycloak

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@pierrejeambrun@jason810496

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Revert "Fix race condition in auth manager initialization" - #62404
Merged
pierrejeambrun merged 1 commit into
mainfrom 
revert-62214-fix/thread-safe-auth-manager-init
Feb 24, 2026
Merged
Revert "Fix race condition in auth manager initialization"#62404
pierrejeambrun merged 1 commit into
mainfrom 
revert-62214-fix/thread-safe-auth-manager-init
Conversation
@pierrejeambrun
@pierrejeambrunpierrejeambrun
commented
Feb 24, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Reverts #62214
I'm having trouble starting breeze with the Fab auth manager because of this change.
I believe this is creating a problem because get_application_builder is actually also called by the fastapi fab provider routes. (generating token, login / login, create users etc...).
So every time we call the fab provider fastapi API, we clear the global fastapi APP and the _return_appbuilder.
Then calling a core api fastapi endpiont will try to re-init the APP, before the overrides are initialized.
 File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 999, in exec_module
File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/main.py", line 46, in <module>
app = cached_app(apps=os.environ.get("AIRFLOW_API_APPS", "all"))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 115, in cached_app
return create_app(apps=apps)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/utils/providers_configuration_loader.py", line 54, in wrapped_function
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 102, in create_app
init_flask_plugins(app)
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/core_api/app.py", line 145, in init_flask_plugins
flask_app = create_app(enable_plugins=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/app.py", line 96, in create_app
init_appbuilder(flask_app, enable_plugins=enable_plugins)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 599, in init_appbuilder
return AirflowAppBuilder(
^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 156, in __init__
self.init_app(app, session)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 208, in init_app
self._add_admin_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 304, in _add_admin_views
auth_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py", line 618, in register_views
self.security_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 440, in register_views
if self.auth_user_registration:
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 754, in auth_user_registration
return current_app.config["AUTH_USER_REGISTRATION"]
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'AUTH_USER_REGISTRATION'

@boring-cyborgboring-cyborgBot
added

area:API
Airflow's REST/HTTP API
area:providers

provider:fab

provider:google
Google (including GCP) related issues
provider:keycloak

labels
Feb 24, 2026
@pierrejeambrun
pierrejeambrun
commented
Feb 24, 2026

Copy link


Copy Markdown

MemberAuthor
Let me try to fix it without reverting first.
@jason810496
jason810496
commented
Feb 24, 2026

Copy link


Copy Markdown

Member
Let me try to fix it without reverting first.
Maybe #62214 (comment) was right?
@pierrejeambrun
pierrejeambrun
commented
Feb 24, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I think it's safer to revert, the change like this is not backward compatible between old fab providers version and the new one. Basically core caching is breaking fab providers in this current state.
@pierrejeambrun
pierrejeambrun
merged commit e2bb922
into
mainFeb 24, 2026

215 of 252 checks passed

@pierrejeambrun
pierrejeambrun
deleted the

revert-62214-fix/thread-safe-auth-manager-init

branch
February 24, 2026 12:58
@kimyoungi99kimyoungi99
mentioned this pull request
Feb 24, 2026
 Merged

@vincbeckvincbeck
mentioned this pull request
Mar 10, 2026

Closed

81 tasks
dominikhei pushed a commit
to dominikhei/airflow
that referenced
this pull request
Mar 11, 2026
@pierrejeambrun@dominikhei
Revert "Fix race condition in auth manager initialization (apache#62214…
18e1dae
…)" (apache#62404)
This reverts commit 5c9171a.
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
@pierrejeambrun@Ankurdeewan
Revert "Fix race condition in auth manager initialization (apache#62214…
dc9e611
…)" (apache#62404)
This reverts commit 5c9171a.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jason810496jason810496jason810496 approved these changes
@vincbeckvincbeckAwaiting requested review from vincbeckvincbeck is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shahar1shahar1Awaiting requested review from shahar1shahar1 is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@choo121600choo121600Awaiting requested review from choo121600choo121600 is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP APIarea:providersprovider:fabprovider:googleGoogle (including GCP) related issuesprovider:keycloak

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@pierrejeambrun@jason810496

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Revert "Fix race condition in auth manager initialization" - #62404
Merged
pierrejeambrun merged 1 commit into
mainfrom 
revert-62214-fix/thread-safe-auth-manager-init
Feb 24, 2026
Merged
Revert "Fix race condition in auth manager initialization"#62404
pierrejeambrun merged 1 commit into
mainfrom 
revert-62214-fix/thread-safe-auth-manager-init
Conversation
@pierrejeambrun
@pierrejeambrunpierrejeambrun
commented
Feb 24, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Reverts #62214
I'm having trouble starting breeze with the Fab auth manager because of this change.
I believe this is creating a problem because get_application_builder is actually also called by the fastapi fab provider routes. (generating token, login / login, create users etc...).
So every time we call the fab provider fastapi API, we clear the global fastapi APP and the _return_appbuilder.
Then calling a core api fastapi endpiont will try to re-init the APP, before the overrides are initialized.
 File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 999, in exec_module
File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/main.py", line 46, in <module>
app = cached_app(apps=os.environ.get("AIRFLOW_API_APPS", "all"))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 115, in cached_app
return create_app(apps=apps)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/utils/providers_configuration_loader.py", line 54, in wrapped_function
return func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/app.py", line 102, in create_app
init_flask_plugins(app)
File "/opt/airflow/airflow-core/src/airflow/api_fastapi/core_api/app.py", line 145, in init_flask_plugins
flask_app = create_app(enable_plugins=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/app.py", line 96, in create_app
init_appbuilder(flask_app, enable_plugins=enable_plugins)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 599, in init_appbuilder
return AirflowAppBuilder(
^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 156, in __init__
self.init_app(app, session)
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 208, in init_app
self._add_admin_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/www/extensions/init_appbuilder.py", line 304, in _add_admin_views
auth_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py", line 618, in register_views
self.security_manager.register_views()
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 440, in register_views
if self.auth_user_registration:
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/airflow/providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py", line 754, in auth_user_registration
return current_app.config["AUTH_USER_REGISTRATION"]
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'AUTH_USER_REGISTRATION'

@boring-cyborgboring-cyborgBot
added

area:API
Airflow's REST/HTTP API
area:providers

provider:fab

provider:google
Google (including GCP) related issues
provider:keycloak

labels
Feb 24, 2026
@pierrejeambrun
pierrejeambrun
commented
Feb 24, 2026

Copy link


Copy Markdown

MemberAuthor
Let me try to fix it without reverting first.
@jason810496
jason810496
commented
Feb 24, 2026

Copy link


Copy Markdown

Member
Let me try to fix it without reverting first.
Maybe #62214 (comment) was right?
@pierrejeambrun
pierrejeambrun
commented
Feb 24, 2026•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
I think it's safer to revert, the change like this is not backward compatible between old fab providers version and the new one. Basically core caching is breaking fab providers in this current state.
@pierrejeambrun
pierrejeambrun
merged commit e2bb922
into
mainFeb 24, 2026

215 of 252 checks passed

@pierrejeambrun
pierrejeambrun
deleted the

revert-62214-fix/thread-safe-auth-manager-init

branch
February 24, 2026 12:58
@kimyoungi99kimyoungi99
mentioned this pull request
Feb 24, 2026
 Merged

@vincbeckvincbeck
mentioned this pull request
Mar 10, 2026

Closed

81 tasks
dominikhei pushed a commit
to dominikhei/airflow
that referenced
this pull request
Mar 11, 2026
@pierrejeambrun@dominikhei
Revert "Fix race condition in auth manager initialization (apache#62214…
18e1dae
…)" (apache#62404)
This reverts commit 5c9171a.
Ankurdeewan pushed a commit
to Ankurdeewan/airflow
that referenced
this pull request
Mar 15, 2026
@pierrejeambrun@Ankurdeewan
Revert "Fix race condition in auth manager initialization (apache#62214…
dc9e611
…)" (apache#62404)
This reverts commit 5c9171a.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jason810496jason810496jason810496 approved these changes
@vincbeckvincbeckAwaiting requested review from vincbeckvincbeck is a code owner
@bugraoz93bugraoz93Awaiting requested review from bugraoz93bugraoz93 is a code owner
@shahar1shahar1Awaiting requested review from shahar1shahar1 is a code owner
@ephraimbuddyephraimbuddyAwaiting requested review from ephraimbuddyephraimbuddy is a code owner
@rawwarrawwarAwaiting requested review from rawwarrawwar is a code owner
@shubhamraj-gitshubhamraj-gitAwaiting requested review from shubhamraj-gitshubhamraj-git is a code owner
@choo121600choo121600Awaiting requested review from choo121600choo121600 is a code owner

Assignees


No one assigned


Labels

area:APIAirflow's REST/HTTP APIarea:providersprovider:fabprovider:googleGoogle (including GCP) related issuesprovider:keycloak

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@pierrejeambrun@jason810496