Skip to content

Make the gunicorn API server respect GUNICORN_CMD_ARGS again - #62522

Merged
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again
Feb 26, 2026
Merged

Make the gunicorn API server respect GUNICORN_CMD_ARGS again#62522
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again

Conversation

@ashb

@ashbashb commented Feb 26, 2026

Copy link
Copy Markdown
Member

Since our new Arbiter and custom code added in #60940 doesn't invoke Gunicorn via the full CLI path of normal gunicorn, we have to manually call this.

This lets us give control to users to accept any and all gunicorn args without us having to put them in our CLI, or keep up to date with changes. This env var is something stock gunicorn already respects too.

Tested with AIRFLOW__API__SERVER_TYPE=gunicorn GUNICORN_CMD_ARGS="--max-requests 2" airflow api-server

And then after two requests we see this:

[2026-02-26 14:25:30 +0000] [91022] [INFO] Maximum request limit of 2 exceeded. Terminating process.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Shutting down
[2026-02-26 14:25:30 +0000] [91022] [INFO] Waiting for application shutdown.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Application shutdown complete.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Finished server process [91022]
[2026-02-26 14:25:30 +0000] [91022] [INFO] Worker exiting (pid: 91022)
[2026-02-26 14:25:31 +0000] [91026] [INFO] Booting worker with pid: 91026
[2026-02-26 14:25:31 +0000] [91026] [INFO] Started server process [91026]
[2026-02-26 14:25:31 +0000] [91026] [INFO] Waiting for application startup.
[2026-02-26 14:25:31 +0000] [91026] [INFO] Application startup complete.

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Comment threadairflow-core/tests/unit/cli/commands/test_gunicorn_monitor.py Outdated

@kaxilkaxil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores support for the GUNICORN_CMD_ARGS environment variable in the Airflow API server when using gunicorn. This functionality was broken after the introduction of a custom Arbiter in PR #60940, which bypassed gunicorn's normal CLI parsing. The fix manually invokes gunicorn's environment variable parsing API to respect user-provided gunicorn arguments.

Changes:

  • Modified load_config() to parse and apply GUNICORN_CMD_ARGS environment variable settings
  • Added comprehensive test coverage for the new functionality including precedence rules
  • Ensured environment variables override programmatic options (consistent with standard behavior)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/api_fastapi/gunicorn_app.pyAdded code to parse GUNICORN_CMD_ARGS and apply settings to gunicorn config
airflow-core/tests/unit/cli/commands/test_gunicorn_monitor.pyAdded three tests verifying config loading, GUNICORN_CMD_ARGS support, and precedence rules

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
@ashb
ashbforce-pushed the apiserver-respect-gunicorn-cmd-args-again branch from cd0921e to 5c5175bCompareFebruary 26, 2026 15:33
@ashb
ashb merged commit 67a86d5 into apache:mainFeb 26, 2026
129 checks passed
@ashb
ashb deleted the apiserver-respect-gunicorn-cmd-args-again branch February 26, 2026 17:26
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 67a86d5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@github-actionsgithub-actionsBot added this to the Airflow 3.1.8 milestone Feb 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.1.8 based on: backport label targeting v3-1-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

AkshayArali pushed a commit to AkshayArali/airflow_630 that referenced this pull request Feb 28, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ashb@kaxil@jedcunningham
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Make the gunicorn API server respect GUNICORN_CMD_ARGS again by ashb · Pull Request #62522 · apache/airflow · GitHub
Skip to content

Make the gunicorn API server respect GUNICORN_CMD_ARGS again - #62522

Merged
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again
Feb 26, 2026
Merged

Make the gunicorn API server respect GUNICORN_CMD_ARGS again#62522
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again

Conversation

@ashb

@ashbashb commented Feb 26, 2026

Copy link
Copy Markdown
Member

Since our new Arbiter and custom code added in #60940 doesn't invoke Gunicorn via the full CLI path of normal gunicorn, we have to manually call this.

This lets us give control to users to accept any and all gunicorn args without us having to put them in our CLI, or keep up to date with changes. This env var is something stock gunicorn already respects too.

Tested with AIRFLOW__API__SERVER_TYPE=gunicorn GUNICORN_CMD_ARGS="--max-requests 2" airflow api-server

And then after two requests we see this:

[2026-02-26 14:25:30 +0000] [91022] [INFO] Maximum request limit of 2 exceeded. Terminating process.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Shutting down
[2026-02-26 14:25:30 +0000] [91022] [INFO] Waiting for application shutdown.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Application shutdown complete.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Finished server process [91022]
[2026-02-26 14:25:30 +0000] [91022] [INFO] Worker exiting (pid: 91022)
[2026-02-26 14:25:31 +0000] [91026] [INFO] Booting worker with pid: 91026
[2026-02-26 14:25:31 +0000] [91026] [INFO] Started server process [91026]
[2026-02-26 14:25:31 +0000] [91026] [INFO] Waiting for application startup.
[2026-02-26 14:25:31 +0000] [91026] [INFO] Application startup complete.

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Comment threadairflow-core/tests/unit/cli/commands/test_gunicorn_monitor.py Outdated

@kaxilkaxil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores support for the GUNICORN_CMD_ARGS environment variable in the Airflow API server when using gunicorn. This functionality was broken after the introduction of a custom Arbiter in PR #60940, which bypassed gunicorn's normal CLI parsing. The fix manually invokes gunicorn's environment variable parsing API to respect user-provided gunicorn arguments.

Changes:

  • Modified load_config() to parse and apply GUNICORN_CMD_ARGS environment variable settings
  • Added comprehensive test coverage for the new functionality including precedence rules
  • Ensured environment variables override programmatic options (consistent with standard behavior)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/api_fastapi/gunicorn_app.pyAdded code to parse GUNICORN_CMD_ARGS and apply settings to gunicorn config
airflow-core/tests/unit/cli/commands/test_gunicorn_monitor.pyAdded three tests verifying config loading, GUNICORN_CMD_ARGS support, and precedence rules

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
@ashb
ashbforce-pushed the apiserver-respect-gunicorn-cmd-args-again branch from cd0921e to 5c5175bCompareFebruary 26, 2026 15:33
@ashb
ashb merged commit 67a86d5 into apache:mainFeb 26, 2026
129 checks passed
@ashb
ashb deleted the apiserver-respect-gunicorn-cmd-args-again branch February 26, 2026 17:26
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 67a86d5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@github-actionsgithub-actionsBot added this to the Airflow 3.1.8 milestone Feb 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.1.8 based on: backport label targeting v3-1-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

AkshayArali pushed a commit to AkshayArali/airflow_630 that referenced this pull request Feb 28, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ashb@kaxil@jedcunningham
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Make the gunicorn API server respect GUNICORN_CMD_ARGS again by ashb · Pull Request #62522 · apache/airflow · GitHub
Skip to content

Make the gunicorn API server respect GUNICORN_CMD_ARGS again - #62522

Merged
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again
Feb 26, 2026
Merged

Make the gunicorn API server respect GUNICORN_CMD_ARGS again#62522
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again

Conversation

@ashb

@ashbashb commented Feb 26, 2026

Copy link
Copy Markdown
Member

Since our new Arbiter and custom code added in #60940 doesn't invoke Gunicorn via the full CLI path of normal gunicorn, we have to manually call this.

This lets us give control to users to accept any and all gunicorn args without us having to put them in our CLI, or keep up to date with changes. This env var is something stock gunicorn already respects too.

Tested with AIRFLOW__API__SERVER_TYPE=gunicorn GUNICORN_CMD_ARGS="--max-requests 2" airflow api-server

And then after two requests we see this:

[2026-02-26 14:25:30 +0000] [91022] [INFO] Maximum request limit of 2 exceeded. Terminating process.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Shutting down
[2026-02-26 14:25:30 +0000] [91022] [INFO] Waiting for application shutdown.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Application shutdown complete.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Finished server process [91022]
[2026-02-26 14:25:30 +0000] [91022] [INFO] Worker exiting (pid: 91022)
[2026-02-26 14:25:31 +0000] [91026] [INFO] Booting worker with pid: 91026
[2026-02-26 14:25:31 +0000] [91026] [INFO] Started server process [91026]
[2026-02-26 14:25:31 +0000] [91026] [INFO] Waiting for application startup.
[2026-02-26 14:25:31 +0000] [91026] [INFO] Application startup complete.

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Comment threadairflow-core/tests/unit/cli/commands/test_gunicorn_monitor.py Outdated

@kaxilkaxil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores support for the GUNICORN_CMD_ARGS environment variable in the Airflow API server when using gunicorn. This functionality was broken after the introduction of a custom Arbiter in PR #60940, which bypassed gunicorn's normal CLI parsing. The fix manually invokes gunicorn's environment variable parsing API to respect user-provided gunicorn arguments.

Changes:

  • Modified load_config() to parse and apply GUNICORN_CMD_ARGS environment variable settings
  • Added comprehensive test coverage for the new functionality including precedence rules
  • Ensured environment variables override programmatic options (consistent with standard behavior)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/api_fastapi/gunicorn_app.pyAdded code to parse GUNICORN_CMD_ARGS and apply settings to gunicorn config
airflow-core/tests/unit/cli/commands/test_gunicorn_monitor.pyAdded three tests verifying config loading, GUNICORN_CMD_ARGS support, and precedence rules

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
@ashb
ashbforce-pushed the apiserver-respect-gunicorn-cmd-args-again branch from cd0921e to 5c5175bCompareFebruary 26, 2026 15:33
@ashb
ashb merged commit 67a86d5 into apache:mainFeb 26, 2026
129 checks passed
@ashb
ashb deleted the apiserver-respect-gunicorn-cmd-args-again branch February 26, 2026 17:26
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 67a86d5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@github-actionsgithub-actionsBot added this to the Airflow 3.1.8 milestone Feb 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.1.8 based on: backport label targeting v3-1-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

AkshayArali pushed a commit to AkshayArali/airflow_630 that referenced this pull request Feb 28, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ashb@kaxil@jedcunningham
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Make the gunicorn API server respect GUNICORN_CMD_ARGS again by ashb · Pull Request #62522 · apache/airflow · GitHub
Skip to content

Make the gunicorn API server respect GUNICORN_CMD_ARGS again - #62522

Merged
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again
Feb 26, 2026
Merged

Make the gunicorn API server respect GUNICORN_CMD_ARGS again#62522
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again

Conversation

@ashb

@ashbashb commented Feb 26, 2026

Copy link
Copy Markdown
Member

Since our new Arbiter and custom code added in #60940 doesn't invoke Gunicorn via the full CLI path of normal gunicorn, we have to manually call this.

This lets us give control to users to accept any and all gunicorn args without us having to put them in our CLI, or keep up to date with changes. This env var is something stock gunicorn already respects too.

Tested with AIRFLOW__API__SERVER_TYPE=gunicorn GUNICORN_CMD_ARGS="--max-requests 2" airflow api-server

And then after two requests we see this:

[2026-02-26 14:25:30 +0000] [91022] [INFO] Maximum request limit of 2 exceeded. Terminating process.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Shutting down
[2026-02-26 14:25:30 +0000] [91022] [INFO] Waiting for application shutdown.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Application shutdown complete.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Finished server process [91022]
[2026-02-26 14:25:30 +0000] [91022] [INFO] Worker exiting (pid: 91022)
[2026-02-26 14:25:31 +0000] [91026] [INFO] Booting worker with pid: 91026
[2026-02-26 14:25:31 +0000] [91026] [INFO] Started server process [91026]
[2026-02-26 14:25:31 +0000] [91026] [INFO] Waiting for application startup.
[2026-02-26 14:25:31 +0000] [91026] [INFO] Application startup complete.

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Comment threadairflow-core/tests/unit/cli/commands/test_gunicorn_monitor.py Outdated

@kaxilkaxil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores support for the GUNICORN_CMD_ARGS environment variable in the Airflow API server when using gunicorn. This functionality was broken after the introduction of a custom Arbiter in PR #60940, which bypassed gunicorn's normal CLI parsing. The fix manually invokes gunicorn's environment variable parsing API to respect user-provided gunicorn arguments.

Changes:

  • Modified load_config() to parse and apply GUNICORN_CMD_ARGS environment variable settings
  • Added comprehensive test coverage for the new functionality including precedence rules
  • Ensured environment variables override programmatic options (consistent with standard behavior)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/api_fastapi/gunicorn_app.pyAdded code to parse GUNICORN_CMD_ARGS and apply settings to gunicorn config
airflow-core/tests/unit/cli/commands/test_gunicorn_monitor.pyAdded three tests verifying config loading, GUNICORN_CMD_ARGS support, and precedence rules

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
@ashb
ashbforce-pushed the apiserver-respect-gunicorn-cmd-args-again branch from cd0921e to 5c5175bCompareFebruary 26, 2026 15:33
@ashb
ashb merged commit 67a86d5 into apache:mainFeb 26, 2026
129 checks passed
@ashb
ashb deleted the apiserver-respect-gunicorn-cmd-args-again branch February 26, 2026 17:26
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 67a86d5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@github-actionsgithub-actionsBot added this to the Airflow 3.1.8 milestone Feb 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.1.8 based on: backport label targeting v3-1-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

AkshayArali pushed a commit to AkshayArali/airflow_630 that referenced this pull request Feb 28, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ashb@kaxil@jedcunningham
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Make the gunicorn API server respect GUNICORN_CMD_ARGS again by ashb · Pull Request #62522 · apache/airflow · GitHub
Skip to content

Make the gunicorn API server respect GUNICORN_CMD_ARGS again - #62522

Merged
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again
Feb 26, 2026
Merged

Make the gunicorn API server respect GUNICORN_CMD_ARGS again#62522
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again

Conversation

@ashb

@ashbashb commented Feb 26, 2026

Copy link
Copy Markdown
Member

Since our new Arbiter and custom code added in #60940 doesn't invoke Gunicorn via the full CLI path of normal gunicorn, we have to manually call this.

This lets us give control to users to accept any and all gunicorn args without us having to put them in our CLI, or keep up to date with changes. This env var is something stock gunicorn already respects too.

Tested with AIRFLOW__API__SERVER_TYPE=gunicorn GUNICORN_CMD_ARGS="--max-requests 2" airflow api-server

And then after two requests we see this:

[2026-02-26 14:25:30 +0000] [91022] [INFO] Maximum request limit of 2 exceeded. Terminating process.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Shutting down
[2026-02-26 14:25:30 +0000] [91022] [INFO] Waiting for application shutdown.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Application shutdown complete.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Finished server process [91022]
[2026-02-26 14:25:30 +0000] [91022] [INFO] Worker exiting (pid: 91022)
[2026-02-26 14:25:31 +0000] [91026] [INFO] Booting worker with pid: 91026
[2026-02-26 14:25:31 +0000] [91026] [INFO] Started server process [91026]
[2026-02-26 14:25:31 +0000] [91026] [INFO] Waiting for application startup.
[2026-02-26 14:25:31 +0000] [91026] [INFO] Application startup complete.

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Comment threadairflow-core/tests/unit/cli/commands/test_gunicorn_monitor.py Outdated

@kaxilkaxil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores support for the GUNICORN_CMD_ARGS environment variable in the Airflow API server when using gunicorn. This functionality was broken after the introduction of a custom Arbiter in PR #60940, which bypassed gunicorn's normal CLI parsing. The fix manually invokes gunicorn's environment variable parsing API to respect user-provided gunicorn arguments.

Changes:

  • Modified load_config() to parse and apply GUNICORN_CMD_ARGS environment variable settings
  • Added comprehensive test coverage for the new functionality including precedence rules
  • Ensured environment variables override programmatic options (consistent with standard behavior)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/api_fastapi/gunicorn_app.pyAdded code to parse GUNICORN_CMD_ARGS and apply settings to gunicorn config
airflow-core/tests/unit/cli/commands/test_gunicorn_monitor.pyAdded three tests verifying config loading, GUNICORN_CMD_ARGS support, and precedence rules

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
@ashb
ashbforce-pushed the apiserver-respect-gunicorn-cmd-args-again branch from cd0921e to 5c5175bCompareFebruary 26, 2026 15:33
@ashb
ashb merged commit 67a86d5 into apache:mainFeb 26, 2026
129 checks passed
@ashb
ashb deleted the apiserver-respect-gunicorn-cmd-args-again branch February 26, 2026 17:26
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 67a86d5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@github-actionsgithub-actionsBot added this to the Airflow 3.1.8 milestone Feb 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.1.8 based on: backport label targeting v3-1-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

AkshayArali pushed a commit to AkshayArali/airflow_630 that referenced this pull request Feb 28, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ashb@kaxil@jedcunningham
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Make the gunicorn API server respect GUNICORN_CMD_ARGS again by ashb · Pull Request #62522 · apache/airflow · GitHub
Skip to content

Make the gunicorn API server respect GUNICORN_CMD_ARGS again - #62522

Merged
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again
Feb 26, 2026
Merged

Make the gunicorn API server respect GUNICORN_CMD_ARGS again#62522
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again

Conversation

@ashb

@ashbashb commented Feb 26, 2026

Copy link
Copy Markdown
Member

Since our new Arbiter and custom code added in #60940 doesn't invoke Gunicorn via the full CLI path of normal gunicorn, we have to manually call this.

This lets us give control to users to accept any and all gunicorn args without us having to put them in our CLI, or keep up to date with changes. This env var is something stock gunicorn already respects too.

Tested with AIRFLOW__API__SERVER_TYPE=gunicorn GUNICORN_CMD_ARGS="--max-requests 2" airflow api-server

And then after two requests we see this:

[2026-02-26 14:25:30 +0000] [91022] [INFO] Maximum request limit of 2 exceeded. Terminating process.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Shutting down
[2026-02-26 14:25:30 +0000] [91022] [INFO] Waiting for application shutdown.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Application shutdown complete.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Finished server process [91022]
[2026-02-26 14:25:30 +0000] [91022] [INFO] Worker exiting (pid: 91022)
[2026-02-26 14:25:31 +0000] [91026] [INFO] Booting worker with pid: 91026
[2026-02-26 14:25:31 +0000] [91026] [INFO] Started server process [91026]
[2026-02-26 14:25:31 +0000] [91026] [INFO] Waiting for application startup.
[2026-02-26 14:25:31 +0000] [91026] [INFO] Application startup complete.

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Comment threadairflow-core/tests/unit/cli/commands/test_gunicorn_monitor.py Outdated

@kaxilkaxil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores support for the GUNICORN_CMD_ARGS environment variable in the Airflow API server when using gunicorn. This functionality was broken after the introduction of a custom Arbiter in PR #60940, which bypassed gunicorn's normal CLI parsing. The fix manually invokes gunicorn's environment variable parsing API to respect user-provided gunicorn arguments.

Changes:

  • Modified load_config() to parse and apply GUNICORN_CMD_ARGS environment variable settings
  • Added comprehensive test coverage for the new functionality including precedence rules
  • Ensured environment variables override programmatic options (consistent with standard behavior)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/api_fastapi/gunicorn_app.pyAdded code to parse GUNICORN_CMD_ARGS and apply settings to gunicorn config
airflow-core/tests/unit/cli/commands/test_gunicorn_monitor.pyAdded three tests verifying config loading, GUNICORN_CMD_ARGS support, and precedence rules

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
@ashb
ashbforce-pushed the apiserver-respect-gunicorn-cmd-args-again branch from cd0921e to 5c5175bCompareFebruary 26, 2026 15:33
@ashb
ashb merged commit 67a86d5 into apache:mainFeb 26, 2026
129 checks passed
@ashb
ashb deleted the apiserver-respect-gunicorn-cmd-args-again branch February 26, 2026 17:26
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 67a86d5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@github-actionsgithub-actionsBot added this to the Airflow 3.1.8 milestone Feb 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.1.8 based on: backport label targeting v3-1-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

AkshayArali pushed a commit to AkshayArali/airflow_630 that referenced this pull request Feb 28, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ashb@kaxil@jedcunningham
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Make the gunicorn API server respect GUNICORN_CMD_ARGS again by ashb · Pull Request #62522 · apache/airflow · GitHub
Skip to content

Make the gunicorn API server respect GUNICORN_CMD_ARGS again - #62522

Merged
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again
Feb 26, 2026
Merged

Make the gunicorn API server respect GUNICORN_CMD_ARGS again#62522
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again

Conversation

@ashb

@ashbashb commented Feb 26, 2026

Copy link
Copy Markdown
Member

Since our new Arbiter and custom code added in #60940 doesn't invoke Gunicorn via the full CLI path of normal gunicorn, we have to manually call this.

This lets us give control to users to accept any and all gunicorn args without us having to put them in our CLI, or keep up to date with changes. This env var is something stock gunicorn already respects too.

Tested with AIRFLOW__API__SERVER_TYPE=gunicorn GUNICORN_CMD_ARGS="--max-requests 2" airflow api-server

And then after two requests we see this:

[2026-02-26 14:25:30 +0000] [91022] [INFO] Maximum request limit of 2 exceeded. Terminating process.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Shutting down
[2026-02-26 14:25:30 +0000] [91022] [INFO] Waiting for application shutdown.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Application shutdown complete.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Finished server process [91022]
[2026-02-26 14:25:30 +0000] [91022] [INFO] Worker exiting (pid: 91022)
[2026-02-26 14:25:31 +0000] [91026] [INFO] Booting worker with pid: 91026
[2026-02-26 14:25:31 +0000] [91026] [INFO] Started server process [91026]
[2026-02-26 14:25:31 +0000] [91026] [INFO] Waiting for application startup.
[2026-02-26 14:25:31 +0000] [91026] [INFO] Application startup complete.

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Comment threadairflow-core/tests/unit/cli/commands/test_gunicorn_monitor.py Outdated

@kaxilkaxil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores support for the GUNICORN_CMD_ARGS environment variable in the Airflow API server when using gunicorn. This functionality was broken after the introduction of a custom Arbiter in PR #60940, which bypassed gunicorn's normal CLI parsing. The fix manually invokes gunicorn's environment variable parsing API to respect user-provided gunicorn arguments.

Changes:

  • Modified load_config() to parse and apply GUNICORN_CMD_ARGS environment variable settings
  • Added comprehensive test coverage for the new functionality including precedence rules
  • Ensured environment variables override programmatic options (consistent with standard behavior)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/api_fastapi/gunicorn_app.pyAdded code to parse GUNICORN_CMD_ARGS and apply settings to gunicorn config
airflow-core/tests/unit/cli/commands/test_gunicorn_monitor.pyAdded three tests verifying config loading, GUNICORN_CMD_ARGS support, and precedence rules

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
@ashb
ashbforce-pushed the apiserver-respect-gunicorn-cmd-args-again branch from cd0921e to 5c5175bCompareFebruary 26, 2026 15:33
@ashb
ashb merged commit 67a86d5 into apache:mainFeb 26, 2026
129 checks passed
@ashb
ashb deleted the apiserver-respect-gunicorn-cmd-args-again branch February 26, 2026 17:26
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 67a86d5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@github-actionsgithub-actionsBot added this to the Airflow 3.1.8 milestone Feb 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.1.8 based on: backport label targeting v3-1-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

AkshayArali pushed a commit to AkshayArali/airflow_630 that referenced this pull request Feb 28, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ashb@kaxil@jedcunningham
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Make the gunicorn API server respect GUNICORN_CMD_ARGS again by ashb · Pull Request #62522 · apache/airflow · GitHub
Skip to content

Make the gunicorn API server respect GUNICORN_CMD_ARGS again - #62522

Merged
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again
Feb 26, 2026
Merged

Make the gunicorn API server respect GUNICORN_CMD_ARGS again#62522
ashb merged 1 commit into
apache:mainfrom
astronomer:apiserver-respect-gunicorn-cmd-args-again

Conversation

@ashb

@ashbashb commented Feb 26, 2026

Copy link
Copy Markdown
Member

Since our new Arbiter and custom code added in #60940 doesn't invoke Gunicorn via the full CLI path of normal gunicorn, we have to manually call this.

This lets us give control to users to accept any and all gunicorn args without us having to put them in our CLI, or keep up to date with changes. This env var is something stock gunicorn already respects too.

Tested with AIRFLOW__API__SERVER_TYPE=gunicorn GUNICORN_CMD_ARGS="--max-requests 2" airflow api-server

And then after two requests we see this:

[2026-02-26 14:25:30 +0000] [91022] [INFO] Maximum request limit of 2 exceeded. Terminating process.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Shutting down
[2026-02-26 14:25:30 +0000] [91022] [INFO] Waiting for application shutdown.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Application shutdown complete.
[2026-02-26 14:25:30 +0000] [91022] [INFO] Finished server process [91022]
[2026-02-26 14:25:30 +0000] [91022] [INFO] Worker exiting (pid: 91022)
[2026-02-26 14:25:31 +0000] [91026] [INFO] Booting worker with pid: 91026
[2026-02-26 14:25:31 +0000] [91026] [INFO] Started server process [91026]
[2026-02-26 14:25:31 +0000] [91026] [INFO] Waiting for application startup.
[2026-02-26 14:25:31 +0000] [91026] [INFO] Application startup complete.

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Comment threadairflow-core/tests/unit/cli/commands/test_gunicorn_monitor.py Outdated

@kaxilkaxil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores support for the GUNICORN_CMD_ARGS environment variable in the Airflow API server when using gunicorn. This functionality was broken after the introduction of a custom Arbiter in PR #60940, which bypassed gunicorn's normal CLI parsing. The fix manually invokes gunicorn's environment variable parsing API to respect user-provided gunicorn arguments.

Changes:

  • Modified load_config() to parse and apply GUNICORN_CMD_ARGS environment variable settings
  • Added comprehensive test coverage for the new functionality including precedence rules
  • Ensured environment variables override programmatic options (consistent with standard behavior)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/api_fastapi/gunicorn_app.pyAdded code to parse GUNICORN_CMD_ARGS and apply settings to gunicorn config
airflow-core/tests/unit/cli/commands/test_gunicorn_monitor.pyAdded three tests verifying config loading, GUNICORN_CMD_ARGS support, and precedence rules

Comment threadairflow-core/src/airflow/api_fastapi/gunicorn_app.py
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
@ashb
ashbforce-pushed the apiserver-respect-gunicorn-cmd-args-again branch from cd0921e to 5c5175bCompareFebruary 26, 2026 15:33
@ashb
ashb merged commit 67a86d5 into apache:mainFeb 26, 2026
129 checks passed
@ashb
ashb deleted the apiserver-respect-gunicorn-cmd-args-again branch February 26, 2026 17:26
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-1-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 67a86d5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@github-actionsgithub-actionsBot added this to the Airflow 3.1.8 milestone Feb 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.1.8 based on: backport label targeting v3-1-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

AkshayArali pushed a commit to AkshayArali/airflow_630 that referenced this pull request Feb 28, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
…62522)
Since our new Arbiter and custom code doesn't invoke Gunicorn via the full CLI
path of normal gunicorn, we have to manually call this.
This lets us give control to users to accept any and all gunicorn args without
us having to put them in our CLI, or keep up to date with changes. This env
var is something stock `gunicorn` already respects too.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ashb@kaxil@jedcunningham