Uh oh!
There was an error while loading. Please reload this page.
Fix mypy error for ObjectStoragePath._from_upath classmethod_or_method typing - #62855
Closed
jason810496 wants to merge 4 commits into
Closed
Fix mypy error for ObjectStoragePath._from_upath classmethod_or_method typing#62855jason810496 wants to merge 4 commits into
jason810496 wants to merge 4 commits into
Conversation
jason810496force-pushed
the
task-sdk/follow-up-for-obj-store-path-mypy-fix
branch
2 times, most recently
from
March 5, 2026 02:32
a5ac5a7 to
34e52e7Comparejason810496
marked this pull request as ready for review
March 5, 2026 02:33
| super().__init__(*args, protocol=protocol, **storage_options) | ||
| @classmethod_or_method # type: ignore[arg-type] | ||
| @_classmethod_or_method |
Contributor
There was a problem hiding this comment.
This seems pretty unconventional and hard to read for little benefit. If we want to go down this route, I suggest we keep runtime import at top level
1 task
jason810496
marked this pull request as draft
March 11, 2026 08:17
jason810496force-pushed
the
task-sdk/follow-up-for-obj-store-path-mypy-fix
branch
from
March 12, 2026 02:39
04c4fec to
037778fCompareInitial plan
…hod_or_method to classmethod under TYPE_CHECKING Co-authored-by: jason810496 <68415893+jason810496@users.noreply.github.com>
Keep the runtime import at top level instead of behind an if/else TYPE_CHECKING block, which is more conventional and easier to read. The TYPE_CHECKING override still aliases _classmethod_or_method to classmethod for mypy. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Jason(Zhe-You) Liu <jason810496@users.noreply.github.com>
jason810496force-pushed
the
task-sdk/follow-up-for-obj-store-path-mypy-fix
branch
from
March 12, 2026 03:22
037778f to
f7919abCompareContributor
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #62701 (comment)
Why
Follow-up Mypy fix for
ObjectStoragePath._from_upath'sclassmethod_or_methoddecorator typing.