Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions airflow-core/src/airflow/utils/log/file_task_handler.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -895,9 +895,27 @@ def _read_from_logs_server(
"See more at https://airflow.apache.org/docs/apache-airflow/"
"stable/configurations-ref.html#secret-key"
)
elif response.status_code == 404:
# Log file not found on the worker's log server.
# This typically happens when a task retried on a different worker
# and the original worker's logs are no longer accessible.
# Fall back to local filesystem read if available.
worker_log_full_path = Path(self.local_base, worker_log_rel_path)
fallback_sources, fallback_streams = self._read_from_local(worker_log_full_path)
if fallback_sources:
sources.extend(fallback_sources)
log_streams.extend(fallback_streams)
else:
sources.append(
f"Log file not found on worker '{ti.hostname}'. "
f"This attempt may have run on a different worker whose logs "
f"are no longer accessible. "
f"Consider configuring remote logging (S3, GCS, etc.) for log persistence."
)
else:
# Check if the resource was properly fetched
response.raise_for_status()

if int(response.headers.get("Content-Length", 0)) > 0:
sources.append(url)
log_streams.append(
Expand Down
92 changes: 92 additions & 0 deletions airflow-core/tests/unit/utils/log/test_file_task_handler.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import annotations

from pathlib import Path
from unittest.mock import MagicMock, patch

from airflow.utils.log.file_task_handler import FileTaskHandler


class TestFileTaskHandlerLogServer:
"""Tests for _read_from_logs_server 404 handling."""

def setup_method(self):
self.handler = FileTaskHandler(base_log_folder="/tmp/test_logs")

self.ti = MagicMock()
self.ti.hostname = "worker-1"
self.ti.triggerer_job = None
self.ti.task = None

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_falls_back_to_local_when_available(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and local logs exist, use local logs."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_stream = MagicMock()
mock_read_local.return_value = (["/tmp/test_logs/dag/run/task/1.log"], [mock_stream])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert sources == ["/tmp/test_logs/dag/run/task/1.log"]
assert streams == [mock_stream]
mock_read_local.assert_called_once_with(Path("/tmp/test_logs", "dag/run/task/1.log"))

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_shows_clear_message_when_no_local_fallback(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and no local logs exist, show helpful message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_read_local.return_value = ([], [])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "worker-1" in sources[0]
assert "no longer accessible" in sources[0]
assert "remote logging" in sources[0]
assert streams == []

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
def test_403_shows_secret_key_message(self, mock_get_url, mock_fetch):
"""When log server returns 403, show secret key configuration message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 403
mock_fetch.return_value = mock_response

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "secret_key" in sources[0]
assert streams == []
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions airflow-core/src/airflow/utils/log/file_task_handler.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -895,9 +895,27 @@ def _read_from_logs_server(
"See more at https://airflow.apache.org/docs/apache-airflow/"
"stable/configurations-ref.html#secret-key"
)
elif response.status_code == 404:
# Log file not found on the worker's log server.
# This typically happens when a task retried on a different worker
# and the original worker's logs are no longer accessible.
# Fall back to local filesystem read if available.
worker_log_full_path = Path(self.local_base, worker_log_rel_path)
fallback_sources, fallback_streams = self._read_from_local(worker_log_full_path)
if fallback_sources:
sources.extend(fallback_sources)
log_streams.extend(fallback_streams)
else:
sources.append(
f"Log file not found on worker '{ti.hostname}'. "
f"This attempt may have run on a different worker whose logs "
f"are no longer accessible. "
f"Consider configuring remote logging (S3, GCS, etc.) for log persistence."
)
else:
# Check if the resource was properly fetched
response.raise_for_status()

if int(response.headers.get("Content-Length", 0)) > 0:
sources.append(url)
log_streams.append(
Expand Down
92 changes: 92 additions & 0 deletions airflow-core/tests/unit/utils/log/test_file_task_handler.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import annotations

from pathlib import Path
from unittest.mock import MagicMock, patch

from airflow.utils.log.file_task_handler import FileTaskHandler


class TestFileTaskHandlerLogServer:
"""Tests for _read_from_logs_server 404 handling."""

def setup_method(self):
self.handler = FileTaskHandler(base_log_folder="/tmp/test_logs")

self.ti = MagicMock()
self.ti.hostname = "worker-1"
self.ti.triggerer_job = None
self.ti.task = None

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_falls_back_to_local_when_available(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and local logs exist, use local logs."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_stream = MagicMock()
mock_read_local.return_value = (["/tmp/test_logs/dag/run/task/1.log"], [mock_stream])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert sources == ["/tmp/test_logs/dag/run/task/1.log"]
assert streams == [mock_stream]
mock_read_local.assert_called_once_with(Path("/tmp/test_logs", "dag/run/task/1.log"))

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_shows_clear_message_when_no_local_fallback(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and no local logs exist, show helpful message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_read_local.return_value = ([], [])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "worker-1" in sources[0]
assert "no longer accessible" in sources[0]
assert "remote logging" in sources[0]
assert streams == []

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
def test_403_shows_secret_key_message(self, mock_get_url, mock_fetch):
"""When log server returns 403, show secret key configuration message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 403
mock_fetch.return_value = mock_response

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "secret_key" in sources[0]
assert streams == []
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions airflow-core/src/airflow/utils/log/file_task_handler.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -895,9 +895,27 @@ def _read_from_logs_server(
"See more at https://airflow.apache.org/docs/apache-airflow/"
"stable/configurations-ref.html#secret-key"
)
elif response.status_code == 404:
# Log file not found on the worker's log server.
# This typically happens when a task retried on a different worker
# and the original worker's logs are no longer accessible.
# Fall back to local filesystem read if available.
worker_log_full_path = Path(self.local_base, worker_log_rel_path)
fallback_sources, fallback_streams = self._read_from_local(worker_log_full_path)
if fallback_sources:
sources.extend(fallback_sources)
log_streams.extend(fallback_streams)
else:
sources.append(
f"Log file not found on worker '{ti.hostname}'. "
f"This attempt may have run on a different worker whose logs "
f"are no longer accessible. "
f"Consider configuring remote logging (S3, GCS, etc.) for log persistence."
)
else:
# Check if the resource was properly fetched
response.raise_for_status()

if int(response.headers.get("Content-Length", 0)) > 0:
sources.append(url)
log_streams.append(
Expand Down
92 changes: 92 additions & 0 deletions airflow-core/tests/unit/utils/log/test_file_task_handler.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import annotations

from pathlib import Path
from unittest.mock import MagicMock, patch

from airflow.utils.log.file_task_handler import FileTaskHandler


class TestFileTaskHandlerLogServer:
"""Tests for _read_from_logs_server 404 handling."""

def setup_method(self):
self.handler = FileTaskHandler(base_log_folder="/tmp/test_logs")

self.ti = MagicMock()
self.ti.hostname = "worker-1"
self.ti.triggerer_job = None
self.ti.task = None

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_falls_back_to_local_when_available(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and local logs exist, use local logs."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_stream = MagicMock()
mock_read_local.return_value = (["/tmp/test_logs/dag/run/task/1.log"], [mock_stream])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert sources == ["/tmp/test_logs/dag/run/task/1.log"]
assert streams == [mock_stream]
mock_read_local.assert_called_once_with(Path("/tmp/test_logs", "dag/run/task/1.log"))

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_shows_clear_message_when_no_local_fallback(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and no local logs exist, show helpful message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_read_local.return_value = ([], [])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "worker-1" in sources[0]
assert "no longer accessible" in sources[0]
assert "remote logging" in sources[0]
assert streams == []

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
def test_403_shows_secret_key_message(self, mock_get_url, mock_fetch):
"""When log server returns 403, show secret key configuration message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 403
mock_fetch.return_value = mock_response

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "secret_key" in sources[0]
assert streams == []
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions airflow-core/src/airflow/utils/log/file_task_handler.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -895,9 +895,27 @@ def _read_from_logs_server(
"See more at https://airflow.apache.org/docs/apache-airflow/"
"stable/configurations-ref.html#secret-key"
)
elif response.status_code == 404:
# Log file not found on the worker's log server.
# This typically happens when a task retried on a different worker
# and the original worker's logs are no longer accessible.
# Fall back to local filesystem read if available.
worker_log_full_path = Path(self.local_base, worker_log_rel_path)
fallback_sources, fallback_streams = self._read_from_local(worker_log_full_path)
if fallback_sources:
sources.extend(fallback_sources)
log_streams.extend(fallback_streams)
else:
sources.append(
f"Log file not found on worker '{ti.hostname}'. "
f"This attempt may have run on a different worker whose logs "
f"are no longer accessible. "
f"Consider configuring remote logging (S3, GCS, etc.) for log persistence."
)
else:
# Check if the resource was properly fetched
response.raise_for_status()

if int(response.headers.get("Content-Length", 0)) > 0:
sources.append(url)
log_streams.append(
Expand Down
92 changes: 92 additions & 0 deletions airflow-core/tests/unit/utils/log/test_file_task_handler.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import annotations

from pathlib import Path
from unittest.mock import MagicMock, patch

from airflow.utils.log.file_task_handler import FileTaskHandler


class TestFileTaskHandlerLogServer:
"""Tests for _read_from_logs_server 404 handling."""

def setup_method(self):
self.handler = FileTaskHandler(base_log_folder="/tmp/test_logs")

self.ti = MagicMock()
self.ti.hostname = "worker-1"
self.ti.triggerer_job = None
self.ti.task = None

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_falls_back_to_local_when_available(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and local logs exist, use local logs."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_stream = MagicMock()
mock_read_local.return_value = (["/tmp/test_logs/dag/run/task/1.log"], [mock_stream])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert sources == ["/tmp/test_logs/dag/run/task/1.log"]
assert streams == [mock_stream]
mock_read_local.assert_called_once_with(Path("/tmp/test_logs", "dag/run/task/1.log"))

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_shows_clear_message_when_no_local_fallback(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and no local logs exist, show helpful message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_read_local.return_value = ([], [])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "worker-1" in sources[0]
assert "no longer accessible" in sources[0]
assert "remote logging" in sources[0]
assert streams == []

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
def test_403_shows_secret_key_message(self, mock_get_url, mock_fetch):
"""When log server returns 403, show secret key configuration message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 403
mock_fetch.return_value = mock_response

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "secret_key" in sources[0]
assert streams == []
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions airflow-core/src/airflow/utils/log/file_task_handler.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -895,9 +895,27 @@ def _read_from_logs_server(
"See more at https://airflow.apache.org/docs/apache-airflow/"
"stable/configurations-ref.html#secret-key"
)
elif response.status_code == 404:
# Log file not found on the worker's log server.
# This typically happens when a task retried on a different worker
# and the original worker's logs are no longer accessible.
# Fall back to local filesystem read if available.
worker_log_full_path = Path(self.local_base, worker_log_rel_path)
fallback_sources, fallback_streams = self._read_from_local(worker_log_full_path)
if fallback_sources:
sources.extend(fallback_sources)
log_streams.extend(fallback_streams)
else:
sources.append(
f"Log file not found on worker '{ti.hostname}'. "
f"This attempt may have run on a different worker whose logs "
f"are no longer accessible. "
f"Consider configuring remote logging (S3, GCS, etc.) for log persistence."
)
else:
# Check if the resource was properly fetched
response.raise_for_status()

if int(response.headers.get("Content-Length", 0)) > 0:
sources.append(url)
log_streams.append(
Expand Down
92 changes: 92 additions & 0 deletions airflow-core/tests/unit/utils/log/test_file_task_handler.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import annotations

from pathlib import Path
from unittest.mock import MagicMock, patch

from airflow.utils.log.file_task_handler import FileTaskHandler


class TestFileTaskHandlerLogServer:
"""Tests for _read_from_logs_server 404 handling."""

def setup_method(self):
self.handler = FileTaskHandler(base_log_folder="/tmp/test_logs")

self.ti = MagicMock()
self.ti.hostname = "worker-1"
self.ti.triggerer_job = None
self.ti.task = None

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_falls_back_to_local_when_available(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and local logs exist, use local logs."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_stream = MagicMock()
mock_read_local.return_value = (["/tmp/test_logs/dag/run/task/1.log"], [mock_stream])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert sources == ["/tmp/test_logs/dag/run/task/1.log"]
assert streams == [mock_stream]
mock_read_local.assert_called_once_with(Path("/tmp/test_logs", "dag/run/task/1.log"))

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_shows_clear_message_when_no_local_fallback(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and no local logs exist, show helpful message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_read_local.return_value = ([], [])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "worker-1" in sources[0]
assert "no longer accessible" in sources[0]
assert "remote logging" in sources[0]
assert streams == []

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
def test_403_shows_secret_key_message(self, mock_get_url, mock_fetch):
"""When log server returns 403, show secret key configuration message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 403
mock_fetch.return_value = mock_response

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "secret_key" in sources[0]
assert streams == []
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions airflow-core/src/airflow/utils/log/file_task_handler.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -895,9 +895,27 @@ def _read_from_logs_server(
"See more at https://airflow.apache.org/docs/apache-airflow/"
"stable/configurations-ref.html#secret-key"
)
elif response.status_code == 404:
# Log file not found on the worker's log server.
# This typically happens when a task retried on a different worker
# and the original worker's logs are no longer accessible.
# Fall back to local filesystem read if available.
worker_log_full_path = Path(self.local_base, worker_log_rel_path)
fallback_sources, fallback_streams = self._read_from_local(worker_log_full_path)
if fallback_sources:
sources.extend(fallback_sources)
log_streams.extend(fallback_streams)
else:
sources.append(
f"Log file not found on worker '{ti.hostname}'. "
f"This attempt may have run on a different worker whose logs "
f"are no longer accessible. "
f"Consider configuring remote logging (S3, GCS, etc.) for log persistence."
)
else:
# Check if the resource was properly fetched
response.raise_for_status()

if int(response.headers.get("Content-Length", 0)) > 0:
sources.append(url)
log_streams.append(
Expand Down
92 changes: 92 additions & 0 deletions airflow-core/tests/unit/utils/log/test_file_task_handler.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import annotations

from pathlib import Path
from unittest.mock import MagicMock, patch

from airflow.utils.log.file_task_handler import FileTaskHandler


class TestFileTaskHandlerLogServer:
"""Tests for _read_from_logs_server 404 handling."""

def setup_method(self):
self.handler = FileTaskHandler(base_log_folder="/tmp/test_logs")

self.ti = MagicMock()
self.ti.hostname = "worker-1"
self.ti.triggerer_job = None
self.ti.task = None

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_falls_back_to_local_when_available(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and local logs exist, use local logs."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_stream = MagicMock()
mock_read_local.return_value = (["/tmp/test_logs/dag/run/task/1.log"], [mock_stream])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert sources == ["/tmp/test_logs/dag/run/task/1.log"]
assert streams == [mock_stream]
mock_read_local.assert_called_once_with(Path("/tmp/test_logs", "dag/run/task/1.log"))

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_shows_clear_message_when_no_local_fallback(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and no local logs exist, show helpful message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_read_local.return_value = ([], [])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "worker-1" in sources[0]
assert "no longer accessible" in sources[0]
assert "remote logging" in sources[0]
assert streams == []

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
def test_403_shows_secret_key_message(self, mock_get_url, mock_fetch):
"""When log server returns 403, show secret key configuration message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 403
mock_fetch.return_value = mock_response

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "secret_key" in sources[0]
assert streams == []
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions airflow-core/src/airflow/utils/log/file_task_handler.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -895,9 +895,27 @@ def _read_from_logs_server(
"See more at https://airflow.apache.org/docs/apache-airflow/"
"stable/configurations-ref.html#secret-key"
)
elif response.status_code == 404:
# Log file not found on the worker's log server.
# This typically happens when a task retried on a different worker
# and the original worker's logs are no longer accessible.
# Fall back to local filesystem read if available.
worker_log_full_path = Path(self.local_base, worker_log_rel_path)
fallback_sources, fallback_streams = self._read_from_local(worker_log_full_path)
if fallback_sources:
sources.extend(fallback_sources)
log_streams.extend(fallback_streams)
else:
sources.append(
f"Log file not found on worker '{ti.hostname}'. "
f"This attempt may have run on a different worker whose logs "
f"are no longer accessible. "
f"Consider configuring remote logging (S3, GCS, etc.) for log persistence."
)
else:
# Check if the resource was properly fetched
response.raise_for_status()

if int(response.headers.get("Content-Length", 0)) > 0:
sources.append(url)
log_streams.append(
Expand Down
92 changes: 92 additions & 0 deletions airflow-core/tests/unit/utils/log/test_file_task_handler.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import annotations

from pathlib import Path
from unittest.mock import MagicMock, patch

from airflow.utils.log.file_task_handler import FileTaskHandler


class TestFileTaskHandlerLogServer:
"""Tests for _read_from_logs_server 404 handling."""

def setup_method(self):
self.handler = FileTaskHandler(base_log_folder="/tmp/test_logs")

self.ti = MagicMock()
self.ti.hostname = "worker-1"
self.ti.triggerer_job = None
self.ti.task = None

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_falls_back_to_local_when_available(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and local logs exist, use local logs."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_stream = MagicMock()
mock_read_local.return_value = (["/tmp/test_logs/dag/run/task/1.log"], [mock_stream])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert sources == ["/tmp/test_logs/dag/run/task/1.log"]
assert streams == [mock_stream]
mock_read_local.assert_called_once_with(Path("/tmp/test_logs", "dag/run/task/1.log"))

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_shows_clear_message_when_no_local_fallback(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and no local logs exist, show helpful message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_read_local.return_value = ([], [])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "worker-1" in sources[0]
assert "no longer accessible" in sources[0]
assert "remote logging" in sources[0]
assert streams == []

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
def test_403_shows_secret_key_message(self, mock_get_url, mock_fetch):
"""When log server returns 403, show secret key configuration message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 403
mock_fetch.return_value = mock_response

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "secret_key" in sources[0]
assert streams == []
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions airflow-core/src/airflow/utils/log/file_task_handler.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -895,9 +895,27 @@ def _read_from_logs_server(
"See more at https://airflow.apache.org/docs/apache-airflow/"
"stable/configurations-ref.html#secret-key"
)
elif response.status_code == 404:
# Log file not found on the worker's log server.
# This typically happens when a task retried on a different worker
# and the original worker's logs are no longer accessible.
# Fall back to local filesystem read if available.
worker_log_full_path = Path(self.local_base, worker_log_rel_path)
fallback_sources, fallback_streams = self._read_from_local(worker_log_full_path)
if fallback_sources:
sources.extend(fallback_sources)
log_streams.extend(fallback_streams)
else:
sources.append(
f"Log file not found on worker '{ti.hostname}'. "
f"This attempt may have run on a different worker whose logs "
f"are no longer accessible. "
f"Consider configuring remote logging (S3, GCS, etc.) for log persistence."
)
else:
# Check if the resource was properly fetched
response.raise_for_status()

if int(response.headers.get("Content-Length", 0)) > 0:
sources.append(url)
log_streams.append(
Expand Down
92 changes: 92 additions & 0 deletions airflow-core/tests/unit/utils/log/test_file_task_handler.py
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,92 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import annotations

from pathlib import Path
from unittest.mock import MagicMock, patch

from airflow.utils.log.file_task_handler import FileTaskHandler


class TestFileTaskHandlerLogServer:
"""Tests for _read_from_logs_server 404 handling."""

def setup_method(self):
self.handler = FileTaskHandler(base_log_folder="/tmp/test_logs")

self.ti = MagicMock()
self.ti.hostname = "worker-1"
self.ti.triggerer_job = None
self.ti.task = None

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_falls_back_to_local_when_available(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and local logs exist, use local logs."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_stream = MagicMock()
mock_read_local.return_value = (["/tmp/test_logs/dag/run/task/1.log"], [mock_stream])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert sources == ["/tmp/test_logs/dag/run/task/1.log"]
assert streams == [mock_stream]
mock_read_local.assert_called_once_with(Path("/tmp/test_logs", "dag/run/task/1.log"))

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
@patch.object(FileTaskHandler, "_read_from_local")
def test_404_shows_clear_message_when_no_local_fallback(self, mock_read_local, mock_get_url, mock_fetch):
"""When log server returns 404 and no local logs exist, show helpful message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 404
mock_fetch.return_value = mock_response

mock_read_local.return_value = ([], [])

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "worker-1" in sources[0]
assert "no longer accessible" in sources[0]
assert "remote logging" in sources[0]
assert streams == []

@patch("airflow.utils.log.file_task_handler._fetch_logs_from_service")
@patch.object(FileTaskHandler, "_get_log_retrieval_url")
def test_403_shows_secret_key_message(self, mock_get_url, mock_fetch):
"""When log server returns 403, show secret key configuration message."""
mock_get_url.return_value = ("http://worker-1/log", "dag/run/task/1.log")

mock_response = MagicMock()
mock_response.status_code = 403
mock_fetch.return_value = mock_response

sources, streams = self.handler._read_from_logs_server(self.ti, "dag/run/task/1.log")

assert len(sources) == 1
assert "secret_key" in sources[0]
assert streams == []