Add log buffering to increase performance when streaming big logs - #63180

Merged
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly
Mar 30, 2026
Merged

Add log buffering to increase performance when streaming big logs#63180
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly

Conversation

@dsuhinin

@dsuhinindsuhinin commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

The current streaming approach does not seem to effectively solve the problem of handling large logs. This PR adds buffering to improve performance when processing them. Previously, loading 320k entries took around 50–60 seconds; with buffering, it now takes about 5 seconds. This change does not break existing functionality and slightly improves overall performance. I've tested next cases:

  • logs with the delay. just around 20 logs per several minutes. Scrolling works well.
  • 320k logs without delay. Buffering and scrolling also works well.
  • initial load for 320K logs also works pretty well and fast. Around 4-6 seconds which I believe is pretty good. Check screenshot.
Screenshot 2026-03-24 at 22 11 13

@boring-cyborgboring-cyborgBot added the area:API Airflow's REST/HTTP API label Mar 9, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

@potiuk

potiuk commented Mar 11, 2026

Copy link
Copy Markdown
Member

@dsuhinin This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • Failing CI checks: CI checks are failing (individual check names not available). Run prek run --from-ref main locally to reproduce. See static checks docs and testing docs.

Note: Your branch is 102 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the Airflow Slack.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@potiuk
potiuk marked this pull request as draft March 11, 2026 00:09

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for Jason idea.

@pierrejeambrunpierrejeambrun mentioned this pull request Mar 12, 2026
@dsuhinindsuhinin changed the title Fix the issue related to big logsAdd log buffering to increase performance when streaming big logsMar 24, 2026
@connorlwilkes

Copy link
Copy Markdown

Testing a similar change internally we have seen a very large performance increase for loading of logs on the front end when viewing logs for a task instance.

I think the front end should really either just use the normal non streaming endpoint or parse the streaming endpoint as a streaming endpoint. My understanding is that it polls the streaming endpoint and gets all the logs every call

@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

hey! I did few tests and it seems like all good. UI just pooling in that case and overall functionality works just fine.

@dsuhinin
dsuhinin marked this pull request as ready for review March 24, 2026 21:17
@dsuhinin

dsuhinin commented Mar 26, 2026

Copy link
Copy Markdown
ContributorAuthor

CI need fixing. I also tested a bunch of scenarios and things were working as expected. Even the case mentioned by Jason

from what I can see I can try to fix only -> https://github.com/apache/airflow/actions/runs/23599259101/job/68727372004?pr=63180

everything else just failing by some reason fully randomly. one update before it were 2 failed steps, now more - 5.

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else just failing by some reason fully randomly. one update before it were 2 failed step, now 5.

It seems like regression of the following integration tests, the other PR also suffer from the same failure.

providers/elasticsearch/tests/integration/elasticsearch/log/test_es_remote_log_io.py::TestElasticsearchRemoteLogIOIntegration

I will look into it if it haven't been resolved.
UPDATE: The ElasticSearch e2e tests had been resolved in #64276, I just rebased this one on top of it.

@jason810496
jason810496force-pushed the dsuhinin/1223-logs-are-loading-very-slowly branch from 461eabb to 934076eCompareMarch 27, 2026 04:24

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge on my end, the UI e2e tests already been failed for a while on main IIRC.

@connorlwilkes

Copy link
Copy Markdown

Is it possible to have the buffer size configurable?

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the issue is tagged for the 3.2 release but I don't know the exact time that we have for getting it merged.

Because people have different use-cases, it would be helpful if the buffer size was configurable. We have found that the performance improvement increases along side the buffer size and the log size. But people with small number of logs won't need a huge buffer size.

Also, a unit test would be helpful to understand how it's supposed to work without having to deep dive into the code like I did.

If time is pressing, we can address the above in a followup PR.

…ery-slowly' into dsuhinin/1223-logs-are-loading-very-slowly
# Conflicts:
#	airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py
@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

Is it possible to have the buffer size configurable?

of course. thew new variable has been added to configure the buffer size.

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the config property. LGTM!

@pierrejeambrunpierrejeambrun added this to the Airflow 3.2.0 milestone Mar 30, 2026
@pierrejeambrun
pierrejeambrun merged commit 63ba163 into apache:mainMar 30, 2026
148 checks passed
github-actionsBot pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Mar 30, 2026
…big logs (apache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Mar 30, 2026
…3180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180) (#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
…ache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
xBis7 pushed a commit to xBis7/airflow that referenced this pull request Apr 21, 2026
…big logs (apache#63180) (apache#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@bbovenzibbovenzi mentioned this pull request Aug 6, 2026
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@dsuhinin@potiuk@connorlwilkes@pierrejeambrun@jason810496@xBis7@bbovenzi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Add log buffering to increase performance when streaming big logs - #63180

Merged
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly
Mar 30, 2026
Merged

Add log buffering to increase performance when streaming big logs#63180
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly

Conversation

@dsuhinin

@dsuhinindsuhinin commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

The current streaming approach does not seem to effectively solve the problem of handling large logs. This PR adds buffering to improve performance when processing them. Previously, loading 320k entries took around 50–60 seconds; with buffering, it now takes about 5 seconds. This change does not break existing functionality and slightly improves overall performance. I've tested next cases:

  • logs with the delay. just around 20 logs per several minutes. Scrolling works well.
  • 320k logs without delay. Buffering and scrolling also works well.
  • initial load for 320K logs also works pretty well and fast. Around 4-6 seconds which I believe is pretty good. Check screenshot.
Screenshot 2026-03-24 at 22 11 13

@boring-cyborgboring-cyborgBot added the area:API Airflow's REST/HTTP API label Mar 9, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

@potiuk

potiuk commented Mar 11, 2026

Copy link
Copy Markdown
Member

@dsuhinin This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • Failing CI checks: CI checks are failing (individual check names not available). Run prek run --from-ref main locally to reproduce. See static checks docs and testing docs.

Note: Your branch is 102 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the Airflow Slack.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@potiuk
potiuk marked this pull request as draft March 11, 2026 00:09

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for Jason idea.

@pierrejeambrunpierrejeambrun mentioned this pull request Mar 12, 2026
@dsuhinindsuhinin changed the title Fix the issue related to big logsAdd log buffering to increase performance when streaming big logsMar 24, 2026
@connorlwilkes

Copy link
Copy Markdown

Testing a similar change internally we have seen a very large performance increase for loading of logs on the front end when viewing logs for a task instance.

I think the front end should really either just use the normal non streaming endpoint or parse the streaming endpoint as a streaming endpoint. My understanding is that it polls the streaming endpoint and gets all the logs every call

@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

hey! I did few tests and it seems like all good. UI just pooling in that case and overall functionality works just fine.

@dsuhinin
dsuhinin marked this pull request as ready for review March 24, 2026 21:17
@dsuhinin

dsuhinin commented Mar 26, 2026

Copy link
Copy Markdown
ContributorAuthor

CI need fixing. I also tested a bunch of scenarios and things were working as expected. Even the case mentioned by Jason

from what I can see I can try to fix only -> https://github.com/apache/airflow/actions/runs/23599259101/job/68727372004?pr=63180

everything else just failing by some reason fully randomly. one update before it were 2 failed steps, now more - 5.

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else just failing by some reason fully randomly. one update before it were 2 failed step, now 5.

It seems like regression of the following integration tests, the other PR also suffer from the same failure.

providers/elasticsearch/tests/integration/elasticsearch/log/test_es_remote_log_io.py::TestElasticsearchRemoteLogIOIntegration

I will look into it if it haven't been resolved.
UPDATE: The ElasticSearch e2e tests had been resolved in #64276, I just rebased this one on top of it.

@jason810496
jason810496force-pushed the dsuhinin/1223-logs-are-loading-very-slowly branch from 461eabb to 934076eCompareMarch 27, 2026 04:24

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge on my end, the UI e2e tests already been failed for a while on main IIRC.

@connorlwilkes

Copy link
Copy Markdown

Is it possible to have the buffer size configurable?

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the issue is tagged for the 3.2 release but I don't know the exact time that we have for getting it merged.

Because people have different use-cases, it would be helpful if the buffer size was configurable. We have found that the performance improvement increases along side the buffer size and the log size. But people with small number of logs won't need a huge buffer size.

Also, a unit test would be helpful to understand how it's supposed to work without having to deep dive into the code like I did.

If time is pressing, we can address the above in a followup PR.

…ery-slowly' into dsuhinin/1223-logs-are-loading-very-slowly
# Conflicts:
#	airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py
@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

Is it possible to have the buffer size configurable?

of course. thew new variable has been added to configure the buffer size.

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the config property. LGTM!

@pierrejeambrunpierrejeambrun added this to the Airflow 3.2.0 milestone Mar 30, 2026
@pierrejeambrun
pierrejeambrun merged commit 63ba163 into apache:mainMar 30, 2026
148 checks passed
github-actionsBot pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Mar 30, 2026
…big logs (apache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Mar 30, 2026
…3180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180) (#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
…ache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
xBis7 pushed a commit to xBis7/airflow that referenced this pull request Apr 21, 2026
…big logs (apache#63180) (apache#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@bbovenzibbovenzi mentioned this pull request Aug 6, 2026
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@dsuhinin@potiuk@connorlwilkes@pierrejeambrun@jason810496@xBis7@bbovenzi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add log buffering to increase performance when streaming big logs - #63180

Merged
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly
Mar 30, 2026
Merged

Add log buffering to increase performance when streaming big logs#63180
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly

Conversation

@dsuhinin

@dsuhinindsuhinin commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

The current streaming approach does not seem to effectively solve the problem of handling large logs. This PR adds buffering to improve performance when processing them. Previously, loading 320k entries took around 50–60 seconds; with buffering, it now takes about 5 seconds. This change does not break existing functionality and slightly improves overall performance. I've tested next cases:

  • logs with the delay. just around 20 logs per several minutes. Scrolling works well.
  • 320k logs without delay. Buffering and scrolling also works well.
  • initial load for 320K logs also works pretty well and fast. Around 4-6 seconds which I believe is pretty good. Check screenshot.
Screenshot 2026-03-24 at 22 11 13

@boring-cyborgboring-cyborgBot added the area:API Airflow's REST/HTTP API label Mar 9, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

@potiuk

potiuk commented Mar 11, 2026

Copy link
Copy Markdown
Member

@dsuhinin This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • Failing CI checks: CI checks are failing (individual check names not available). Run prek run --from-ref main locally to reproduce. See static checks docs and testing docs.

Note: Your branch is 102 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the Airflow Slack.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@potiuk
potiuk marked this pull request as draft March 11, 2026 00:09

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for Jason idea.

@pierrejeambrunpierrejeambrun mentioned this pull request Mar 12, 2026
@dsuhinindsuhinin changed the title Fix the issue related to big logsAdd log buffering to increase performance when streaming big logsMar 24, 2026
@connorlwilkes

Copy link
Copy Markdown

Testing a similar change internally we have seen a very large performance increase for loading of logs on the front end when viewing logs for a task instance.

I think the front end should really either just use the normal non streaming endpoint or parse the streaming endpoint as a streaming endpoint. My understanding is that it polls the streaming endpoint and gets all the logs every call

@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

hey! I did few tests and it seems like all good. UI just pooling in that case and overall functionality works just fine.

@dsuhinin
dsuhinin marked this pull request as ready for review March 24, 2026 21:17
@dsuhinin

dsuhinin commented Mar 26, 2026

Copy link
Copy Markdown
ContributorAuthor

CI need fixing. I also tested a bunch of scenarios and things were working as expected. Even the case mentioned by Jason

from what I can see I can try to fix only -> https://github.com/apache/airflow/actions/runs/23599259101/job/68727372004?pr=63180

everything else just failing by some reason fully randomly. one update before it were 2 failed steps, now more - 5.

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else just failing by some reason fully randomly. one update before it were 2 failed step, now 5.

It seems like regression of the following integration tests, the other PR also suffer from the same failure.

providers/elasticsearch/tests/integration/elasticsearch/log/test_es_remote_log_io.py::TestElasticsearchRemoteLogIOIntegration

I will look into it if it haven't been resolved.
UPDATE: The ElasticSearch e2e tests had been resolved in #64276, I just rebased this one on top of it.

@jason810496
jason810496force-pushed the dsuhinin/1223-logs-are-loading-very-slowly branch from 461eabb to 934076eCompareMarch 27, 2026 04:24

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge on my end, the UI e2e tests already been failed for a while on main IIRC.

@connorlwilkes

Copy link
Copy Markdown

Is it possible to have the buffer size configurable?

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the issue is tagged for the 3.2 release but I don't know the exact time that we have for getting it merged.

Because people have different use-cases, it would be helpful if the buffer size was configurable. We have found that the performance improvement increases along side the buffer size and the log size. But people with small number of logs won't need a huge buffer size.

Also, a unit test would be helpful to understand how it's supposed to work without having to deep dive into the code like I did.

If time is pressing, we can address the above in a followup PR.

…ery-slowly' into dsuhinin/1223-logs-are-loading-very-slowly
# Conflicts:
#	airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py
@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

Is it possible to have the buffer size configurable?

of course. thew new variable has been added to configure the buffer size.

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the config property. LGTM!

@pierrejeambrunpierrejeambrun added this to the Airflow 3.2.0 milestone Mar 30, 2026
@pierrejeambrun
pierrejeambrun merged commit 63ba163 into apache:mainMar 30, 2026
148 checks passed
github-actionsBot pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Mar 30, 2026
…big logs (apache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Mar 30, 2026
…3180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180) (#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
…ache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
xBis7 pushed a commit to xBis7/airflow that referenced this pull request Apr 21, 2026
…big logs (apache#63180) (apache#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@bbovenzibbovenzi mentioned this pull request Aug 6, 2026
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@dsuhinin@potiuk@connorlwilkes@pierrejeambrun@jason810496@xBis7@bbovenzi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add log buffering to increase performance when streaming big logs - #63180

Merged
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly
Mar 30, 2026
Merged

Add log buffering to increase performance when streaming big logs#63180
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly

Conversation

@dsuhinin

@dsuhinindsuhinin commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

The current streaming approach does not seem to effectively solve the problem of handling large logs. This PR adds buffering to improve performance when processing them. Previously, loading 320k entries took around 50–60 seconds; with buffering, it now takes about 5 seconds. This change does not break existing functionality and slightly improves overall performance. I've tested next cases:

  • logs with the delay. just around 20 logs per several minutes. Scrolling works well.
  • 320k logs without delay. Buffering and scrolling also works well.
  • initial load for 320K logs also works pretty well and fast. Around 4-6 seconds which I believe is pretty good. Check screenshot.
Screenshot 2026-03-24 at 22 11 13

@boring-cyborgboring-cyborgBot added the area:API Airflow's REST/HTTP API label Mar 9, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

@potiuk

potiuk commented Mar 11, 2026

Copy link
Copy Markdown
Member

@dsuhinin This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • Failing CI checks: CI checks are failing (individual check names not available). Run prek run --from-ref main locally to reproduce. See static checks docs and testing docs.

Note: Your branch is 102 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the Airflow Slack.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@potiuk
potiuk marked this pull request as draft March 11, 2026 00:09

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for Jason idea.

@pierrejeambrunpierrejeambrun mentioned this pull request Mar 12, 2026
@dsuhinindsuhinin changed the title Fix the issue related to big logsAdd log buffering to increase performance when streaming big logsMar 24, 2026
@connorlwilkes

Copy link
Copy Markdown

Testing a similar change internally we have seen a very large performance increase for loading of logs on the front end when viewing logs for a task instance.

I think the front end should really either just use the normal non streaming endpoint or parse the streaming endpoint as a streaming endpoint. My understanding is that it polls the streaming endpoint and gets all the logs every call

@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

hey! I did few tests and it seems like all good. UI just pooling in that case and overall functionality works just fine.

@dsuhinin
dsuhinin marked this pull request as ready for review March 24, 2026 21:17
@dsuhinin

dsuhinin commented Mar 26, 2026

Copy link
Copy Markdown
ContributorAuthor

CI need fixing. I also tested a bunch of scenarios and things were working as expected. Even the case mentioned by Jason

from what I can see I can try to fix only -> https://github.com/apache/airflow/actions/runs/23599259101/job/68727372004?pr=63180

everything else just failing by some reason fully randomly. one update before it were 2 failed steps, now more - 5.

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else just failing by some reason fully randomly. one update before it were 2 failed step, now 5.

It seems like regression of the following integration tests, the other PR also suffer from the same failure.

providers/elasticsearch/tests/integration/elasticsearch/log/test_es_remote_log_io.py::TestElasticsearchRemoteLogIOIntegration

I will look into it if it haven't been resolved.
UPDATE: The ElasticSearch e2e tests had been resolved in #64276, I just rebased this one on top of it.

@jason810496
jason810496force-pushed the dsuhinin/1223-logs-are-loading-very-slowly branch from 461eabb to 934076eCompareMarch 27, 2026 04:24

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge on my end, the UI e2e tests already been failed for a while on main IIRC.

@connorlwilkes

Copy link
Copy Markdown

Is it possible to have the buffer size configurable?

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the issue is tagged for the 3.2 release but I don't know the exact time that we have for getting it merged.

Because people have different use-cases, it would be helpful if the buffer size was configurable. We have found that the performance improvement increases along side the buffer size and the log size. But people with small number of logs won't need a huge buffer size.

Also, a unit test would be helpful to understand how it's supposed to work without having to deep dive into the code like I did.

If time is pressing, we can address the above in a followup PR.

…ery-slowly' into dsuhinin/1223-logs-are-loading-very-slowly
# Conflicts:
#	airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py
@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

Is it possible to have the buffer size configurable?

of course. thew new variable has been added to configure the buffer size.

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the config property. LGTM!

@pierrejeambrunpierrejeambrun added this to the Airflow 3.2.0 milestone Mar 30, 2026
@pierrejeambrun
pierrejeambrun merged commit 63ba163 into apache:mainMar 30, 2026
148 checks passed
github-actionsBot pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Mar 30, 2026
…big logs (apache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Mar 30, 2026
…3180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180) (#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
…ache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
xBis7 pushed a commit to xBis7/airflow that referenced this pull request Apr 21, 2026
…big logs (apache#63180) (apache#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@bbovenzibbovenzi mentioned this pull request Aug 6, 2026
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@dsuhinin@potiuk@connorlwilkes@pierrejeambrun@jason810496@xBis7@bbovenzi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Add log buffering to increase performance when streaming big logs - #63180

Merged
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly
Mar 30, 2026
Merged

Add log buffering to increase performance when streaming big logs#63180
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly

Conversation

@dsuhinin

@dsuhinindsuhinin commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

The current streaming approach does not seem to effectively solve the problem of handling large logs. This PR adds buffering to improve performance when processing them. Previously, loading 320k entries took around 50–60 seconds; with buffering, it now takes about 5 seconds. This change does not break existing functionality and slightly improves overall performance. I've tested next cases:

  • logs with the delay. just around 20 logs per several minutes. Scrolling works well.
  • 320k logs without delay. Buffering and scrolling also works well.
  • initial load for 320K logs also works pretty well and fast. Around 4-6 seconds which I believe is pretty good. Check screenshot.
Screenshot 2026-03-24 at 22 11 13

@boring-cyborgboring-cyborgBot added the area:API Airflow's REST/HTTP API label Mar 9, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

@potiuk

potiuk commented Mar 11, 2026

Copy link
Copy Markdown
Member

@dsuhinin This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • Failing CI checks: CI checks are failing (individual check names not available). Run prek run --from-ref main locally to reproduce. See static checks docs and testing docs.

Note: Your branch is 102 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the Airflow Slack.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@potiuk
potiuk marked this pull request as draft March 11, 2026 00:09

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for Jason idea.

@pierrejeambrunpierrejeambrun mentioned this pull request Mar 12, 2026
@dsuhinindsuhinin changed the title Fix the issue related to big logsAdd log buffering to increase performance when streaming big logsMar 24, 2026
@connorlwilkes

Copy link
Copy Markdown

Testing a similar change internally we have seen a very large performance increase for loading of logs on the front end when viewing logs for a task instance.

I think the front end should really either just use the normal non streaming endpoint or parse the streaming endpoint as a streaming endpoint. My understanding is that it polls the streaming endpoint and gets all the logs every call

@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

hey! I did few tests and it seems like all good. UI just pooling in that case and overall functionality works just fine.

@dsuhinin
dsuhinin marked this pull request as ready for review March 24, 2026 21:17
@dsuhinin

dsuhinin commented Mar 26, 2026

Copy link
Copy Markdown
ContributorAuthor

CI need fixing. I also tested a bunch of scenarios and things were working as expected. Even the case mentioned by Jason

from what I can see I can try to fix only -> https://github.com/apache/airflow/actions/runs/23599259101/job/68727372004?pr=63180

everything else just failing by some reason fully randomly. one update before it were 2 failed steps, now more - 5.

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else just failing by some reason fully randomly. one update before it were 2 failed step, now 5.

It seems like regression of the following integration tests, the other PR also suffer from the same failure.

providers/elasticsearch/tests/integration/elasticsearch/log/test_es_remote_log_io.py::TestElasticsearchRemoteLogIOIntegration

I will look into it if it haven't been resolved.
UPDATE: The ElasticSearch e2e tests had been resolved in #64276, I just rebased this one on top of it.

@jason810496
jason810496force-pushed the dsuhinin/1223-logs-are-loading-very-slowly branch from 461eabb to 934076eCompareMarch 27, 2026 04:24

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge on my end, the UI e2e tests already been failed for a while on main IIRC.

@connorlwilkes

Copy link
Copy Markdown

Is it possible to have the buffer size configurable?

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the issue is tagged for the 3.2 release but I don't know the exact time that we have for getting it merged.

Because people have different use-cases, it would be helpful if the buffer size was configurable. We have found that the performance improvement increases along side the buffer size and the log size. But people with small number of logs won't need a huge buffer size.

Also, a unit test would be helpful to understand how it's supposed to work without having to deep dive into the code like I did.

If time is pressing, we can address the above in a followup PR.

…ery-slowly' into dsuhinin/1223-logs-are-loading-very-slowly
# Conflicts:
#	airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py
@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

Is it possible to have the buffer size configurable?

of course. thew new variable has been added to configure the buffer size.

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the config property. LGTM!

@pierrejeambrunpierrejeambrun added this to the Airflow 3.2.0 milestone Mar 30, 2026
@pierrejeambrun
pierrejeambrun merged commit 63ba163 into apache:mainMar 30, 2026
148 checks passed
github-actionsBot pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Mar 30, 2026
…big logs (apache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Mar 30, 2026
…3180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180) (#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
…ache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
xBis7 pushed a commit to xBis7/airflow that referenced this pull request Apr 21, 2026
…big logs (apache#63180) (apache#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@bbovenzibbovenzi mentioned this pull request Aug 6, 2026
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@dsuhinin@potiuk@connorlwilkes@pierrejeambrun@jason810496@xBis7@bbovenzi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add log buffering to increase performance when streaming big logs - #63180

Merged
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly
Mar 30, 2026
Merged

Add log buffering to increase performance when streaming big logs#63180
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly

Conversation

@dsuhinin

@dsuhinindsuhinin commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

The current streaming approach does not seem to effectively solve the problem of handling large logs. This PR adds buffering to improve performance when processing them. Previously, loading 320k entries took around 50–60 seconds; with buffering, it now takes about 5 seconds. This change does not break existing functionality and slightly improves overall performance. I've tested next cases:

  • logs with the delay. just around 20 logs per several minutes. Scrolling works well.
  • 320k logs without delay. Buffering and scrolling also works well.
  • initial load for 320K logs also works pretty well and fast. Around 4-6 seconds which I believe is pretty good. Check screenshot.
Screenshot 2026-03-24 at 22 11 13

@boring-cyborgboring-cyborgBot added the area:API Airflow's REST/HTTP API label Mar 9, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

@potiuk

potiuk commented Mar 11, 2026

Copy link
Copy Markdown
Member

@dsuhinin This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • Failing CI checks: CI checks are failing (individual check names not available). Run prek run --from-ref main locally to reproduce. See static checks docs and testing docs.

Note: Your branch is 102 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the Airflow Slack.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@potiuk
potiuk marked this pull request as draft March 11, 2026 00:09

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for Jason idea.

@pierrejeambrunpierrejeambrun mentioned this pull request Mar 12, 2026
@dsuhinindsuhinin changed the title Fix the issue related to big logsAdd log buffering to increase performance when streaming big logsMar 24, 2026
@connorlwilkes

Copy link
Copy Markdown

Testing a similar change internally we have seen a very large performance increase for loading of logs on the front end when viewing logs for a task instance.

I think the front end should really either just use the normal non streaming endpoint or parse the streaming endpoint as a streaming endpoint. My understanding is that it polls the streaming endpoint and gets all the logs every call

@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

hey! I did few tests and it seems like all good. UI just pooling in that case and overall functionality works just fine.

@dsuhinin
dsuhinin marked this pull request as ready for review March 24, 2026 21:17
@dsuhinin

dsuhinin commented Mar 26, 2026

Copy link
Copy Markdown
ContributorAuthor

CI need fixing. I also tested a bunch of scenarios and things were working as expected. Even the case mentioned by Jason

from what I can see I can try to fix only -> https://github.com/apache/airflow/actions/runs/23599259101/job/68727372004?pr=63180

everything else just failing by some reason fully randomly. one update before it were 2 failed steps, now more - 5.

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else just failing by some reason fully randomly. one update before it were 2 failed step, now 5.

It seems like regression of the following integration tests, the other PR also suffer from the same failure.

providers/elasticsearch/tests/integration/elasticsearch/log/test_es_remote_log_io.py::TestElasticsearchRemoteLogIOIntegration

I will look into it if it haven't been resolved.
UPDATE: The ElasticSearch e2e tests had been resolved in #64276, I just rebased this one on top of it.

@jason810496
jason810496force-pushed the dsuhinin/1223-logs-are-loading-very-slowly branch from 461eabb to 934076eCompareMarch 27, 2026 04:24

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge on my end, the UI e2e tests already been failed for a while on main IIRC.

@connorlwilkes

Copy link
Copy Markdown

Is it possible to have the buffer size configurable?

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the issue is tagged for the 3.2 release but I don't know the exact time that we have for getting it merged.

Because people have different use-cases, it would be helpful if the buffer size was configurable. We have found that the performance improvement increases along side the buffer size and the log size. But people with small number of logs won't need a huge buffer size.

Also, a unit test would be helpful to understand how it's supposed to work without having to deep dive into the code like I did.

If time is pressing, we can address the above in a followup PR.

…ery-slowly' into dsuhinin/1223-logs-are-loading-very-slowly
# Conflicts:
#	airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py
@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

Is it possible to have the buffer size configurable?

of course. thew new variable has been added to configure the buffer size.

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the config property. LGTM!

@pierrejeambrunpierrejeambrun added this to the Airflow 3.2.0 milestone Mar 30, 2026
@pierrejeambrun
pierrejeambrun merged commit 63ba163 into apache:mainMar 30, 2026
148 checks passed
github-actionsBot pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Mar 30, 2026
…big logs (apache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Mar 30, 2026
…3180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180) (#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
…ache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
xBis7 pushed a commit to xBis7/airflow that referenced this pull request Apr 21, 2026
…big logs (apache#63180) (apache#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@bbovenzibbovenzi mentioned this pull request Aug 6, 2026
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@dsuhinin@potiuk@connorlwilkes@pierrejeambrun@jason810496@xBis7@bbovenzi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add log buffering to increase performance when streaming big logs - #63180

Merged
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly
Mar 30, 2026
Merged

Add log buffering to increase performance when streaming big logs#63180
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly

Conversation

@dsuhinin

@dsuhinindsuhinin commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

The current streaming approach does not seem to effectively solve the problem of handling large logs. This PR adds buffering to improve performance when processing them. Previously, loading 320k entries took around 50–60 seconds; with buffering, it now takes about 5 seconds. This change does not break existing functionality and slightly improves overall performance. I've tested next cases:

  • logs with the delay. just around 20 logs per several minutes. Scrolling works well.
  • 320k logs without delay. Buffering and scrolling also works well.
  • initial load for 320K logs also works pretty well and fast. Around 4-6 seconds which I believe is pretty good. Check screenshot.
Screenshot 2026-03-24 at 22 11 13

@boring-cyborgboring-cyborgBot added the area:API Airflow's REST/HTTP API label Mar 9, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

@potiuk

potiuk commented Mar 11, 2026

Copy link
Copy Markdown
Member

@dsuhinin This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • Failing CI checks: CI checks are failing (individual check names not available). Run prek run --from-ref main locally to reproduce. See static checks docs and testing docs.

Note: Your branch is 102 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the Airflow Slack.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@potiuk
potiuk marked this pull request as draft March 11, 2026 00:09

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for Jason idea.

@pierrejeambrunpierrejeambrun mentioned this pull request Mar 12, 2026
@dsuhinindsuhinin changed the title Fix the issue related to big logsAdd log buffering to increase performance when streaming big logsMar 24, 2026
@connorlwilkes

Copy link
Copy Markdown

Testing a similar change internally we have seen a very large performance increase for loading of logs on the front end when viewing logs for a task instance.

I think the front end should really either just use the normal non streaming endpoint or parse the streaming endpoint as a streaming endpoint. My understanding is that it polls the streaming endpoint and gets all the logs every call

@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

hey! I did few tests and it seems like all good. UI just pooling in that case and overall functionality works just fine.

@dsuhinin
dsuhinin marked this pull request as ready for review March 24, 2026 21:17
@dsuhinin

dsuhinin commented Mar 26, 2026

Copy link
Copy Markdown
ContributorAuthor

CI need fixing. I also tested a bunch of scenarios and things were working as expected. Even the case mentioned by Jason

from what I can see I can try to fix only -> https://github.com/apache/airflow/actions/runs/23599259101/job/68727372004?pr=63180

everything else just failing by some reason fully randomly. one update before it were 2 failed steps, now more - 5.

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else just failing by some reason fully randomly. one update before it were 2 failed step, now 5.

It seems like regression of the following integration tests, the other PR also suffer from the same failure.

providers/elasticsearch/tests/integration/elasticsearch/log/test_es_remote_log_io.py::TestElasticsearchRemoteLogIOIntegration

I will look into it if it haven't been resolved.
UPDATE: The ElasticSearch e2e tests had been resolved in #64276, I just rebased this one on top of it.

@jason810496
jason810496force-pushed the dsuhinin/1223-logs-are-loading-very-slowly branch from 461eabb to 934076eCompareMarch 27, 2026 04:24

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge on my end, the UI e2e tests already been failed for a while on main IIRC.

@connorlwilkes

Copy link
Copy Markdown

Is it possible to have the buffer size configurable?

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the issue is tagged for the 3.2 release but I don't know the exact time that we have for getting it merged.

Because people have different use-cases, it would be helpful if the buffer size was configurable. We have found that the performance improvement increases along side the buffer size and the log size. But people with small number of logs won't need a huge buffer size.

Also, a unit test would be helpful to understand how it's supposed to work without having to deep dive into the code like I did.

If time is pressing, we can address the above in a followup PR.

…ery-slowly' into dsuhinin/1223-logs-are-loading-very-slowly
# Conflicts:
#	airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py
@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

Is it possible to have the buffer size configurable?

of course. thew new variable has been added to configure the buffer size.

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the config property. LGTM!

@pierrejeambrunpierrejeambrun added this to the Airflow 3.2.0 milestone Mar 30, 2026
@pierrejeambrun
pierrejeambrun merged commit 63ba163 into apache:mainMar 30, 2026
148 checks passed
github-actionsBot pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Mar 30, 2026
…big logs (apache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Mar 30, 2026
…3180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180) (#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
…ache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
xBis7 pushed a commit to xBis7/airflow that referenced this pull request Apr 21, 2026
…big logs (apache#63180) (apache#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@bbovenzibbovenzi mentioned this pull request Aug 6, 2026
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@dsuhinin@potiuk@connorlwilkes@pierrejeambrun@jason810496@xBis7@bbovenzi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Add log buffering to increase performance when streaming big logs - #63180

Merged
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly
Mar 30, 2026
Merged

Add log buffering to increase performance when streaming big logs#63180
pierrejeambrun merged 19 commits into
apache:mainfrom
dsuhinin:dsuhinin/1223-logs-are-loading-very-slowly

Conversation

@dsuhinin

@dsuhinindsuhinin commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

The current streaming approach does not seem to effectively solve the problem of handling large logs. This PR adds buffering to improve performance when processing them. Previously, loading 320k entries took around 50–60 seconds; with buffering, it now takes about 5 seconds. This change does not break existing functionality and slightly improves overall performance. I've tested next cases:

  • logs with the delay. just around 20 logs per several minutes. Scrolling works well.
  • 320k logs without delay. Buffering and scrolling also works well.
  • initial load for 320K logs also works pretty well and fast. Around 4-6 seconds which I believe is pretty good. Check screenshot.
Screenshot 2026-03-24 at 22 11 13

@boring-cyborgboring-cyborgBot added the area:API Airflow's REST/HTTP API label Mar 9, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

@potiuk

potiuk commented Mar 11, 2026

Copy link
Copy Markdown
Member

@dsuhinin This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • Failing CI checks: CI checks are failing (individual check names not available). Run prek run --from-ref main locally to reproduce. See static checks docs and testing docs.

Note: Your branch is 102 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the Airflow Slack.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

@potiuk
potiuk marked this pull request as draft March 11, 2026 00:09

@pierrejeambrunpierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for Jason idea.

@pierrejeambrunpierrejeambrun mentioned this pull request Mar 12, 2026
@dsuhinindsuhinin changed the title Fix the issue related to big logsAdd log buffering to increase performance when streaming big logsMar 24, 2026
@connorlwilkes

Copy link
Copy Markdown

Testing a similar change internally we have seen a very large performance increase for loading of logs on the front end when viewing logs for a task instance.

I think the front end should really either just use the normal non streaming endpoint or parse the streaming endpoint as a streaming endpoint. My understanding is that it polls the streaming endpoint and gets all the logs every call

@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

I kind of reminder why I didn't add the buffering in last refactoring. There also be the case that we just produce 10 or 20 logs per minute. If I remember correctly, the API server will show the logs until all the logs exceed the threshold, which look not that real-time for users. (Prehaps we could have another coroutine that trigger by time interval to solve the above "blocking" problem)

Maybe worthwhile to test the scenario I mention above again when you have a moment, thanks.

hey! I did few tests and it seems like all good. UI just pooling in that case and overall functionality works just fine.

@dsuhinin
dsuhinin marked this pull request as ready for review March 24, 2026 21:17
@dsuhinin

dsuhinin commented Mar 26, 2026

Copy link
Copy Markdown
ContributorAuthor

CI need fixing. I also tested a bunch of scenarios and things were working as expected. Even the case mentioned by Jason

from what I can see I can try to fix only -> https://github.com/apache/airflow/actions/runs/23599259101/job/68727372004?pr=63180

everything else just failing by some reason fully randomly. one update before it were 2 failed steps, now more - 5.

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else just failing by some reason fully randomly. one update before it were 2 failed step, now 5.

It seems like regression of the following integration tests, the other PR also suffer from the same failure.

providers/elasticsearch/tests/integration/elasticsearch/log/test_es_remote_log_io.py::TestElasticsearchRemoteLogIOIntegration

I will look into it if it haven't been resolved.
UPDATE: The ElasticSearch e2e tests had been resolved in #64276, I just rebased this one on top of it.

@jason810496
jason810496force-pushed the dsuhinin/1223-logs-are-loading-very-slowly branch from 461eabb to 934076eCompareMarch 27, 2026 04:24

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge on my end, the UI e2e tests already been failed for a while on main IIRC.

@connorlwilkes

Copy link
Copy Markdown

Is it possible to have the buffer size configurable?

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the issue is tagged for the 3.2 release but I don't know the exact time that we have for getting it merged.

Because people have different use-cases, it would be helpful if the buffer size was configurable. We have found that the performance improvement increases along side the buffer size and the log size. But people with small number of logs won't need a huge buffer size.

Also, a unit test would be helpful to understand how it's supposed to work without having to deep dive into the code like I did.

If time is pressing, we can address the above in a followup PR.

…ery-slowly' into dsuhinin/1223-logs-are-loading-very-slowly
# Conflicts:
#	airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py
@dsuhinin

Copy link
Copy Markdown
ContributorAuthor

Is it possible to have the buffer size configurable?

of course. thew new variable has been added to configure the buffer size.

@xBis7xBis7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the config property. LGTM!

@pierrejeambrunpierrejeambrun added this to the Airflow 3.2.0 milestone Mar 30, 2026
@pierrejeambrun
pierrejeambrun merged commit 63ba163 into apache:mainMar 30, 2026
148 checks passed
github-actionsBot pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Mar 30, 2026
…big logs (apache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Mar 30, 2026
…3180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
pierrejeambrun pushed a commit that referenced this pull request Mar 30, 2026
…big logs (#63180) (#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
…ache#63180)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
xBis7 pushed a commit to xBis7/airflow that referenced this pull request Apr 21, 2026
…big logs (apache#63180) (apache#64475)
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *add buffering back to speed logs loading.
* *fix scrolling for big logs.
* *return back `# type: ignore[arg-type]`. apply PR remarks.
* *make buffer size configurable.
* *add back some comments.
(cherry picked from commit 63ba163)
Co-authored-by: Software Developer <7852635+dsuhinin@users.noreply.github.com>
@bbovenzibbovenzi mentioned this pull request Aug 6, 2026
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:APIAirflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@dsuhinin@potiuk@connorlwilkes@pierrejeambrun@jason810496@xBis7@bbovenzi