Fix ti.start_date showing deferral-resume time instead of original start time - #63247

Merged
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context
Apr 19, 2026
Merged

Fix ti.start_date showing deferral-resume time instead of original start time#63247
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context

Conversation

@henry3260

@henry3260henry3260 commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Why

When a task resumes from a deferred state, the /execution/task-instances/{id}/run endpoint currently fails to include the original start_date in the returned context. This causes the Task SDK to receive incomplete or incorrect time information, which impacts the consistency of execution time semantics (i.e., the start_date should always reflect the task's initial start time, not the time it resumed).

What

  • Updated SQLAlchemy Query: Added TI.start_date to the select statement in ti_run to ensure the original task start time is properly fetched from the database.
  • Populated TIRunContext: Explicitly mapped context.start_date = ti.start_date in the TIRunContext response during the resume scenario (when next_method is present).
  • Preserved DB Behavior: Ensured that the existing logic remains intact—the TI.start_date in the database is strictly preserved and not overwritten when a task resumes.

closes: #63240

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@henry3260
henry3260 marked this pull request as ready for review March 11, 2026 05:00
CopilotAI review requested due to automatic review settings March 11, 2026 05:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes inaccurate context["ti"].start_date for deferred task instances by propagating the original TI start time from the Execution API to the Task SDK supervisor so resumed-from-deferral runs don’t appear to “start” at resume time.

Changes:

  • Extend TIRunContext (Execution API + Task SDK generated models) with an optional start_date.
  • Populate TIRunContext.start_date from the Execution API when resuming from deferral.
  • Teach the Task SDK supervisor to prefer ti_context.start_date over datetime.now() when provided.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/supervisor.pyUses ti_context.start_date (when present) as the startup start time sent to the child process.
task-sdk/src/airflow/sdk/api/datamodels/_generated.pyAdds start_date to the generated TIRunContext model.
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.pyAdds start_date to the ti_run response context when resuming from deferral.
airflow-core/src/airflow/api_fastapi/execution_api/datamodels/taskinstance.pyDocuments and exposes start_date on the server-side TIRunContext model.

You can also share your feedback on Copilot code review. Take the survey.

@henry3260
henry3260 marked this pull request as draft March 11, 2026 05:30
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch 4 times, most recently from 3be3946 to 2e458c5CompareMarch 16, 2026 01:39
@henry3260
henry3260 marked this pull request as ready for review March 16, 2026 03:04
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 2e458c5 to 6611e25CompareMarch 16, 2026 03:05
@arnoldmr01

Copy link
Copy Markdown
Contributor

LGTM!Thanks for your work.

@arnoldmr01

Copy link
Copy Markdown
Contributor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

@henry3260

Copy link
Copy Markdown
ContributorAuthor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

Thanks for your review! I will add a test case for this

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The patch make sense to me overall.

Comment threadtask-sdk/src/airflow/sdk/execution_time/supervisor.py Outdated
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 1ffebc5 to cdee639CompareMarch 31, 2026 09:56
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from cdee639 to 8fa7aa0CompareMarch 31, 2026 14:32
@henry3260

Copy link
Copy Markdown
ContributorAuthor

Nice! The patch make sense to me overall.

Thanks for the review, Jason! I've addressed all the comments.

@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 6, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, left a final nit before we merge.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from b09f837 to cccf0b5CompareApril 14, 2026 10:38
@jason810496jason810496 added this to the Airflow 3.2.2 milestone Apr 19, 2026
@jason810496
jason810496 merged commit a90202d into apache:mainApr 19, 2026
141 checks passed
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Apr 19, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
@henry3260
henry3260 deleted the fix-start-date-is-inaccurate-from-context branch April 20, 2026 02:53
vatsrahul1001 pushed a commit to jason810496/airflow that referenced this pull request Apr 23, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk pushed a commit to jason810496/airflow that referenced this pull request Apr 26, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ti.start_date from the context dictionary is inaccurate for deferred TIs

5 participants

@henry3260@arnoldmr01@jason810496@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Fix ti.start_date showing deferral-resume time instead of original start time - #63247

Merged
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context
Apr 19, 2026
Merged

Fix ti.start_date showing deferral-resume time instead of original start time#63247
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context

Conversation

@henry3260

@henry3260henry3260 commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Why

When a task resumes from a deferred state, the /execution/task-instances/{id}/run endpoint currently fails to include the original start_date in the returned context. This causes the Task SDK to receive incomplete or incorrect time information, which impacts the consistency of execution time semantics (i.e., the start_date should always reflect the task's initial start time, not the time it resumed).

What

  • Updated SQLAlchemy Query: Added TI.start_date to the select statement in ti_run to ensure the original task start time is properly fetched from the database.
  • Populated TIRunContext: Explicitly mapped context.start_date = ti.start_date in the TIRunContext response during the resume scenario (when next_method is present).
  • Preserved DB Behavior: Ensured that the existing logic remains intact—the TI.start_date in the database is strictly preserved and not overwritten when a task resumes.

closes: #63240

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@henry3260
henry3260 marked this pull request as ready for review March 11, 2026 05:00
CopilotAI review requested due to automatic review settings March 11, 2026 05:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes inaccurate context["ti"].start_date for deferred task instances by propagating the original TI start time from the Execution API to the Task SDK supervisor so resumed-from-deferral runs don’t appear to “start” at resume time.

Changes:

  • Extend TIRunContext (Execution API + Task SDK generated models) with an optional start_date.
  • Populate TIRunContext.start_date from the Execution API when resuming from deferral.
  • Teach the Task SDK supervisor to prefer ti_context.start_date over datetime.now() when provided.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/supervisor.pyUses ti_context.start_date (when present) as the startup start time sent to the child process.
task-sdk/src/airflow/sdk/api/datamodels/_generated.pyAdds start_date to the generated TIRunContext model.
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.pyAdds start_date to the ti_run response context when resuming from deferral.
airflow-core/src/airflow/api_fastapi/execution_api/datamodels/taskinstance.pyDocuments and exposes start_date on the server-side TIRunContext model.

You can also share your feedback on Copilot code review. Take the survey.

@henry3260
henry3260 marked this pull request as draft March 11, 2026 05:30
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch 4 times, most recently from 3be3946 to 2e458c5CompareMarch 16, 2026 01:39
@henry3260
henry3260 marked this pull request as ready for review March 16, 2026 03:04
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 2e458c5 to 6611e25CompareMarch 16, 2026 03:05
@arnoldmr01

Copy link
Copy Markdown
Contributor

LGTM!Thanks for your work.

@arnoldmr01

Copy link
Copy Markdown
Contributor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

@henry3260

Copy link
Copy Markdown
ContributorAuthor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

Thanks for your review! I will add a test case for this

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The patch make sense to me overall.

Comment threadtask-sdk/src/airflow/sdk/execution_time/supervisor.py Outdated
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 1ffebc5 to cdee639CompareMarch 31, 2026 09:56
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from cdee639 to 8fa7aa0CompareMarch 31, 2026 14:32
@henry3260

Copy link
Copy Markdown
ContributorAuthor

Nice! The patch make sense to me overall.

Thanks for the review, Jason! I've addressed all the comments.

@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 6, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, left a final nit before we merge.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from b09f837 to cccf0b5CompareApril 14, 2026 10:38
@jason810496jason810496 added this to the Airflow 3.2.2 milestone Apr 19, 2026
@jason810496
jason810496 merged commit a90202d into apache:mainApr 19, 2026
141 checks passed
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Apr 19, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
@henry3260
henry3260 deleted the fix-start-date-is-inaccurate-from-context branch April 20, 2026 02:53
vatsrahul1001 pushed a commit to jason810496/airflow that referenced this pull request Apr 23, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk pushed a commit to jason810496/airflow that referenced this pull request Apr 26, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ti.start_date from the context dictionary is inaccurate for deferred TIs

5 participants

@henry3260@arnoldmr01@jason810496@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix ti.start_date showing deferral-resume time instead of original start time - #63247

Merged
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context
Apr 19, 2026
Merged

Fix ti.start_date showing deferral-resume time instead of original start time#63247
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context

Conversation

@henry3260

@henry3260henry3260 commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Why

When a task resumes from a deferred state, the /execution/task-instances/{id}/run endpoint currently fails to include the original start_date in the returned context. This causes the Task SDK to receive incomplete or incorrect time information, which impacts the consistency of execution time semantics (i.e., the start_date should always reflect the task's initial start time, not the time it resumed).

What

  • Updated SQLAlchemy Query: Added TI.start_date to the select statement in ti_run to ensure the original task start time is properly fetched from the database.
  • Populated TIRunContext: Explicitly mapped context.start_date = ti.start_date in the TIRunContext response during the resume scenario (when next_method is present).
  • Preserved DB Behavior: Ensured that the existing logic remains intact—the TI.start_date in the database is strictly preserved and not overwritten when a task resumes.

closes: #63240

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@henry3260
henry3260 marked this pull request as ready for review March 11, 2026 05:00
CopilotAI review requested due to automatic review settings March 11, 2026 05:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes inaccurate context["ti"].start_date for deferred task instances by propagating the original TI start time from the Execution API to the Task SDK supervisor so resumed-from-deferral runs don’t appear to “start” at resume time.

Changes:

  • Extend TIRunContext (Execution API + Task SDK generated models) with an optional start_date.
  • Populate TIRunContext.start_date from the Execution API when resuming from deferral.
  • Teach the Task SDK supervisor to prefer ti_context.start_date over datetime.now() when provided.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/supervisor.pyUses ti_context.start_date (when present) as the startup start time sent to the child process.
task-sdk/src/airflow/sdk/api/datamodels/_generated.pyAdds start_date to the generated TIRunContext model.
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.pyAdds start_date to the ti_run response context when resuming from deferral.
airflow-core/src/airflow/api_fastapi/execution_api/datamodels/taskinstance.pyDocuments and exposes start_date on the server-side TIRunContext model.

You can also share your feedback on Copilot code review. Take the survey.

@henry3260
henry3260 marked this pull request as draft March 11, 2026 05:30
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch 4 times, most recently from 3be3946 to 2e458c5CompareMarch 16, 2026 01:39
@henry3260
henry3260 marked this pull request as ready for review March 16, 2026 03:04
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 2e458c5 to 6611e25CompareMarch 16, 2026 03:05
@arnoldmr01

Copy link
Copy Markdown
Contributor

LGTM!Thanks for your work.

@arnoldmr01

Copy link
Copy Markdown
Contributor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

@henry3260

Copy link
Copy Markdown
ContributorAuthor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

Thanks for your review! I will add a test case for this

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The patch make sense to me overall.

Comment threadtask-sdk/src/airflow/sdk/execution_time/supervisor.py Outdated
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 1ffebc5 to cdee639CompareMarch 31, 2026 09:56
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from cdee639 to 8fa7aa0CompareMarch 31, 2026 14:32
@henry3260

Copy link
Copy Markdown
ContributorAuthor

Nice! The patch make sense to me overall.

Thanks for the review, Jason! I've addressed all the comments.

@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 6, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, left a final nit before we merge.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from b09f837 to cccf0b5CompareApril 14, 2026 10:38
@jason810496jason810496 added this to the Airflow 3.2.2 milestone Apr 19, 2026
@jason810496
jason810496 merged commit a90202d into apache:mainApr 19, 2026
141 checks passed
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Apr 19, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
@henry3260
henry3260 deleted the fix-start-date-is-inaccurate-from-context branch April 20, 2026 02:53
vatsrahul1001 pushed a commit to jason810496/airflow that referenced this pull request Apr 23, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk pushed a commit to jason810496/airflow that referenced this pull request Apr 26, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ti.start_date from the context dictionary is inaccurate for deferred TIs

5 participants

@henry3260@arnoldmr01@jason810496@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix ti.start_date showing deferral-resume time instead of original start time - #63247

Merged
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context
Apr 19, 2026
Merged

Fix ti.start_date showing deferral-resume time instead of original start time#63247
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context

Conversation

@henry3260

@henry3260henry3260 commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Why

When a task resumes from a deferred state, the /execution/task-instances/{id}/run endpoint currently fails to include the original start_date in the returned context. This causes the Task SDK to receive incomplete or incorrect time information, which impacts the consistency of execution time semantics (i.e., the start_date should always reflect the task's initial start time, not the time it resumed).

What

  • Updated SQLAlchemy Query: Added TI.start_date to the select statement in ti_run to ensure the original task start time is properly fetched from the database.
  • Populated TIRunContext: Explicitly mapped context.start_date = ti.start_date in the TIRunContext response during the resume scenario (when next_method is present).
  • Preserved DB Behavior: Ensured that the existing logic remains intact—the TI.start_date in the database is strictly preserved and not overwritten when a task resumes.

closes: #63240

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@henry3260
henry3260 marked this pull request as ready for review March 11, 2026 05:00
CopilotAI review requested due to automatic review settings March 11, 2026 05:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes inaccurate context["ti"].start_date for deferred task instances by propagating the original TI start time from the Execution API to the Task SDK supervisor so resumed-from-deferral runs don’t appear to “start” at resume time.

Changes:

  • Extend TIRunContext (Execution API + Task SDK generated models) with an optional start_date.
  • Populate TIRunContext.start_date from the Execution API when resuming from deferral.
  • Teach the Task SDK supervisor to prefer ti_context.start_date over datetime.now() when provided.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/supervisor.pyUses ti_context.start_date (when present) as the startup start time sent to the child process.
task-sdk/src/airflow/sdk/api/datamodels/_generated.pyAdds start_date to the generated TIRunContext model.
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.pyAdds start_date to the ti_run response context when resuming from deferral.
airflow-core/src/airflow/api_fastapi/execution_api/datamodels/taskinstance.pyDocuments and exposes start_date on the server-side TIRunContext model.

You can also share your feedback on Copilot code review. Take the survey.

@henry3260
henry3260 marked this pull request as draft March 11, 2026 05:30
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch 4 times, most recently from 3be3946 to 2e458c5CompareMarch 16, 2026 01:39
@henry3260
henry3260 marked this pull request as ready for review March 16, 2026 03:04
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 2e458c5 to 6611e25CompareMarch 16, 2026 03:05
@arnoldmr01

Copy link
Copy Markdown
Contributor

LGTM!Thanks for your work.

@arnoldmr01

Copy link
Copy Markdown
Contributor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

@henry3260

Copy link
Copy Markdown
ContributorAuthor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

Thanks for your review! I will add a test case for this

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The patch make sense to me overall.

Comment threadtask-sdk/src/airflow/sdk/execution_time/supervisor.py Outdated
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 1ffebc5 to cdee639CompareMarch 31, 2026 09:56
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from cdee639 to 8fa7aa0CompareMarch 31, 2026 14:32
@henry3260

Copy link
Copy Markdown
ContributorAuthor

Nice! The patch make sense to me overall.

Thanks for the review, Jason! I've addressed all the comments.

@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 6, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, left a final nit before we merge.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from b09f837 to cccf0b5CompareApril 14, 2026 10:38
@jason810496jason810496 added this to the Airflow 3.2.2 milestone Apr 19, 2026
@jason810496
jason810496 merged commit a90202d into apache:mainApr 19, 2026
141 checks passed
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Apr 19, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
@henry3260
henry3260 deleted the fix-start-date-is-inaccurate-from-context branch April 20, 2026 02:53
vatsrahul1001 pushed a commit to jason810496/airflow that referenced this pull request Apr 23, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk pushed a commit to jason810496/airflow that referenced this pull request Apr 26, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ti.start_date from the context dictionary is inaccurate for deferred TIs

5 participants

@henry3260@arnoldmr01@jason810496@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Fix ti.start_date showing deferral-resume time instead of original start time - #63247

Merged
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context
Apr 19, 2026
Merged

Fix ti.start_date showing deferral-resume time instead of original start time#63247
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context

Conversation

@henry3260

@henry3260henry3260 commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Why

When a task resumes from a deferred state, the /execution/task-instances/{id}/run endpoint currently fails to include the original start_date in the returned context. This causes the Task SDK to receive incomplete or incorrect time information, which impacts the consistency of execution time semantics (i.e., the start_date should always reflect the task's initial start time, not the time it resumed).

What

  • Updated SQLAlchemy Query: Added TI.start_date to the select statement in ti_run to ensure the original task start time is properly fetched from the database.
  • Populated TIRunContext: Explicitly mapped context.start_date = ti.start_date in the TIRunContext response during the resume scenario (when next_method is present).
  • Preserved DB Behavior: Ensured that the existing logic remains intact—the TI.start_date in the database is strictly preserved and not overwritten when a task resumes.

closes: #63240

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@henry3260
henry3260 marked this pull request as ready for review March 11, 2026 05:00
CopilotAI review requested due to automatic review settings March 11, 2026 05:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes inaccurate context["ti"].start_date for deferred task instances by propagating the original TI start time from the Execution API to the Task SDK supervisor so resumed-from-deferral runs don’t appear to “start” at resume time.

Changes:

  • Extend TIRunContext (Execution API + Task SDK generated models) with an optional start_date.
  • Populate TIRunContext.start_date from the Execution API when resuming from deferral.
  • Teach the Task SDK supervisor to prefer ti_context.start_date over datetime.now() when provided.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/supervisor.pyUses ti_context.start_date (when present) as the startup start time sent to the child process.
task-sdk/src/airflow/sdk/api/datamodels/_generated.pyAdds start_date to the generated TIRunContext model.
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.pyAdds start_date to the ti_run response context when resuming from deferral.
airflow-core/src/airflow/api_fastapi/execution_api/datamodels/taskinstance.pyDocuments and exposes start_date on the server-side TIRunContext model.

You can also share your feedback on Copilot code review. Take the survey.

@henry3260
henry3260 marked this pull request as draft March 11, 2026 05:30
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch 4 times, most recently from 3be3946 to 2e458c5CompareMarch 16, 2026 01:39
@henry3260
henry3260 marked this pull request as ready for review March 16, 2026 03:04
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 2e458c5 to 6611e25CompareMarch 16, 2026 03:05
@arnoldmr01

Copy link
Copy Markdown
Contributor

LGTM!Thanks for your work.

@arnoldmr01

Copy link
Copy Markdown
Contributor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

@henry3260

Copy link
Copy Markdown
ContributorAuthor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

Thanks for your review! I will add a test case for this

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The patch make sense to me overall.

Comment threadtask-sdk/src/airflow/sdk/execution_time/supervisor.py Outdated
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 1ffebc5 to cdee639CompareMarch 31, 2026 09:56
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from cdee639 to 8fa7aa0CompareMarch 31, 2026 14:32
@henry3260

Copy link
Copy Markdown
ContributorAuthor

Nice! The patch make sense to me overall.

Thanks for the review, Jason! I've addressed all the comments.

@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 6, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, left a final nit before we merge.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from b09f837 to cccf0b5CompareApril 14, 2026 10:38
@jason810496jason810496 added this to the Airflow 3.2.2 milestone Apr 19, 2026
@jason810496
jason810496 merged commit a90202d into apache:mainApr 19, 2026
141 checks passed
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Apr 19, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
@henry3260
henry3260 deleted the fix-start-date-is-inaccurate-from-context branch April 20, 2026 02:53
vatsrahul1001 pushed a commit to jason810496/airflow that referenced this pull request Apr 23, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk pushed a commit to jason810496/airflow that referenced this pull request Apr 26, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ti.start_date from the context dictionary is inaccurate for deferred TIs

5 participants

@henry3260@arnoldmr01@jason810496@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix ti.start_date showing deferral-resume time instead of original start time - #63247

Merged
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context
Apr 19, 2026
Merged

Fix ti.start_date showing deferral-resume time instead of original start time#63247
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context

Conversation

@henry3260

@henry3260henry3260 commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Why

When a task resumes from a deferred state, the /execution/task-instances/{id}/run endpoint currently fails to include the original start_date in the returned context. This causes the Task SDK to receive incomplete or incorrect time information, which impacts the consistency of execution time semantics (i.e., the start_date should always reflect the task's initial start time, not the time it resumed).

What

  • Updated SQLAlchemy Query: Added TI.start_date to the select statement in ti_run to ensure the original task start time is properly fetched from the database.
  • Populated TIRunContext: Explicitly mapped context.start_date = ti.start_date in the TIRunContext response during the resume scenario (when next_method is present).
  • Preserved DB Behavior: Ensured that the existing logic remains intact—the TI.start_date in the database is strictly preserved and not overwritten when a task resumes.

closes: #63240

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@henry3260
henry3260 marked this pull request as ready for review March 11, 2026 05:00
CopilotAI review requested due to automatic review settings March 11, 2026 05:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes inaccurate context["ti"].start_date for deferred task instances by propagating the original TI start time from the Execution API to the Task SDK supervisor so resumed-from-deferral runs don’t appear to “start” at resume time.

Changes:

  • Extend TIRunContext (Execution API + Task SDK generated models) with an optional start_date.
  • Populate TIRunContext.start_date from the Execution API when resuming from deferral.
  • Teach the Task SDK supervisor to prefer ti_context.start_date over datetime.now() when provided.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/supervisor.pyUses ti_context.start_date (when present) as the startup start time sent to the child process.
task-sdk/src/airflow/sdk/api/datamodels/_generated.pyAdds start_date to the generated TIRunContext model.
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.pyAdds start_date to the ti_run response context when resuming from deferral.
airflow-core/src/airflow/api_fastapi/execution_api/datamodels/taskinstance.pyDocuments and exposes start_date on the server-side TIRunContext model.

You can also share your feedback on Copilot code review. Take the survey.

@henry3260
henry3260 marked this pull request as draft March 11, 2026 05:30
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch 4 times, most recently from 3be3946 to 2e458c5CompareMarch 16, 2026 01:39
@henry3260
henry3260 marked this pull request as ready for review March 16, 2026 03:04
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 2e458c5 to 6611e25CompareMarch 16, 2026 03:05
@arnoldmr01

Copy link
Copy Markdown
Contributor

LGTM!Thanks for your work.

@arnoldmr01

Copy link
Copy Markdown
Contributor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

@henry3260

Copy link
Copy Markdown
ContributorAuthor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

Thanks for your review! I will add a test case for this

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The patch make sense to me overall.

Comment threadtask-sdk/src/airflow/sdk/execution_time/supervisor.py Outdated
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 1ffebc5 to cdee639CompareMarch 31, 2026 09:56
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from cdee639 to 8fa7aa0CompareMarch 31, 2026 14:32
@henry3260

Copy link
Copy Markdown
ContributorAuthor

Nice! The patch make sense to me overall.

Thanks for the review, Jason! I've addressed all the comments.

@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 6, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, left a final nit before we merge.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from b09f837 to cccf0b5CompareApril 14, 2026 10:38
@jason810496jason810496 added this to the Airflow 3.2.2 milestone Apr 19, 2026
@jason810496
jason810496 merged commit a90202d into apache:mainApr 19, 2026
141 checks passed
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Apr 19, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
@henry3260
henry3260 deleted the fix-start-date-is-inaccurate-from-context branch April 20, 2026 02:53
vatsrahul1001 pushed a commit to jason810496/airflow that referenced this pull request Apr 23, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk pushed a commit to jason810496/airflow that referenced this pull request Apr 26, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ti.start_date from the context dictionary is inaccurate for deferred TIs

5 participants

@henry3260@arnoldmr01@jason810496@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix ti.start_date showing deferral-resume time instead of original start time - #63247

Merged
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context
Apr 19, 2026
Merged

Fix ti.start_date showing deferral-resume time instead of original start time#63247
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context

Conversation

@henry3260

@henry3260henry3260 commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Why

When a task resumes from a deferred state, the /execution/task-instances/{id}/run endpoint currently fails to include the original start_date in the returned context. This causes the Task SDK to receive incomplete or incorrect time information, which impacts the consistency of execution time semantics (i.e., the start_date should always reflect the task's initial start time, not the time it resumed).

What

  • Updated SQLAlchemy Query: Added TI.start_date to the select statement in ti_run to ensure the original task start time is properly fetched from the database.
  • Populated TIRunContext: Explicitly mapped context.start_date = ti.start_date in the TIRunContext response during the resume scenario (when next_method is present).
  • Preserved DB Behavior: Ensured that the existing logic remains intact—the TI.start_date in the database is strictly preserved and not overwritten when a task resumes.

closes: #63240

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@henry3260
henry3260 marked this pull request as ready for review March 11, 2026 05:00
CopilotAI review requested due to automatic review settings March 11, 2026 05:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes inaccurate context["ti"].start_date for deferred task instances by propagating the original TI start time from the Execution API to the Task SDK supervisor so resumed-from-deferral runs don’t appear to “start” at resume time.

Changes:

  • Extend TIRunContext (Execution API + Task SDK generated models) with an optional start_date.
  • Populate TIRunContext.start_date from the Execution API when resuming from deferral.
  • Teach the Task SDK supervisor to prefer ti_context.start_date over datetime.now() when provided.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/supervisor.pyUses ti_context.start_date (when present) as the startup start time sent to the child process.
task-sdk/src/airflow/sdk/api/datamodels/_generated.pyAdds start_date to the generated TIRunContext model.
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.pyAdds start_date to the ti_run response context when resuming from deferral.
airflow-core/src/airflow/api_fastapi/execution_api/datamodels/taskinstance.pyDocuments and exposes start_date on the server-side TIRunContext model.

You can also share your feedback on Copilot code review. Take the survey.

@henry3260
henry3260 marked this pull request as draft March 11, 2026 05:30
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch 4 times, most recently from 3be3946 to 2e458c5CompareMarch 16, 2026 01:39
@henry3260
henry3260 marked this pull request as ready for review March 16, 2026 03:04
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 2e458c5 to 6611e25CompareMarch 16, 2026 03:05
@arnoldmr01

Copy link
Copy Markdown
Contributor

LGTM!Thanks for your work.

@arnoldmr01

Copy link
Copy Markdown
Contributor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

@henry3260

Copy link
Copy Markdown
ContributorAuthor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

Thanks for your review! I will add a test case for this

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The patch make sense to me overall.

Comment threadtask-sdk/src/airflow/sdk/execution_time/supervisor.py Outdated
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 1ffebc5 to cdee639CompareMarch 31, 2026 09:56
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from cdee639 to 8fa7aa0CompareMarch 31, 2026 14:32
@henry3260

Copy link
Copy Markdown
ContributorAuthor

Nice! The patch make sense to me overall.

Thanks for the review, Jason! I've addressed all the comments.

@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 6, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, left a final nit before we merge.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from b09f837 to cccf0b5CompareApril 14, 2026 10:38
@jason810496jason810496 added this to the Airflow 3.2.2 milestone Apr 19, 2026
@jason810496
jason810496 merged commit a90202d into apache:mainApr 19, 2026
141 checks passed
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Apr 19, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
@henry3260
henry3260 deleted the fix-start-date-is-inaccurate-from-context branch April 20, 2026 02:53
vatsrahul1001 pushed a commit to jason810496/airflow that referenced this pull request Apr 23, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk pushed a commit to jason810496/airflow that referenced this pull request Apr 26, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ti.start_date from the context dictionary is inaccurate for deferred TIs

5 participants

@henry3260@arnoldmr01@jason810496@potiuk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Fix ti.start_date showing deferral-resume time instead of original start time - #63247

Merged
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context
Apr 19, 2026
Merged

Fix ti.start_date showing deferral-resume time instead of original start time#63247
jason810496 merged 4 commits into
apache:mainfrom
henry3260:fix-start-date-is-inaccurate-from-context

Conversation

@henry3260

@henry3260henry3260 commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Why

When a task resumes from a deferred state, the /execution/task-instances/{id}/run endpoint currently fails to include the original start_date in the returned context. This causes the Task SDK to receive incomplete or incorrect time information, which impacts the consistency of execution time semantics (i.e., the start_date should always reflect the task's initial start time, not the time it resumed).

What

  • Updated SQLAlchemy Query: Added TI.start_date to the select statement in ti_run to ensure the original task start time is properly fetched from the database.
  • Populated TIRunContext: Explicitly mapped context.start_date = ti.start_date in the TIRunContext response during the resume scenario (when next_method is present).
  • Preserved DB Behavior: Ensured that the existing logic remains intact—the TI.start_date in the database is strictly preserved and not overwritten when a task resumes.

closes: #63240

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@henry3260
henry3260 marked this pull request as ready for review March 11, 2026 05:00
CopilotAI review requested due to automatic review settings March 11, 2026 05:00

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes inaccurate context["ti"].start_date for deferred task instances by propagating the original TI start time from the Execution API to the Task SDK supervisor so resumed-from-deferral runs don’t appear to “start” at resume time.

Changes:

  • Extend TIRunContext (Execution API + Task SDK generated models) with an optional start_date.
  • Populate TIRunContext.start_date from the Execution API when resuming from deferral.
  • Teach the Task SDK supervisor to prefer ti_context.start_date over datetime.now() when provided.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/supervisor.pyUses ti_context.start_date (when present) as the startup start time sent to the child process.
task-sdk/src/airflow/sdk/api/datamodels/_generated.pyAdds start_date to the generated TIRunContext model.
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.pyAdds start_date to the ti_run response context when resuming from deferral.
airflow-core/src/airflow/api_fastapi/execution_api/datamodels/taskinstance.pyDocuments and exposes start_date on the server-side TIRunContext model.

You can also share your feedback on Copilot code review. Take the survey.

@henry3260
henry3260 marked this pull request as draft March 11, 2026 05:30
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch 4 times, most recently from 3be3946 to 2e458c5CompareMarch 16, 2026 01:39
@henry3260
henry3260 marked this pull request as ready for review March 16, 2026 03:04
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 2e458c5 to 6611e25CompareMarch 16, 2026 03:05
@arnoldmr01

Copy link
Copy Markdown
Contributor

LGTM!Thanks for your work.

@arnoldmr01

Copy link
Copy Markdown
Contributor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

@henry3260

Copy link
Copy Markdown
ContributorAuthor

Would it make sense to add a test here to verify that StartupDetails.model_construct uses ti_context.start_date as start_date?

Just a personal thought. I'm not sure if it is necessary

Thanks for your review! I will add a test case for this

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The patch make sense to me overall.

Comment threadtask-sdk/src/airflow/sdk/execution_time/supervisor.py Outdated
Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from 1ffebc5 to cdee639CompareMarch 31, 2026 09:56
@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from cdee639 to 8fa7aa0CompareMarch 31, 2026 14:32
@henry3260

Copy link
Copy Markdown
ContributorAuthor

Nice! The patch make sense to me overall.

Thanks for the review, Jason! I've addressed all the comments.

@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 6, 2026

@jason810496jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, left a final nit before we merge.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@henry3260
henry3260force-pushed the fix-start-date-is-inaccurate-from-context branch from b09f837 to cccf0b5CompareApril 14, 2026 10:38
@jason810496jason810496 added this to the Airflow 3.2.2 milestone Apr 19, 2026
@jason810496
jason810496 merged commit a90202d into apache:mainApr 19, 2026
141 checks passed
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Apr 19, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
@henry3260
henry3260 deleted the fix-start-date-is-inaccurate-from-context branch April 20, 2026 02:53
vatsrahul1001 pushed a commit to jason810496/airflow that referenced this pull request Apr 23, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk pushed a commit to jason810496/airflow that referenced this pull request Apr 26, 2026
… original start time (apache#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… original start time (#63247) (#65491)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Fix ti.start_date showing deferral-resume time instead of original start time (#63247)
* Fix ti.start_date showing deferral-resume time instead of original start time
* Add API migration
* Add unit test
* add unit test to verify the resume start date behavior
(cherry picked from commit a90202d)
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Henry Chen <henryhenry0512@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ti.start_date from the context dictionary is inaccurate for deferred TIs

5 participants

@henry3260@arnoldmr01@jason810496@potiuk