Uh oh!
There was an error while loading. Please reload this page.
Persisting filter by tag - #63273
Merged
Merged
Conversation
zachliu
requested review from
bbovenzi, choo121600, guan404ming, pierrejeambrun, ryanahamilton, shubhamraj-git and vatsrahul1001
as code ownersMarch 10, 2026 14:22
zachliuforce-pushed
the
persisting-filter-by-tag
branch
2 times, most recently
from
March 10, 2026 17:46
8eda13b to
b34a375CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
zachliuforce-pushed
the
persisting-filter-by-tag
branch
from
March 12, 2026 03:27
b0c94e7 to
a597cb8Compare
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR!
LGTM just a few nits / suggestions.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
zachliuforce-pushed
the
persisting-filter-by-tag
branch
from
March 18, 2026 21:16
44943e0 to
dd0555eComparepierrejeambrunforce-pushed
the
persisting-filter-by-tag
branch
from
March 23, 2026 14:36
dd0555e to
d5e2556Comparepierrejeambrun
commented
Mar 23, 2026
Member
Rebased the branch to try to fix the transient CI errors 🤞 |
zachliu
commented
Mar 23, 2026
ContributorAuthor
🫡 |
Uh oh!
There was an error while loading. Please reload this page.
aaron-y-chen pushed a commit
to aaron-y-chen/airflow
that referenced
this pull request
Mar 30, 2026
* define constants for dags tag filter * make tags persistent * add deps list * optimizing, need no extra constants * Add useTagFilter hook for DagsList tag filtering * Add TagMatchMode type to useTagFilter hook * Extract tag filter logic into reusable useTagFilter hook * Add tests for useTagFilter hook * Reset offset when tag filter mode changes * Fix tag filter mode persistence for single tag selections * Stop resetting tag match mode when tag count drops below 2
Suraj-kumar00 pushed a commit
to Suraj-kumar00/airflow
that referenced
this pull request
Apr 7, 2026
* define constants for dags tag filter * make tags persistent * add deps list * optimizing, need no extra constants * Add useTagFilter hook for DagsList tag filtering * Add TagMatchMode type to useTagFilter hook * Extract tag filter logic into reusable useTagFilter hook * Add tests for useTagFilter hook * Reset offset when tag filter mode changes * Fix tag filter mode persistence for single tag selections * Stop resetting tag match mode when tag count drops below 2
abhijeets25012-tech pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Apr 9, 2026
* define constants for dags tag filter * make tags persistent * add deps list * optimizing, need no extra constants * Add useTagFilter hook for DagsList tag filtering * Add TagMatchMode type to useTagFilter hook * Extract tag filter logic into reusable useTagFilter hook * Add tests for useTagFilter hook * Reset offset when tag filter mode changes * Fix tag filter mode persistence for single tag selections * Stop resetting tag match mode when tag count drops below 2
1 task
pierrejeambrun added a commit
to astronomer/airflow
that referenced
this pull request
Aug 10, 2026
PR apache#68484 shipped save/restore/set-default views on every table that goes through the shared FilterBar, but the Dags list hand-rolls its own filter row (DagsFilters) and was left out. Users complained that their status, run-state, favorites, and needs-review filters reset on navigation. PresetFiltersMenu is already self-contained — it reads and writes useSearchParams and persists per pathname to localStorage — so it drops into DagsFilters unchanged. All Dags-page filters (paused, favorite, last/any run state, needs_review, tags, tags_match_mode, teams, timetable_type, name_pattern) are already URL params, so a saved preset restores them faithfully. For that to actually hold, the tag filter had to stop persisting its selection to localStorage (added in apache#63273): that fallback shadowed the URL, so applying a preset that omitted tags kept the previous selection instead of clearing it. Tags are now URL-only like every other filter, and the stale tags / tags_match_mode keys are pruned on load. closes: apache#66933
bbovenzi pushed a commit
that referenced
this pull request
Aug 11, 2026
PR #68484 shipped save/restore/set-default views on every table that goes through the shared FilterBar, but the Dags list hand-rolls its own filter row (DagsFilters) and was left out. Users complained that their status, run-state, favorites, and needs-review filters reset on navigation. PresetFiltersMenu is already self-contained — it reads and writes useSearchParams and persists per pathname to localStorage — so it drops into DagsFilters unchanged. All Dags-page filters (paused, favorite, last/any run state, needs_review, tags, tags_match_mode, teams, timetable_type, name_pattern) are already URL params, so a saved preset restores them faithfully. For that to actually hold, the tag filter had to stop persisting its selection to localStorage (added in #63273): that fallback shadowed the URL, so applying a preset that omitted tags kept the previous selection instead of clearing it. Tags are now URL-only like every other filter, and the stale tags / tags_match_mode keys are pruned on load. closes: #66933
dabla pushed a commit
to dabla/airflow
that referenced
this pull request
Aug 14, 2026
PR apache#68484 shipped save/restore/set-default views on every table that goes through the shared FilterBar, but the Dags list hand-rolls its own filter row (DagsFilters) and was left out. Users complained that their status, run-state, favorites, and needs-review filters reset on navigation. PresetFiltersMenu is already self-contained — it reads and writes useSearchParams and persists per pathname to localStorage — so it drops into DagsFilters unchanged. All Dags-page filters (paused, favorite, last/any run state, needs_review, tags, tags_match_mode, teams, timetable_type, name_pattern) are already URL params, so a saved preset restores them faithfully. For that to actually hold, the tag filter had to stop persisting its selection to localStorage (added in apache#63273): that fallback shadowed the URL, so applying a preset that omitted tags kept the previous selection instead of clearing it. Tags are now URL-only like every other filter, and the stale tags / tags_match_mode keys are pruned on load. closes: apache#66933
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter by tagstate not persisted in Airflow 3.x #60590I followed the existing pattern established by src/components/DataTable/useTableUrlState.ts, which persists table sort preferences to
localStorageusing the same approach.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.