Skip to content

fix(task-sdk): add greenback fallback for Variable access in triggerer - #63387

Merged
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676
May 1, 2026
Merged

fix(task-sdk): add greenback fallback for Variable access in triggerer#63387
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676

Conversation

@YoannAbriel

Copy link
Copy Markdown
Contributor

ExecutionAPISecretsBackend.get_variable() is missing the RuntimeError + greenback fallback that get_connection() already has (added in #57154). When a deferrable operator's trigger calls Variable.get() inside the triggerer's async event loop, SUPERVISOR_COMMS.send() raises RuntimeError from async_to_sync. The bare except Exception swallows it and returns None, so every backend returns nothing and the variable is reported as not found.

Added the same greenback portal detection and aget_variable() fallback that get_connection() uses. Added a matching unit test.

Closes: #61676


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 4, claude-opus-4-6)

Generated-by: Claude Code (Opus 4, claude-opus-4-6) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 4 times, most recently from e6164e1 to 9c34355CompareMarch 14, 2026 13:06
@eladkaleladkal added this to the Airflow 3.1.9 milestone Mar 15, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 2 times, most recently from d5e75ba to a1323e5CompareMarch 23, 2026 13:09
@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 2, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 9 times, most recently from 0c37a69 to d7f004aCompareApril 10, 2026 09:04
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds the missing greenback fallback path to ExecutionAPISecretsBackend.get_variable() so triggerer usage of Variable.get() doesn’t incorrectly return None when SUPERVISOR_COMMS.send() hits the async_to_syncRuntimeError in an async event loop.

Changes:

  • Add RuntimeError detection + greenback portal fallback to get_variable() (mirroring get_connection() behavior).
  • Add a unit test covering the new fallback path for variable access.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/secrets/execution_api.pyAdds greenback portal detection + async fallback for get_variable() when async_to_sync fails in triggerer contexts.
task-sdk/tests/task_sdk/execution_time/test_secrets.pyAdds a regression test ensuring get_variable() uses the greenback fallback when SUPERVISOR_COMMS.send() raises the known RuntimeError.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_secrets.py
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 3 times, most recently from a01808a to 8008073CompareApril 13, 2026 06:06
@kaxil
kaxil merged commit e6170dd into apache:mainMay 1, 2026
112 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387)
(cherry picked from commit e6170dd)
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Closes: #61676
potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triggerer can not access Variables

6 participants

@YoannAbriel@kaxil@potiuk@vatsrahul1001@eladkal
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(task-sdk): add greenback fallback for Variable access in triggerer by YoannAbriel · Pull Request #63387 · apache/airflow · GitHub
Skip to content

fix(task-sdk): add greenback fallback for Variable access in triggerer - #63387

Merged
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676
May 1, 2026
Merged

fix(task-sdk): add greenback fallback for Variable access in triggerer#63387
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676

Conversation

@YoannAbriel

Copy link
Copy Markdown
Contributor

ExecutionAPISecretsBackend.get_variable() is missing the RuntimeError + greenback fallback that get_connection() already has (added in #57154). When a deferrable operator's trigger calls Variable.get() inside the triggerer's async event loop, SUPERVISOR_COMMS.send() raises RuntimeError from async_to_sync. The bare except Exception swallows it and returns None, so every backend returns nothing and the variable is reported as not found.

Added the same greenback portal detection and aget_variable() fallback that get_connection() uses. Added a matching unit test.

Closes: #61676


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 4, claude-opus-4-6)

Generated-by: Claude Code (Opus 4, claude-opus-4-6) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 4 times, most recently from e6164e1 to 9c34355CompareMarch 14, 2026 13:06
@eladkaleladkal added this to the Airflow 3.1.9 milestone Mar 15, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 2 times, most recently from d5e75ba to a1323e5CompareMarch 23, 2026 13:09
@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 2, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 9 times, most recently from 0c37a69 to d7f004aCompareApril 10, 2026 09:04
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds the missing greenback fallback path to ExecutionAPISecretsBackend.get_variable() so triggerer usage of Variable.get() doesn’t incorrectly return None when SUPERVISOR_COMMS.send() hits the async_to_syncRuntimeError in an async event loop.

Changes:

  • Add RuntimeError detection + greenback portal fallback to get_variable() (mirroring get_connection() behavior).
  • Add a unit test covering the new fallback path for variable access.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/secrets/execution_api.pyAdds greenback portal detection + async fallback for get_variable() when async_to_sync fails in triggerer contexts.
task-sdk/tests/task_sdk/execution_time/test_secrets.pyAdds a regression test ensuring get_variable() uses the greenback fallback when SUPERVISOR_COMMS.send() raises the known RuntimeError.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_secrets.py
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 3 times, most recently from a01808a to 8008073CompareApril 13, 2026 06:06
@kaxil
kaxil merged commit e6170dd into apache:mainMay 1, 2026
112 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387)
(cherry picked from commit e6170dd)
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Closes: #61676
potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triggerer can not access Variables

6 participants

@YoannAbriel@kaxil@potiuk@vatsrahul1001@eladkal
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(task-sdk): add greenback fallback for Variable access in triggerer by YoannAbriel · Pull Request #63387 · apache/airflow · GitHub
Skip to content

fix(task-sdk): add greenback fallback for Variable access in triggerer - #63387

Merged
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676
May 1, 2026
Merged

fix(task-sdk): add greenback fallback for Variable access in triggerer#63387
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676

Conversation

@YoannAbriel

Copy link
Copy Markdown
Contributor

ExecutionAPISecretsBackend.get_variable() is missing the RuntimeError + greenback fallback that get_connection() already has (added in #57154). When a deferrable operator's trigger calls Variable.get() inside the triggerer's async event loop, SUPERVISOR_COMMS.send() raises RuntimeError from async_to_sync. The bare except Exception swallows it and returns None, so every backend returns nothing and the variable is reported as not found.

Added the same greenback portal detection and aget_variable() fallback that get_connection() uses. Added a matching unit test.

Closes: #61676


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 4, claude-opus-4-6)

Generated-by: Claude Code (Opus 4, claude-opus-4-6) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 4 times, most recently from e6164e1 to 9c34355CompareMarch 14, 2026 13:06
@eladkaleladkal added this to the Airflow 3.1.9 milestone Mar 15, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 2 times, most recently from d5e75ba to a1323e5CompareMarch 23, 2026 13:09
@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 2, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 9 times, most recently from 0c37a69 to d7f004aCompareApril 10, 2026 09:04
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds the missing greenback fallback path to ExecutionAPISecretsBackend.get_variable() so triggerer usage of Variable.get() doesn’t incorrectly return None when SUPERVISOR_COMMS.send() hits the async_to_syncRuntimeError in an async event loop.

Changes:

  • Add RuntimeError detection + greenback portal fallback to get_variable() (mirroring get_connection() behavior).
  • Add a unit test covering the new fallback path for variable access.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/secrets/execution_api.pyAdds greenback portal detection + async fallback for get_variable() when async_to_sync fails in triggerer contexts.
task-sdk/tests/task_sdk/execution_time/test_secrets.pyAdds a regression test ensuring get_variable() uses the greenback fallback when SUPERVISOR_COMMS.send() raises the known RuntimeError.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_secrets.py
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 3 times, most recently from a01808a to 8008073CompareApril 13, 2026 06:06
@kaxil
kaxil merged commit e6170dd into apache:mainMay 1, 2026
112 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387)
(cherry picked from commit e6170dd)
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Closes: #61676
potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triggerer can not access Variables

6 participants

@YoannAbriel@kaxil@potiuk@vatsrahul1001@eladkal
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(task-sdk): add greenback fallback for Variable access in triggerer by YoannAbriel · Pull Request #63387 · apache/airflow · GitHub
Skip to content

fix(task-sdk): add greenback fallback for Variable access in triggerer - #63387

Merged
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676
May 1, 2026
Merged

fix(task-sdk): add greenback fallback for Variable access in triggerer#63387
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676

Conversation

@YoannAbriel

Copy link
Copy Markdown
Contributor

ExecutionAPISecretsBackend.get_variable() is missing the RuntimeError + greenback fallback that get_connection() already has (added in #57154). When a deferrable operator's trigger calls Variable.get() inside the triggerer's async event loop, SUPERVISOR_COMMS.send() raises RuntimeError from async_to_sync. The bare except Exception swallows it and returns None, so every backend returns nothing and the variable is reported as not found.

Added the same greenback portal detection and aget_variable() fallback that get_connection() uses. Added a matching unit test.

Closes: #61676


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 4, claude-opus-4-6)

Generated-by: Claude Code (Opus 4, claude-opus-4-6) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 4 times, most recently from e6164e1 to 9c34355CompareMarch 14, 2026 13:06
@eladkaleladkal added this to the Airflow 3.1.9 milestone Mar 15, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 2 times, most recently from d5e75ba to a1323e5CompareMarch 23, 2026 13:09
@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 2, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 9 times, most recently from 0c37a69 to d7f004aCompareApril 10, 2026 09:04
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds the missing greenback fallback path to ExecutionAPISecretsBackend.get_variable() so triggerer usage of Variable.get() doesn’t incorrectly return None when SUPERVISOR_COMMS.send() hits the async_to_syncRuntimeError in an async event loop.

Changes:

  • Add RuntimeError detection + greenback portal fallback to get_variable() (mirroring get_connection() behavior).
  • Add a unit test covering the new fallback path for variable access.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/secrets/execution_api.pyAdds greenback portal detection + async fallback for get_variable() when async_to_sync fails in triggerer contexts.
task-sdk/tests/task_sdk/execution_time/test_secrets.pyAdds a regression test ensuring get_variable() uses the greenback fallback when SUPERVISOR_COMMS.send() raises the known RuntimeError.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_secrets.py
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 3 times, most recently from a01808a to 8008073CompareApril 13, 2026 06:06
@kaxil
kaxil merged commit e6170dd into apache:mainMay 1, 2026
112 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387)
(cherry picked from commit e6170dd)
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Closes: #61676
potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triggerer can not access Variables

6 participants

@YoannAbriel@kaxil@potiuk@vatsrahul1001@eladkal
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(task-sdk): add greenback fallback for Variable access in triggerer by YoannAbriel · Pull Request #63387 · apache/airflow · GitHub
Skip to content

fix(task-sdk): add greenback fallback for Variable access in triggerer - #63387

Merged
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676
May 1, 2026
Merged

fix(task-sdk): add greenback fallback for Variable access in triggerer#63387
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676

Conversation

@YoannAbriel

Copy link
Copy Markdown
Contributor

ExecutionAPISecretsBackend.get_variable() is missing the RuntimeError + greenback fallback that get_connection() already has (added in #57154). When a deferrable operator's trigger calls Variable.get() inside the triggerer's async event loop, SUPERVISOR_COMMS.send() raises RuntimeError from async_to_sync. The bare except Exception swallows it and returns None, so every backend returns nothing and the variable is reported as not found.

Added the same greenback portal detection and aget_variable() fallback that get_connection() uses. Added a matching unit test.

Closes: #61676


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 4, claude-opus-4-6)

Generated-by: Claude Code (Opus 4, claude-opus-4-6) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 4 times, most recently from e6164e1 to 9c34355CompareMarch 14, 2026 13:06
@eladkaleladkal added this to the Airflow 3.1.9 milestone Mar 15, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 2 times, most recently from d5e75ba to a1323e5CompareMarch 23, 2026 13:09
@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 2, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 9 times, most recently from 0c37a69 to d7f004aCompareApril 10, 2026 09:04
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds the missing greenback fallback path to ExecutionAPISecretsBackend.get_variable() so triggerer usage of Variable.get() doesn’t incorrectly return None when SUPERVISOR_COMMS.send() hits the async_to_syncRuntimeError in an async event loop.

Changes:

  • Add RuntimeError detection + greenback portal fallback to get_variable() (mirroring get_connection() behavior).
  • Add a unit test covering the new fallback path for variable access.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/secrets/execution_api.pyAdds greenback portal detection + async fallback for get_variable() when async_to_sync fails in triggerer contexts.
task-sdk/tests/task_sdk/execution_time/test_secrets.pyAdds a regression test ensuring get_variable() uses the greenback fallback when SUPERVISOR_COMMS.send() raises the known RuntimeError.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_secrets.py
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 3 times, most recently from a01808a to 8008073CompareApril 13, 2026 06:06
@kaxil
kaxil merged commit e6170dd into apache:mainMay 1, 2026
112 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387)
(cherry picked from commit e6170dd)
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Closes: #61676
potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triggerer can not access Variables

6 participants

@YoannAbriel@kaxil@potiuk@vatsrahul1001@eladkal
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(task-sdk): add greenback fallback for Variable access in triggerer by YoannAbriel · Pull Request #63387 · apache/airflow · GitHub
Skip to content

fix(task-sdk): add greenback fallback for Variable access in triggerer - #63387

Merged
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676
May 1, 2026
Merged

fix(task-sdk): add greenback fallback for Variable access in triggerer#63387
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676

Conversation

@YoannAbriel

Copy link
Copy Markdown
Contributor

ExecutionAPISecretsBackend.get_variable() is missing the RuntimeError + greenback fallback that get_connection() already has (added in #57154). When a deferrable operator's trigger calls Variable.get() inside the triggerer's async event loop, SUPERVISOR_COMMS.send() raises RuntimeError from async_to_sync. The bare except Exception swallows it and returns None, so every backend returns nothing and the variable is reported as not found.

Added the same greenback portal detection and aget_variable() fallback that get_connection() uses. Added a matching unit test.

Closes: #61676


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 4, claude-opus-4-6)

Generated-by: Claude Code (Opus 4, claude-opus-4-6) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 4 times, most recently from e6164e1 to 9c34355CompareMarch 14, 2026 13:06
@eladkaleladkal added this to the Airflow 3.1.9 milestone Mar 15, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 2 times, most recently from d5e75ba to a1323e5CompareMarch 23, 2026 13:09
@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 2, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 9 times, most recently from 0c37a69 to d7f004aCompareApril 10, 2026 09:04
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds the missing greenback fallback path to ExecutionAPISecretsBackend.get_variable() so triggerer usage of Variable.get() doesn’t incorrectly return None when SUPERVISOR_COMMS.send() hits the async_to_syncRuntimeError in an async event loop.

Changes:

  • Add RuntimeError detection + greenback portal fallback to get_variable() (mirroring get_connection() behavior).
  • Add a unit test covering the new fallback path for variable access.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/secrets/execution_api.pyAdds greenback portal detection + async fallback for get_variable() when async_to_sync fails in triggerer contexts.
task-sdk/tests/task_sdk/execution_time/test_secrets.pyAdds a regression test ensuring get_variable() uses the greenback fallback when SUPERVISOR_COMMS.send() raises the known RuntimeError.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_secrets.py
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 3 times, most recently from a01808a to 8008073CompareApril 13, 2026 06:06
@kaxil
kaxil merged commit e6170dd into apache:mainMay 1, 2026
112 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387)
(cherry picked from commit e6170dd)
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Closes: #61676
potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triggerer can not access Variables

6 participants

@YoannAbriel@kaxil@potiuk@vatsrahul1001@eladkal
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(task-sdk): add greenback fallback for Variable access in triggerer by YoannAbriel · Pull Request #63387 · apache/airflow · GitHub
Skip to content

fix(task-sdk): add greenback fallback for Variable access in triggerer - #63387

Merged
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676
May 1, 2026
Merged

fix(task-sdk): add greenback fallback for Variable access in triggerer#63387
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676

Conversation

@YoannAbriel

Copy link
Copy Markdown
Contributor

ExecutionAPISecretsBackend.get_variable() is missing the RuntimeError + greenback fallback that get_connection() already has (added in #57154). When a deferrable operator's trigger calls Variable.get() inside the triggerer's async event loop, SUPERVISOR_COMMS.send() raises RuntimeError from async_to_sync. The bare except Exception swallows it and returns None, so every backend returns nothing and the variable is reported as not found.

Added the same greenback portal detection and aget_variable() fallback that get_connection() uses. Added a matching unit test.

Closes: #61676


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 4, claude-opus-4-6)

Generated-by: Claude Code (Opus 4, claude-opus-4-6) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 4 times, most recently from e6164e1 to 9c34355CompareMarch 14, 2026 13:06
@eladkaleladkal added this to the Airflow 3.1.9 milestone Mar 15, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 2 times, most recently from d5e75ba to a1323e5CompareMarch 23, 2026 13:09
@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 2, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 9 times, most recently from 0c37a69 to d7f004aCompareApril 10, 2026 09:04
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds the missing greenback fallback path to ExecutionAPISecretsBackend.get_variable() so triggerer usage of Variable.get() doesn’t incorrectly return None when SUPERVISOR_COMMS.send() hits the async_to_syncRuntimeError in an async event loop.

Changes:

  • Add RuntimeError detection + greenback portal fallback to get_variable() (mirroring get_connection() behavior).
  • Add a unit test covering the new fallback path for variable access.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/secrets/execution_api.pyAdds greenback portal detection + async fallback for get_variable() when async_to_sync fails in triggerer contexts.
task-sdk/tests/task_sdk/execution_time/test_secrets.pyAdds a regression test ensuring get_variable() uses the greenback fallback when SUPERVISOR_COMMS.send() raises the known RuntimeError.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_secrets.py
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 3 times, most recently from a01808a to 8008073CompareApril 13, 2026 06:06
@kaxil
kaxil merged commit e6170dd into apache:mainMay 1, 2026
112 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387)
(cherry picked from commit e6170dd)
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Closes: #61676
potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triggerer can not access Variables

6 participants

@YoannAbriel@kaxil@potiuk@vatsrahul1001@eladkal
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(task-sdk): add greenback fallback for Variable access in triggerer by YoannAbriel · Pull Request #63387 · apache/airflow · GitHub
Skip to content

fix(task-sdk): add greenback fallback for Variable access in triggerer - #63387

Merged
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676
May 1, 2026
Merged

fix(task-sdk): add greenback fallback for Variable access in triggerer#63387
kaxil merged 1 commit into
apache:mainfrom
YoannAbriel:fix/issue-61676

Conversation

@YoannAbriel

Copy link
Copy Markdown
Contributor

ExecutionAPISecretsBackend.get_variable() is missing the RuntimeError + greenback fallback that get_connection() already has (added in #57154). When a deferrable operator's trigger calls Variable.get() inside the triggerer's async event loop, SUPERVISOR_COMMS.send() raises RuntimeError from async_to_sync. The bare except Exception swallows it and returns None, so every backend returns nothing and the variable is reported as not found.

Added the same greenback portal detection and aget_variable() fallback that get_connection() uses. Added a matching unit test.

Closes: #61676


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Opus 4, claude-opus-4-6)

Generated-by: Claude Code (Opus 4, claude-opus-4-6) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 4 times, most recently from e6164e1 to 9c34355CompareMarch 14, 2026 13:06
@eladkaleladkal added this to the Airflow 3.1.9 milestone Mar 15, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 2 times, most recently from d5e75ba to a1323e5CompareMarch 23, 2026 13:09
@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 2, 2026
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 9 times, most recently from 0c37a69 to d7f004aCompareApril 10, 2026 09:04
@kaxil
kaxil requested a review from CopilotApril 10, 2026 19:55

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds the missing greenback fallback path to ExecutionAPISecretsBackend.get_variable() so triggerer usage of Variable.get() doesn’t incorrectly return None when SUPERVISOR_COMMS.send() hits the async_to_syncRuntimeError in an async event loop.

Changes:

  • Add RuntimeError detection + greenback portal fallback to get_variable() (mirroring get_connection() behavior).
  • Add a unit test covering the new fallback path for variable access.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

FileDescription
task-sdk/src/airflow/sdk/execution_time/secrets/execution_api.pyAdds greenback portal detection + async fallback for get_variable() when async_to_sync fails in triggerer contexts.
task-sdk/tests/task_sdk/execution_time/test_secrets.pyAdds a regression test ensuring get_variable() uses the greenback fallback when SUPERVISOR_COMMS.send() raises the known RuntimeError.

Comment threadtask-sdk/tests/task_sdk/execution_time/test_secrets.py
@YoannAbriel
YoannAbrielforce-pushed the fix/issue-61676 branch 3 times, most recently from a01808a to 8008073CompareApril 13, 2026 06:06
@kaxil
kaxil merged commit e6170dd into apache:mainMay 1, 2026
112 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387)
(cherry picked from commit e6170dd)
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Closes: #61676
potiuk pushed a commit that referenced this pull request May 2, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
…#63387) (#66239)
(cherry picked from commit e6170dd)
Closes: #61676
Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Triggerer can not access Variables

6 participants

@YoannAbriel@kaxil@potiuk@vatsrahul1001@eladkal