Return dag-specified results in dag run wait API by uranusjr · Pull Request #64577 · apache/airflow

uranusjr · 2026-04-01T12:55:33Z

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set.

The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

bugraoz93

Look good to me! It could be good to include unit test for the new conditional. Even though behavior not changed, we have new statements to test accordong to resulset

Copilot

Pull request overview

This PR aims to change the DAG run “wait” API behavior so that, when result_task_ids is not explicitly provided, the API returns XCom values marked as DAG results (dag_result=True) instead of returning no results.

Changes:

Update XCom query selection to default to dag_result=True XComs when result_task_ids is None.
Add SQLAlchemy true() import to build the new dag_result filter.

uranusjr · 2026-04-02T07:16:46Z

Test added (and rebased to resolve conflict)

pierrejeambrun

We need to adjust the permission check. (People that cannot read xcom shouldn't be able to access that, and currently the check is only performed when result_task_ids is explicitly set. #64415 (And add a test for that)

uranusjr · 2026-04-08T05:26:57Z

I adjusted the logic to not return any results if the API user does not have perm to view XComs (but still can view the dag run’s state)

pierrejeambrun

LGTM thanks. (two small tests need adjustments)

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set. The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

uranusjr · 2026-04-01T12:55:33Z

For #51711 (comment).

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set.

The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

bugraoz93

Look good to me! It could be good to include unit test for the new conditional. Even though behavior not changed, we have new statements to test accordong to resulset

Copilot

Pull request overview

This PR aims to change the DAG run “wait” API behavior so that, when result_task_ids is not explicitly provided, the API returns XCom values marked as DAG results (dag_result=True) instead of returning no results.

Changes:

Update XCom query selection to default to dag_result=True XComs when result_task_ids is None.
Add SQLAlchemy true() import to build the new dag_result filter.

uranusjr · 2026-04-02T07:16:46Z

Test added (and rebased to resolve conflict)

pierrejeambrun

We need to adjust the permission check. (People that cannot read xcom shouldn't be able to access that, and currently the check is only performed when result_task_ids is explicitly set. #64415 (And add a test for that)

uranusjr · 2026-04-08T05:26:57Z

I adjusted the logic to not return any results if the API user does not have perm to view XComs (but still can view the dag run’s state)

pierrejeambrun

LGTM thanks. (two small tests need adjustments)

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set. The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

uranusjr · 2026-04-01T12:55:33Z

For #51711 (comment).

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set.

The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

bugraoz93

Look good to me! It could be good to include unit test for the new conditional. Even though behavior not changed, we have new statements to test accordong to resulset

Copilot

Pull request overview

This PR aims to change the DAG run “wait” API behavior so that, when result_task_ids is not explicitly provided, the API returns XCom values marked as DAG results (dag_result=True) instead of returning no results.

Changes:

Update XCom query selection to default to dag_result=True XComs when result_task_ids is None.
Add SQLAlchemy true() import to build the new dag_result filter.

uranusjr · 2026-04-02T07:16:46Z

Test added (and rebased to resolve conflict)

pierrejeambrun

We need to adjust the permission check. (People that cannot read xcom shouldn't be able to access that, and currently the check is only performed when result_task_ids is explicitly set. #64415 (And add a test for that)

uranusjr · 2026-04-08T05:26:57Z

I adjusted the logic to not return any results if the API user does not have perm to view XComs (but still can view the dag run’s state)

pierrejeambrun

LGTM thanks. (two small tests need adjustments)

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set. The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

uranusjr · 2026-04-01T12:55:33Z

For #51711 (comment).

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set.

The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

bugraoz93

Look good to me! It could be good to include unit test for the new conditional. Even though behavior not changed, we have new statements to test accordong to resulset

Copilot

Pull request overview

This PR aims to change the DAG run “wait” API behavior so that, when result_task_ids is not explicitly provided, the API returns XCom values marked as DAG results (dag_result=True) instead of returning no results.

Changes:

Update XCom query selection to default to dag_result=True XComs when result_task_ids is None.
Add SQLAlchemy true() import to build the new dag_result filter.

uranusjr · 2026-04-02T07:16:46Z

Test added (and rebased to resolve conflict)

pierrejeambrun

We need to adjust the permission check. (People that cannot read xcom shouldn't be able to access that, and currently the check is only performed when result_task_ids is explicitly set. #64415 (And add a test for that)

uranusjr · 2026-04-08T05:26:57Z

I adjusted the logic to not return any results if the API user does not have perm to view XComs (but still can view the dag run’s state)

pierrejeambrun

LGTM thanks. (two small tests need adjustments)

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set. The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

uranusjr · 2026-04-01T12:55:33Z

For #51711 (comment).

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set.

The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

bugraoz93

Look good to me! It could be good to include unit test for the new conditional. Even though behavior not changed, we have new statements to test accordong to resulset

Copilot

Pull request overview

This PR aims to change the DAG run “wait” API behavior so that, when result_task_ids is not explicitly provided, the API returns XCom values marked as DAG results (dag_result=True) instead of returning no results.

Changes:

Update XCom query selection to default to dag_result=True XComs when result_task_ids is None.
Add SQLAlchemy true() import to build the new dag_result filter.

uranusjr · 2026-04-02T07:16:46Z

Test added (and rebased to resolve conflict)

pierrejeambrun

We need to adjust the permission check. (People that cannot read xcom shouldn't be able to access that, and currently the check is only performed when result_task_ids is explicitly set. #64415 (And add a test for that)

uranusjr · 2026-04-08T05:26:57Z

I adjusted the logic to not return any results if the API user does not have perm to view XComs (but still can view the dag run’s state)

pierrejeambrun

LGTM thanks. (two small tests need adjustments)

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set. The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

uranusjr · 2026-04-01T12:55:33Z

For #51711 (comment).

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set.

The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

bugraoz93

Look good to me! It could be good to include unit test for the new conditional. Even though behavior not changed, we have new statements to test accordong to resulset

Copilot

Pull request overview

This PR aims to change the DAG run “wait” API behavior so that, when result_task_ids is not explicitly provided, the API returns XCom values marked as DAG results (dag_result=True) instead of returning no results.

Changes:

Update XCom query selection to default to dag_result=True XComs when result_task_ids is None.
Add SQLAlchemy true() import to build the new dag_result filter.

uranusjr · 2026-04-02T07:16:46Z

Test added (and rebased to resolve conflict)

pierrejeambrun

We need to adjust the permission check. (People that cannot read xcom shouldn't be able to access that, and currently the check is only performed when result_task_ids is explicitly set. #64415 (And add a test for that)

uranusjr · 2026-04-08T05:26:57Z

I adjusted the logic to not return any results if the API user does not have perm to view XComs (but still can view the dag run’s state)

pierrejeambrun

LGTM thanks. (two small tests need adjustments)

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set. The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

uranusjr · 2026-04-01T12:55:33Z

For #51711 (comment).

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set.

The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

bugraoz93

Look good to me! It could be good to include unit test for the new conditional. Even though behavior not changed, we have new statements to test accordong to resulset

Copilot

Pull request overview

This PR aims to change the DAG run “wait” API behavior so that, when result_task_ids is not explicitly provided, the API returns XCom values marked as DAG results (dag_result=True) instead of returning no results.

Changes:

Update XCom query selection to default to dag_result=True XComs when result_task_ids is None.
Add SQLAlchemy true() import to build the new dag_result filter.

uranusjr · 2026-04-02T07:16:46Z

Test added (and rebased to resolve conflict)

pierrejeambrun

We need to adjust the permission check. (People that cannot read xcom shouldn't be able to access that, and currently the check is only performed when result_task_ids is explicitly set. #64415 (And add a test for that)

uranusjr · 2026-04-08T05:26:57Z

I adjusted the logic to not return any results if the API user does not have perm to view XComs (but still can view the dag run’s state)

pierrejeambrun

LGTM thanks. (two small tests need adjustments)

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set. The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

uranusjr · 2026-04-01T12:55:33Z

For #51711 (comment).

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set.

The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

bugraoz93

Look good to me! It could be good to include unit test for the new conditional. Even though behavior not changed, we have new statements to test accordong to resulset

Copilot

Pull request overview

This PR aims to change the DAG run “wait” API behavior so that, when result_task_ids is not explicitly provided, the API returns XCom values marked as DAG results (dag_result=True) instead of returning no results.

Changes:

Update XCom query selection to default to dag_result=True XComs when result_task_ids is None.
Add SQLAlchemy true() import to build the new dag_result filter.

uranusjr · 2026-04-02T07:16:46Z

Test added (and rebased to resolve conflict)

pierrejeambrun

We need to adjust the permission check. (People that cannot read xcom shouldn't be able to access that, and currently the check is only performed when result_task_ids is explicitly set. #64415 (And add a test for that)

uranusjr · 2026-04-08T05:26:57Z

I adjusted the logic to not return any results if the API user does not have perm to view XComs (but still can view the dag run’s state)

pierrejeambrun

LGTM thanks. (two small tests need adjustments)

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

When result_task_ids is not explicitly set, default to return XCom values with dag_results set to true, which are values set by tasks with the returns_dag_result flag set. The behavior is unchanged if result_task_ids is explicitly set (values from those tasks are returned instead), or if there are not tasks authored to return dag results (the "results" dict will be absent).

uranusjr requested review from bugraoz93, choo121600, ephraimbuddy, jason810496, pierrejeambrun, rawwar and shubhamraj-git as code owners April 1, 2026 12:55

boring-cyborgBot added the area:API Airflow's REST/HTTP API label Apr 1, 2026

bugraoz93 approved these changes Apr 1, 2026
View reviewed changes

kaxil requested a review from Copilot April 2, 2026 00:38

Copilotstarted reviewing on behalf of kaxil April 2, 2026 00:39 View session

CopilotAI reviewed Apr 2, 2026
View reviewed changes

uranusjr force-pushed the api-wait-return-result branch from 9a86866 to 812c4d9Compare April 2, 2026 07:16

uranusjr commented Apr 2, 2026
View reviewed changes

Comment threadairflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py

pierrejeambrun reviewed Apr 3, 2026
View reviewed changes

uranusjr force-pushed the api-wait-return-result branch from 812c4d9 to 833c650Compare April 8, 2026 05:26

pierrejeambrun approved these changes Apr 10, 2026
View reviewed changes

pierrejeambrun reviewed Apr 10, 2026
View reviewed changes

Comment threadairflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py Outdated

kaxil requested a review from Copilot April 10, 2026 19:55

CopilotAI reviewed Apr 10, 2026
View reviewed changes

uranusjr force-pushed the api-wait-return-result branch from 833c650 to 080ae5fCompare June 13, 2026 14:51

uranusjr requested review from bbovenzi, guan404ming, ryanahamilton and vatsrahul1001 as code owners June 13, 2026 14:51

uranusjr added 2 commits June 14, 2026 07:39

Adjust perm check to author-specified results
e1bc70e

uranusjr force-pushed the api-wait-return-result branch from 080ae5f to e1bc70eCompare June 13, 2026 23:39

uranusjr merged commit ec3f008 into apache:mainJun 14, 2026
146 checks passed

uranusjr deleted the api-wait-return-result branch June 14, 2026 01:07

uranusjr linked an issue Jun 15, 2026 that may be closed by this pull request
Enable Inference Execution / Synchronous DAG Execution #51711
Closed

vatsrahul1001 added this to the Airflow 3.3.0 milestone Jun 15, 2026

pgagnon pushed a commit to pgagnon/airflow that referenced this pull request Jun 15, 2026
Return dag-specified results in dag run wait API (apache#64577)
7d0df93

imrichardwu pushed a commit to imrichardwu/airflow that referenced this pull request Jun 16, 2026
Return dag-specified results in dag run wait API (apache#64577)
42d2ffa

dingo4dev pushed a commit to dingo4dev/airflow that referenced this pull request Jun 16, 2026
Return dag-specified results in dag run wait API (apache#64577)
5aa4291