Uh oh!
There was an error while loading. Please reload this page.
[v3-2-test] fix(scheduler): skip asset-triggered dags without SerializedDagModel (#64322) - #64738
Merged
Merged
Conversation
…zedDagModel (#64322) * fix(scheduler): skip asset-triggered dags without SerializedDagModel in dags_needing_dagruns Remove those dag_ids from the in-memory candidate set until serialization exists; retain AssetDagRunQueue rows and emit DEBUG logs. Add unit tests and a bugfix newsfragment. * fix(scheduler): prevent premature asset-triggered DagRuns when SerializedDagModel is unavailable * test(dag): persist DagModel before AssetDagRunQueue in unit tests Split DagModel and AssetDagRunQueue inserts and flush after DagModel so foreign-key order matches production DB constraints in TestDagModel. * Apply suggestions from code review Co-authored-by: Wei Lee <weilee.rx@gmail.com> * refactor(dag): clarify ADRQ skip log and condense serialized-DAG guard Combine the missing-from-serialized set check with a walrus assignment and improve the debug message when DagRun creation is skipped for DAGs with queued asset events but no SerializedDagModel row. * test(models): align caplog assertions with updated serialized dag warnings * test(dag): align ADRQ missing-serialized log assertion with message text * Apply suggestion from @jscheffl Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> * chore(newsfragments): remove 64322.bugfix.rst --------- (cherry picked from commit b91394a) Co-authored-by: Leonardo Soares <leoss33@outlook.com.br> Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
1 task
eladkal
marked this pull request as ready for review
April 6, 2026 10:17
Uh oh!
There was an error while loading. Please reload this page.
vatsrahul1001 pushed a commit
that referenced
this pull request
Apr 8, 2026
…zedDagModel (#64322) (#64738) * fix(scheduler): skip asset-triggered dags without SerializedDagModel in dags_needing_dagruns Remove those dag_ids from the in-memory candidate set until serialization exists; retain AssetDagRunQueue rows and emit DEBUG logs. Add unit tests and a bugfix newsfragment. * fix(scheduler): prevent premature asset-triggered DagRuns when SerializedDagModel is unavailable * test(dag): persist DagModel before AssetDagRunQueue in unit tests Split DagModel and AssetDagRunQueue inserts and flush after DagModel so foreign-key order matches production DB constraints in TestDagModel. * Apply suggestions from code review * refactor(dag): clarify ADRQ skip log and condense serialized-DAG guard Combine the missing-from-serialized set check with a walrus assignment and improve the debug message when DagRun creation is skipped for DAGs with queued asset events but no SerializedDagModel row. * test(models): align caplog assertions with updated serialized dag warnings * test(dag): align ADRQ missing-serialized log assertion with message text * Apply suggestion from @jscheffl * chore(newsfragments): remove 64322.bugfix.rst --------- (cherry picked from commit b91394a) Co-authored-by: Leonardo Soares <leoss33@outlook.com.br> Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
vatsrahul1001 pushed a commit
that referenced
this pull request
Apr 15, 2026
…zedDagModel (#64322) (#64738) * fix(scheduler): skip asset-triggered dags without SerializedDagModel in dags_needing_dagruns Remove those dag_ids from the in-memory candidate set until serialization exists; retain AssetDagRunQueue rows and emit DEBUG logs. Add unit tests and a bugfix newsfragment. * fix(scheduler): prevent premature asset-triggered DagRuns when SerializedDagModel is unavailable * test(dag): persist DagModel before AssetDagRunQueue in unit tests Split DagModel and AssetDagRunQueue inserts and flush after DagModel so foreign-key order matches production DB constraints in TestDagModel. * Apply suggestions from code review * refactor(dag): clarify ADRQ skip log and condense serialized-DAG guard Combine the missing-from-serialized set check with a walrus assignment and improve the debug message when DagRun creation is skipped for DAGs with queued asset events but no SerializedDagModel row. * test(models): align caplog assertions with updated serialized dag warnings * test(dag): align ADRQ missing-serialized log assertion with message text * Apply suggestion from @jscheffl * chore(newsfragments): remove 64322.bugfix.rst --------- (cherry picked from commit b91394a) Co-authored-by: Leonardo Soares <leoss33@outlook.com.br> Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
vatsrahul1001 pushed a commit
that referenced
this pull request
Apr 15, 2026
…zedDagModel (#64322) (#64738) * fix(scheduler): skip asset-triggered dags without SerializedDagModel in dags_needing_dagruns Remove those dag_ids from the in-memory candidate set until serialization exists; retain AssetDagRunQueue rows and emit DEBUG logs. Add unit tests and a bugfix newsfragment. * fix(scheduler): prevent premature asset-triggered DagRuns when SerializedDagModel is unavailable * test(dag): persist DagModel before AssetDagRunQueue in unit tests Split DagModel and AssetDagRunQueue inserts and flush after DagModel so foreign-key order matches production DB constraints in TestDagModel. * Apply suggestions from code review * refactor(dag): clarify ADRQ skip log and condense serialized-DAG guard Combine the missing-from-serialized set check with a walrus assignment and improve the debug message when DagRun creation is skipped for DAGs with queued asset events but no SerializedDagModel row. * test(models): align caplog assertions with updated serialized dag warnings * test(dag): align ADRQ missing-serialized log assertion with message text * Apply suggestion from @jscheffl * chore(newsfragments): remove 64322.bugfix.rst --------- (cherry picked from commit b91394a) Co-authored-by: Leonardo Soares <leoss33@outlook.com.br> Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
vatsrahul1001 pushed a commit
that referenced
this pull request
Apr 15, 2026
…zedDagModel (#64322) (#64738) * fix(scheduler): skip asset-triggered dags without SerializedDagModel in dags_needing_dagruns Remove those dag_ids from the in-memory candidate set until serialization exists; retain AssetDagRunQueue rows and emit DEBUG logs. Add unit tests and a bugfix newsfragment. * fix(scheduler): prevent premature asset-triggered DagRuns when SerializedDagModel is unavailable * test(dag): persist DagModel before AssetDagRunQueue in unit tests Split DagModel and AssetDagRunQueue inserts and flush after DagModel so foreign-key order matches production DB constraints in TestDagModel. * Apply suggestions from code review * refactor(dag): clarify ADRQ skip log and condense serialized-DAG guard Combine the missing-from-serialized set check with a walrus assignment and improve the debug message when DagRun creation is skipped for DAGs with queued asset events but no SerializedDagModel row. * test(models): align caplog assertions with updated serialized dag warnings * test(dag): align ADRQ missing-serialized log assertion with message text * Apply suggestion from @jscheffl * chore(newsfragments): remove 64322.bugfix.rst --------- (cherry picked from commit b91394a) Co-authored-by: Leonardo Soares <leoss33@outlook.com.br> Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
vatsrahul1001 pushed a commit
that referenced
this pull request
Apr 15, 2026
…zedDagModel (#64322) (#64738) * fix(scheduler): skip asset-triggered dags without SerializedDagModel in dags_needing_dagruns Remove those dag_ids from the in-memory candidate set until serialization exists; retain AssetDagRunQueue rows and emit DEBUG logs. Add unit tests and a bugfix newsfragment. * fix(scheduler): prevent premature asset-triggered DagRuns when SerializedDagModel is unavailable * test(dag): persist DagModel before AssetDagRunQueue in unit tests Split DagModel and AssetDagRunQueue inserts and flush after DagModel so foreign-key order matches production DB constraints in TestDagModel. * Apply suggestions from code review * refactor(dag): clarify ADRQ skip log and condense serialized-DAG guard Combine the missing-from-serialized set check with a walrus assignment and improve the debug message when DagRun creation is skipped for DAGs with queued asset events but no SerializedDagModel row. * test(models): align caplog assertions with updated serialized dag warnings * test(dag): align ADRQ missing-serialized log assertion with message text * Apply suggestion from @jscheffl * chore(newsfragments): remove 64322.bugfix.rst --------- (cherry picked from commit b91394a) Co-authored-by: Leonardo Soares <leoss33@outlook.com.br> Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
53 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove those dag_ids from the in-memory candidate set until serialization
exists; retain AssetDagRunQueue rows and emit DEBUG logs. Add unit tests and
a bugfix newsfragment.
fix(scheduler): prevent premature asset-triggered DagRuns when SerializedDagModel is unavailable
test(dag): persist DagModel before AssetDagRunQueue in unit tests
Split DagModel and AssetDagRunQueue inserts and flush after DagModel so foreign-key order matches production DB constraints in TestDagModel.
Co-authored-by: Wei Lee weilee.rx@gmail.com
Combine the missing-from-serialized set check with a walrus assignment and improve the debug message when DagRun creation is skipped for DAGs with queued asset events but no SerializedDagModel row.
test(models): align caplog assertions with updated serialized dag warnings
test(dag): align ADRQ missing-serialized log assertion with message text
Apply suggestion from @jscheffl
Co-authored-by: Jens Scheffler 95105677+jscheffl@users.noreply.github.com
(cherry picked from commit b91394a)
Co-authored-by: Leonardo Soares leoss33@outlook.com.br
Co-authored-by: Wei Lee weilee.rx@gmail.com
Co-authored-by: Jens Scheffler 95105677+jscheffl@users.noreply.github.com