Enable SQLAlchemy connection pool settings for file-based SQLite - #64888

Merged
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf
Apr 17, 2026
Merged

Enable SQLAlchemy connection pool settings for file-based SQLite#64888
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf

Conversation

@jason810496

Copy link
Copy Markdown
Member

Why

SQLAlchemy 2.0+ uses QueuePool by default for file-based SQLite databases, but Airflow unconditionally skips all pool configuration (pool_size, max_overflow, pool_recycle, pool_pre_ping) for any SQLite connection — a guard that was only correct for SQLAlchemy 1.x.

What

  • Remove the blanket not SQL_ALCHEMY_CONN.startswith("sqlite") guard in prepare_engine_args and replace it with a targeted check that only skips pool settings for in-memory SQLite (sqlite://, sqlite:///:memory:), which uses SingletonThreadPool that doesn't support max_overflow.
  • File-based SQLite now receives the same pool configuration as PostgreSQL and MySQL.
  • Update the SQLAlchemy docs link from 1.4 to 2.0.
  • Add unit tests covering both cases:
    • File-based SQLite gets pool settings through configure_orm.
    • In-memory SQLite skips pool settings (tested via prepare_engine_args directly, since configure_orm rejects sqlite:///:memory: as a relative path before reaching pool logic).

@jason810496jason810496 self-assigned this Apr 8, 2026
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 0d2ec20 to 539f56bCompareApril 8, 2026 12:26
@jason810496
jason810496 marked this pull request as ready for review April 8, 2026 12:26
@jason810496
jason810496 requested a review from CopilotApril 8, 2026 12:26

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Airflow’s SQLAlchemy engine configuration so that connection pool settings are applied to file-based SQLite connections (matching SQLAlchemy 2.0+ defaults), while still skipping pool settings for in-memory SQLite connections where they are not supported.

Changes:

  • Adjust prepare_engine_args to skip pool settings only for in-memory SQLite instead of all SQLite.
  • Update the SQLAlchemy docs link to the 2.0 documentation.
  • Add unit tests to validate pool settings for file-based SQLite and skipping behavior for in-memory SQLite.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/settings.pyRefines pool-setting guard for SQLite and updates SQLAlchemy docs link.
airflow-core/tests/unit/core/test_sqlalchemy_config.pyAdds tests for file-based SQLite pooling and in-memory SQLite pool-setting skip behavior.

Comment threadairflow-core/src/airflow/settings.py Outdated
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadairflow-core/src/airflow/settings.py Outdated

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from a40d548 to 7f22ef8CompareApril 16, 2026 13:00
@jason810496
jason810496 requested a review from Lee-WApril 16, 2026 13:00
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 7f22ef8 to 2c27de6CompareApril 17, 2026 06:13
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py Outdated

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only failing static check in CI was fixed in latest main, so I will merge it.

@jason810496
jason810496 merged commit d6ba3c4 into apache:mainApr 17, 2026
75 of 76 checks passed
@github-actionsgithub-actionsBot added this to the Airflow 3.2.2 milestone Apr 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actionsBot pushed a commit that referenced this pull request Apr 17, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Apr 17, 2026
… SQLite (apache#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 23, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk pushed a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@Lee-W
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Enable SQLAlchemy connection pool settings for file-based SQLite - #64888

Merged
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf
Apr 17, 2026
Merged

Enable SQLAlchemy connection pool settings for file-based SQLite#64888
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf

Conversation

@jason810496

Copy link
Copy Markdown
Member

Why

SQLAlchemy 2.0+ uses QueuePool by default for file-based SQLite databases, but Airflow unconditionally skips all pool configuration (pool_size, max_overflow, pool_recycle, pool_pre_ping) for any SQLite connection — a guard that was only correct for SQLAlchemy 1.x.

What

  • Remove the blanket not SQL_ALCHEMY_CONN.startswith("sqlite") guard in prepare_engine_args and replace it with a targeted check that only skips pool settings for in-memory SQLite (sqlite://, sqlite:///:memory:), which uses SingletonThreadPool that doesn't support max_overflow.
  • File-based SQLite now receives the same pool configuration as PostgreSQL and MySQL.
  • Update the SQLAlchemy docs link from 1.4 to 2.0.
  • Add unit tests covering both cases:
    • File-based SQLite gets pool settings through configure_orm.
    • In-memory SQLite skips pool settings (tested via prepare_engine_args directly, since configure_orm rejects sqlite:///:memory: as a relative path before reaching pool logic).

@jason810496jason810496 self-assigned this Apr 8, 2026
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 0d2ec20 to 539f56bCompareApril 8, 2026 12:26
@jason810496
jason810496 marked this pull request as ready for review April 8, 2026 12:26
@jason810496
jason810496 requested a review from CopilotApril 8, 2026 12:26

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Airflow’s SQLAlchemy engine configuration so that connection pool settings are applied to file-based SQLite connections (matching SQLAlchemy 2.0+ defaults), while still skipping pool settings for in-memory SQLite connections where they are not supported.

Changes:

  • Adjust prepare_engine_args to skip pool settings only for in-memory SQLite instead of all SQLite.
  • Update the SQLAlchemy docs link to the 2.0 documentation.
  • Add unit tests to validate pool settings for file-based SQLite and skipping behavior for in-memory SQLite.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/settings.pyRefines pool-setting guard for SQLite and updates SQLAlchemy docs link.
airflow-core/tests/unit/core/test_sqlalchemy_config.pyAdds tests for file-based SQLite pooling and in-memory SQLite pool-setting skip behavior.

Comment threadairflow-core/src/airflow/settings.py Outdated
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadairflow-core/src/airflow/settings.py Outdated

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from a40d548 to 7f22ef8CompareApril 16, 2026 13:00
@jason810496
jason810496 requested a review from Lee-WApril 16, 2026 13:00
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 7f22ef8 to 2c27de6CompareApril 17, 2026 06:13
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py Outdated

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only failing static check in CI was fixed in latest main, so I will merge it.

@jason810496
jason810496 merged commit d6ba3c4 into apache:mainApr 17, 2026
75 of 76 checks passed
@github-actionsgithub-actionsBot added this to the Airflow 3.2.2 milestone Apr 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actionsBot pushed a commit that referenced this pull request Apr 17, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Apr 17, 2026
… SQLite (apache#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 23, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk pushed a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@Lee-W
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Enable SQLAlchemy connection pool settings for file-based SQLite - #64888

Merged
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf
Apr 17, 2026
Merged

Enable SQLAlchemy connection pool settings for file-based SQLite#64888
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf

Conversation

@jason810496

Copy link
Copy Markdown
Member

Why

SQLAlchemy 2.0+ uses QueuePool by default for file-based SQLite databases, but Airflow unconditionally skips all pool configuration (pool_size, max_overflow, pool_recycle, pool_pre_ping) for any SQLite connection — a guard that was only correct for SQLAlchemy 1.x.

What

  • Remove the blanket not SQL_ALCHEMY_CONN.startswith("sqlite") guard in prepare_engine_args and replace it with a targeted check that only skips pool settings for in-memory SQLite (sqlite://, sqlite:///:memory:), which uses SingletonThreadPool that doesn't support max_overflow.
  • File-based SQLite now receives the same pool configuration as PostgreSQL and MySQL.
  • Update the SQLAlchemy docs link from 1.4 to 2.0.
  • Add unit tests covering both cases:
    • File-based SQLite gets pool settings through configure_orm.
    • In-memory SQLite skips pool settings (tested via prepare_engine_args directly, since configure_orm rejects sqlite:///:memory: as a relative path before reaching pool logic).

@jason810496jason810496 self-assigned this Apr 8, 2026
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 0d2ec20 to 539f56bCompareApril 8, 2026 12:26
@jason810496
jason810496 marked this pull request as ready for review April 8, 2026 12:26
@jason810496
jason810496 requested a review from CopilotApril 8, 2026 12:26

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Airflow’s SQLAlchemy engine configuration so that connection pool settings are applied to file-based SQLite connections (matching SQLAlchemy 2.0+ defaults), while still skipping pool settings for in-memory SQLite connections where they are not supported.

Changes:

  • Adjust prepare_engine_args to skip pool settings only for in-memory SQLite instead of all SQLite.
  • Update the SQLAlchemy docs link to the 2.0 documentation.
  • Add unit tests to validate pool settings for file-based SQLite and skipping behavior for in-memory SQLite.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/settings.pyRefines pool-setting guard for SQLite and updates SQLAlchemy docs link.
airflow-core/tests/unit/core/test_sqlalchemy_config.pyAdds tests for file-based SQLite pooling and in-memory SQLite pool-setting skip behavior.

Comment threadairflow-core/src/airflow/settings.py Outdated
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadairflow-core/src/airflow/settings.py Outdated

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from a40d548 to 7f22ef8CompareApril 16, 2026 13:00
@jason810496
jason810496 requested a review from Lee-WApril 16, 2026 13:00
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 7f22ef8 to 2c27de6CompareApril 17, 2026 06:13
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py Outdated

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only failing static check in CI was fixed in latest main, so I will merge it.

@jason810496
jason810496 merged commit d6ba3c4 into apache:mainApr 17, 2026
75 of 76 checks passed
@github-actionsgithub-actionsBot added this to the Airflow 3.2.2 milestone Apr 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actionsBot pushed a commit that referenced this pull request Apr 17, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Apr 17, 2026
… SQLite (apache#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 23, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk pushed a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@Lee-W
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Enable SQLAlchemy connection pool settings for file-based SQLite - #64888

Merged
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf
Apr 17, 2026
Merged

Enable SQLAlchemy connection pool settings for file-based SQLite#64888
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf

Conversation

@jason810496

Copy link
Copy Markdown
Member

Why

SQLAlchemy 2.0+ uses QueuePool by default for file-based SQLite databases, but Airflow unconditionally skips all pool configuration (pool_size, max_overflow, pool_recycle, pool_pre_ping) for any SQLite connection — a guard that was only correct for SQLAlchemy 1.x.

What

  • Remove the blanket not SQL_ALCHEMY_CONN.startswith("sqlite") guard in prepare_engine_args and replace it with a targeted check that only skips pool settings for in-memory SQLite (sqlite://, sqlite:///:memory:), which uses SingletonThreadPool that doesn't support max_overflow.
  • File-based SQLite now receives the same pool configuration as PostgreSQL and MySQL.
  • Update the SQLAlchemy docs link from 1.4 to 2.0.
  • Add unit tests covering both cases:
    • File-based SQLite gets pool settings through configure_orm.
    • In-memory SQLite skips pool settings (tested via prepare_engine_args directly, since configure_orm rejects sqlite:///:memory: as a relative path before reaching pool logic).

@jason810496jason810496 self-assigned this Apr 8, 2026
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 0d2ec20 to 539f56bCompareApril 8, 2026 12:26
@jason810496
jason810496 marked this pull request as ready for review April 8, 2026 12:26
@jason810496
jason810496 requested a review from CopilotApril 8, 2026 12:26

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Airflow’s SQLAlchemy engine configuration so that connection pool settings are applied to file-based SQLite connections (matching SQLAlchemy 2.0+ defaults), while still skipping pool settings for in-memory SQLite connections where they are not supported.

Changes:

  • Adjust prepare_engine_args to skip pool settings only for in-memory SQLite instead of all SQLite.
  • Update the SQLAlchemy docs link to the 2.0 documentation.
  • Add unit tests to validate pool settings for file-based SQLite and skipping behavior for in-memory SQLite.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/settings.pyRefines pool-setting guard for SQLite and updates SQLAlchemy docs link.
airflow-core/tests/unit/core/test_sqlalchemy_config.pyAdds tests for file-based SQLite pooling and in-memory SQLite pool-setting skip behavior.

Comment threadairflow-core/src/airflow/settings.py Outdated
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadairflow-core/src/airflow/settings.py Outdated

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from a40d548 to 7f22ef8CompareApril 16, 2026 13:00
@jason810496
jason810496 requested a review from Lee-WApril 16, 2026 13:00
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 7f22ef8 to 2c27de6CompareApril 17, 2026 06:13
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py Outdated

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only failing static check in CI was fixed in latest main, so I will merge it.

@jason810496
jason810496 merged commit d6ba3c4 into apache:mainApr 17, 2026
75 of 76 checks passed
@github-actionsgithub-actionsBot added this to the Airflow 3.2.2 milestone Apr 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actionsBot pushed a commit that referenced this pull request Apr 17, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Apr 17, 2026
… SQLite (apache#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 23, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk pushed a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@Lee-W
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Enable SQLAlchemy connection pool settings for file-based SQLite - #64888

Merged
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf
Apr 17, 2026
Merged

Enable SQLAlchemy connection pool settings for file-based SQLite#64888
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf

Conversation

@jason810496

Copy link
Copy Markdown
Member

Why

SQLAlchemy 2.0+ uses QueuePool by default for file-based SQLite databases, but Airflow unconditionally skips all pool configuration (pool_size, max_overflow, pool_recycle, pool_pre_ping) for any SQLite connection — a guard that was only correct for SQLAlchemy 1.x.

What

  • Remove the blanket not SQL_ALCHEMY_CONN.startswith("sqlite") guard in prepare_engine_args and replace it with a targeted check that only skips pool settings for in-memory SQLite (sqlite://, sqlite:///:memory:), which uses SingletonThreadPool that doesn't support max_overflow.
  • File-based SQLite now receives the same pool configuration as PostgreSQL and MySQL.
  • Update the SQLAlchemy docs link from 1.4 to 2.0.
  • Add unit tests covering both cases:
    • File-based SQLite gets pool settings through configure_orm.
    • In-memory SQLite skips pool settings (tested via prepare_engine_args directly, since configure_orm rejects sqlite:///:memory: as a relative path before reaching pool logic).

@jason810496jason810496 self-assigned this Apr 8, 2026
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 0d2ec20 to 539f56bCompareApril 8, 2026 12:26
@jason810496
jason810496 marked this pull request as ready for review April 8, 2026 12:26
@jason810496
jason810496 requested a review from CopilotApril 8, 2026 12:26

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Airflow’s SQLAlchemy engine configuration so that connection pool settings are applied to file-based SQLite connections (matching SQLAlchemy 2.0+ defaults), while still skipping pool settings for in-memory SQLite connections where they are not supported.

Changes:

  • Adjust prepare_engine_args to skip pool settings only for in-memory SQLite instead of all SQLite.
  • Update the SQLAlchemy docs link to the 2.0 documentation.
  • Add unit tests to validate pool settings for file-based SQLite and skipping behavior for in-memory SQLite.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/settings.pyRefines pool-setting guard for SQLite and updates SQLAlchemy docs link.
airflow-core/tests/unit/core/test_sqlalchemy_config.pyAdds tests for file-based SQLite pooling and in-memory SQLite pool-setting skip behavior.

Comment threadairflow-core/src/airflow/settings.py Outdated
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadairflow-core/src/airflow/settings.py Outdated

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from a40d548 to 7f22ef8CompareApril 16, 2026 13:00
@jason810496
jason810496 requested a review from Lee-WApril 16, 2026 13:00
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 7f22ef8 to 2c27de6CompareApril 17, 2026 06:13
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py Outdated

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only failing static check in CI was fixed in latest main, so I will merge it.

@jason810496
jason810496 merged commit d6ba3c4 into apache:mainApr 17, 2026
75 of 76 checks passed
@github-actionsgithub-actionsBot added this to the Airflow 3.2.2 milestone Apr 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actionsBot pushed a commit that referenced this pull request Apr 17, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Apr 17, 2026
… SQLite (apache#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 23, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk pushed a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@Lee-W
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Enable SQLAlchemy connection pool settings for file-based SQLite - #64888

Merged
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf
Apr 17, 2026
Merged

Enable SQLAlchemy connection pool settings for file-based SQLite#64888
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf

Conversation

@jason810496

Copy link
Copy Markdown
Member

Why

SQLAlchemy 2.0+ uses QueuePool by default for file-based SQLite databases, but Airflow unconditionally skips all pool configuration (pool_size, max_overflow, pool_recycle, pool_pre_ping) for any SQLite connection — a guard that was only correct for SQLAlchemy 1.x.

What

  • Remove the blanket not SQL_ALCHEMY_CONN.startswith("sqlite") guard in prepare_engine_args and replace it with a targeted check that only skips pool settings for in-memory SQLite (sqlite://, sqlite:///:memory:), which uses SingletonThreadPool that doesn't support max_overflow.
  • File-based SQLite now receives the same pool configuration as PostgreSQL and MySQL.
  • Update the SQLAlchemy docs link from 1.4 to 2.0.
  • Add unit tests covering both cases:
    • File-based SQLite gets pool settings through configure_orm.
    • In-memory SQLite skips pool settings (tested via prepare_engine_args directly, since configure_orm rejects sqlite:///:memory: as a relative path before reaching pool logic).

@jason810496jason810496 self-assigned this Apr 8, 2026
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 0d2ec20 to 539f56bCompareApril 8, 2026 12:26
@jason810496
jason810496 marked this pull request as ready for review April 8, 2026 12:26
@jason810496
jason810496 requested a review from CopilotApril 8, 2026 12:26

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Airflow’s SQLAlchemy engine configuration so that connection pool settings are applied to file-based SQLite connections (matching SQLAlchemy 2.0+ defaults), while still skipping pool settings for in-memory SQLite connections where they are not supported.

Changes:

  • Adjust prepare_engine_args to skip pool settings only for in-memory SQLite instead of all SQLite.
  • Update the SQLAlchemy docs link to the 2.0 documentation.
  • Add unit tests to validate pool settings for file-based SQLite and skipping behavior for in-memory SQLite.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/settings.pyRefines pool-setting guard for SQLite and updates SQLAlchemy docs link.
airflow-core/tests/unit/core/test_sqlalchemy_config.pyAdds tests for file-based SQLite pooling and in-memory SQLite pool-setting skip behavior.

Comment threadairflow-core/src/airflow/settings.py Outdated
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadairflow-core/src/airflow/settings.py Outdated

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from a40d548 to 7f22ef8CompareApril 16, 2026 13:00
@jason810496
jason810496 requested a review from Lee-WApril 16, 2026 13:00
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 7f22ef8 to 2c27de6CompareApril 17, 2026 06:13
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py Outdated

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only failing static check in CI was fixed in latest main, so I will merge it.

@jason810496
jason810496 merged commit d6ba3c4 into apache:mainApr 17, 2026
75 of 76 checks passed
@github-actionsgithub-actionsBot added this to the Airflow 3.2.2 milestone Apr 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actionsBot pushed a commit that referenced this pull request Apr 17, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Apr 17, 2026
… SQLite (apache#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 23, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk pushed a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@Lee-W
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Enable SQLAlchemy connection pool settings for file-based SQLite - #64888

Merged
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf
Apr 17, 2026
Merged

Enable SQLAlchemy connection pool settings for file-based SQLite#64888
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf

Conversation

@jason810496

Copy link
Copy Markdown
Member

Why

SQLAlchemy 2.0+ uses QueuePool by default for file-based SQLite databases, but Airflow unconditionally skips all pool configuration (pool_size, max_overflow, pool_recycle, pool_pre_ping) for any SQLite connection — a guard that was only correct for SQLAlchemy 1.x.

What

  • Remove the blanket not SQL_ALCHEMY_CONN.startswith("sqlite") guard in prepare_engine_args and replace it with a targeted check that only skips pool settings for in-memory SQLite (sqlite://, sqlite:///:memory:), which uses SingletonThreadPool that doesn't support max_overflow.
  • File-based SQLite now receives the same pool configuration as PostgreSQL and MySQL.
  • Update the SQLAlchemy docs link from 1.4 to 2.0.
  • Add unit tests covering both cases:
    • File-based SQLite gets pool settings through configure_orm.
    • In-memory SQLite skips pool settings (tested via prepare_engine_args directly, since configure_orm rejects sqlite:///:memory: as a relative path before reaching pool logic).

@jason810496jason810496 self-assigned this Apr 8, 2026
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 0d2ec20 to 539f56bCompareApril 8, 2026 12:26
@jason810496
jason810496 marked this pull request as ready for review April 8, 2026 12:26
@jason810496
jason810496 requested a review from CopilotApril 8, 2026 12:26

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Airflow’s SQLAlchemy engine configuration so that connection pool settings are applied to file-based SQLite connections (matching SQLAlchemy 2.0+ defaults), while still skipping pool settings for in-memory SQLite connections where they are not supported.

Changes:

  • Adjust prepare_engine_args to skip pool settings only for in-memory SQLite instead of all SQLite.
  • Update the SQLAlchemy docs link to the 2.0 documentation.
  • Add unit tests to validate pool settings for file-based SQLite and skipping behavior for in-memory SQLite.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/settings.pyRefines pool-setting guard for SQLite and updates SQLAlchemy docs link.
airflow-core/tests/unit/core/test_sqlalchemy_config.pyAdds tests for file-based SQLite pooling and in-memory SQLite pool-setting skip behavior.

Comment threadairflow-core/src/airflow/settings.py Outdated
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadairflow-core/src/airflow/settings.py Outdated

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from a40d548 to 7f22ef8CompareApril 16, 2026 13:00
@jason810496
jason810496 requested a review from Lee-WApril 16, 2026 13:00
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 7f22ef8 to 2c27de6CompareApril 17, 2026 06:13
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py Outdated

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only failing static check in CI was fixed in latest main, so I will merge it.

@jason810496
jason810496 merged commit d6ba3c4 into apache:mainApr 17, 2026
75 of 76 checks passed
@github-actionsgithub-actionsBot added this to the Airflow 3.2.2 milestone Apr 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actionsBot pushed a commit that referenced this pull request Apr 17, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Apr 17, 2026
… SQLite (apache#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 23, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk pushed a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@Lee-W
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Enable SQLAlchemy connection pool settings for file-based SQLite - #64888

Merged
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf
Apr 17, 2026
Merged

Enable SQLAlchemy connection pool settings for file-based SQLite#64888
jason810496 merged 4 commits into
apache:mainfrom
jason810496:fix/sqite-sqlalchemy-pool-conf

Conversation

@jason810496

Copy link
Copy Markdown
Member

Why

SQLAlchemy 2.0+ uses QueuePool by default for file-based SQLite databases, but Airflow unconditionally skips all pool configuration (pool_size, max_overflow, pool_recycle, pool_pre_ping) for any SQLite connection — a guard that was only correct for SQLAlchemy 1.x.

What

  • Remove the blanket not SQL_ALCHEMY_CONN.startswith("sqlite") guard in prepare_engine_args and replace it with a targeted check that only skips pool settings for in-memory SQLite (sqlite://, sqlite:///:memory:), which uses SingletonThreadPool that doesn't support max_overflow.
  • File-based SQLite now receives the same pool configuration as PostgreSQL and MySQL.
  • Update the SQLAlchemy docs link from 1.4 to 2.0.
  • Add unit tests covering both cases:
    • File-based SQLite gets pool settings through configure_orm.
    • In-memory SQLite skips pool settings (tested via prepare_engine_args directly, since configure_orm rejects sqlite:///:memory: as a relative path before reaching pool logic).

@jason810496jason810496 self-assigned this Apr 8, 2026
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 0d2ec20 to 539f56bCompareApril 8, 2026 12:26
@jason810496
jason810496 marked this pull request as ready for review April 8, 2026 12:26
@jason810496
jason810496 requested a review from CopilotApril 8, 2026 12:26

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Airflow’s SQLAlchemy engine configuration so that connection pool settings are applied to file-based SQLite connections (matching SQLAlchemy 2.0+ defaults), while still skipping pool settings for in-memory SQLite connections where they are not supported.

Changes:

  • Adjust prepare_engine_args to skip pool settings only for in-memory SQLite instead of all SQLite.
  • Update the SQLAlchemy docs link to the 2.0 documentation.
  • Add unit tests to validate pool settings for file-based SQLite and skipping behavior for in-memory SQLite.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
airflow-core/src/airflow/settings.pyRefines pool-setting guard for SQLite and updates SQLAlchemy docs link.
airflow-core/tests/unit/core/test_sqlalchemy_config.pyAdds tests for file-based SQLite pooling and in-memory SQLite pool-setting skip behavior.

Comment threadairflow-core/src/airflow/settings.py Outdated
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment threadairflow-core/src/airflow/settings.py Outdated

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from a40d548 to 7f22ef8CompareApril 16, 2026 13:00
@jason810496
jason810496 requested a review from Lee-WApril 16, 2026 13:00
@jason810496
jason810496force-pushed the fix/sqite-sqlalchemy-pool-conf branch from 7f22ef8 to 2c27de6CompareApril 17, 2026 06:13
Comment threadairflow-core/tests/unit/core/test_sqlalchemy_config.py Outdated

@jason810496jason810496 left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only failing static check in CI was fixed in latest main, so I will merge it.

@jason810496
jason810496 merged commit d6ba3c4 into apache:mainApr 17, 2026
75 of 76 checks passed
@github-actionsgithub-actionsBot added this to the Airflow 3.2.2 milestone Apr 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

github-actionsBot pushed a commit that referenced this pull request Apr 17, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Apr 17, 2026
… SQLite (apache#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 23, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk pushed a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk added a commit that referenced this pull request Apr 26, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 27, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… SQLite (#64888) (#65411)
* [v3-2-test] Bump actions/github-script in the github-actions-updates group (#65150) (#65160)
Bumps the github-actions-updates group with 1 update: [actions/github-script](https://github.com/actions/github-script).
Updates `actions/github-script` from 8.0.0 to 9.0.0
- [Release notes](https://github.com/actions/github-script/releases)
- [Commits](actions/github-script@ed59741...3a2844b)
(cherry picked from commit e5a047c)
---
updated-dependencies:
- dependency-name: actions/github-script
dependency-version: 9.0.0
dependency-type: direct:production
update-type: version-update:semver-major
dependency-group: github-actions-updates
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [v3-2-test] Added breeze generate issue content for airflow-ctl (#65042) (#65241)
* Add breeze generate issue content for airflow-ctl
* add new command to doc
(cherry picked from commit b24538b)
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
* [v3-2-test] Run release calendar verification on its own schedule (#65118) (#65242)
* Move release calendar verification to its own scheduled workflow
Run dev/verify_release_calendar.py from a dedicated daily scheduled
workflow instead of as a canary job in the main CI pipeline, and
notify the #release-management Slack channel when the check fails so
the issue is surfaced to release managers directly.
* Include wiki and calendar links in release calendar Slack alert
(cherry picked from commit 048e9a1)
* [v3-2-test] Enable SQLAlchemy connection pool settings for file-based SQLite (#64888)
* Enable SQLAlchemy connection pool settings for file-based SQLite
* Fix review comments
* Fix import make_url comment
* Address Wei's final nit
(cherry picked from commit d6ba3c4)
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Justin Pakzad <114518232+justinpakzad@users.noreply.github.com>
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jason810496@Lee-W