Skip to content

[AIRFLOW-5803] Update S3Hook import paths [AIP-21] - #6535

Merged
potiuk merged 6 commits into
apache:masterfrom
mingrammer:airflow-5803
Nov 10, 2019
Merged

[AIRFLOW-5803] Update S3Hook import paths [AIP-21]#6535
potiuk merged 6 commits into
apache:masterfrom
mingrammer:airflow-5803

Conversation

@mingrammer

Copy link
Copy Markdown
Contributor

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Reopen with a new aws provider path (refer: #6465)

@codecov-io

codecov-io commented Nov 10, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6535 into master will decrease coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #6535 +/- ##
==========================================
- Coverage 84.07% 83.78% -0.29% 
==========================================
Files 636 636 Lines 36853 36853 ==========================================
- Hits 30983 30878 -105 - Misses 5870 5975 +105
Impacted FilesCoverage Δ
airflow/contrib/hooks/wasb_hook.py100% <ø> (ø)⬆️
airflow/sensors/s3_key_sensor.py100% <100%> (ø)⬆️
airflow/contrib/operators/s3_to_gcs_operator.py86.44% <100%> (ø)⬆️
airflow/sensors/s3_prefix_sensor.py100% <100%> (ø)⬆️
...rflow/contrib/operators/s3_copy_object_operator.py100% <100%> (ø)⬆️
airflow/operators/google_api_to_s3_transfer.py100% <100%> (ø)⬆️
airflow/operators/gcs_to_s3.py94.73% <100%> (ø)⬆️
airflow/operators/redshift_to_s3_operator.py97.14% <100%> (ø)⬆️
...ontrib/operators/imap_attachment_to_s3_operator.py100% <100%> (ø)⬆️
airflow/operators/s3_to_redshift_operator.py100% <100%> (ø)⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee8b927...83b8407. Read the comment docs.

@potiuk
potiuk merged commit f1b1127 into apache:masterNov 10, 2019
@potiuk

Copy link
Copy Markdown
Member

Thanks @mingrammer !

@mingrammer
mingrammer deleted the airflow-5803 branch November 10, 2019 13:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mingrammer@codecov-io@potiuk