Uh oh!
There was an error while loading. Please reload this page.
Refactor and extract shared request handler logic from supervisor _handle_request methods - #65624
Conversation
leeyspaul
commented
Apr 21, 2026
This branch is currently based on #65269 for the shared |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
leeyspaul
commented
Apr 21, 2026
This PR is currently waiting on #65269 to merge, and then we'll mark this as ready afterwards. @ferruzzi two things below that I'd like to ask for your attention on!
|
ferruzzi
commented
Apr 21, 2026
Personally I think DFP should have masked |
Will do, I'll ask in Slack. Thank you. Slack thread here: https://apache-airflow.slack.com/archives/C06K9Q5G2UA/p1776817558532799 |
ferruzzi
commented
Apr 22, 2026
Had a chat with @o-nikolas and @vincbeck this morning, their recommendation is to add the mask, but do it in its own PR so we can backport that one. |
leeyspaul
commented
Apr 22, 2026
That sounds good, I'll open up a separate PR for that one. |
leeyspaul
commented
Apr 23, 2026
Whoops, sorry, still pending merge of #65269. Converted back to draft. |
059c5e9 to
32d2ba2Compareferruzzi
commented
May 12, 2026
#65269 is merged and I think this looks good. We should be ready to merge it, I think?? |
9b22ef1 to
f9e572bCompareUh oh!
There was an error while loading. Please reload this page.
Extract shared request handling into
request_handlers.pyand reuse it in the task supervisor, triggerer, and DAG file processor.This reduces duplicated
_handle_request()logic across the subprocess supervisors and alignsGetXComhandling on the same response-normalization path.Related: #65570
Was generative AI tooling used to co-author this PR?
Generated-by: Codex, GPT-5.4
Note:
No new tests here because this was intended as a behavior-preserving refactor and the affected handler paths already have existing supervisor/processor coverage.
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.