Skip to content

run finalize when supervisor call fails - #65714

Merged
potiuk merged 1 commit into
mainfrom
run-finalizers-when-supervisor-call-fails
Apr 27, 2026
Merged

run finalize when supervisor call fails#65714
potiuk merged 1 commit into
mainfrom
run-finalizers-when-supervisor-call-fails

Conversation

@mobuchowski

@mobuchowskimobuchowski commented Apr 23, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

If the API rejects the worker's state report (e.g. returns 409 because the server already moved the TI to a terminal state, or due to other bug, like the one fixed by #65594), the resulting exception escapes run() and skips finalize(), so listeners like OpenLineage emit a START with no matching COMPLETE/FAIL. This PR wraps the terminal-state SUPERVISOR_COMMS.send(...) in run()'s finally block.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Claude Code following the guidelines

@mobuchowski
run finalize when supervisor call fails
07ece3b
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
@mobuchowski
mobuchowski marked this pull request as ready for review April 23, 2026 13:00
@mobuchowski

mobuchowski commented Apr 23, 2026

Copy link
Copy Markdown
ContributorAuthor

@ashb wdyt?

kacpermuda
kacpermuda approved these changes Apr 24, 2026
View reviewed changes

@kacpermudakacpermuda left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing that !

@potiuk
potiuk merged commit 428f133 into mainApr 27, 2026
201 of 212 checks passed
@potiuk
potiuk deleted the run-finalizers-when-supervisor-call-fails branch April 27, 2026 11:47
@github-actionsgithub-actionsBot added this to the Airflow 3.2.2 milestone Apr 27, 2026
@github-actions

github-actionsBot commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions

github-actionsBot commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
✅v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
70b44bb
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
4aa99d0
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
mobuchowski added a commit that referenced this pull request Apr 27, 2026
@github-actions@mobuchowski
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
caf9494
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
@github-actions@mobuchowski@vatsrahul1001
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
12e170d
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
@mobuchowskimobuchowski mentioned this pull request Jun 18, 2026
Merged
1 task
This was referenced Aug 3, 2026
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner
+1 more reviewer
@kacpermudakacpermudakacpermuda approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:task-sdk

Projects

None yet

Milestone

Airflow 3.2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@mobuchowski@potiuk@kacpermuda
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
run finalize when supervisor call fails by mobuchowski · Pull Request #65714 · apache/airflow · GitHub
Skip to content
run finalize when supervisor call fails - #65714
Merged
potiuk merged 1 commit into
mainfrom 
run-finalizers-when-supervisor-call-fails
Apr 27, 2026
Merged
run finalize when supervisor call fails#65714
potiuk merged 1 commit into
mainfrom 
run-finalizers-when-supervisor-call-fails
Conversation
@mobuchowski
@mobuchowskimobuchowski
commented
Apr 23, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
If the API rejects the worker's state report (e.g. returns 409 because the server already moved the TI to a terminal state, or due to other bug, like the one fixed by #65594), the resulting exception escapes run() and skips finalize(), so listeners like OpenLineage emit a START with no matching COMPLETE/FAIL. This PR wraps the terminal-state SUPERVISOR_COMMS.send(...) in run()'s finally block.
Was generative AI tooling used to co-author this PR?
  •  Yes (please specify the tool below)
Generated-by: Claude Code following the guidelines
@mobuchowski
run finalize when supervisor call fails
07ece3b
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
@mobuchowski
mobuchowski
marked this pull request as ready for review
April 23, 2026 13:00
@mobuchowski
mobuchowski
commented
Apr 23, 2026

Copy link


Copy Markdown

ContributorAuthor
@ashb wdyt?
kacpermuda
kacpermuda
approved these changes
Apr 24, 2026
View reviewed changes
@kacpermudakacpermuda
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing that !
@potiuk
potiuk
merged commit 428f133
into
mainApr 27, 2026

201 of 212 checks passed

@potiuk
potiuk
deleted the

run-finalizers-when-supervisor-call-fails

branch
April 27, 2026 11:47
@github-actionsgithub-actionsBot
added this to the Airflow 3.2.2 milestone
Apr 27, 2026
@github-actions
github-actionsBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Hi maintainer, this PR was merged without a milestone set.

We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test

If this milestone is not correct, please update it to the appropriate milestone.
This comment was generated by Milestone Tag Assistant.
@github-actions
github-actionsBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Backport successfully created: v3-2-test
Note: As of Merging PRs targeted for Airflow 3.X

the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in #release-management Slack channel.
StatusBranchResult
✅v3-2-testPR Link
github-actionsBot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
70b44bb
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
aws-airflow-bot pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
4aa99d0
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
mobuchowski added a commit
that referenced
this pull request
Apr 27, 2026
@github-actions@mobuchowski
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
caf9494
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
vatsrahul1001 pushed a commit
that referenced
this pull request
May 20, 2026
@github-actions@mobuchowski@vatsrahul1001
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
12e170d
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
@mobuchowskimobuchowski
mentioned this pull request
Jun 18, 2026
 Merged

1 task

This was referenced Aug 3, 2026

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

+1 more reviewer

@kacpermudakacpermudakacpermuda approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area:task-sdk

Projects


None yet


Milestone

Airflow 3.2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@mobuchowski@potiuk@kacpermuda

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
run finalize when supervisor call fails by mobuchowski · Pull Request #65714 · apache/airflow · GitHub
Skip to content
run finalize when supervisor call fails - #65714
Merged
potiuk merged 1 commit into
mainfrom 
run-finalizers-when-supervisor-call-fails
Apr 27, 2026
Merged
run finalize when supervisor call fails#65714
potiuk merged 1 commit into
mainfrom 
run-finalizers-when-supervisor-call-fails
Conversation
@mobuchowski
@mobuchowskimobuchowski
commented
Apr 23, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
If the API rejects the worker's state report (e.g. returns 409 because the server already moved the TI to a terminal state, or due to other bug, like the one fixed by #65594), the resulting exception escapes run() and skips finalize(), so listeners like OpenLineage emit a START with no matching COMPLETE/FAIL. This PR wraps the terminal-state SUPERVISOR_COMMS.send(...) in run()'s finally block.
Was generative AI tooling used to co-author this PR?
  •  Yes (please specify the tool below)
Generated-by: Claude Code following the guidelines
@mobuchowski
run finalize when supervisor call fails
07ece3b
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
@mobuchowski
mobuchowski
marked this pull request as ready for review
April 23, 2026 13:00
@mobuchowski
mobuchowski
commented
Apr 23, 2026

Copy link


Copy Markdown

ContributorAuthor
@ashb wdyt?
kacpermuda
kacpermuda
approved these changes
Apr 24, 2026
View reviewed changes
@kacpermudakacpermuda
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing that !
@potiuk
potiuk
merged commit 428f133
into
mainApr 27, 2026

201 of 212 checks passed

@potiuk
potiuk
deleted the

run-finalizers-when-supervisor-call-fails

branch
April 27, 2026 11:47
@github-actionsgithub-actionsBot
added this to the Airflow 3.2.2 milestone
Apr 27, 2026
@github-actions
github-actionsBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Hi maintainer, this PR was merged without a milestone set.

We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test

If this milestone is not correct, please update it to the appropriate milestone.
This comment was generated by Milestone Tag Assistant.
@github-actions
github-actionsBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Backport successfully created: v3-2-test
Note: As of Merging PRs targeted for Airflow 3.X

the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in #release-management Slack channel.
StatusBranchResult
✅v3-2-testPR Link
github-actionsBot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
70b44bb
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
aws-airflow-bot pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
4aa99d0
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
mobuchowski added a commit
that referenced
this pull request
Apr 27, 2026
@github-actions@mobuchowski
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
caf9494
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
vatsrahul1001 pushed a commit
that referenced
this pull request
May 20, 2026
@github-actions@mobuchowski@vatsrahul1001
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
12e170d
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
@mobuchowskimobuchowski
mentioned this pull request
Jun 18, 2026
 Merged

1 task

This was referenced Aug 3, 2026

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

+1 more reviewer

@kacpermudakacpermudakacpermuda approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area:task-sdk

Projects


None yet


Milestone

Airflow 3.2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@mobuchowski@potiuk@kacpermuda

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
run finalize when supervisor call fails by mobuchowski · Pull Request #65714 · apache/airflow · GitHub
Skip to content
run finalize when supervisor call fails - #65714
Merged
potiuk merged 1 commit into
mainfrom 
run-finalizers-when-supervisor-call-fails
Apr 27, 2026
Merged
run finalize when supervisor call fails#65714
potiuk merged 1 commit into
mainfrom 
run-finalizers-when-supervisor-call-fails
Conversation
@mobuchowski
@mobuchowskimobuchowski
commented
Apr 23, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
If the API rejects the worker's state report (e.g. returns 409 because the server already moved the TI to a terminal state, or due to other bug, like the one fixed by #65594), the resulting exception escapes run() and skips finalize(), so listeners like OpenLineage emit a START with no matching COMPLETE/FAIL. This PR wraps the terminal-state SUPERVISOR_COMMS.send(...) in run()'s finally block.
Was generative AI tooling used to co-author this PR?
  •  Yes (please specify the tool below)
Generated-by: Claude Code following the guidelines
@mobuchowski
run finalize when supervisor call fails
07ece3b
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
@mobuchowski
mobuchowski
marked this pull request as ready for review
April 23, 2026 13:00
@mobuchowski
mobuchowski
commented
Apr 23, 2026

Copy link


Copy Markdown

ContributorAuthor
@ashb wdyt?
kacpermuda
kacpermuda
approved these changes
Apr 24, 2026
View reviewed changes
@kacpermudakacpermuda
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing that !
@potiuk
potiuk
merged commit 428f133
into
mainApr 27, 2026

201 of 212 checks passed

@potiuk
potiuk
deleted the

run-finalizers-when-supervisor-call-fails

branch
April 27, 2026 11:47
@github-actionsgithub-actionsBot
added this to the Airflow 3.2.2 milestone
Apr 27, 2026
@github-actions
github-actionsBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Hi maintainer, this PR was merged without a milestone set.

We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test

If this milestone is not correct, please update it to the appropriate milestone.
This comment was generated by Milestone Tag Assistant.
@github-actions
github-actionsBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Backport successfully created: v3-2-test
Note: As of Merging PRs targeted for Airflow 3.X

the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in #release-management Slack channel.
StatusBranchResult
✅v3-2-testPR Link
github-actionsBot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
70b44bb
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
aws-airflow-bot pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
4aa99d0
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
mobuchowski added a commit
that referenced
this pull request
Apr 27, 2026
@github-actions@mobuchowski
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
caf9494
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
vatsrahul1001 pushed a commit
that referenced
this pull request
May 20, 2026
@github-actions@mobuchowski@vatsrahul1001
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
12e170d
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
@mobuchowskimobuchowski
mentioned this pull request
Jun 18, 2026
 Merged

1 task

This was referenced Aug 3, 2026

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

+1 more reviewer

@kacpermudakacpermudakacpermuda approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area:task-sdk

Projects


None yet


Milestone

Airflow 3.2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@mobuchowski@potiuk@kacpermuda

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
run finalize when supervisor call fails by mobuchowski · Pull Request #65714 · apache/airflow · GitHub
Skip to content
run finalize when supervisor call fails - #65714
Merged
potiuk merged 1 commit into
mainfrom 
run-finalizers-when-supervisor-call-fails
Apr 27, 2026
Merged
run finalize when supervisor call fails#65714
potiuk merged 1 commit into
mainfrom 
run-finalizers-when-supervisor-call-fails
Conversation
@mobuchowski
@mobuchowskimobuchowski
commented
Apr 23, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
If the API rejects the worker's state report (e.g. returns 409 because the server already moved the TI to a terminal state, or due to other bug, like the one fixed by #65594), the resulting exception escapes run() and skips finalize(), so listeners like OpenLineage emit a START with no matching COMPLETE/FAIL. This PR wraps the terminal-state SUPERVISOR_COMMS.send(...) in run()'s finally block.
Was generative AI tooling used to co-author this PR?
  •  Yes (please specify the tool below)
Generated-by: Claude Code following the guidelines
@mobuchowski
run finalize when supervisor call fails
07ece3b
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
@mobuchowski
mobuchowski
marked this pull request as ready for review
April 23, 2026 13:00
@mobuchowski
mobuchowski
commented
Apr 23, 2026

Copy link


Copy Markdown

ContributorAuthor
@ashb wdyt?
kacpermuda
kacpermuda
approved these changes
Apr 24, 2026
View reviewed changes
@kacpermudakacpermuda
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing that !
@potiuk
potiuk
merged commit 428f133
into
mainApr 27, 2026

201 of 212 checks passed

@potiuk
potiuk
deleted the

run-finalizers-when-supervisor-call-fails

branch
April 27, 2026 11:47
@github-actionsgithub-actionsBot
added this to the Airflow 3.2.2 milestone
Apr 27, 2026
@github-actions
github-actionsBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Hi maintainer, this PR was merged without a milestone set.

We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test

If this milestone is not correct, please update it to the appropriate milestone.
This comment was generated by Milestone Tag Assistant.
@github-actions
github-actionsBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Backport successfully created: v3-2-test
Note: As of Merging PRs targeted for Airflow 3.X

the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in #release-management Slack channel.
StatusBranchResult
✅v3-2-testPR Link
github-actionsBot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
70b44bb
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
aws-airflow-bot pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
4aa99d0
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
mobuchowski added a commit
that referenced
this pull request
Apr 27, 2026
@github-actions@mobuchowski
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
caf9494
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
vatsrahul1001 pushed a commit
that referenced
this pull request
May 20, 2026
@github-actions@mobuchowski@vatsrahul1001
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
12e170d
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
@mobuchowskimobuchowski
mentioned this pull request
Jun 18, 2026
 Merged

1 task

This was referenced Aug 3, 2026

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

+1 more reviewer

@kacpermudakacpermudakacpermuda approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area:task-sdk

Projects


None yet


Milestone

Airflow 3.2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@mobuchowski@potiuk@kacpermuda

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
run finalize when supervisor call fails by mobuchowski · Pull Request #65714 · apache/airflow · GitHub
Skip to content
run finalize when supervisor call fails - #65714
Merged
potiuk merged 1 commit into
mainfrom 
run-finalizers-when-supervisor-call-fails
Apr 27, 2026
Merged
run finalize when supervisor call fails#65714
potiuk merged 1 commit into
mainfrom 
run-finalizers-when-supervisor-call-fails
Conversation
@mobuchowski
@mobuchowskimobuchowski
commented
Apr 23, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
If the API rejects the worker's state report (e.g. returns 409 because the server already moved the TI to a terminal state, or due to other bug, like the one fixed by #65594), the resulting exception escapes run() and skips finalize(), so listeners like OpenLineage emit a START with no matching COMPLETE/FAIL. This PR wraps the terminal-state SUPERVISOR_COMMS.send(...) in run()'s finally block.
Was generative AI tooling used to co-author this PR?
  •  Yes (please specify the tool below)
Generated-by: Claude Code following the guidelines
@mobuchowski
run finalize when supervisor call fails
07ece3b
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
@mobuchowski
mobuchowski
marked this pull request as ready for review
April 23, 2026 13:00
@mobuchowski
mobuchowski
commented
Apr 23, 2026

Copy link


Copy Markdown

ContributorAuthor
@ashb wdyt?
kacpermuda
kacpermuda
approved these changes
Apr 24, 2026
View reviewed changes
@kacpermudakacpermuda
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing that !
@potiuk
potiuk
merged commit 428f133
into
mainApr 27, 2026

201 of 212 checks passed

@potiuk
potiuk
deleted the

run-finalizers-when-supervisor-call-fails

branch
April 27, 2026 11:47
@github-actionsgithub-actionsBot
added this to the Airflow 3.2.2 milestone
Apr 27, 2026
@github-actions
github-actionsBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Hi maintainer, this PR was merged without a milestone set.

We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test

If this milestone is not correct, please update it to the appropriate milestone.
This comment was generated by Milestone Tag Assistant.
@github-actions
github-actionsBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Backport successfully created: v3-2-test
Note: As of Merging PRs targeted for Airflow 3.X

the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in #release-management Slack channel.
StatusBranchResult
✅v3-2-testPR Link
github-actionsBot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
70b44bb
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
aws-airflow-bot pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
4aa99d0
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
mobuchowski added a commit
that referenced
this pull request
Apr 27, 2026
@github-actions@mobuchowski
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
caf9494
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
vatsrahul1001 pushed a commit
that referenced
this pull request
May 20, 2026
@github-actions@mobuchowski@vatsrahul1001
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
12e170d
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
@mobuchowskimobuchowski
mentioned this pull request
Jun 18, 2026
 Merged

1 task

This was referenced Aug 3, 2026

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

+1 more reviewer

@kacpermudakacpermudakacpermuda approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area:task-sdk

Projects


None yet


Milestone

Airflow 3.2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@mobuchowski@potiuk@kacpermuda

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
run finalize when supervisor call fails by mobuchowski · Pull Request #65714 · apache/airflow · GitHub
Skip to content
run finalize when supervisor call fails - #65714
Merged
potiuk merged 1 commit into
mainfrom 
run-finalizers-when-supervisor-call-fails
Apr 27, 2026
Merged
run finalize when supervisor call fails#65714
potiuk merged 1 commit into
mainfrom 
run-finalizers-when-supervisor-call-fails
Conversation
@mobuchowski
@mobuchowskimobuchowski
commented
Apr 23, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
If the API rejects the worker's state report (e.g. returns 409 because the server already moved the TI to a terminal state, or due to other bug, like the one fixed by #65594), the resulting exception escapes run() and skips finalize(), so listeners like OpenLineage emit a START with no matching COMPLETE/FAIL. This PR wraps the terminal-state SUPERVISOR_COMMS.send(...) in run()'s finally block.
Was generative AI tooling used to co-author this PR?
  •  Yes (please specify the tool below)
Generated-by: Claude Code following the guidelines
@mobuchowski
run finalize when supervisor call fails
07ece3b
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
@mobuchowski
mobuchowski
marked this pull request as ready for review
April 23, 2026 13:00
@mobuchowski
mobuchowski
commented
Apr 23, 2026

Copy link


Copy Markdown

ContributorAuthor
@ashb wdyt?
kacpermuda
kacpermuda
approved these changes
Apr 24, 2026
View reviewed changes
@kacpermudakacpermuda
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing that !
@potiuk
potiuk
merged commit 428f133
into
mainApr 27, 2026

201 of 212 checks passed

@potiuk
potiuk
deleted the

run-finalizers-when-supervisor-call-fails

branch
April 27, 2026 11:47
@github-actionsgithub-actionsBot
added this to the Airflow 3.2.2 milestone
Apr 27, 2026
@github-actions
github-actionsBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Hi maintainer, this PR was merged without a milestone set.

We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test

If this milestone is not correct, please update it to the appropriate milestone.
This comment was generated by Milestone Tag Assistant.
@github-actions
github-actionsBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Backport successfully created: v3-2-test
Note: As of Merging PRs targeted for Airflow 3.X

the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in #release-management Slack channel.
StatusBranchResult
✅v3-2-testPR Link
github-actionsBot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
70b44bb
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
aws-airflow-bot pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
4aa99d0
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
mobuchowski added a commit
that referenced
this pull request
Apr 27, 2026
@github-actions@mobuchowski
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
caf9494
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
vatsrahul1001 pushed a commit
that referenced
this pull request
May 20, 2026
@github-actions@mobuchowski@vatsrahul1001
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
12e170d
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
@mobuchowskimobuchowski
mentioned this pull request
Jun 18, 2026
 Merged

1 task

This was referenced Aug 3, 2026

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

+1 more reviewer

@kacpermudakacpermudakacpermuda approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area:task-sdk

Projects


None yet


Milestone

Airflow 3.2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@mobuchowski@potiuk@kacpermuda

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
run finalize when supervisor call fails by mobuchowski · Pull Request #65714 · apache/airflow · GitHub
Skip to content
run finalize when supervisor call fails - #65714
Merged
potiuk merged 1 commit into
mainfrom 
run-finalizers-when-supervisor-call-fails
Apr 27, 2026
Merged
run finalize when supervisor call fails#65714
potiuk merged 1 commit into
mainfrom 
run-finalizers-when-supervisor-call-fails
Conversation
@mobuchowski
@mobuchowskimobuchowski
commented
Apr 23, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
If the API rejects the worker's state report (e.g. returns 409 because the server already moved the TI to a terminal state, or due to other bug, like the one fixed by #65594), the resulting exception escapes run() and skips finalize(), so listeners like OpenLineage emit a START with no matching COMPLETE/FAIL. This PR wraps the terminal-state SUPERVISOR_COMMS.send(...) in run()'s finally block.
Was generative AI tooling used to co-author this PR?
  •  Yes (please specify the tool below)
Generated-by: Claude Code following the guidelines
@mobuchowski
run finalize when supervisor call fails
07ece3b
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
@mobuchowski
mobuchowski
marked this pull request as ready for review
April 23, 2026 13:00
@mobuchowski
mobuchowski
commented
Apr 23, 2026

Copy link


Copy Markdown

ContributorAuthor
@ashb wdyt?
kacpermuda
kacpermuda
approved these changes
Apr 24, 2026
View reviewed changes
@kacpermudakacpermuda
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing that !
@potiuk
potiuk
merged commit 428f133
into
mainApr 27, 2026

201 of 212 checks passed

@potiuk
potiuk
deleted the

run-finalizers-when-supervisor-call-fails

branch
April 27, 2026 11:47
@github-actionsgithub-actionsBot
added this to the Airflow 3.2.2 milestone
Apr 27, 2026
@github-actions
github-actionsBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Hi maintainer, this PR was merged without a milestone set.

We've automatically set the milestone to Airflow 3.2.2 based on: backport label targeting v3-2-test

If this milestone is not correct, please update it to the appropriate milestone.
This comment was generated by Milestone Tag Assistant.
@github-actions
github-actionsBot
commented
Apr 27, 2026

Copy link


Copy Markdown

Contributor
Backport successfully created: v3-2-test
Note: As of Merging PRs targeted for Airflow 3.X

the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in #release-management Slack channel.
StatusBranchResult
✅v3-2-testPR Link
github-actionsBot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
70b44bb
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
aws-airflow-bot pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 27, 2026
@mobuchowskiYour friendly bot
[v3-2-test] run finalize when supervisor call fails (apache#65714)
4aa99d0
(cherry picked from commit 428f133)
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
mobuchowski added a commit
that referenced
this pull request
Apr 27, 2026
@github-actions@mobuchowski
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
caf9494
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
vatsrahul1001 pushed a commit
that referenced
this pull request
May 20, 2026
@github-actions@mobuchowski@vatsrahul1001
[v3-2-test] run finalize when supervisor call fails (#65714) (#65946)
12e170d
(cherry picked from commit 428f133)
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Co-authored-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
@mobuchowskimobuchowski
mentioned this pull request
Jun 18, 2026
 Merged

1 task

This was referenced Aug 3, 2026

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@potiukpotiukpotiuk approved these changes
@ashbashbAwaiting requested review from ashbashb is a code owner
@kaxilkaxilAwaiting requested review from kaxilkaxil is a code owner
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajeshamoghrajesh is a code owner

+1 more reviewer

@kacpermudakacpermudakacpermuda approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

area:task-sdk

Projects


None yet


Milestone

Airflow 3.2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@mobuchowski@potiuk@kacpermuda