Fix remote_task_handler_kwargs passing handler params to RemoteLogIO by srchilukoori · Pull Request #65957 · apache/airflow

srchilukoori · 2026-04-27T14:35:08Z

remote_task_handler_kwargs has two bugs when it contains FileTaskHandler
params like max_bytes, backup_count, or delay:

TypeError at startup — all kwargs are passed to the RemoteLogIO
constructor (attrs-based), which rejects unknown params like max_bytes.
Handler params silently ignored — _handler_kwargs is reset to {}
after each RemoteLogIO construction, so handler params never reach
DEFAULT_LOGGING_CONFIG["handlers"]["task"].

PR #65412 partially fixed this by correcting the variable name used for the
handler config update, but the kwargs split was still missing.

Root cause:_handler_kwargs was being passed wholesale to both the
RemoteLogIO constructor and the handler config update, with a reset to {}
in between.

Fix: Split _handler_kwargs into _file_handler_kwargs (params belonging
to FileTaskHandler.__init__: max_bytes, backup_count, delay) and
_io_kwargs (everything else) before the provider if/elif chain. RemoteLogIO
gets _io_kwargs, handler config gets _file_handler_kwargs.

This PR continues work from #63594 and #62932, both closed for inactivity.
The approach is the same (static param set split), with reviewer feedback from
those PRs addressed here (coupling guard test, expanded test coverage).

closes: #58770

Was generative AI tooling used to co-author this PR?

Yes — Claude

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.

srchilukoori · 2026-04-29T14:12:02Z

@potiuk, @eladkal could you review this PR, please. (found you from file history)

jscheffl · 2026-04-29T22:00:38Z

@AutomationDev85 as you filed the bug, can you have a look?

Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: apache#58770

…coding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines.

jscheffl

Looks good to me, @AutomationDev85 Can you have another look?

github-actions · 2026-05-05T19:09:09Z

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	v3-2-test

…RemoteLogIO (#65957) (#66440) * Fix remote_task_handler_kwargs passing handler params to RemoteLogIO Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: #58770 * Derive FileTaskHandler params dynamically via inspect instead of hardcoding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines. * Move inspect and FileTaskHandler imports to top level --------- (cherry picked from commit 823b86e) Co-authored-by: Sadha Chilukoori <srchilukoori@gmail.com> Co-authored-by: Sadha Chilukoori <ssreddy.8555@gmail.com>

srchilukoori · 2026-04-27T14:35:08Z

remote_task_handler_kwargs has two bugs when it contains FileTaskHandler
params like max_bytes, backup_count, or delay:

TypeError at startup — all kwargs are passed to the RemoteLogIO
constructor (attrs-based), which rejects unknown params like max_bytes.
Handler params silently ignored — _handler_kwargs is reset to {}
after each RemoteLogIO construction, so handler params never reach
DEFAULT_LOGGING_CONFIG["handlers"]["task"].

PR #65412 partially fixed this by correcting the variable name used for the
handler config update, but the kwargs split was still missing.

Root cause:_handler_kwargs was being passed wholesale to both the
RemoteLogIO constructor and the handler config update, with a reset to {}
in between.

Fix: Split _handler_kwargs into _file_handler_kwargs (params belonging
to FileTaskHandler.__init__: max_bytes, backup_count, delay) and
_io_kwargs (everything else) before the provider if/elif chain. RemoteLogIO
gets _io_kwargs, handler config gets _file_handler_kwargs.

This PR continues work from #63594 and #62932, both closed for inactivity.
The approach is the same (static param set split), with reviewer feedback from
those PRs addressed here (coupling guard test, expanded test coverage).

closes: #58770

Was generative AI tooling used to co-author this PR?

Yes — Claude

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.

srchilukoori · 2026-04-29T14:12:02Z

@potiuk, @eladkal could you review this PR, please. (found you from file history)

jscheffl · 2026-04-29T22:00:38Z

@AutomationDev85 as you filed the bug, can you have a look?

Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: apache#58770

…coding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines.

jscheffl

Looks good to me, @AutomationDev85 Can you have another look?

github-actions · 2026-05-05T19:09:09Z

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	v3-2-test

…RemoteLogIO (#65957) (#66440) * Fix remote_task_handler_kwargs passing handler params to RemoteLogIO Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: #58770 * Derive FileTaskHandler params dynamically via inspect instead of hardcoding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines. * Move inspect and FileTaskHandler imports to top level --------- (cherry picked from commit 823b86e) Co-authored-by: Sadha Chilukoori <srchilukoori@gmail.com> Co-authored-by: Sadha Chilukoori <ssreddy.8555@gmail.com>

srchilukoori · 2026-04-27T14:35:08Z

remote_task_handler_kwargs has two bugs when it contains FileTaskHandler
params like max_bytes, backup_count, or delay:

TypeError at startup — all kwargs are passed to the RemoteLogIO
constructor (attrs-based), which rejects unknown params like max_bytes.
Handler params silently ignored — _handler_kwargs is reset to {}
after each RemoteLogIO construction, so handler params never reach
DEFAULT_LOGGING_CONFIG["handlers"]["task"].

PR #65412 partially fixed this by correcting the variable name used for the
handler config update, but the kwargs split was still missing.

Root cause:_handler_kwargs was being passed wholesale to both the
RemoteLogIO constructor and the handler config update, with a reset to {}
in between.

Fix: Split _handler_kwargs into _file_handler_kwargs (params belonging
to FileTaskHandler.__init__: max_bytes, backup_count, delay) and
_io_kwargs (everything else) before the provider if/elif chain. RemoteLogIO
gets _io_kwargs, handler config gets _file_handler_kwargs.

This PR continues work from #63594 and #62932, both closed for inactivity.
The approach is the same (static param set split), with reviewer feedback from
those PRs addressed here (coupling guard test, expanded test coverage).

closes: #58770

Was generative AI tooling used to co-author this PR?

Yes — Claude

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.

srchilukoori · 2026-04-29T14:12:02Z

@potiuk, @eladkal could you review this PR, please. (found you from file history)

jscheffl · 2026-04-29T22:00:38Z

@AutomationDev85 as you filed the bug, can you have a look?

Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: apache#58770

…coding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines.

jscheffl

Looks good to me, @AutomationDev85 Can you have another look?

github-actions · 2026-05-05T19:09:09Z

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	v3-2-test

…RemoteLogIO (#65957) (#66440) * Fix remote_task_handler_kwargs passing handler params to RemoteLogIO Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: #58770 * Derive FileTaskHandler params dynamically via inspect instead of hardcoding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines. * Move inspect and FileTaskHandler imports to top level --------- (cherry picked from commit 823b86e) Co-authored-by: Sadha Chilukoori <srchilukoori@gmail.com> Co-authored-by: Sadha Chilukoori <ssreddy.8555@gmail.com>

srchilukoori · 2026-04-27T14:35:08Z

remote_task_handler_kwargs has two bugs when it contains FileTaskHandler
params like max_bytes, backup_count, or delay:

TypeError at startup — all kwargs are passed to the RemoteLogIO
constructor (attrs-based), which rejects unknown params like max_bytes.
Handler params silently ignored — _handler_kwargs is reset to {}
after each RemoteLogIO construction, so handler params never reach
DEFAULT_LOGGING_CONFIG["handlers"]["task"].

PR #65412 partially fixed this by correcting the variable name used for the
handler config update, but the kwargs split was still missing.

Root cause:_handler_kwargs was being passed wholesale to both the
RemoteLogIO constructor and the handler config update, with a reset to {}
in between.

Fix: Split _handler_kwargs into _file_handler_kwargs (params belonging
to FileTaskHandler.__init__: max_bytes, backup_count, delay) and
_io_kwargs (everything else) before the provider if/elif chain. RemoteLogIO
gets _io_kwargs, handler config gets _file_handler_kwargs.

This PR continues work from #63594 and #62932, both closed for inactivity.
The approach is the same (static param set split), with reviewer feedback from
those PRs addressed here (coupling guard test, expanded test coverage).

closes: #58770

Was generative AI tooling used to co-author this PR?

Yes — Claude

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.

srchilukoori · 2026-04-29T14:12:02Z

@potiuk, @eladkal could you review this PR, please. (found you from file history)

jscheffl · 2026-04-29T22:00:38Z

@AutomationDev85 as you filed the bug, can you have a look?

Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: apache#58770

…coding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines.

jscheffl

Looks good to me, @AutomationDev85 Can you have another look?

github-actions · 2026-05-05T19:09:09Z

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	v3-2-test

…RemoteLogIO (#65957) (#66440) * Fix remote_task_handler_kwargs passing handler params to RemoteLogIO Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: #58770 * Derive FileTaskHandler params dynamically via inspect instead of hardcoding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines. * Move inspect and FileTaskHandler imports to top level --------- (cherry picked from commit 823b86e) Co-authored-by: Sadha Chilukoori <srchilukoori@gmail.com> Co-authored-by: Sadha Chilukoori <ssreddy.8555@gmail.com>

srchilukoori · 2026-04-27T14:35:08Z

remote_task_handler_kwargs has two bugs when it contains FileTaskHandler
params like max_bytes, backup_count, or delay:

TypeError at startup — all kwargs are passed to the RemoteLogIO
constructor (attrs-based), which rejects unknown params like max_bytes.
Handler params silently ignored — _handler_kwargs is reset to {}
after each RemoteLogIO construction, so handler params never reach
DEFAULT_LOGGING_CONFIG["handlers"]["task"].

PR #65412 partially fixed this by correcting the variable name used for the
handler config update, but the kwargs split was still missing.

Root cause:_handler_kwargs was being passed wholesale to both the
RemoteLogIO constructor and the handler config update, with a reset to {}
in between.

Fix: Split _handler_kwargs into _file_handler_kwargs (params belonging
to FileTaskHandler.__init__: max_bytes, backup_count, delay) and
_io_kwargs (everything else) before the provider if/elif chain. RemoteLogIO
gets _io_kwargs, handler config gets _file_handler_kwargs.

This PR continues work from #63594 and #62932, both closed for inactivity.
The approach is the same (static param set split), with reviewer feedback from
those PRs addressed here (coupling guard test, expanded test coverage).

closes: #58770

Was generative AI tooling used to co-author this PR?

Yes — Claude

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.

srchilukoori · 2026-04-29T14:12:02Z

@potiuk, @eladkal could you review this PR, please. (found you from file history)

jscheffl · 2026-04-29T22:00:38Z

@AutomationDev85 as you filed the bug, can you have a look?

Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: apache#58770

…coding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines.

jscheffl

Looks good to me, @AutomationDev85 Can you have another look?

github-actions · 2026-05-05T19:09:09Z

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	v3-2-test

…RemoteLogIO (#65957) (#66440) * Fix remote_task_handler_kwargs passing handler params to RemoteLogIO Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: #58770 * Derive FileTaskHandler params dynamically via inspect instead of hardcoding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines. * Move inspect and FileTaskHandler imports to top level --------- (cherry picked from commit 823b86e) Co-authored-by: Sadha Chilukoori <srchilukoori@gmail.com> Co-authored-by: Sadha Chilukoori <ssreddy.8555@gmail.com>

srchilukoori · 2026-04-27T14:35:08Z

remote_task_handler_kwargs has two bugs when it contains FileTaskHandler
params like max_bytes, backup_count, or delay:

TypeError at startup — all kwargs are passed to the RemoteLogIO
constructor (attrs-based), which rejects unknown params like max_bytes.
Handler params silently ignored — _handler_kwargs is reset to {}
after each RemoteLogIO construction, so handler params never reach
DEFAULT_LOGGING_CONFIG["handlers"]["task"].

PR #65412 partially fixed this by correcting the variable name used for the
handler config update, but the kwargs split was still missing.

Root cause:_handler_kwargs was being passed wholesale to both the
RemoteLogIO constructor and the handler config update, with a reset to {}
in between.

Fix: Split _handler_kwargs into _file_handler_kwargs (params belonging
to FileTaskHandler.__init__: max_bytes, backup_count, delay) and
_io_kwargs (everything else) before the provider if/elif chain. RemoteLogIO
gets _io_kwargs, handler config gets _file_handler_kwargs.

This PR continues work from #63594 and #62932, both closed for inactivity.
The approach is the same (static param set split), with reviewer feedback from
those PRs addressed here (coupling guard test, expanded test coverage).

closes: #58770

Was generative AI tooling used to co-author this PR?

Yes — Claude

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.

srchilukoori · 2026-04-29T14:12:02Z

@potiuk, @eladkal could you review this PR, please. (found you from file history)

jscheffl · 2026-04-29T22:00:38Z

@AutomationDev85 as you filed the bug, can you have a look?

Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: apache#58770

…coding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines.

jscheffl

Looks good to me, @AutomationDev85 Can you have another look?

github-actions · 2026-05-05T19:09:09Z

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	v3-2-test

…RemoteLogIO (#65957) (#66440) * Fix remote_task_handler_kwargs passing handler params to RemoteLogIO Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: #58770 * Derive FileTaskHandler params dynamically via inspect instead of hardcoding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines. * Move inspect and FileTaskHandler imports to top level --------- (cherry picked from commit 823b86e) Co-authored-by: Sadha Chilukoori <srchilukoori@gmail.com> Co-authored-by: Sadha Chilukoori <ssreddy.8555@gmail.com>

srchilukoori · 2026-04-27T14:35:08Z

remote_task_handler_kwargs has two bugs when it contains FileTaskHandler
params like max_bytes, backup_count, or delay:

TypeError at startup — all kwargs are passed to the RemoteLogIO
constructor (attrs-based), which rejects unknown params like max_bytes.
Handler params silently ignored — _handler_kwargs is reset to {}
after each RemoteLogIO construction, so handler params never reach
DEFAULT_LOGGING_CONFIG["handlers"]["task"].

PR #65412 partially fixed this by correcting the variable name used for the
handler config update, but the kwargs split was still missing.

Root cause:_handler_kwargs was being passed wholesale to both the
RemoteLogIO constructor and the handler config update, with a reset to {}
in between.

Fix: Split _handler_kwargs into _file_handler_kwargs (params belonging
to FileTaskHandler.__init__: max_bytes, backup_count, delay) and
_io_kwargs (everything else) before the provider if/elif chain. RemoteLogIO
gets _io_kwargs, handler config gets _file_handler_kwargs.

This PR continues work from #63594 and #62932, both closed for inactivity.
The approach is the same (static param set split), with reviewer feedback from
those PRs addressed here (coupling guard test, expanded test coverage).

closes: #58770

Was generative AI tooling used to co-author this PR?

Yes — Claude

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.

srchilukoori · 2026-04-29T14:12:02Z

@potiuk, @eladkal could you review this PR, please. (found you from file history)

jscheffl · 2026-04-29T22:00:38Z

@AutomationDev85 as you filed the bug, can you have a look?

Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: apache#58770

…coding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines.

jscheffl

Looks good to me, @AutomationDev85 Can you have another look?

github-actions · 2026-05-05T19:09:09Z

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	v3-2-test

…RemoteLogIO (#65957) (#66440) * Fix remote_task_handler_kwargs passing handler params to RemoteLogIO Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: #58770 * Derive FileTaskHandler params dynamically via inspect instead of hardcoding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines. * Move inspect and FileTaskHandler imports to top level --------- (cherry picked from commit 823b86e) Co-authored-by: Sadha Chilukoori <srchilukoori@gmail.com> Co-authored-by: Sadha Chilukoori <ssreddy.8555@gmail.com>

srchilukoori · 2026-04-27T14:35:08Z

remote_task_handler_kwargs has two bugs when it contains FileTaskHandler
params like max_bytes, backup_count, or delay:

TypeError at startup — all kwargs are passed to the RemoteLogIO
constructor (attrs-based), which rejects unknown params like max_bytes.
Handler params silently ignored — _handler_kwargs is reset to {}
after each RemoteLogIO construction, so handler params never reach
DEFAULT_LOGGING_CONFIG["handlers"]["task"].

PR #65412 partially fixed this by correcting the variable name used for the
handler config update, but the kwargs split was still missing.

Root cause:_handler_kwargs was being passed wholesale to both the
RemoteLogIO constructor and the handler config update, with a reset to {}
in between.

Fix: Split _handler_kwargs into _file_handler_kwargs (params belonging
to FileTaskHandler.__init__: max_bytes, backup_count, delay) and
_io_kwargs (everything else) before the provider if/elif chain. RemoteLogIO
gets _io_kwargs, handler config gets _file_handler_kwargs.

This PR continues work from #63594 and #62932, both closed for inactivity.
The approach is the same (static param set split), with reviewer feedback from
those PRs addressed here (coupling guard test, expanded test coverage).

closes: #58770

Was generative AI tooling used to co-author this PR?

Yes — Claude

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.

srchilukoori · 2026-04-29T14:12:02Z

@potiuk, @eladkal could you review this PR, please. (found you from file history)

jscheffl · 2026-04-29T22:00:38Z

@AutomationDev85 as you filed the bug, can you have a look?

Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: apache#58770

…coding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines.

jscheffl

Looks good to me, @AutomationDev85 Can you have another look?

github-actions · 2026-05-05T19:09:09Z

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
✅	v3-2-test

…RemoteLogIO (#65957) (#66440) * Fix remote_task_handler_kwargs passing handler params to RemoteLogIO Split remote_task_handler_kwargs into handler-level params (max_bytes, backup_count, delay) and IO-level params before the provider if/elif chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"], IO params go to the RemoteLogIO constructor. Previously all kwargs were passed to RemoteLogIO (causing TypeError for attrs-based classes) and then reset to {}, so handler params never reached FileTaskHandler. closes: #58770 * Derive FileTaskHandler params dynamically via inspect instead of hardcoding Address review feedback: use inspect.signature(FileTaskHandler.__init__) to determine which remote_task_handler_kwargs belong to the file handler vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines. * Move inspect and FileTaskHandler imports to top level --------- (cherry picked from commit 823b86e) Co-authored-by: Sadha Chilukoori <srchilukoori@gmail.com> Co-authored-by: Sadha Chilukoori <ssreddy.8555@gmail.com>

boring-cyborgBot added area:ConfigTemplates area:logging labels Apr 27, 2026

jscheffl added the backport-to-v3-2-test label Apr 29, 2026

jscheffl added this to the Airflow 3.2.2 milestone Apr 29, 2026

jscheffl added the type:bug-fix Changelog: Bug Fixes label Apr 29, 2026

AutomationDev85 reviewed Apr 30, 2026
View reviewed changes

Comment threadairflow-core/src/airflow/config_templates/airflow_local_settings.py Outdated
Comment threadairflow-core/src/airflow/config_templates/airflow_local_settings.py Outdated

Sadha Chilukoori added 2 commits May 2, 2026 07:12

srchilukoori force-pushed the fix/issue-58770-handler-kwargs branch from 6e1a6e5 to b426c40Compare May 2, 2026 14:13

jscheffl approved these changes May 2, 2026
View reviewed changes

AutomationDev85 reviewed May 4, 2026
View reviewed changes

Comment threadairflow-core/src/airflow/config_templates/airflow_local_settings.py Outdated
Comment threadairflow-core/src/airflow/config_templates/airflow_local_settings.py Outdated

Move inspect and FileTaskHandler imports to top level
f53c807

srchilukoori requested a review from AutomationDev85 May 5, 2026 13:43

potiuk added the ready for maintainer review Set after triaging when all criteria pass. label May 5, 2026

jscheffl approved these changes May 5, 2026
View reviewed changes

jscheffl merged commit 823b86e into apache:mainMay 5, 2026
93 checks passed

srchilukoori deleted the fix/issue-58770-handler-kwargs branch May 11, 2026 13:34