Uh oh!
There was an error while loading. Please reload this page.
Fix Monaco JSON editor loading in UI - #65990
Conversation
13a1e5b to
546a36eCompare| }, | ||
| }; | ||
| loader.config({ monaco: monaco as unknown as Monaco }); |
There was a problem hiding this comment.
Ideally we shouldn't need type-casting like this. But if its necessary then please leave a comment explaining why
There was a problem hiding this comment.
We shouldn't be changing the uv.lock
| readonly env: ImportMetaEnv; | ||
| } | ||
| declare module "monaco-editor/esm/vs/editor/editor.api.js" { |
There was a problem hiding this comment.
Let's also add a comment on why this is necessary
potiuk
commented
May 5, 2026
@shaealh — There are 3 unresolved review thread(s) on this PR from @bbovenzi. Could you either push a fix or reply in each thread explaining why the feedback doesn't apply? Once you believe the feedback is addressed, mark the thread as resolved so the reviewer isn't re-pinged needlessly. Thanks! Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
Quickest fix: git fetch upstream main && git rebase upstream/main
rm uv.lock && uv lock
git add uv.lock && git rebase --continue
git push --force-with-leaseAutomated nudge — ignore if you're not ready to rebase. This comment is updated in place on future |
bbovenzi
commented
May 13, 2026
Closing in favor of #66647 |
Fixes#65954
Configures Monaco to use bundled editor and JSON workers instead of relying on the default loader path. This prevents JSON editors/viewers from getting stuck on
Loading...in packaged Airflow UI views such as Connections and XComs.Tests:
corepack pnpm test src/utils/configureMonaco.test.tscorepack pnpm lintcorepack pnpm build