Skip to content

Bump google-cloud-aiplatform to force upgrade of litellm - #66632

Merged
jscheffl merged 2 commits into
apache:mainfrom
jscheffl:bugfix/bump-google-cloud-aiplatform-for-litellm
Jun 3, 2026
Merged

Bump google-cloud-aiplatform to force upgrade of litellm#66632
jscheffl merged 2 commits into
apache:mainfrom
jscheffl:bugfix/bump-google-cloud-aiplatform-for-litellm

Conversation

@jscheffl

@jscheffljscheffl commented May 9, 2026

Copy link
Copy Markdown
Contributor

Sine a while we carry the transitive litellm vulnerability in Dependabot. This PR attempts to bump google-cloud-aiplatform in order to ensure a non vulnerable transitive dependency is enforced.

Not sure why but as a trade we need to lower the click dependency from >=8.3.0 to >=8.1.8 - is this acceptable as a trade?

This refers to to upgrade in click by @eladkal in #61613

Let's see if CI turns green...


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@jscheffljscheffl added the full tests needed We need to run full set of tests for this PR to merge label May 9, 2026
@jscheffl
jscheffl requested a review from potiuk as a code ownerMay 9, 2026 18:34
@jscheffljscheffl added the all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs label May 9, 2026
@jscheffl
jschefflforce-pushed the bugfix/bump-google-cloud-aiplatform-for-litellm branch from c5cc4c7 to f0074afCompareMay 9, 2026 20:04
@potiuk

Copy link
Copy Markdown
Member

It is pretty strange with 8.1.8 though.. Let me take a look

@jscheffl

jscheffl commented May 9, 2026

Copy link
Copy Markdown
ContributorAuthor

It is pretty strange with 8.1.8 though.. Let me take a look

It is litellm which exactly pins this version :-(
image

--> https://github.com/BerriAI/litellm/blob/v1.83.7-stable/pyproject.toml#L32

mhm... on un-released "main" they have releaxed meanwhile... https://github.com/BerriAI/litellm/blob/litellm_internal_staging/pyproject.toml#L24 (and pin is even still existing on RC1 of 1.84)

@jscheffl
jschefflforce-pushed the bugfix/bump-google-cloud-aiplatform-for-litellm branch 3 times, most recently from 15858cd to 561815eCompareMay 10, 2026 17:17

@potiukpotiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since they are going to relax soon - It looks fine :)

@jscheffl
jschefflforce-pushed the bugfix/bump-google-cloud-aiplatform-for-litellm branch 3 times, most recently from 61eea23 to 13f5b56CompareMay 11, 2026 22:40
@jscheffl

Copy link
Copy Markdown
ContributorAuthor

Mhm, considering that litellm with less restrictive pinning of click has been released 13h ago...
image
...and we cut a providers release Monday/Tuesday I'd suggest we wait a moment until the cooldown allows to get the newest and then we do not need to downgrade click with a lot less side effecs. Will park the PR until then.

  • Wait until Cooldown of 4 days is reached on 2026-05-18 and revert click downgrade

@jscheffl
jschefflforce-pushed the bugfix/bump-google-cloud-aiplatform-for-litellm branch from b696744 to 95d0de4CompareMay 17, 2026 19:50
@jscheffl

Copy link
Copy Markdown
ContributorAuthor

Note: PR will fail in UV needs upgrading until cooldown is reached in ~24h Then needs a rebase and UV to be updated here.

@jscheffl

Copy link
Copy Markdown
ContributorAuthor

Still not working as the litellm version that is relaxing click dependency is not in the allowed range for google-cloud-aiplatform which is actually rendering the transitive dependency. Opened bug googleapis/python-aiplatform#6827 and PR googleapis/python-aiplatform#6828 in hoping the upper bound to litellm is relaxed.

@jscheffl
jschefflforce-pushed the bugfix/bump-google-cloud-aiplatform-for-litellm branch from 95d0de4 to 64d24a7CompareMay 23, 2026 18:20
@shahar1

Copy link
Copy Markdown
Contributor

Still not working as the litellm version that is relaxing click dependency is not in the allowed range for google-cloud-aiplatform which is actually rendering the transitive dependency. Opened bug googleapis/python-aiplatform#6827 and PR googleapis/python-aiplatform#6828 in hoping the upper bound to litellm is relaxed.

Please note the signing CLA is necessary to get this merged

@jscheffl

Copy link
Copy Markdown
ContributorAuthor

Still not working as the litellm version that is relaxing click dependency is not in the allowed range for google-cloud-aiplatform which is actually rendering the transitive dependency. Opened bug googleapis/python-aiplatform#6827 and PR googleapis/python-aiplatform#6828 in hoping the upper bound to litellm is relaxed.

Please note the signing CLA is necessary to get this merged

Clicked on it but looking a current CI errors seems I need to amend to have a conventional commit :-D

@jscheffl
jschefflforce-pushed the bugfix/bump-google-cloud-aiplatform-for-litellm branch from 64d24a7 to 4dced04CompareJune 3, 2026 19:31
@jscheffl

Copy link
Copy Markdown
ContributorAuthor

@shahar1@potiuk v0.155.0 with my litellm bump was released today, rebased, made a cooldown exception (I assume/hope we can trust Google release :-D) and then (finally!) we can get rid of litellm dependabot alarms!

@jscheffl
jscheffl merged commit 78039ba into apache:mainJun 3, 2026
294 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-2-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testCommit Link

You can attempt to backport this manually by running:

cherry_picker 78039ba v3-2-test

This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@jscheffl

Copy link
Copy Markdown
ContributorAuthor

Ah, would not backport, pyproject-toml changes are unrelevant for v3.2.test

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

all versionsIf set, the CI build will be forced to use all versions of Python/K8S/DBsarea:dev-toolsarea:providersfull tests neededWe need to run full set of tests for this PR to mergekind:documentationprovider:googleGoogle (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@jscheffl@potiuk@shahar1