Skip to content

Adapt GCP CloudSQL trigger to run in private cloud - #66917

Merged
shahar1 merged 1 commit into
apache:mainfrom
VladaZakharova:fix_cloudsql_private_cloud
May 15, 2026
Merged

Adapt GCP CloudSQL trigger to run in private cloud#66917
shahar1 merged 1 commit into
apache:mainfrom
VladaZakharova:fix_cloudsql_private_cloud

Conversation

@olegkachur-e

@olegkachur-eolegkachur-e commented May 14, 2026

Copy link
Copy Markdown
Contributor
  • moidfy trigger
  • slight hooks refactoring
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborgboring-cyborgBot added area:providers provider:google Google (including GCP) related issues labels May 14, 2026
@olegkachur-e
olegkachur-eforce-pushed the fix_cloudsql_private_cloud branch from 692c1f4 to 7eb215aCompareMay 14, 2026 08:27
shahar1
shahar1 requested changes May 14, 2026
View reviewed changes
Comment threadproviders/google/src/airflow/providers/google/cloud/hooks/cloud_sql.py
Comment threadproviders/google/src/airflow/providers/google/cloud/triggers/cloud_sql.py
Comment threadproviders/google/tests/unit/google/cloud/triggers/test_cloud_sql.py Outdated
Comment threadproviders/google/tests/unit/google/cloud/triggers/test_cloud_sql.py Outdated
@shahar1shahar1 mentioned this pull request May 14, 2026
Merged
1 task
@olegkachur-e
olegkachur-eforce-pushed the fix_cloudsql_private_cloud branch from 7eb215a to 0656816CompareMay 15, 2026 08:47
Oleg Kachur
Adapt GCP CloudSQL trigger to run in private cloud
d51691d
- moidfy trigger
- slight hooks refactoring
@olegkachur-e
olegkachur-eforce-pushed the fix_cloudsql_private_cloud branch from 0656816 to d51691dCompareMay 15, 2026 08:52
@olegkachur-e
olegkachur-e requested a review from shahar1May 15, 2026 08:52
@olegkachur-e

olegkachur-e commented May 15, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@shahar1 Thank you for the detailed review and serialization catch, I believe I've addressed the all the comments, please take a look.

@shahar1
shahar1 merged commit 4f47c3a into apache:mainMay 15, 2026
94 checks passed
@jscheffljscheffl mentioned this pull request May 19, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahar1shahar1shahar1 approved these changes

Assignees

No one assigned

Labels

area:providersprovider:googleGoogle (including GCP) related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olegkachur-e@shahar1