Uh oh!
There was an error while loading. Please reload this page.
[v3-2-test] Breeze: make breeze down discover and stop every compose project (#66311) - #66928
Merged
Conversation
vatsrahul1001
requested review from
amoghrajesh, ashb, bugraoz93, choo121600, ephraimbuddy, gopidesupavan, jason810496, jedcunningham, jscheffl and potiuk
as code ownersMay 14, 2026 09:55
…66311) Discovers running docker compose projects via the `com.docker.compose.project` label and brings down every one matching a known breeze prefix (`breeze`, `prek`, `docker-compose`, `docs`, `db`, `providers`, plus `breeze-`, `airflow-test`, `constraints-`, `providers-`). One `breeze down` now leaves the host clean regardless of which breeze commands, prek hooks, or CI steps were running. Two new flags: `--all-projects` also catches compose projects that don't match any known breeze prefix (off by default to avoid wiping unrelated host projects); `--project-name <name>` restricts cleanup to a single project (useful in CI). Single-use cleanup gaps fixed: - `run_command_via_breeze_shell` (used by every breeze-shell-based prek hook) now wraps the subprocess in try/finally and passes `--volumes` to the down call, so prek runs no longer leak DB volumes between hooks and KeyboardInterrupt no longer skips cleanup. - `breeze registry extract-data` and `breeze registry backfill-data` added try/finally cleanup of their unique compose projects (previously leaked `breeze-registry-*` and `breeze-backfill-*` on every invocation). - `breeze doctor` now uses the same label-based cleanup. (cherry picked from commit 2635495)
Uh oh!
There was an error while loading. Please reload this page.
vatsrahul1001 added a commit
that referenced
this pull request
May 20, 2026
…66311) (#66928) Discovers running docker compose projects via the `com.docker.compose.project` label and brings down every one matching a known breeze prefix (`breeze`, `prek`, `docker-compose`, `docs`, `db`, `providers`, plus `breeze-`, `airflow-test`, `constraints-`, `providers-`). One `breeze down` now leaves the host clean regardless of which breeze commands, prek hooks, or CI steps were running. Two new flags: `--all-projects` also catches compose projects that don't match any known breeze prefix (off by default to avoid wiping unrelated host projects); `--project-name <name>` restricts cleanup to a single project (useful in CI). Single-use cleanup gaps fixed: - `run_command_via_breeze_shell` (used by every breeze-shell-based prek hook) now wraps the subprocess in try/finally and passes `--volumes` to the down call, so prek runs no longer leak DB volumes between hooks and KeyboardInterrupt no longer skips cleanup. - `breeze registry extract-data` and `breeze registry backfill-data` added try/finally cleanup of their unique compose projects (previously leaked `breeze-registry-*` and `breeze-backfill-*` on every invocation). - `breeze doctor` now uses the same label-based cleanup. (cherry picked from commit 2635495) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001 added a commit
that referenced
this pull request
May 20, 2026
…66311) (#66928) Discovers running docker compose projects via the `com.docker.compose.project` label and brings down every one matching a known breeze prefix (`breeze`, `prek`, `docker-compose`, `docs`, `db`, `providers`, plus `breeze-`, `airflow-test`, `constraints-`, `providers-`). One `breeze down` now leaves the host clean regardless of which breeze commands, prek hooks, or CI steps were running. Two new flags: `--all-projects` also catches compose projects that don't match any known breeze prefix (off by default to avoid wiping unrelated host projects); `--project-name <name>` restricts cleanup to a single project (useful in CI). Single-use cleanup gaps fixed: - `run_command_via_breeze_shell` (used by every breeze-shell-based prek hook) now wraps the subprocess in try/finally and passes `--volumes` to the down call, so prek runs no longer leak DB volumes between hooks and KeyboardInterrupt no longer skips cleanup. - `breeze registry extract-data` and `breeze registry backfill-data` added try/finally cleanup of their unique compose projects (previously leaked `breeze-registry-*` and `breeze-backfill-*` on every invocation). - `breeze doctor` now uses the same label-based cleanup. (cherry picked from commit 2635495) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001 added a commit
that referenced
this pull request
May 21, 2026
…66311) (#66928) Discovers running docker compose projects via the `com.docker.compose.project` label and brings down every one matching a known breeze prefix (`breeze`, `prek`, `docker-compose`, `docs`, `db`, `providers`, plus `breeze-`, `airflow-test`, `constraints-`, `providers-`). One `breeze down` now leaves the host clean regardless of which breeze commands, prek hooks, or CI steps were running. Two new flags: `--all-projects` also catches compose projects that don't match any known breeze prefix (off by default to avoid wiping unrelated host projects); `--project-name <name>` restricts cleanup to a single project (useful in CI). Single-use cleanup gaps fixed: - `run_command_via_breeze_shell` (used by every breeze-shell-based prek hook) now wraps the subprocess in try/finally and passes `--volumes` to the down call, so prek runs no longer leak DB volumes between hooks and KeyboardInterrupt no longer skips cleanup. - `breeze registry extract-data` and `breeze registry backfill-data` added try/finally cleanup of their unique compose projects (previously leaked `breeze-registry-*` and `breeze-backfill-*` on every invocation). - `breeze doctor` now uses the same label-based cleanup. (cherry picked from commit 2635495) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #66311
needs #66927 to be merged first
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines