Skip to content

Serialize poll_interval and impersonation_chain on DataFusionStartPipelineTrigger - #66968

Merged
shahar1 merged 1 commit into
apache:mainfrom
Nishieee:fix/google-datafusion-trigger-serialize-init-params
May 15, 2026
Merged

Serialize poll_interval and impersonation_chain on DataFusionStartPipelineTrigger#66968
shahar1 merged 1 commit into
apache:mainfrom
Nishieee:fix/google-datafusion-trigger-serialize-init-params

Conversation

@Nishieee

@NishieeeNishieee commented May 14, 2026

Copy link
Copy Markdown
Contributor

DataFusionStartPipelineTrigger stored poll_interval and impersonation_chain but omitted them from serialize(), so the triggerer could lose those values after restart or handoff. Include both in the serialized kwargs, update the serialization unit test, and add a round-trip test for non-default values.

related: #66961


Was generative AI tooling used to co-author this PR?
  • Yes — Cursor

Generated-by: Cursor following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions.

@Nishieee
Nishieee requested a review from shahar1 as a code ownerMay 14, 2026 20:08
@boring-cyborgboring-cyborgBot added area:providers provider:google Google (including GCP) related issues labels May 14, 2026
@NishieeeNishieee changed the title Serialize poll_interval and impersonation_chain on DataFusionStartPip…Serialize poll_interval and impersonation_chain on DataFusionStartPipelineTriggerMay 14, 2026
@choo121600choo121600 added the ready for maintainer review Set after triaging when all criteria pass. label May 15, 2026
@shahar1
shahar1 merged commit 775b7e4 into apache:mainMay 15, 2026
94 checks passed
@boring-cyborg

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providersprovider:googleGoogle (including GCP) related issuesready for maintainer reviewSet after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Nishieee@shahar1@choo121600