Skip to content

Enable ruff PLE1205 to catch logging calls with too many arguments#66978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahar1 merged 3 commits into from
May 15, 2026
Merged

Enable ruff PLE1205 to catch logging calls with too many arguments #66978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b540d0
Enable ruff PLE1205 and fix 12 logging calls with too many arguments
shahar1 May 15, 2026
9ce0d72
Update providers/google/src/airflow/providers/google/suite/hooks/driv…
shahar1 May 15, 2026
4fa39e5
Fix log.exception
shahar1 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/utils/log/file_task_handler.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -855,7 +855,7 @@ def _init_file(self, ti, *, identifier: str | None = None):
try:
os.chmod(full_path, new_file_permissions)
except OSError as e:
logger.warning("OSError while changing ownership of the log file. ", e)
logger.warning("OSError while changing ownership of the log file. %s", e)

return full_path

Expand Down
5 changes: 1 addition & 4 deletions providers/amazon/src/airflow/providers/amazon/aws/operators/redshift_data.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -120,10 +120,7 @@ def __init__(
if poll_interval > 0:
self.poll_interval = poll_interval
else:
self.log.warning(
"Invalid poll_interval:",
poll_interval,
)
self.log.warning("Invalid poll_interval: %s", poll_interval)
self.return_sql_result = return_sql_result
self.deferrable = deferrable
self.session_id = session_id
Expand Down
6 changes: 1 addition & 5 deletions providers/amazon/src/airflow/providers/amazon/aws/sensors/ssm.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -108,11 +108,7 @@ def poke(self, context: Context):
command_invocations = response.get("CommandInvocations", [])

if not command_invocations:
self.log.info(
"No command invocations found",
"command_id=%s yet, waiting...",
self.command_id,
Comment thread
shahar1 marked this conversation as resolved.
)
self.log.info("No command invocations found, command_id=%s yet, waiting...", self.command_id)
return False

for invocation in command_invocations:
Expand Down
4 changes: 2 additions & 2 deletions providers/amazon/src/airflow/providers/amazon/aws/utils/task_log_fetcher.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
)
except ClientError as error:
if error.response["Error"]["Code"] != "ResourceNotFoundException":
self.logger.warning("Error on retrieving Cloudwatch log events", error)
self.logger.warning("Error on retrieving Cloudwatch log events: %s", error)
else:
self.logger.info(
"Cannot find log stream yet, it can take a couple of seconds to show up. "
Expand All@@ -95,7 +95,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
)
yield from ()
except ConnectionClosedError as error:
self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events", error)
self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events: %s", error)
yield from ()

@staticmethod
Expand Down
4 changes: 2 additions & 2 deletions providers/google/src/airflow/providers/google/cloud/operators/compute.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1042,7 +1042,7 @@ def execute(self, context: Context) -> dict:
request_id=self.request_id,
project_id=self.project_id,
)
self.log.info("The specified Instance Template has been created SUCCESSFULLY", self.body)
self.log.info("The specified Instance Template has been created SUCCESSFULLY: %s", self.body)
new_template = hook.get_instance_template(
resource_id=self.resource_id,
project_id=self.project_id,
Expand DownExpand Up@@ -1611,7 +1611,7 @@ def execute(self, context: Context) -> dict:
project_id=self.project_id,
zone=self.zone,
)
self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY", self.body)
self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY: %s", self.body)
new_instance_group_manager = hook.get_instance_group_manager(
resource_id=self.resource_id,
project_id=self.project_id,
Expand Down
2 changes: 1 addition & 1 deletion providers/google/src/airflow/providers/google/suite/hooks/drive.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -304,7 +304,7 @@ def upload_file(
try:
upload_location = self._resolve_file_path(folder_id)
except GoogleApiClientError as e:
self.log.warning("A problem has been encountered when trying to resolve file path: ", e)
self.log.exception("A problem has been encountered when trying to resolve file path: %s", e)

if show_full_target_path:
self.log.info("File %s uploaded to gdrive://%s.", local_location, upload_location)
Expand Down
2 changes: 1 addition & 1 deletion providers/google/tests/system/google/cloud/gcs/example_gcs_to_gdrive.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -170,7 +170,7 @@ def remove_files_from_drive():
if files := root_path["files"]:
batch = service.new_batch_http_request()
for file in files:
log.info("Preparing to remove file: {}", file)
log.info("Preparing to remove file: %s", file)
batch.add(service.files().delete(fileId=file["id"]))
batch.execute()
log.info("Selected files removed.")
Expand Down
2 changes: 1 addition & 1 deletion providers/google/tests/system/google/cloud/gcs/example_gdrive_to_gcs.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -136,7 +136,7 @@ def remove_files_from_drive():
response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
if files := response["files"]:
file = files[0]
log.info("Deleting file {}...", file)
log.info("Deleting file %s...", file)
service.files().delete(fileId=file["id"])
log.info("Done.")

Expand Down
2 changes: 1 addition & 1 deletion providers/google/tests/system/google/cloud/transfers/example_gdrive_to_local.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ def remove_file_from_drive():
response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
if files := response["files"]:
file = files[0]
log.info("Deleting file {}...", file)
log.info("Deleting file %s...", file)
service.files().delete(fileId=file["id"])
log.info("Done.")

Expand Down
2 changes: 1 addition & 1 deletion providers/google/tests/system/google/suite/example_local_to_drive.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ def remove_files_from_drive():
if files := root_path["files"]:
batch = service.new_batch_http_request()
for file in files:
log.info("Preparing to remove file: {}", file)
log.info("Preparing to remove file: %s", file)
batch.add(service.files().delete(fileId=file["id"]))
batch.execute()
log.info("Selected files removed.")
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -628,6 +628,7 @@ extend-select = [
"PLW2101", # Threading lock directly created in with statement has no effect
"PLW2901", # Outer {outer_kind} variable {name} overwritten by inner {inner_kind} target
"PLW3301", # Nested {func} calls can be flattened
"PLE1205", # Logging format string has too many arguments (extra args are silently dropped)
# Per rule enables
"RUF006", # Checks for asyncio dangling task
"RUF015", # Checks for unnecessary iterable allocation for first element
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Enable ruff PLE1205 to catch logging calls with too many arguments by shahar1 · Pull Request #66978 · apache/airflow · GitHub
Skip to content
Enable ruff PLE1205 to catch logging calls with too many arguments#66978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

shahar1
merged 3 commits into

from

May 15, 2026
 Merged


Enable ruff PLE1205 to catch logging calls with too many arguments
#66978
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
5b540d0

Enable ruff PLE1205 and fix 12 logging calls with too many arguments


shahar1 May 15, 2026
9ce0d72

Update providers/google/src/airflow/providers/google/suite/hooks/driv…


shahar1 May 15, 2026
4fa39e5

Fix log.exception


shahar1 May 15, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
airflow-core/src/airflow/utils/log/file_task_handler.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -855,7 +855,7 @@ def _init_file(self, ti, *, identifier: str | None = None):
 try:
 os.chmod(full_path, new_file_permissions)
 except OSError as e:
 logger.warning("OSError while changing ownership of the log file. ", e)
 logger.warning("OSError while changing ownership of the log file. %s", e)

 return full_path

Expand Down

5 changes: 1 addition & 4 deletions
providers/amazon/src/airflow/providers/amazon/aws/operators/redshift_data.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,10 +120,7 @@ def __init__(
 if poll_interval > 0:
 self.poll_interval = poll_interval
 else:
 self.log.warning(
 "Invalid poll_interval:",
 poll_interval,
 )
 self.log.warning("Invalid poll_interval: %s", poll_interval)
 self.return_sql_result = return_sql_result
 self.deferrable = deferrable
 self.session_id = session_id
Expand Down

6 changes: 1 addition & 5 deletions
providers/amazon/src/airflow/providers/amazon/aws/sensors/ssm.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -108,11 +108,7 @@ def poke(self, context: Context):
 command_invocations = response.get("CommandInvocations", [])

 if not command_invocations:
 self.log.info(
 "No command invocations found",
 "command_id=%s yet, waiting...",
 self.command_id,
Comment thread
shahar1 marked this conversation as resolved.

 )
 self.log.info("No command invocations found, command_id=%s yet, waiting...", self.command_id)
 return False

 for invocation in command_invocations:
Expand Down

4 changes: 2 additions & 2 deletions
providers/amazon/src/airflow/providers/amazon/aws/utils/task_log_fetcher.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
 )
 except ClientError as error:
 if error.response["Error"]["Code"] != "ResourceNotFoundException":
 self.logger.warning("Error on retrieving Cloudwatch log events", error)
 self.logger.warning("Error on retrieving Cloudwatch log events: %s", error)
 else:
 self.logger.info(
 "Cannot find log stream yet, it can take a couple of seconds to show up. "
Expand All@@ -95,7 +95,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
 )
 yield from ()
 except ConnectionClosedError as error:
 self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events", error)
 self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events: %s", error)
 yield from ()

 @staticmethod
Expand Down

4 changes: 2 additions & 2 deletions
providers/google/src/airflow/providers/google/cloud/operators/compute.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1042,7 +1042,7 @@ def execute(self, context: Context) -> dict:
 request_id=self.request_id,
 project_id=self.project_id,
 )
 self.log.info("The specified Instance Template has been created SUCCESSFULLY", self.body)
 self.log.info("The specified Instance Template has been created SUCCESSFULLY: %s", self.body)
 new_template = hook.get_instance_template(
 resource_id=self.resource_id,
 project_id=self.project_id,
Expand DownExpand Up@@ -1611,7 +1611,7 @@ def execute(self, context: Context) -> dict:
 project_id=self.project_id,
 zone=self.zone,
 )
 self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY", self.body)
 self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY: %s", self.body)
 new_instance_group_manager = hook.get_instance_group_manager(
 resource_id=self.resource_id,
 project_id=self.project_id,
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/src/airflow/providers/google/suite/hooks/drive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -304,7 +304,7 @@ def upload_file(
 try:
 upload_location = self._resolve_file_path(folder_id)
 except GoogleApiClientError as e:
 self.log.warning("A problem has been encountered when trying to resolve file path: ", e)
 self.log.exception("A problem has been encountered when trying to resolve file path: %s", e)

 if show_full_target_path:
 self.log.info("File %s uploaded to gdrive://%s.", local_location, upload_location)
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/gcs/example_gcs_to_gdrive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -170,7 +170,7 @@ def remove_files_from_drive():
 if files := root_path["files"]:
 batch = service.new_batch_http_request()
 for file in files:
 log.info("Preparing to remove file: {}", file)
 log.info("Preparing to remove file: %s", file)
 batch.add(service.files().delete(fileId=file["id"]))
 batch.execute()
 log.info("Selected files removed.")
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/gcs/example_gdrive_to_gcs.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -136,7 +136,7 @@ def remove_files_from_drive():
 response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
 if files := response["files"]:
 file = files[0]
 log.info("Deleting file {}...", file)
 log.info("Deleting file %s...", file)
 service.files().delete(fileId=file["id"])
 log.info("Done.")

Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/transfers/example_gdrive_to_local.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ def remove_file_from_drive():
 response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
 if files := response["files"]:
 file = files[0]
 log.info("Deleting file {}...", file)
 log.info("Deleting file %s...", file)
 service.files().delete(fileId=file["id"])
 log.info("Done.")

Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/suite/example_local_to_drive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ def remove_files_from_drive():
 if files := root_path["files"]:
 batch = service.new_batch_http_request()
 for file in files:
 log.info("Preparing to remove file: {}", file)
 log.info("Preparing to remove file: %s", file)
 batch.add(service.files().delete(fileId=file["id"]))
 batch.execute()
 log.info("Selected files removed.")
Expand Down

1 change: 1 addition & 0 deletions
pyproject.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -628,6 +628,7 @@ extend-select = [
 "PLW2101", # Threading lock directly created in with statement has no effect
 "PLW2901", # Outer {outer_kind} variable {name} overwritten by inner {inner_kind} target
 "PLW3301", # Nested {func} calls can be flattened
 "PLE1205", # Logging format string has too many arguments (extra args are silently dropped)
 # Per rule enables
 "RUF006", # Checks for asyncio dangling task
 "RUF015", # Checks for unnecessary iterable allocation for first element
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable ruff PLE1205 to catch logging calls with too many arguments by shahar1 · Pull Request #66978 · apache/airflow · GitHub
Skip to content
Enable ruff PLE1205 to catch logging calls with too many arguments#66978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

shahar1
merged 3 commits into

from

May 15, 2026
 Merged


Enable ruff PLE1205 to catch logging calls with too many arguments
#66978
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
5b540d0

Enable ruff PLE1205 and fix 12 logging calls with too many arguments


shahar1 May 15, 2026
9ce0d72

Update providers/google/src/airflow/providers/google/suite/hooks/driv…


shahar1 May 15, 2026
4fa39e5

Fix log.exception


shahar1 May 15, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
airflow-core/src/airflow/utils/log/file_task_handler.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -855,7 +855,7 @@ def _init_file(self, ti, *, identifier: str | None = None):
 try:
 os.chmod(full_path, new_file_permissions)
 except OSError as e:
 logger.warning("OSError while changing ownership of the log file. ", e)
 logger.warning("OSError while changing ownership of the log file. %s", e)

 return full_path

Expand Down

5 changes: 1 addition & 4 deletions
providers/amazon/src/airflow/providers/amazon/aws/operators/redshift_data.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,10 +120,7 @@ def __init__(
 if poll_interval > 0:
 self.poll_interval = poll_interval
 else:
 self.log.warning(
 "Invalid poll_interval:",
 poll_interval,
 )
 self.log.warning("Invalid poll_interval: %s", poll_interval)
 self.return_sql_result = return_sql_result
 self.deferrable = deferrable
 self.session_id = session_id
Expand Down

6 changes: 1 addition & 5 deletions
providers/amazon/src/airflow/providers/amazon/aws/sensors/ssm.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -108,11 +108,7 @@ def poke(self, context: Context):
 command_invocations = response.get("CommandInvocations", [])

 if not command_invocations:
 self.log.info(
 "No command invocations found",
 "command_id=%s yet, waiting...",
 self.command_id,
Comment thread
shahar1 marked this conversation as resolved.

 )
 self.log.info("No command invocations found, command_id=%s yet, waiting...", self.command_id)
 return False

 for invocation in command_invocations:
Expand Down

4 changes: 2 additions & 2 deletions
providers/amazon/src/airflow/providers/amazon/aws/utils/task_log_fetcher.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
 )
 except ClientError as error:
 if error.response["Error"]["Code"] != "ResourceNotFoundException":
 self.logger.warning("Error on retrieving Cloudwatch log events", error)
 self.logger.warning("Error on retrieving Cloudwatch log events: %s", error)
 else:
 self.logger.info(
 "Cannot find log stream yet, it can take a couple of seconds to show up. "
Expand All@@ -95,7 +95,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
 )
 yield from ()
 except ConnectionClosedError as error:
 self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events", error)
 self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events: %s", error)
 yield from ()

 @staticmethod
Expand Down

4 changes: 2 additions & 2 deletions
providers/google/src/airflow/providers/google/cloud/operators/compute.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1042,7 +1042,7 @@ def execute(self, context: Context) -> dict:
 request_id=self.request_id,
 project_id=self.project_id,
 )
 self.log.info("The specified Instance Template has been created SUCCESSFULLY", self.body)
 self.log.info("The specified Instance Template has been created SUCCESSFULLY: %s", self.body)
 new_template = hook.get_instance_template(
 resource_id=self.resource_id,
 project_id=self.project_id,
Expand DownExpand Up@@ -1611,7 +1611,7 @@ def execute(self, context: Context) -> dict:
 project_id=self.project_id,
 zone=self.zone,
 )
 self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY", self.body)
 self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY: %s", self.body)
 new_instance_group_manager = hook.get_instance_group_manager(
 resource_id=self.resource_id,
 project_id=self.project_id,
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/src/airflow/providers/google/suite/hooks/drive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -304,7 +304,7 @@ def upload_file(
 try:
 upload_location = self._resolve_file_path(folder_id)
 except GoogleApiClientError as e:
 self.log.warning("A problem has been encountered when trying to resolve file path: ", e)
 self.log.exception("A problem has been encountered when trying to resolve file path: %s", e)

 if show_full_target_path:
 self.log.info("File %s uploaded to gdrive://%s.", local_location, upload_location)
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/gcs/example_gcs_to_gdrive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -170,7 +170,7 @@ def remove_files_from_drive():
 if files := root_path["files"]:
 batch = service.new_batch_http_request()
 for file in files:
 log.info("Preparing to remove file: {}", file)
 log.info("Preparing to remove file: %s", file)
 batch.add(service.files().delete(fileId=file["id"]))
 batch.execute()
 log.info("Selected files removed.")
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/gcs/example_gdrive_to_gcs.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -136,7 +136,7 @@ def remove_files_from_drive():
 response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
 if files := response["files"]:
 file = files[0]
 log.info("Deleting file {}...", file)
 log.info("Deleting file %s...", file)
 service.files().delete(fileId=file["id"])
 log.info("Done.")

Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/transfers/example_gdrive_to_local.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ def remove_file_from_drive():
 response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
 if files := response["files"]:
 file = files[0]
 log.info("Deleting file {}...", file)
 log.info("Deleting file %s...", file)
 service.files().delete(fileId=file["id"])
 log.info("Done.")

Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/suite/example_local_to_drive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ def remove_files_from_drive():
 if files := root_path["files"]:
 batch = service.new_batch_http_request()
 for file in files:
 log.info("Preparing to remove file: {}", file)
 log.info("Preparing to remove file: %s", file)
 batch.add(service.files().delete(fileId=file["id"]))
 batch.execute()
 log.info("Selected files removed.")
Expand Down

1 change: 1 addition & 0 deletions
pyproject.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -628,6 +628,7 @@ extend-select = [
 "PLW2101", # Threading lock directly created in with statement has no effect
 "PLW2901", # Outer {outer_kind} variable {name} overwritten by inner {inner_kind} target
 "PLW3301", # Nested {func} calls can be flattened
 "PLE1205", # Logging format string has too many arguments (extra args are silently dropped)
 # Per rule enables
 "RUF006", # Checks for asyncio dangling task
 "RUF015", # Checks for unnecessary iterable allocation for first element
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable ruff PLE1205 to catch logging calls with too many arguments by shahar1 · Pull Request #66978 · apache/airflow · GitHub
Skip to content
Enable ruff PLE1205 to catch logging calls with too many arguments#66978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

shahar1
merged 3 commits into

from

May 15, 2026
 Merged


Enable ruff PLE1205 to catch logging calls with too many arguments
#66978
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
5b540d0

Enable ruff PLE1205 and fix 12 logging calls with too many arguments


shahar1 May 15, 2026
9ce0d72

Update providers/google/src/airflow/providers/google/suite/hooks/driv…


shahar1 May 15, 2026
4fa39e5

Fix log.exception


shahar1 May 15, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
airflow-core/src/airflow/utils/log/file_task_handler.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -855,7 +855,7 @@ def _init_file(self, ti, *, identifier: str | None = None):
 try:
 os.chmod(full_path, new_file_permissions)
 except OSError as e:
 logger.warning("OSError while changing ownership of the log file. ", e)
 logger.warning("OSError while changing ownership of the log file. %s", e)

 return full_path

Expand Down

5 changes: 1 addition & 4 deletions
providers/amazon/src/airflow/providers/amazon/aws/operators/redshift_data.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,10 +120,7 @@ def __init__(
 if poll_interval > 0:
 self.poll_interval = poll_interval
 else:
 self.log.warning(
 "Invalid poll_interval:",
 poll_interval,
 )
 self.log.warning("Invalid poll_interval: %s", poll_interval)
 self.return_sql_result = return_sql_result
 self.deferrable = deferrable
 self.session_id = session_id
Expand Down

6 changes: 1 addition & 5 deletions
providers/amazon/src/airflow/providers/amazon/aws/sensors/ssm.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -108,11 +108,7 @@ def poke(self, context: Context):
 command_invocations = response.get("CommandInvocations", [])

 if not command_invocations:
 self.log.info(
 "No command invocations found",
 "command_id=%s yet, waiting...",
 self.command_id,
Comment thread
shahar1 marked this conversation as resolved.

 )
 self.log.info("No command invocations found, command_id=%s yet, waiting...", self.command_id)
 return False

 for invocation in command_invocations:
Expand Down

4 changes: 2 additions & 2 deletions
providers/amazon/src/airflow/providers/amazon/aws/utils/task_log_fetcher.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
 )
 except ClientError as error:
 if error.response["Error"]["Code"] != "ResourceNotFoundException":
 self.logger.warning("Error on retrieving Cloudwatch log events", error)
 self.logger.warning("Error on retrieving Cloudwatch log events: %s", error)
 else:
 self.logger.info(
 "Cannot find log stream yet, it can take a couple of seconds to show up. "
Expand All@@ -95,7 +95,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
 )
 yield from ()
 except ConnectionClosedError as error:
 self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events", error)
 self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events: %s", error)
 yield from ()

 @staticmethod
Expand Down

4 changes: 2 additions & 2 deletions
providers/google/src/airflow/providers/google/cloud/operators/compute.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1042,7 +1042,7 @@ def execute(self, context: Context) -> dict:
 request_id=self.request_id,
 project_id=self.project_id,
 )
 self.log.info("The specified Instance Template has been created SUCCESSFULLY", self.body)
 self.log.info("The specified Instance Template has been created SUCCESSFULLY: %s", self.body)
 new_template = hook.get_instance_template(
 resource_id=self.resource_id,
 project_id=self.project_id,
Expand DownExpand Up@@ -1611,7 +1611,7 @@ def execute(self, context: Context) -> dict:
 project_id=self.project_id,
 zone=self.zone,
 )
 self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY", self.body)
 self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY: %s", self.body)
 new_instance_group_manager = hook.get_instance_group_manager(
 resource_id=self.resource_id,
 project_id=self.project_id,
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/src/airflow/providers/google/suite/hooks/drive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -304,7 +304,7 @@ def upload_file(
 try:
 upload_location = self._resolve_file_path(folder_id)
 except GoogleApiClientError as e:
 self.log.warning("A problem has been encountered when trying to resolve file path: ", e)
 self.log.exception("A problem has been encountered when trying to resolve file path: %s", e)

 if show_full_target_path:
 self.log.info("File %s uploaded to gdrive://%s.", local_location, upload_location)
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/gcs/example_gcs_to_gdrive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -170,7 +170,7 @@ def remove_files_from_drive():
 if files := root_path["files"]:
 batch = service.new_batch_http_request()
 for file in files:
 log.info("Preparing to remove file: {}", file)
 log.info("Preparing to remove file: %s", file)
 batch.add(service.files().delete(fileId=file["id"]))
 batch.execute()
 log.info("Selected files removed.")
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/gcs/example_gdrive_to_gcs.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -136,7 +136,7 @@ def remove_files_from_drive():
 response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
 if files := response["files"]:
 file = files[0]
 log.info("Deleting file {}...", file)
 log.info("Deleting file %s...", file)
 service.files().delete(fileId=file["id"])
 log.info("Done.")

Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/transfers/example_gdrive_to_local.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ def remove_file_from_drive():
 response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
 if files := response["files"]:
 file = files[0]
 log.info("Deleting file {}...", file)
 log.info("Deleting file %s...", file)
 service.files().delete(fileId=file["id"])
 log.info("Done.")

Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/suite/example_local_to_drive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ def remove_files_from_drive():
 if files := root_path["files"]:
 batch = service.new_batch_http_request()
 for file in files:
 log.info("Preparing to remove file: {}", file)
 log.info("Preparing to remove file: %s", file)
 batch.add(service.files().delete(fileId=file["id"]))
 batch.execute()
 log.info("Selected files removed.")
Expand Down

1 change: 1 addition & 0 deletions
pyproject.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -628,6 +628,7 @@ extend-select = [
 "PLW2101", # Threading lock directly created in with statement has no effect
 "PLW2901", # Outer {outer_kind} variable {name} overwritten by inner {inner_kind} target
 "PLW3301", # Nested {func} calls can be flattened
 "PLE1205", # Logging format string has too many arguments (extra args are silently dropped)
 # Per rule enables
 "RUF006", # Checks for asyncio dangling task
 "RUF015", # Checks for unnecessary iterable allocation for first element
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Enable ruff PLE1205 to catch logging calls with too many arguments by shahar1 · Pull Request #66978 · apache/airflow · GitHub
Skip to content
Enable ruff PLE1205 to catch logging calls with too many arguments#66978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

shahar1
merged 3 commits into

from

May 15, 2026
 Merged


Enable ruff PLE1205 to catch logging calls with too many arguments
#66978
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
5b540d0

Enable ruff PLE1205 and fix 12 logging calls with too many arguments


shahar1 May 15, 2026
9ce0d72

Update providers/google/src/airflow/providers/google/suite/hooks/driv…


shahar1 May 15, 2026
4fa39e5

Fix log.exception


shahar1 May 15, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
airflow-core/src/airflow/utils/log/file_task_handler.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -855,7 +855,7 @@ def _init_file(self, ti, *, identifier: str | None = None):
 try:
 os.chmod(full_path, new_file_permissions)
 except OSError as e:
 logger.warning("OSError while changing ownership of the log file. ", e)
 logger.warning("OSError while changing ownership of the log file. %s", e)

 return full_path

Expand Down

5 changes: 1 addition & 4 deletions
providers/amazon/src/airflow/providers/amazon/aws/operators/redshift_data.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,10 +120,7 @@ def __init__(
 if poll_interval > 0:
 self.poll_interval = poll_interval
 else:
 self.log.warning(
 "Invalid poll_interval:",
 poll_interval,
 )
 self.log.warning("Invalid poll_interval: %s", poll_interval)
 self.return_sql_result = return_sql_result
 self.deferrable = deferrable
 self.session_id = session_id
Expand Down

6 changes: 1 addition & 5 deletions
providers/amazon/src/airflow/providers/amazon/aws/sensors/ssm.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -108,11 +108,7 @@ def poke(self, context: Context):
 command_invocations = response.get("CommandInvocations", [])

 if not command_invocations:
 self.log.info(
 "No command invocations found",
 "command_id=%s yet, waiting...",
 self.command_id,
Comment thread
shahar1 marked this conversation as resolved.

 )
 self.log.info("No command invocations found, command_id=%s yet, waiting...", self.command_id)
 return False

 for invocation in command_invocations:
Expand Down

4 changes: 2 additions & 2 deletions
providers/amazon/src/airflow/providers/amazon/aws/utils/task_log_fetcher.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
 )
 except ClientError as error:
 if error.response["Error"]["Code"] != "ResourceNotFoundException":
 self.logger.warning("Error on retrieving Cloudwatch log events", error)
 self.logger.warning("Error on retrieving Cloudwatch log events: %s", error)
 else:
 self.logger.info(
 "Cannot find log stream yet, it can take a couple of seconds to show up. "
Expand All@@ -95,7 +95,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
 )
 yield from ()
 except ConnectionClosedError as error:
 self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events", error)
 self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events: %s", error)
 yield from ()

 @staticmethod
Expand Down

4 changes: 2 additions & 2 deletions
providers/google/src/airflow/providers/google/cloud/operators/compute.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1042,7 +1042,7 @@ def execute(self, context: Context) -> dict:
 request_id=self.request_id,
 project_id=self.project_id,
 )
 self.log.info("The specified Instance Template has been created SUCCESSFULLY", self.body)
 self.log.info("The specified Instance Template has been created SUCCESSFULLY: %s", self.body)
 new_template = hook.get_instance_template(
 resource_id=self.resource_id,
 project_id=self.project_id,
Expand DownExpand Up@@ -1611,7 +1611,7 @@ def execute(self, context: Context) -> dict:
 project_id=self.project_id,
 zone=self.zone,
 )
 self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY", self.body)
 self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY: %s", self.body)
 new_instance_group_manager = hook.get_instance_group_manager(
 resource_id=self.resource_id,
 project_id=self.project_id,
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/src/airflow/providers/google/suite/hooks/drive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -304,7 +304,7 @@ def upload_file(
 try:
 upload_location = self._resolve_file_path(folder_id)
 except GoogleApiClientError as e:
 self.log.warning("A problem has been encountered when trying to resolve file path: ", e)
 self.log.exception("A problem has been encountered when trying to resolve file path: %s", e)

 if show_full_target_path:
 self.log.info("File %s uploaded to gdrive://%s.", local_location, upload_location)
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/gcs/example_gcs_to_gdrive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -170,7 +170,7 @@ def remove_files_from_drive():
 if files := root_path["files"]:
 batch = service.new_batch_http_request()
 for file in files:
 log.info("Preparing to remove file: {}", file)
 log.info("Preparing to remove file: %s", file)
 batch.add(service.files().delete(fileId=file["id"]))
 batch.execute()
 log.info("Selected files removed.")
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/gcs/example_gdrive_to_gcs.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -136,7 +136,7 @@ def remove_files_from_drive():
 response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
 if files := response["files"]:
 file = files[0]
 log.info("Deleting file {}...", file)
 log.info("Deleting file %s...", file)
 service.files().delete(fileId=file["id"])
 log.info("Done.")

Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/transfers/example_gdrive_to_local.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ def remove_file_from_drive():
 response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
 if files := response["files"]:
 file = files[0]
 log.info("Deleting file {}...", file)
 log.info("Deleting file %s...", file)
 service.files().delete(fileId=file["id"])
 log.info("Done.")

Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/suite/example_local_to_drive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ def remove_files_from_drive():
 if files := root_path["files"]:
 batch = service.new_batch_http_request()
 for file in files:
 log.info("Preparing to remove file: {}", file)
 log.info("Preparing to remove file: %s", file)
 batch.add(service.files().delete(fileId=file["id"]))
 batch.execute()
 log.info("Selected files removed.")
Expand Down

1 change: 1 addition & 0 deletions
pyproject.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -628,6 +628,7 @@ extend-select = [
 "PLW2101", # Threading lock directly created in with statement has no effect
 "PLW2901", # Outer {outer_kind} variable {name} overwritten by inner {inner_kind} target
 "PLW3301", # Nested {func} calls can be flattened
 "PLE1205", # Logging format string has too many arguments (extra args are silently dropped)
 # Per rule enables
 "RUF006", # Checks for asyncio dangling task
 "RUF015", # Checks for unnecessary iterable allocation for first element
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable ruff PLE1205 to catch logging calls with too many arguments by shahar1 · Pull Request #66978 · apache/airflow · GitHub
Skip to content
Enable ruff PLE1205 to catch logging calls with too many arguments#66978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

shahar1
merged 3 commits into

from

May 15, 2026
 Merged


Enable ruff PLE1205 to catch logging calls with too many arguments
#66978
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
5b540d0

Enable ruff PLE1205 and fix 12 logging calls with too many arguments


shahar1 May 15, 2026
9ce0d72

Update providers/google/src/airflow/providers/google/suite/hooks/driv…


shahar1 May 15, 2026
4fa39e5

Fix log.exception


shahar1 May 15, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
airflow-core/src/airflow/utils/log/file_task_handler.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -855,7 +855,7 @@ def _init_file(self, ti, *, identifier: str | None = None):
 try:
 os.chmod(full_path, new_file_permissions)
 except OSError as e:
 logger.warning("OSError while changing ownership of the log file. ", e)
 logger.warning("OSError while changing ownership of the log file. %s", e)

 return full_path

Expand Down

5 changes: 1 addition & 4 deletions
providers/amazon/src/airflow/providers/amazon/aws/operators/redshift_data.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,10 +120,7 @@ def __init__(
 if poll_interval > 0:
 self.poll_interval = poll_interval
 else:
 self.log.warning(
 "Invalid poll_interval:",
 poll_interval,
 )
 self.log.warning("Invalid poll_interval: %s", poll_interval)
 self.return_sql_result = return_sql_result
 self.deferrable = deferrable
 self.session_id = session_id
Expand Down

6 changes: 1 addition & 5 deletions
providers/amazon/src/airflow/providers/amazon/aws/sensors/ssm.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -108,11 +108,7 @@ def poke(self, context: Context):
 command_invocations = response.get("CommandInvocations", [])

 if not command_invocations:
 self.log.info(
 "No command invocations found",
 "command_id=%s yet, waiting...",
 self.command_id,
Comment thread
shahar1 marked this conversation as resolved.

 )
 self.log.info("No command invocations found, command_id=%s yet, waiting...", self.command_id)
 return False

 for invocation in command_invocations:
Expand Down

4 changes: 2 additions & 2 deletions
providers/amazon/src/airflow/providers/amazon/aws/utils/task_log_fetcher.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
 )
 except ClientError as error:
 if error.response["Error"]["Code"] != "ResourceNotFoundException":
 self.logger.warning("Error on retrieving Cloudwatch log events", error)
 self.logger.warning("Error on retrieving Cloudwatch log events: %s", error)
 else:
 self.logger.info(
 "Cannot find log stream yet, it can take a couple of seconds to show up. "
Expand All@@ -95,7 +95,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
 )
 yield from ()
 except ConnectionClosedError as error:
 self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events", error)
 self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events: %s", error)
 yield from ()

 @staticmethod
Expand Down

4 changes: 2 additions & 2 deletions
providers/google/src/airflow/providers/google/cloud/operators/compute.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1042,7 +1042,7 @@ def execute(self, context: Context) -> dict:
 request_id=self.request_id,
 project_id=self.project_id,
 )
 self.log.info("The specified Instance Template has been created SUCCESSFULLY", self.body)
 self.log.info("The specified Instance Template has been created SUCCESSFULLY: %s", self.body)
 new_template = hook.get_instance_template(
 resource_id=self.resource_id,
 project_id=self.project_id,
Expand DownExpand Up@@ -1611,7 +1611,7 @@ def execute(self, context: Context) -> dict:
 project_id=self.project_id,
 zone=self.zone,
 )
 self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY", self.body)
 self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY: %s", self.body)
 new_instance_group_manager = hook.get_instance_group_manager(
 resource_id=self.resource_id,
 project_id=self.project_id,
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/src/airflow/providers/google/suite/hooks/drive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -304,7 +304,7 @@ def upload_file(
 try:
 upload_location = self._resolve_file_path(folder_id)
 except GoogleApiClientError as e:
 self.log.warning("A problem has been encountered when trying to resolve file path: ", e)
 self.log.exception("A problem has been encountered when trying to resolve file path: %s", e)

 if show_full_target_path:
 self.log.info("File %s uploaded to gdrive://%s.", local_location, upload_location)
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/gcs/example_gcs_to_gdrive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -170,7 +170,7 @@ def remove_files_from_drive():
 if files := root_path["files"]:
 batch = service.new_batch_http_request()
 for file in files:
 log.info("Preparing to remove file: {}", file)
 log.info("Preparing to remove file: %s", file)
 batch.add(service.files().delete(fileId=file["id"]))
 batch.execute()
 log.info("Selected files removed.")
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/gcs/example_gdrive_to_gcs.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -136,7 +136,7 @@ def remove_files_from_drive():
 response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
 if files := response["files"]:
 file = files[0]
 log.info("Deleting file {}...", file)
 log.info("Deleting file %s...", file)
 service.files().delete(fileId=file["id"])
 log.info("Done.")

Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/transfers/example_gdrive_to_local.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ def remove_file_from_drive():
 response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
 if files := response["files"]:
 file = files[0]
 log.info("Deleting file {}...", file)
 log.info("Deleting file %s...", file)
 service.files().delete(fileId=file["id"])
 log.info("Done.")

Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/suite/example_local_to_drive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ def remove_files_from_drive():
 if files := root_path["files"]:
 batch = service.new_batch_http_request()
 for file in files:
 log.info("Preparing to remove file: {}", file)
 log.info("Preparing to remove file: %s", file)
 batch.add(service.files().delete(fileId=file["id"]))
 batch.execute()
 log.info("Selected files removed.")
Expand Down

1 change: 1 addition & 0 deletions
pyproject.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -628,6 +628,7 @@ extend-select = [
 "PLW2101", # Threading lock directly created in with statement has no effect
 "PLW2901", # Outer {outer_kind} variable {name} overwritten by inner {inner_kind} target
 "PLW3301", # Nested {func} calls can be flattened
 "PLE1205", # Logging format string has too many arguments (extra args are silently dropped)
 # Per rule enables
 "RUF006", # Checks for asyncio dangling task
 "RUF015", # Checks for unnecessary iterable allocation for first element
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable ruff PLE1205 to catch logging calls with too many arguments by shahar1 · Pull Request #66978 · apache/airflow · GitHub
Skip to content
Enable ruff PLE1205 to catch logging calls with too many arguments#66978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

shahar1
merged 3 commits into

from

May 15, 2026
 Merged


Enable ruff PLE1205 to catch logging calls with too many arguments
#66978
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
5b540d0

Enable ruff PLE1205 and fix 12 logging calls with too many arguments


shahar1 May 15, 2026
9ce0d72

Update providers/google/src/airflow/providers/google/suite/hooks/driv…


shahar1 May 15, 2026
4fa39e5

Fix log.exception


shahar1 May 15, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
airflow-core/src/airflow/utils/log/file_task_handler.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -855,7 +855,7 @@ def _init_file(self, ti, *, identifier: str | None = None):
 try:
 os.chmod(full_path, new_file_permissions)
 except OSError as e:
 logger.warning("OSError while changing ownership of the log file. ", e)
 logger.warning("OSError while changing ownership of the log file. %s", e)

 return full_path

Expand Down

5 changes: 1 addition & 4 deletions
providers/amazon/src/airflow/providers/amazon/aws/operators/redshift_data.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,10 +120,7 @@ def __init__(
 if poll_interval > 0:
 self.poll_interval = poll_interval
 else:
 self.log.warning(
 "Invalid poll_interval:",
 poll_interval,
 )
 self.log.warning("Invalid poll_interval: %s", poll_interval)
 self.return_sql_result = return_sql_result
 self.deferrable = deferrable
 self.session_id = session_id
Expand Down

6 changes: 1 addition & 5 deletions
providers/amazon/src/airflow/providers/amazon/aws/sensors/ssm.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -108,11 +108,7 @@ def poke(self, context: Context):
 command_invocations = response.get("CommandInvocations", [])

 if not command_invocations:
 self.log.info(
 "No command invocations found",
 "command_id=%s yet, waiting...",
 self.command_id,
Comment thread
shahar1 marked this conversation as resolved.

 )
 self.log.info("No command invocations found, command_id=%s yet, waiting...", self.command_id)
 return False

 for invocation in command_invocations:
Expand Down

4 changes: 2 additions & 2 deletions
providers/amazon/src/airflow/providers/amazon/aws/utils/task_log_fetcher.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
 )
 except ClientError as error:
 if error.response["Error"]["Code"] != "ResourceNotFoundException":
 self.logger.warning("Error on retrieving Cloudwatch log events", error)
 self.logger.warning("Error on retrieving Cloudwatch log events: %s", error)
 else:
 self.logger.info(
 "Cannot find log stream yet, it can take a couple of seconds to show up. "
Expand All@@ -95,7 +95,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
 )
 yield from ()
 except ConnectionClosedError as error:
 self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events", error)
 self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events: %s", error)
 yield from ()

 @staticmethod
Expand Down

4 changes: 2 additions & 2 deletions
providers/google/src/airflow/providers/google/cloud/operators/compute.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1042,7 +1042,7 @@ def execute(self, context: Context) -> dict:
 request_id=self.request_id,
 project_id=self.project_id,
 )
 self.log.info("The specified Instance Template has been created SUCCESSFULLY", self.body)
 self.log.info("The specified Instance Template has been created SUCCESSFULLY: %s", self.body)
 new_template = hook.get_instance_template(
 resource_id=self.resource_id,
 project_id=self.project_id,
Expand DownExpand Up@@ -1611,7 +1611,7 @@ def execute(self, context: Context) -> dict:
 project_id=self.project_id,
 zone=self.zone,
 )
 self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY", self.body)
 self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY: %s", self.body)
 new_instance_group_manager = hook.get_instance_group_manager(
 resource_id=self.resource_id,
 project_id=self.project_id,
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/src/airflow/providers/google/suite/hooks/drive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -304,7 +304,7 @@ def upload_file(
 try:
 upload_location = self._resolve_file_path(folder_id)
 except GoogleApiClientError as e:
 self.log.warning("A problem has been encountered when trying to resolve file path: ", e)
 self.log.exception("A problem has been encountered when trying to resolve file path: %s", e)

 if show_full_target_path:
 self.log.info("File %s uploaded to gdrive://%s.", local_location, upload_location)
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/gcs/example_gcs_to_gdrive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -170,7 +170,7 @@ def remove_files_from_drive():
 if files := root_path["files"]:
 batch = service.new_batch_http_request()
 for file in files:
 log.info("Preparing to remove file: {}", file)
 log.info("Preparing to remove file: %s", file)
 batch.add(service.files().delete(fileId=file["id"]))
 batch.execute()
 log.info("Selected files removed.")
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/gcs/example_gdrive_to_gcs.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -136,7 +136,7 @@ def remove_files_from_drive():
 response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
 if files := response["files"]:
 file = files[0]
 log.info("Deleting file {}...", file)
 log.info("Deleting file %s...", file)
 service.files().delete(fileId=file["id"])
 log.info("Done.")

Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/transfers/example_gdrive_to_local.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ def remove_file_from_drive():
 response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
 if files := response["files"]:
 file = files[0]
 log.info("Deleting file {}...", file)
 log.info("Deleting file %s...", file)
 service.files().delete(fileId=file["id"])
 log.info("Done.")

Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/suite/example_local_to_drive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ def remove_files_from_drive():
 if files := root_path["files"]:
 batch = service.new_batch_http_request()
 for file in files:
 log.info("Preparing to remove file: {}", file)
 log.info("Preparing to remove file: %s", file)
 batch.add(service.files().delete(fileId=file["id"]))
 batch.execute()
 log.info("Selected files removed.")
Expand Down

1 change: 1 addition & 0 deletions
pyproject.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -628,6 +628,7 @@ extend-select = [
 "PLW2101", # Threading lock directly created in with statement has no effect
 "PLW2901", # Outer {outer_kind} variable {name} overwritten by inner {inner_kind} target
 "PLW3301", # Nested {func} calls can be flattened
 "PLE1205", # Logging format string has too many arguments (extra args are silently dropped)
 # Per rule enables
 "RUF006", # Checks for asyncio dangling task
 "RUF015", # Checks for unnecessary iterable allocation for first element
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Enable ruff PLE1205 to catch logging calls with too many arguments by shahar1 · Pull Request #66978 · apache/airflow · GitHub
Skip to content
Enable ruff PLE1205 to catch logging calls with too many arguments#66978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

shahar1
merged 3 commits into

from

May 15, 2026
 Merged


Enable ruff PLE1205 to catch logging calls with too many arguments
#66978
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
5b540d0

Enable ruff PLE1205 and fix 12 logging calls with too many arguments


shahar1 May 15, 2026
9ce0d72

Update providers/google/src/airflow/providers/google/suite/hooks/driv…


shahar1 May 15, 2026
4fa39e5

Fix log.exception


shahar1 May 15, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
airflow-core/src/airflow/utils/log/file_task_handler.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -855,7 +855,7 @@ def _init_file(self, ti, *, identifier: str | None = None):
 try:
 os.chmod(full_path, new_file_permissions)
 except OSError as e:
 logger.warning("OSError while changing ownership of the log file. ", e)
 logger.warning("OSError while changing ownership of the log file. %s", e)

 return full_path

Expand Down

5 changes: 1 addition & 4 deletions
providers/amazon/src/airflow/providers/amazon/aws/operators/redshift_data.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -120,10 +120,7 @@ def __init__(
 if poll_interval > 0:
 self.poll_interval = poll_interval
 else:
 self.log.warning(
 "Invalid poll_interval:",
 poll_interval,
 )
 self.log.warning("Invalid poll_interval: %s", poll_interval)
 self.return_sql_result = return_sql_result
 self.deferrable = deferrable
 self.session_id = session_id
Expand Down

6 changes: 1 addition & 5 deletions
providers/amazon/src/airflow/providers/amazon/aws/sensors/ssm.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -108,11 +108,7 @@ def poke(self, context: Context):
 command_invocations = response.get("CommandInvocations", [])

 if not command_invocations:
 self.log.info(
 "No command invocations found",
 "command_id=%s yet, waiting...",
 self.command_id,
Comment thread
shahar1 marked this conversation as resolved.

 )
 self.log.info("No command invocations found, command_id=%s yet, waiting...", self.command_id)
 return False

 for invocation in command_invocations:
Expand Down

4 changes: 2 additions & 2 deletions
providers/amazon/src/airflow/providers/amazon/aws/utils/task_log_fetcher.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
 )
 except ClientError as error:
 if error.response["Error"]["Code"] != "ResourceNotFoundException":
 self.logger.warning("Error on retrieving Cloudwatch log events", error)
 self.logger.warning("Error on retrieving Cloudwatch log events: %s", error)
 else:
 self.logger.info(
 "Cannot find log stream yet, it can take a couple of seconds to show up. "
Expand All@@ -95,7 +95,7 @@ def _get_log_events(self, skip_token: AwsLogsHook.ContinuationToken | None = Non
 )
 yield from ()
 except ConnectionClosedError as error:
 self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events", error)
 self.logger.warning("ConnectionClosedError on retrieving Cloudwatch log events: %s", error)
 yield from ()

 @staticmethod
Expand Down

4 changes: 2 additions & 2 deletions
providers/google/src/airflow/providers/google/cloud/operators/compute.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1042,7 +1042,7 @@ def execute(self, context: Context) -> dict:
 request_id=self.request_id,
 project_id=self.project_id,
 )
 self.log.info("The specified Instance Template has been created SUCCESSFULLY", self.body)
 self.log.info("The specified Instance Template has been created SUCCESSFULLY: %s", self.body)
 new_template = hook.get_instance_template(
 resource_id=self.resource_id,
 project_id=self.project_id,
Expand DownExpand Up@@ -1611,7 +1611,7 @@ def execute(self, context: Context) -> dict:
 project_id=self.project_id,
 zone=self.zone,
 )
 self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY", self.body)
 self.log.info("The specified Instance Group Manager has been created SUCCESSFULLY: %s", self.body)
 new_instance_group_manager = hook.get_instance_group_manager(
 resource_id=self.resource_id,
 project_id=self.project_id,
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/src/airflow/providers/google/suite/hooks/drive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -304,7 +304,7 @@ def upload_file(
 try:
 upload_location = self._resolve_file_path(folder_id)
 except GoogleApiClientError as e:
 self.log.warning("A problem has been encountered when trying to resolve file path: ", e)
 self.log.exception("A problem has been encountered when trying to resolve file path: %s", e)

 if show_full_target_path:
 self.log.info("File %s uploaded to gdrive://%s.", local_location, upload_location)
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/gcs/example_gcs_to_gdrive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -170,7 +170,7 @@ def remove_files_from_drive():
 if files := root_path["files"]:
 batch = service.new_batch_http_request()
 for file in files:
 log.info("Preparing to remove file: {}", file)
 log.info("Preparing to remove file: %s", file)
 batch.add(service.files().delete(fileId=file["id"]))
 batch.execute()
 log.info("Selected files removed.")
Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/gcs/example_gdrive_to_gcs.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -136,7 +136,7 @@ def remove_files_from_drive():
 response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
 if files := response["files"]:
 file = files[0]
 log.info("Deleting file {}...", file)
 log.info("Deleting file %s...", file)
 service.files().delete(fileId=file["id"])
 log.info("Done.")

Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/cloud/transfers/example_gdrive_to_local.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -137,7 +137,7 @@ def remove_file_from_drive():
 response = service.files().list(q=f"name = '{DRIVE_FILE_NAME}'").execute()
 if files := response["files"]:
 file = files[0]
 log.info("Deleting file {}...", file)
 log.info("Deleting file %s...", file)
 service.files().delete(fileId=file["id"])
 log.info("Done.")

Expand Down

2 changes: 1 addition & 1 deletion
providers/google/tests/system/google/suite/example_local_to_drive.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ def remove_files_from_drive():
 if files := root_path["files"]:
 batch = service.new_batch_http_request()
 for file in files:
 log.info("Preparing to remove file: {}", file)
 log.info("Preparing to remove file: %s", file)
 batch.add(service.files().delete(fileId=file["id"]))
 batch.execute()
 log.info("Selected files removed.")
Expand Down

1 change: 1 addition & 0 deletions
pyproject.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -628,6 +628,7 @@ extend-select = [
 "PLW2101", # Threading lock directly created in with statement has no effect
 "PLW2901", # Outer {outer_kind} variable {name} overwritten by inner {inner_kind} target
 "PLW3301", # Nested {func} calls can be flattened
 "PLE1205", # Logging format string has too many arguments (extra args are silently dropped)
 # Per rule enables
 "RUF006", # Checks for asyncio dangling task
 "RUF015", # Checks for unnecessary iterable allocation for first element
Expand Down
Loading