Skip to content

Deprecate implicit legacy SQL default in BigQuery operators - #67113

Merged
shahar1 merged 1 commit into
apache:mainfrom
VladaZakharova:bq-legacy-sql
Jun 26, 2026
Merged

Deprecate implicit legacy SQL default in BigQuery operators#67113
shahar1 merged 1 commit into
apache:mainfrom
VladaZakharova:bq-legacy-sql

Conversation

@VladaZakharova

@VladaZakharovaVladaZakharova commented May 18, 2026

Copy link
Copy Markdown
Contributor

Deprecates the implicit use_legacy_sql=True default in older BigQuery operators.

BigQuery now recommends GoogleSQL, and legacy SQL availability is restricted after June 1, 2026 depending on prior usage. This change keeps the current runtime behavior for compatibility, but emits an AirflowProviderDeprecationWarning when use_legacy_sql is omitted and Airflow falls back to the old legacy SQL default.
Documentation: https://docs.cloud.google.com/bigquery/docs/legacy-sql-feature-availability#:~:text=BigQuery%20monitors%20the%20use%20of,after%20the%20evaluation%20period%20ends.

Users can avoid the warning by choosing explicitly:

use_legacy_sql=False to use GoogleSQL.
use_legacy_sql=True if they intentionally still need legacy SQL.
The warning applies only to the implicit default. Explicit legacy SQL usage remains supported.

This also updates BigQuery operator and connection docs with guidance about GoogleSQL and legacy SQL availability.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Important

🛠️ Maintainer triage note for @VladaZakharova · by @potiuk · 2026-06-17 18:53 UTC

Some review feedback from shahar1 is waiting on you:

The ball is in your court — you've been assigned to this PR. Reply or push a fix in each thread, then mark them resolved.

Automated triage — may be imperfect; a maintainer takes the next look.

@potiuk

Copy link
Copy Markdown
Member

@VladaZakharova A few things need addressing before review — see our Pull Request quality criteria.

  • CI fails: MySQL tests: core / DB-core:MySQL:8.0:3.10:API...CLI (and possibly other checks — see the Checks tab for the full list).

No rush.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.


Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting

@potiukpotiuk added the ready for maintainer review Set after triaging when all criteria pass. label Jun 3, 2026
@VladaZakharova
VladaZakharovaforce-pushed the bq-legacy-sql branch 2 times, most recently from f75e23c to 6128ce2CompareJune 19, 2026 14:00
@VladaZakharova
VladaZakharovaforce-pushed the bq-legacy-sql branch 2 times, most recently from 6128ce2 to 5060e67CompareJune 22, 2026 10:52

@shahar1shahar1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mypy fail seems unrelated

@shahar1
shahar1 merged commit b94ca10 into apache:mainJun 26, 2026
171 of 172 checks passed
karenbraganz pushed a commit to karenbraganz/airflow that referenced this pull request Jun 30, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providerskind:documentationprovider:googleGoogle (including GCP) related issuesready for maintainer reviewSet after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@VladaZakharova@potiuk@shahar1