Skip to content

Fix ValueError when supervisor force-closes stuck sockets after timeout - #67115

Merged
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup
May 19, 2026
Merged

Fix ValueError when supervisor force-closes stuck sockets after timeout#67115
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup

Conversation

@AutomationDev85

@AutomationDev85AutomationDev85 commented May 18, 2026

Copy link
Copy Markdown
Contributor

Overview

Some Edge workers intermittently fail with the following error:

2026-05-17T09:39:34.839980Z [error ] Task execution failed [airflow.providers.edge3.cli.worker] loc=worker.py:226
Traceback (most recent call last):
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/edge3/cli/worker.py", line 213, in _run_job_via_supervisor
supervise(
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 2107, in supervise
exit_code = process.wait()
^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1062, in wait
self._monitor_subprocess()
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1127, in _monitor_subprocess
alive = self._service_subprocess(max_wait_time=max_wait_time) is None
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 791, in _service_subprocess
events = self.selector.select(timeout=timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/python/lib/python3.12/selectors.py", line 468, in select
fd_event_list = self._selector.poll(timeout, max_ev)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: I/O operation on closed epoll object

After analyzing the issue, we found that after the socket cleanup timeout fires and _cleanup_open_sockets() closes the selector, the monitor loop was not exited. On the next iteration it called selector.select() on the already-closed epoll object, causing the ValueError.

Details of change:

  • Add a break to exit the monitor loop immediately after the forced socket cleanup, preventing any further calls to selector.select() on the closed selector.
  • Call _open_sockets.clear() inside _cleanup_open_sockets() to keep the socket registry consistent with the selector state after cleanup.
  • Adapt unit test.

@jscheffljscheffl added this to the Airflow 3.2.2 milestone May 18, 2026
@jscheffljscheffl added the type:bug-fix Changelog: Bug Fixes label May 18, 2026
@AutomationDev85
AutomationDev85force-pushed the bugfix/supervisor-fail-during-socket-cleanup branch from 7a58932 to 9465ed7CompareMay 19, 2026 06:45
@vatsrahul1001vatsrahul1001 added ready for maintainer review Set after triaging when all criteria pass. backport-to-v3-2-test labels May 19, 2026

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking nit, otherwise LGTM

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@ashb

ashb commented May 19, 2026

Copy link
Copy Markdown
Member

Interesting. I sort of hoped that the stuck socket timeout never fired.

@vatsrahul1001
vatsrahul1001 merged commit 9bb5ff3 into apache:mainMay 19, 2026
112 of 113 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

vatsrahul1001 pushed a commit that referenced this pull request May 19, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 21, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@AutomationDev85@ashb@amoghrajesh@vatsrahul1001@jscheffl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix ValueError when supervisor force-closes stuck sockets after timeout by AutomationDev85 · Pull Request #67115 · apache/airflow · GitHub
Skip to content

Fix ValueError when supervisor force-closes stuck sockets after timeout - #67115

Merged
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup
May 19, 2026
Merged

Fix ValueError when supervisor force-closes stuck sockets after timeout#67115
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup

Conversation

@AutomationDev85

@AutomationDev85AutomationDev85 commented May 18, 2026

Copy link
Copy Markdown
Contributor

Overview

Some Edge workers intermittently fail with the following error:

2026-05-17T09:39:34.839980Z [error ] Task execution failed [airflow.providers.edge3.cli.worker] loc=worker.py:226
Traceback (most recent call last):
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/edge3/cli/worker.py", line 213, in _run_job_via_supervisor
supervise(
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 2107, in supervise
exit_code = process.wait()
^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1062, in wait
self._monitor_subprocess()
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1127, in _monitor_subprocess
alive = self._service_subprocess(max_wait_time=max_wait_time) is None
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 791, in _service_subprocess
events = self.selector.select(timeout=timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/python/lib/python3.12/selectors.py", line 468, in select
fd_event_list = self._selector.poll(timeout, max_ev)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: I/O operation on closed epoll object

After analyzing the issue, we found that after the socket cleanup timeout fires and _cleanup_open_sockets() closes the selector, the monitor loop was not exited. On the next iteration it called selector.select() on the already-closed epoll object, causing the ValueError.

Details of change:

  • Add a break to exit the monitor loop immediately after the forced socket cleanup, preventing any further calls to selector.select() on the closed selector.
  • Call _open_sockets.clear() inside _cleanup_open_sockets() to keep the socket registry consistent with the selector state after cleanup.
  • Adapt unit test.

@jscheffljscheffl added this to the Airflow 3.2.2 milestone May 18, 2026
@jscheffljscheffl added the type:bug-fix Changelog: Bug Fixes label May 18, 2026
@AutomationDev85
AutomationDev85force-pushed the bugfix/supervisor-fail-during-socket-cleanup branch from 7a58932 to 9465ed7CompareMay 19, 2026 06:45
@vatsrahul1001vatsrahul1001 added ready for maintainer review Set after triaging when all criteria pass. backport-to-v3-2-test labels May 19, 2026

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking nit, otherwise LGTM

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@ashb

ashb commented May 19, 2026

Copy link
Copy Markdown
Member

Interesting. I sort of hoped that the stuck socket timeout never fired.

@vatsrahul1001
vatsrahul1001 merged commit 9bb5ff3 into apache:mainMay 19, 2026
112 of 113 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

vatsrahul1001 pushed a commit that referenced this pull request May 19, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 21, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@AutomationDev85@ashb@amoghrajesh@vatsrahul1001@jscheffl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix ValueError when supervisor force-closes stuck sockets after timeout by AutomationDev85 · Pull Request #67115 · apache/airflow · GitHub
Skip to content

Fix ValueError when supervisor force-closes stuck sockets after timeout - #67115

Merged
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup
May 19, 2026
Merged

Fix ValueError when supervisor force-closes stuck sockets after timeout#67115
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup

Conversation

@AutomationDev85

@AutomationDev85AutomationDev85 commented May 18, 2026

Copy link
Copy Markdown
Contributor

Overview

Some Edge workers intermittently fail with the following error:

2026-05-17T09:39:34.839980Z [error ] Task execution failed [airflow.providers.edge3.cli.worker] loc=worker.py:226
Traceback (most recent call last):
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/edge3/cli/worker.py", line 213, in _run_job_via_supervisor
supervise(
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 2107, in supervise
exit_code = process.wait()
^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1062, in wait
self._monitor_subprocess()
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1127, in _monitor_subprocess
alive = self._service_subprocess(max_wait_time=max_wait_time) is None
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 791, in _service_subprocess
events = self.selector.select(timeout=timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/python/lib/python3.12/selectors.py", line 468, in select
fd_event_list = self._selector.poll(timeout, max_ev)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: I/O operation on closed epoll object

After analyzing the issue, we found that after the socket cleanup timeout fires and _cleanup_open_sockets() closes the selector, the monitor loop was not exited. On the next iteration it called selector.select() on the already-closed epoll object, causing the ValueError.

Details of change:

  • Add a break to exit the monitor loop immediately after the forced socket cleanup, preventing any further calls to selector.select() on the closed selector.
  • Call _open_sockets.clear() inside _cleanup_open_sockets() to keep the socket registry consistent with the selector state after cleanup.
  • Adapt unit test.

@jscheffljscheffl added this to the Airflow 3.2.2 milestone May 18, 2026
@jscheffljscheffl added the type:bug-fix Changelog: Bug Fixes label May 18, 2026
@AutomationDev85
AutomationDev85force-pushed the bugfix/supervisor-fail-during-socket-cleanup branch from 7a58932 to 9465ed7CompareMay 19, 2026 06:45
@vatsrahul1001vatsrahul1001 added ready for maintainer review Set after triaging when all criteria pass. backport-to-v3-2-test labels May 19, 2026

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking nit, otherwise LGTM

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@ashb

ashb commented May 19, 2026

Copy link
Copy Markdown
Member

Interesting. I sort of hoped that the stuck socket timeout never fired.

@vatsrahul1001
vatsrahul1001 merged commit 9bb5ff3 into apache:mainMay 19, 2026
112 of 113 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

vatsrahul1001 pushed a commit that referenced this pull request May 19, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 21, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@AutomationDev85@ashb@amoghrajesh@vatsrahul1001@jscheffl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix ValueError when supervisor force-closes stuck sockets after timeout by AutomationDev85 · Pull Request #67115 · apache/airflow · GitHub
Skip to content

Fix ValueError when supervisor force-closes stuck sockets after timeout - #67115

Merged
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup
May 19, 2026
Merged

Fix ValueError when supervisor force-closes stuck sockets after timeout#67115
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup

Conversation

@AutomationDev85

@AutomationDev85AutomationDev85 commented May 18, 2026

Copy link
Copy Markdown
Contributor

Overview

Some Edge workers intermittently fail with the following error:

2026-05-17T09:39:34.839980Z [error ] Task execution failed [airflow.providers.edge3.cli.worker] loc=worker.py:226
Traceback (most recent call last):
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/edge3/cli/worker.py", line 213, in _run_job_via_supervisor
supervise(
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 2107, in supervise
exit_code = process.wait()
^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1062, in wait
self._monitor_subprocess()
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1127, in _monitor_subprocess
alive = self._service_subprocess(max_wait_time=max_wait_time) is None
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 791, in _service_subprocess
events = self.selector.select(timeout=timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/python/lib/python3.12/selectors.py", line 468, in select
fd_event_list = self._selector.poll(timeout, max_ev)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: I/O operation on closed epoll object

After analyzing the issue, we found that after the socket cleanup timeout fires and _cleanup_open_sockets() closes the selector, the monitor loop was not exited. On the next iteration it called selector.select() on the already-closed epoll object, causing the ValueError.

Details of change:

  • Add a break to exit the monitor loop immediately after the forced socket cleanup, preventing any further calls to selector.select() on the closed selector.
  • Call _open_sockets.clear() inside _cleanup_open_sockets() to keep the socket registry consistent with the selector state after cleanup.
  • Adapt unit test.

@jscheffljscheffl added this to the Airflow 3.2.2 milestone May 18, 2026
@jscheffljscheffl added the type:bug-fix Changelog: Bug Fixes label May 18, 2026
@AutomationDev85
AutomationDev85force-pushed the bugfix/supervisor-fail-during-socket-cleanup branch from 7a58932 to 9465ed7CompareMay 19, 2026 06:45
@vatsrahul1001vatsrahul1001 added ready for maintainer review Set after triaging when all criteria pass. backport-to-v3-2-test labels May 19, 2026

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking nit, otherwise LGTM

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@ashb

ashb commented May 19, 2026

Copy link
Copy Markdown
Member

Interesting. I sort of hoped that the stuck socket timeout never fired.

@vatsrahul1001
vatsrahul1001 merged commit 9bb5ff3 into apache:mainMay 19, 2026
112 of 113 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

vatsrahul1001 pushed a commit that referenced this pull request May 19, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 21, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@AutomationDev85@ashb@amoghrajesh@vatsrahul1001@jscheffl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Fix ValueError when supervisor force-closes stuck sockets after timeout by AutomationDev85 · Pull Request #67115 · apache/airflow · GitHub
Skip to content

Fix ValueError when supervisor force-closes stuck sockets after timeout - #67115

Merged
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup
May 19, 2026
Merged

Fix ValueError when supervisor force-closes stuck sockets after timeout#67115
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup

Conversation

@AutomationDev85

@AutomationDev85AutomationDev85 commented May 18, 2026

Copy link
Copy Markdown
Contributor

Overview

Some Edge workers intermittently fail with the following error:

2026-05-17T09:39:34.839980Z [error ] Task execution failed [airflow.providers.edge3.cli.worker] loc=worker.py:226
Traceback (most recent call last):
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/edge3/cli/worker.py", line 213, in _run_job_via_supervisor
supervise(
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 2107, in supervise
exit_code = process.wait()
^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1062, in wait
self._monitor_subprocess()
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1127, in _monitor_subprocess
alive = self._service_subprocess(max_wait_time=max_wait_time) is None
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 791, in _service_subprocess
events = self.selector.select(timeout=timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/python/lib/python3.12/selectors.py", line 468, in select
fd_event_list = self._selector.poll(timeout, max_ev)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: I/O operation on closed epoll object

After analyzing the issue, we found that after the socket cleanup timeout fires and _cleanup_open_sockets() closes the selector, the monitor loop was not exited. On the next iteration it called selector.select() on the already-closed epoll object, causing the ValueError.

Details of change:

  • Add a break to exit the monitor loop immediately after the forced socket cleanup, preventing any further calls to selector.select() on the closed selector.
  • Call _open_sockets.clear() inside _cleanup_open_sockets() to keep the socket registry consistent with the selector state after cleanup.
  • Adapt unit test.

@jscheffljscheffl added this to the Airflow 3.2.2 milestone May 18, 2026
@jscheffljscheffl added the type:bug-fix Changelog: Bug Fixes label May 18, 2026
@AutomationDev85
AutomationDev85force-pushed the bugfix/supervisor-fail-during-socket-cleanup branch from 7a58932 to 9465ed7CompareMay 19, 2026 06:45
@vatsrahul1001vatsrahul1001 added ready for maintainer review Set after triaging when all criteria pass. backport-to-v3-2-test labels May 19, 2026

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking nit, otherwise LGTM

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@ashb

ashb commented May 19, 2026

Copy link
Copy Markdown
Member

Interesting. I sort of hoped that the stuck socket timeout never fired.

@vatsrahul1001
vatsrahul1001 merged commit 9bb5ff3 into apache:mainMay 19, 2026
112 of 113 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

vatsrahul1001 pushed a commit that referenced this pull request May 19, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 21, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@AutomationDev85@ashb@amoghrajesh@vatsrahul1001@jscheffl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix ValueError when supervisor force-closes stuck sockets after timeout by AutomationDev85 · Pull Request #67115 · apache/airflow · GitHub
Skip to content

Fix ValueError when supervisor force-closes stuck sockets after timeout - #67115

Merged
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup
May 19, 2026
Merged

Fix ValueError when supervisor force-closes stuck sockets after timeout#67115
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup

Conversation

@AutomationDev85

@AutomationDev85AutomationDev85 commented May 18, 2026

Copy link
Copy Markdown
Contributor

Overview

Some Edge workers intermittently fail with the following error:

2026-05-17T09:39:34.839980Z [error ] Task execution failed [airflow.providers.edge3.cli.worker] loc=worker.py:226
Traceback (most recent call last):
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/edge3/cli/worker.py", line 213, in _run_job_via_supervisor
supervise(
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 2107, in supervise
exit_code = process.wait()
^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1062, in wait
self._monitor_subprocess()
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1127, in _monitor_subprocess
alive = self._service_subprocess(max_wait_time=max_wait_time) is None
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 791, in _service_subprocess
events = self.selector.select(timeout=timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/python/lib/python3.12/selectors.py", line 468, in select
fd_event_list = self._selector.poll(timeout, max_ev)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: I/O operation on closed epoll object

After analyzing the issue, we found that after the socket cleanup timeout fires and _cleanup_open_sockets() closes the selector, the monitor loop was not exited. On the next iteration it called selector.select() on the already-closed epoll object, causing the ValueError.

Details of change:

  • Add a break to exit the monitor loop immediately after the forced socket cleanup, preventing any further calls to selector.select() on the closed selector.
  • Call _open_sockets.clear() inside _cleanup_open_sockets() to keep the socket registry consistent with the selector state after cleanup.
  • Adapt unit test.

@jscheffljscheffl added this to the Airflow 3.2.2 milestone May 18, 2026
@jscheffljscheffl added the type:bug-fix Changelog: Bug Fixes label May 18, 2026
@AutomationDev85
AutomationDev85force-pushed the bugfix/supervisor-fail-during-socket-cleanup branch from 7a58932 to 9465ed7CompareMay 19, 2026 06:45
@vatsrahul1001vatsrahul1001 added ready for maintainer review Set after triaging when all criteria pass. backport-to-v3-2-test labels May 19, 2026

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking nit, otherwise LGTM

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@ashb

ashb commented May 19, 2026

Copy link
Copy Markdown
Member

Interesting. I sort of hoped that the stuck socket timeout never fired.

@vatsrahul1001
vatsrahul1001 merged commit 9bb5ff3 into apache:mainMay 19, 2026
112 of 113 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

vatsrahul1001 pushed a commit that referenced this pull request May 19, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 21, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@AutomationDev85@ashb@amoghrajesh@vatsrahul1001@jscheffl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix ValueError when supervisor force-closes stuck sockets after timeout by AutomationDev85 · Pull Request #67115 · apache/airflow · GitHub
Skip to content

Fix ValueError when supervisor force-closes stuck sockets after timeout - #67115

Merged
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup
May 19, 2026
Merged

Fix ValueError when supervisor force-closes stuck sockets after timeout#67115
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup

Conversation

@AutomationDev85

@AutomationDev85AutomationDev85 commented May 18, 2026

Copy link
Copy Markdown
Contributor

Overview

Some Edge workers intermittently fail with the following error:

2026-05-17T09:39:34.839980Z [error ] Task execution failed [airflow.providers.edge3.cli.worker] loc=worker.py:226
Traceback (most recent call last):
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/edge3/cli/worker.py", line 213, in _run_job_via_supervisor
supervise(
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 2107, in supervise
exit_code = process.wait()
^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1062, in wait
self._monitor_subprocess()
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1127, in _monitor_subprocess
alive = self._service_subprocess(max_wait_time=max_wait_time) is None
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 791, in _service_subprocess
events = self.selector.select(timeout=timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/python/lib/python3.12/selectors.py", line 468, in select
fd_event_list = self._selector.poll(timeout, max_ev)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: I/O operation on closed epoll object

After analyzing the issue, we found that after the socket cleanup timeout fires and _cleanup_open_sockets() closes the selector, the monitor loop was not exited. On the next iteration it called selector.select() on the already-closed epoll object, causing the ValueError.

Details of change:

  • Add a break to exit the monitor loop immediately after the forced socket cleanup, preventing any further calls to selector.select() on the closed selector.
  • Call _open_sockets.clear() inside _cleanup_open_sockets() to keep the socket registry consistent with the selector state after cleanup.
  • Adapt unit test.

@jscheffljscheffl added this to the Airflow 3.2.2 milestone May 18, 2026
@jscheffljscheffl added the type:bug-fix Changelog: Bug Fixes label May 18, 2026
@AutomationDev85
AutomationDev85force-pushed the bugfix/supervisor-fail-during-socket-cleanup branch from 7a58932 to 9465ed7CompareMay 19, 2026 06:45
@vatsrahul1001vatsrahul1001 added ready for maintainer review Set after triaging when all criteria pass. backport-to-v3-2-test labels May 19, 2026

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking nit, otherwise LGTM

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@ashb

ashb commented May 19, 2026

Copy link
Copy Markdown
Member

Interesting. I sort of hoped that the stuck socket timeout never fired.

@vatsrahul1001
vatsrahul1001 merged commit 9bb5ff3 into apache:mainMay 19, 2026
112 of 113 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

vatsrahul1001 pushed a commit that referenced this pull request May 19, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 21, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@AutomationDev85@ashb@amoghrajesh@vatsrahul1001@jscheffl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Fix ValueError when supervisor force-closes stuck sockets after timeout by AutomationDev85 · Pull Request #67115 · apache/airflow · GitHub
Skip to content

Fix ValueError when supervisor force-closes stuck sockets after timeout - #67115

Merged
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup
May 19, 2026
Merged

Fix ValueError when supervisor force-closes stuck sockets after timeout#67115
vatsrahul1001 merged 2 commits into
apache:mainfrom
boschglobal:bugfix/supervisor-fail-during-socket-cleanup

Conversation

@AutomationDev85

@AutomationDev85AutomationDev85 commented May 18, 2026

Copy link
Copy Markdown
Contributor

Overview

Some Edge workers intermittently fail with the following error:

2026-05-17T09:39:34.839980Z [error ] Task execution failed [airflow.providers.edge3.cli.worker] loc=worker.py:226
Traceback (most recent call last):
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/edge3/cli/worker.py", line 213, in _run_job_via_supervisor
supervise(
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 2107, in supervise
exit_code = process.wait()
^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1062, in wait
self._monitor_subprocess()
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 1127, in _monitor_subprocess
alive = self._service_subprocess(max_wait_time=max_wait_time) is None
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/supervisor.py", line 791, in _service_subprocess
events = self.selector.select(timeout=timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/python/lib/python3.12/selectors.py", line 468, in select
fd_event_list = self._selector.poll(timeout, max_ev)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: I/O operation on closed epoll object

After analyzing the issue, we found that after the socket cleanup timeout fires and _cleanup_open_sockets() closes the selector, the monitor loop was not exited. On the next iteration it called selector.select() on the already-closed epoll object, causing the ValueError.

Details of change:

  • Add a break to exit the monitor loop immediately after the forced socket cleanup, preventing any further calls to selector.select() on the closed selector.
  • Call _open_sockets.clear() inside _cleanup_open_sockets() to keep the socket registry consistent with the selector state after cleanup.
  • Adapt unit test.

@jscheffljscheffl added this to the Airflow 3.2.2 milestone May 18, 2026
@jscheffljscheffl added the type:bug-fix Changelog: Bug Fixes label May 18, 2026
@AutomationDev85
AutomationDev85force-pushed the bugfix/supervisor-fail-during-socket-cleanup branch from 7a58932 to 9465ed7CompareMay 19, 2026 06:45
@vatsrahul1001vatsrahul1001 added ready for maintainer review Set after triaging when all criteria pass. backport-to-v3-2-test labels May 19, 2026

@amoghrajeshamoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking nit, otherwise LGTM

Comment threadtask-sdk/tests/task_sdk/execution_time/test_supervisor.py Outdated
@ashb

ashb commented May 19, 2026

Copy link
Copy Markdown
Member

Interesting. I sort of hoped that the stuck socket timeout never fired.

@vatsrahul1001
vatsrahul1001 merged commit 9bb5ff3 into apache:mainMay 19, 2026
112 of 113 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

vatsrahul1001 pushed a commit that referenced this pull request May 19, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request May 21, 2026
… after timeout (#67115) (#67162)
* Fix ValueError when supervisor force-closes stuck sockets after timeout
* Improve mock socket spec
---------
(cherry picked from commit 9bb5ff3)
Co-authored-by: AutomationDev85 <96178949+AutomationDev85@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdkready for maintainer reviewSet after triaging when all criteria pass.type:bug-fixChangelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@AutomationDev85@ashb@amoghrajesh@vatsrahul1001@jscheffl