Add prek hook to enforce keyword-only `session` on `@provide_session` by jason810496 · Pull Request #67150 · apache/airflow

jason810496 · 2026-05-19T04:51:16Z

related: Make Pool model session parameter keyword-only #66967

Why

The project convention is that any function decorated with @provide_session must declare session as keyword-only (after a bare *), so callers cannot pass it positionally by accident. Today this is only documented in contributing-docs/05_pull_requests.rst#database-session-handling, so regressions slip in during review.

What

New prek hook check-no-new-provide-session-positional scans changed files (or --all-files) for @provide_session functions whose session parameter is still positional.
Existing offenders are recorded in scripts/ci/prek/known_provide_session_positional.txt as path::N entries (max count per file). The hook fails when a file exceeds its limit, and auto-tightens the entry when the count decreases so the allowlist only shrinks over time. (Following convention of build(prek-hook): Check whether new "raise AirflowException" is added #55416 )
Supports --all-files, --cleanup (drop stale entries), and --generate (rebuild the allowlist from scratch).

Was generative AI tooling used to co-author this PR?

Yes, with help of Claude Code Opus 4.7 following the guidelines

Copilot

Pull request overview

This PR introduces a new prek/pre-commit hook intended to prevent regressions where functions decorated with @provide_session accept session positionally, enforcing the documented convention that session should be keyword-only.

Changes:

Add check_provide_session_kwargs.py prek hook that AST-scans Python files for @provide_session functions with positional session.
Introduce a shrinking allowlist (known_provide_session_positional.txt) to grandfather existing violations while preventing increases.
Add unit tests for decorator detection, violation counting, and allowlist tightening/cleanup behavior; wire the hook into .pre-commit-config.yaml.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`scripts/ci/prek/check_provide_session_kwargs.py`	Implements the new AST-based checker, allowlist manager, and CLI modes (`--all-files`, `--cleanup`, `--generate`).
`scripts/ci/prek/known_provide_session_positional.txt`	Initial allowlist of existing positional-`session` offenders with per-file maximum counts.
`scripts/tests/ci/prek/test_check_provide_session_kwargs.py`	Unit tests for the new hook’s core logic and allowlist behavior.
`.pre-commit-config.yaml`	Registers the new hook so it runs on relevant Python paths (and the allowlist/script paths).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

When only the allowlist file is changed, the hook now unions the previous allowlist (from `git show HEAD:<file>`) with the current one, so removing an entry can't silently drop coverage for a file that still has positional `session` arguments.

Lee-W

a few nits, but nothing is blocking

- Drop ``task-sdk`` from ``_PROJECT_SOURCE_ROOTS`` and the docstring/help text; task-sdk does not use ``@provide_session``. - Rename ``_previous_allowlist`` to ``_parse_tracked_allowlist`` so the name is a verb and reflects that it parses the git-tracked (``HEAD``) version. - Rename test fixtures ``fake_repo`` and ``git_repo`` to ``create_fake_repo`` and ``create_git_repo`` to match the verb-prefix naming convention, and use ``@pytest.mark.usefixtures`` for tests that only need the side-effect.

airflow-ctl talks to Airflow via the API and has no @provide_session callsites, so scanning it is wasted work and misleading in the help text. The .pre-commit-config.yaml files pattern already only matches airflow-core|providers, so this just brings the script's own --all-files/--generate scope and docs in line.

jscheffl

LGTM!

jason810496 · 2026-05-19T04:51:16Z

related: Make Pool model session parameter keyword-only #66967

Why

The project convention is that any function decorated with @provide_session must declare session as keyword-only (after a bare *), so callers cannot pass it positionally by accident. Today this is only documented in contributing-docs/05_pull_requests.rst#database-session-handling, so regressions slip in during review.

What

New prek hook check-no-new-provide-session-positional scans changed files (or --all-files) for @provide_session functions whose session parameter is still positional.
Existing offenders are recorded in scripts/ci/prek/known_provide_session_positional.txt as path::N entries (max count per file). The hook fails when a file exceeds its limit, and auto-tightens the entry when the count decreases so the allowlist only shrinks over time. (Following convention of build(prek-hook): Check whether new "raise AirflowException" is added #55416 )
Supports --all-files, --cleanup (drop stale entries), and --generate (rebuild the allowlist from scratch).

Was generative AI tooling used to co-author this PR?

Yes, with help of Claude Code Opus 4.7 following the guidelines

Copilot

Pull request overview

This PR introduces a new prek/pre-commit hook intended to prevent regressions where functions decorated with @provide_session accept session positionally, enforcing the documented convention that session should be keyword-only.

Changes:

Add check_provide_session_kwargs.py prek hook that AST-scans Python files for @provide_session functions with positional session.
Introduce a shrinking allowlist (known_provide_session_positional.txt) to grandfather existing violations while preventing increases.
Add unit tests for decorator detection, violation counting, and allowlist tightening/cleanup behavior; wire the hook into .pre-commit-config.yaml.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`scripts/ci/prek/check_provide_session_kwargs.py`	Implements the new AST-based checker, allowlist manager, and CLI modes (`--all-files`, `--cleanup`, `--generate`).
`scripts/ci/prek/known_provide_session_positional.txt`	Initial allowlist of existing positional-`session` offenders with per-file maximum counts.
`scripts/tests/ci/prek/test_check_provide_session_kwargs.py`	Unit tests for the new hook’s core logic and allowlist behavior.
`.pre-commit-config.yaml`	Registers the new hook so it runs on relevant Python paths (and the allowlist/script paths).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

When only the allowlist file is changed, the hook now unions the previous allowlist (from `git show HEAD:<file>`) with the current one, so removing an entry can't silently drop coverage for a file that still has positional `session` arguments.

Lee-W

a few nits, but nothing is blocking

- Drop ``task-sdk`` from ``_PROJECT_SOURCE_ROOTS`` and the docstring/help text; task-sdk does not use ``@provide_session``. - Rename ``_previous_allowlist`` to ``_parse_tracked_allowlist`` so the name is a verb and reflects that it parses the git-tracked (``HEAD``) version. - Rename test fixtures ``fake_repo`` and ``git_repo`` to ``create_fake_repo`` and ``create_git_repo`` to match the verb-prefix naming convention, and use ``@pytest.mark.usefixtures`` for tests that only need the side-effect.

airflow-ctl talks to Airflow via the API and has no @provide_session callsites, so scanning it is wasted work and misleading in the help text. The .pre-commit-config.yaml files pattern already only matches airflow-core|providers, so this just brings the script's own --all-files/--generate scope and docs in line.

jscheffl

LGTM!

jason810496 · 2026-05-19T04:51:16Z

related: Make Pool model session parameter keyword-only #66967

Why

The project convention is that any function decorated with @provide_session must declare session as keyword-only (after a bare *), so callers cannot pass it positionally by accident. Today this is only documented in contributing-docs/05_pull_requests.rst#database-session-handling, so regressions slip in during review.

What

New prek hook check-no-new-provide-session-positional scans changed files (or --all-files) for @provide_session functions whose session parameter is still positional.
Existing offenders are recorded in scripts/ci/prek/known_provide_session_positional.txt as path::N entries (max count per file). The hook fails when a file exceeds its limit, and auto-tightens the entry when the count decreases so the allowlist only shrinks over time. (Following convention of build(prek-hook): Check whether new "raise AirflowException" is added #55416 )
Supports --all-files, --cleanup (drop stale entries), and --generate (rebuild the allowlist from scratch).

Was generative AI tooling used to co-author this PR?

Yes, with help of Claude Code Opus 4.7 following the guidelines

Copilot

Pull request overview

This PR introduces a new prek/pre-commit hook intended to prevent regressions where functions decorated with @provide_session accept session positionally, enforcing the documented convention that session should be keyword-only.

Changes:

Add check_provide_session_kwargs.py prek hook that AST-scans Python files for @provide_session functions with positional session.
Introduce a shrinking allowlist (known_provide_session_positional.txt) to grandfather existing violations while preventing increases.
Add unit tests for decorator detection, violation counting, and allowlist tightening/cleanup behavior; wire the hook into .pre-commit-config.yaml.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`scripts/ci/prek/check_provide_session_kwargs.py`	Implements the new AST-based checker, allowlist manager, and CLI modes (`--all-files`, `--cleanup`, `--generate`).
`scripts/ci/prek/known_provide_session_positional.txt`	Initial allowlist of existing positional-`session` offenders with per-file maximum counts.
`scripts/tests/ci/prek/test_check_provide_session_kwargs.py`	Unit tests for the new hook’s core logic and allowlist behavior.
`.pre-commit-config.yaml`	Registers the new hook so it runs on relevant Python paths (and the allowlist/script paths).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

When only the allowlist file is changed, the hook now unions the previous allowlist (from `git show HEAD:<file>`) with the current one, so removing an entry can't silently drop coverage for a file that still has positional `session` arguments.

Lee-W

a few nits, but nothing is blocking

- Drop ``task-sdk`` from ``_PROJECT_SOURCE_ROOTS`` and the docstring/help text; task-sdk does not use ``@provide_session``. - Rename ``_previous_allowlist`` to ``_parse_tracked_allowlist`` so the name is a verb and reflects that it parses the git-tracked (``HEAD``) version. - Rename test fixtures ``fake_repo`` and ``git_repo`` to ``create_fake_repo`` and ``create_git_repo`` to match the verb-prefix naming convention, and use ``@pytest.mark.usefixtures`` for tests that only need the side-effect.

airflow-ctl talks to Airflow via the API and has no @provide_session callsites, so scanning it is wasted work and misleading in the help text. The .pre-commit-config.yaml files pattern already only matches airflow-core|providers, so this just brings the script's own --all-files/--generate scope and docs in line.

jscheffl

LGTM!

jason810496 · 2026-05-19T04:51:16Z

related: Make Pool model session parameter keyword-only #66967

Why

The project convention is that any function decorated with @provide_session must declare session as keyword-only (after a bare *), so callers cannot pass it positionally by accident. Today this is only documented in contributing-docs/05_pull_requests.rst#database-session-handling, so regressions slip in during review.

What

New prek hook check-no-new-provide-session-positional scans changed files (or --all-files) for @provide_session functions whose session parameter is still positional.
Existing offenders are recorded in scripts/ci/prek/known_provide_session_positional.txt as path::N entries (max count per file). The hook fails when a file exceeds its limit, and auto-tightens the entry when the count decreases so the allowlist only shrinks over time. (Following convention of build(prek-hook): Check whether new "raise AirflowException" is added #55416 )
Supports --all-files, --cleanup (drop stale entries), and --generate (rebuild the allowlist from scratch).

Was generative AI tooling used to co-author this PR?

Yes, with help of Claude Code Opus 4.7 following the guidelines

Copilot

Pull request overview

This PR introduces a new prek/pre-commit hook intended to prevent regressions where functions decorated with @provide_session accept session positionally, enforcing the documented convention that session should be keyword-only.

Changes:

Add check_provide_session_kwargs.py prek hook that AST-scans Python files for @provide_session functions with positional session.
Introduce a shrinking allowlist (known_provide_session_positional.txt) to grandfather existing violations while preventing increases.
Add unit tests for decorator detection, violation counting, and allowlist tightening/cleanup behavior; wire the hook into .pre-commit-config.yaml.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`scripts/ci/prek/check_provide_session_kwargs.py`	Implements the new AST-based checker, allowlist manager, and CLI modes (`--all-files`, `--cleanup`, `--generate`).
`scripts/ci/prek/known_provide_session_positional.txt`	Initial allowlist of existing positional-`session` offenders with per-file maximum counts.
`scripts/tests/ci/prek/test_check_provide_session_kwargs.py`	Unit tests for the new hook’s core logic and allowlist behavior.
`.pre-commit-config.yaml`	Registers the new hook so it runs on relevant Python paths (and the allowlist/script paths).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

When only the allowlist file is changed, the hook now unions the previous allowlist (from `git show HEAD:<file>`) with the current one, so removing an entry can't silently drop coverage for a file that still has positional `session` arguments.

Lee-W

a few nits, but nothing is blocking

- Drop ``task-sdk`` from ``_PROJECT_SOURCE_ROOTS`` and the docstring/help text; task-sdk does not use ``@provide_session``. - Rename ``_previous_allowlist`` to ``_parse_tracked_allowlist`` so the name is a verb and reflects that it parses the git-tracked (``HEAD``) version. - Rename test fixtures ``fake_repo`` and ``git_repo`` to ``create_fake_repo`` and ``create_git_repo`` to match the verb-prefix naming convention, and use ``@pytest.mark.usefixtures`` for tests that only need the side-effect.

airflow-ctl talks to Airflow via the API and has no @provide_session callsites, so scanning it is wasted work and misleading in the help text. The .pre-commit-config.yaml files pattern already only matches airflow-core|providers, so this just brings the script's own --all-files/--generate scope and docs in line.

jscheffl

LGTM!

jason810496 · 2026-05-19T04:51:16Z

related: Make Pool model session parameter keyword-only #66967

Why

The project convention is that any function decorated with @provide_session must declare session as keyword-only (after a bare *), so callers cannot pass it positionally by accident. Today this is only documented in contributing-docs/05_pull_requests.rst#database-session-handling, so regressions slip in during review.

What

New prek hook check-no-new-provide-session-positional scans changed files (or --all-files) for @provide_session functions whose session parameter is still positional.
Existing offenders are recorded in scripts/ci/prek/known_provide_session_positional.txt as path::N entries (max count per file). The hook fails when a file exceeds its limit, and auto-tightens the entry when the count decreases so the allowlist only shrinks over time. (Following convention of build(prek-hook): Check whether new "raise AirflowException" is added #55416 )
Supports --all-files, --cleanup (drop stale entries), and --generate (rebuild the allowlist from scratch).

Was generative AI tooling used to co-author this PR?

Yes, with help of Claude Code Opus 4.7 following the guidelines

Copilot

Pull request overview

This PR introduces a new prek/pre-commit hook intended to prevent regressions where functions decorated with @provide_session accept session positionally, enforcing the documented convention that session should be keyword-only.

Changes:

Add check_provide_session_kwargs.py prek hook that AST-scans Python files for @provide_session functions with positional session.
Introduce a shrinking allowlist (known_provide_session_positional.txt) to grandfather existing violations while preventing increases.
Add unit tests for decorator detection, violation counting, and allowlist tightening/cleanup behavior; wire the hook into .pre-commit-config.yaml.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`scripts/ci/prek/check_provide_session_kwargs.py`	Implements the new AST-based checker, allowlist manager, and CLI modes (`--all-files`, `--cleanup`, `--generate`).
`scripts/ci/prek/known_provide_session_positional.txt`	Initial allowlist of existing positional-`session` offenders with per-file maximum counts.
`scripts/tests/ci/prek/test_check_provide_session_kwargs.py`	Unit tests for the new hook’s core logic and allowlist behavior.
`.pre-commit-config.yaml`	Registers the new hook so it runs on relevant Python paths (and the allowlist/script paths).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

When only the allowlist file is changed, the hook now unions the previous allowlist (from `git show HEAD:<file>`) with the current one, so removing an entry can't silently drop coverage for a file that still has positional `session` arguments.

Lee-W

a few nits, but nothing is blocking

- Drop ``task-sdk`` from ``_PROJECT_SOURCE_ROOTS`` and the docstring/help text; task-sdk does not use ``@provide_session``. - Rename ``_previous_allowlist`` to ``_parse_tracked_allowlist`` so the name is a verb and reflects that it parses the git-tracked (``HEAD``) version. - Rename test fixtures ``fake_repo`` and ``git_repo`` to ``create_fake_repo`` and ``create_git_repo`` to match the verb-prefix naming convention, and use ``@pytest.mark.usefixtures`` for tests that only need the side-effect.

airflow-ctl talks to Airflow via the API and has no @provide_session callsites, so scanning it is wasted work and misleading in the help text. The .pre-commit-config.yaml files pattern already only matches airflow-core|providers, so this just brings the script's own --all-files/--generate scope and docs in line.

jscheffl

LGTM!

jason810496 · 2026-05-19T04:51:16Z

related: Make Pool model session parameter keyword-only #66967

Why

The project convention is that any function decorated with @provide_session must declare session as keyword-only (after a bare *), so callers cannot pass it positionally by accident. Today this is only documented in contributing-docs/05_pull_requests.rst#database-session-handling, so regressions slip in during review.

What

New prek hook check-no-new-provide-session-positional scans changed files (or --all-files) for @provide_session functions whose session parameter is still positional.
Existing offenders are recorded in scripts/ci/prek/known_provide_session_positional.txt as path::N entries (max count per file). The hook fails when a file exceeds its limit, and auto-tightens the entry when the count decreases so the allowlist only shrinks over time. (Following convention of build(prek-hook): Check whether new "raise AirflowException" is added #55416 )
Supports --all-files, --cleanup (drop stale entries), and --generate (rebuild the allowlist from scratch).

Was generative AI tooling used to co-author this PR?

Yes, with help of Claude Code Opus 4.7 following the guidelines

Copilot

Pull request overview

This PR introduces a new prek/pre-commit hook intended to prevent regressions where functions decorated with @provide_session accept session positionally, enforcing the documented convention that session should be keyword-only.

Changes:

Add check_provide_session_kwargs.py prek hook that AST-scans Python files for @provide_session functions with positional session.
Introduce a shrinking allowlist (known_provide_session_positional.txt) to grandfather existing violations while preventing increases.
Add unit tests for decorator detection, violation counting, and allowlist tightening/cleanup behavior; wire the hook into .pre-commit-config.yaml.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`scripts/ci/prek/check_provide_session_kwargs.py`	Implements the new AST-based checker, allowlist manager, and CLI modes (`--all-files`, `--cleanup`, `--generate`).
`scripts/ci/prek/known_provide_session_positional.txt`	Initial allowlist of existing positional-`session` offenders with per-file maximum counts.
`scripts/tests/ci/prek/test_check_provide_session_kwargs.py`	Unit tests for the new hook’s core logic and allowlist behavior.
`.pre-commit-config.yaml`	Registers the new hook so it runs on relevant Python paths (and the allowlist/script paths).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

When only the allowlist file is changed, the hook now unions the previous allowlist (from `git show HEAD:<file>`) with the current one, so removing an entry can't silently drop coverage for a file that still has positional `session` arguments.

Lee-W

a few nits, but nothing is blocking

- Drop ``task-sdk`` from ``_PROJECT_SOURCE_ROOTS`` and the docstring/help text; task-sdk does not use ``@provide_session``. - Rename ``_previous_allowlist`` to ``_parse_tracked_allowlist`` so the name is a verb and reflects that it parses the git-tracked (``HEAD``) version. - Rename test fixtures ``fake_repo`` and ``git_repo`` to ``create_fake_repo`` and ``create_git_repo`` to match the verb-prefix naming convention, and use ``@pytest.mark.usefixtures`` for tests that only need the side-effect.

airflow-ctl talks to Airflow via the API and has no @provide_session callsites, so scanning it is wasted work and misleading in the help text. The .pre-commit-config.yaml files pattern already only matches airflow-core|providers, so this just brings the script's own --all-files/--generate scope and docs in line.

jscheffl

LGTM!

jason810496 · 2026-05-19T04:51:16Z

related: Make Pool model session parameter keyword-only #66967

Why

The project convention is that any function decorated with @provide_session must declare session as keyword-only (after a bare *), so callers cannot pass it positionally by accident. Today this is only documented in contributing-docs/05_pull_requests.rst#database-session-handling, so regressions slip in during review.

What

New prek hook check-no-new-provide-session-positional scans changed files (or --all-files) for @provide_session functions whose session parameter is still positional.
Existing offenders are recorded in scripts/ci/prek/known_provide_session_positional.txt as path::N entries (max count per file). The hook fails when a file exceeds its limit, and auto-tightens the entry when the count decreases so the allowlist only shrinks over time. (Following convention of build(prek-hook): Check whether new "raise AirflowException" is added #55416 )
Supports --all-files, --cleanup (drop stale entries), and --generate (rebuild the allowlist from scratch).

Was generative AI tooling used to co-author this PR?

Yes, with help of Claude Code Opus 4.7 following the guidelines

Copilot

Pull request overview

This PR introduces a new prek/pre-commit hook intended to prevent regressions where functions decorated with @provide_session accept session positionally, enforcing the documented convention that session should be keyword-only.

Changes:

Add check_provide_session_kwargs.py prek hook that AST-scans Python files for @provide_session functions with positional session.
Introduce a shrinking allowlist (known_provide_session_positional.txt) to grandfather existing violations while preventing increases.
Add unit tests for decorator detection, violation counting, and allowlist tightening/cleanup behavior; wire the hook into .pre-commit-config.yaml.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`scripts/ci/prek/check_provide_session_kwargs.py`	Implements the new AST-based checker, allowlist manager, and CLI modes (`--all-files`, `--cleanup`, `--generate`).
`scripts/ci/prek/known_provide_session_positional.txt`	Initial allowlist of existing positional-`session` offenders with per-file maximum counts.
`scripts/tests/ci/prek/test_check_provide_session_kwargs.py`	Unit tests for the new hook’s core logic and allowlist behavior.
`.pre-commit-config.yaml`	Registers the new hook so it runs on relevant Python paths (and the allowlist/script paths).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

When only the allowlist file is changed, the hook now unions the previous allowlist (from `git show HEAD:<file>`) with the current one, so removing an entry can't silently drop coverage for a file that still has positional `session` arguments.

Lee-W

a few nits, but nothing is blocking

- Drop ``task-sdk`` from ``_PROJECT_SOURCE_ROOTS`` and the docstring/help text; task-sdk does not use ``@provide_session``. - Rename ``_previous_allowlist`` to ``_parse_tracked_allowlist`` so the name is a verb and reflects that it parses the git-tracked (``HEAD``) version. - Rename test fixtures ``fake_repo`` and ``git_repo`` to ``create_fake_repo`` and ``create_git_repo`` to match the verb-prefix naming convention, and use ``@pytest.mark.usefixtures`` for tests that only need the side-effect.

airflow-ctl talks to Airflow via the API and has no @provide_session callsites, so scanning it is wasted work and misleading in the help text. The .pre-commit-config.yaml files pattern already only matches airflow-core|providers, so this just brings the script's own --all-files/--generate scope and docs in line.

jscheffl

LGTM!

jason810496 · 2026-05-19T04:51:16Z

related: Make Pool model session parameter keyword-only #66967

Why

The project convention is that any function decorated with @provide_session must declare session as keyword-only (after a bare *), so callers cannot pass it positionally by accident. Today this is only documented in contributing-docs/05_pull_requests.rst#database-session-handling, so regressions slip in during review.

What

New prek hook check-no-new-provide-session-positional scans changed files (or --all-files) for @provide_session functions whose session parameter is still positional.
Existing offenders are recorded in scripts/ci/prek/known_provide_session_positional.txt as path::N entries (max count per file). The hook fails when a file exceeds its limit, and auto-tightens the entry when the count decreases so the allowlist only shrinks over time. (Following convention of build(prek-hook): Check whether new "raise AirflowException" is added #55416 )
Supports --all-files, --cleanup (drop stale entries), and --generate (rebuild the allowlist from scratch).

Was generative AI tooling used to co-author this PR?

Yes, with help of Claude Code Opus 4.7 following the guidelines

Copilot

Pull request overview

This PR introduces a new prek/pre-commit hook intended to prevent regressions where functions decorated with @provide_session accept session positionally, enforcing the documented convention that session should be keyword-only.

Changes:

Add check_provide_session_kwargs.py prek hook that AST-scans Python files for @provide_session functions with positional session.
Introduce a shrinking allowlist (known_provide_session_positional.txt) to grandfather existing violations while preventing increases.
Add unit tests for decorator detection, violation counting, and allowlist tightening/cleanup behavior; wire the hook into .pre-commit-config.yaml.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`scripts/ci/prek/check_provide_session_kwargs.py`	Implements the new AST-based checker, allowlist manager, and CLI modes (`--all-files`, `--cleanup`, `--generate`).
`scripts/ci/prek/known_provide_session_positional.txt`	Initial allowlist of existing positional-`session` offenders with per-file maximum counts.
`scripts/tests/ci/prek/test_check_provide_session_kwargs.py`	Unit tests for the new hook’s core logic and allowlist behavior.
`.pre-commit-config.yaml`	Registers the new hook so it runs on relevant Python paths (and the allowlist/script paths).

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

When only the allowlist file is changed, the hook now unions the previous allowlist (from `git show HEAD:<file>`) with the current one, so removing an entry can't silently drop coverage for a file that still has positional `session` arguments.

Lee-W

a few nits, but nothing is blocking

- Drop ``task-sdk`` from ``_PROJECT_SOURCE_ROOTS`` and the docstring/help text; task-sdk does not use ``@provide_session``. - Rename ``_previous_allowlist`` to ``_parse_tracked_allowlist`` so the name is a verb and reflects that it parses the git-tracked (``HEAD``) version. - Rename test fixtures ``fake_repo`` and ``git_repo`` to ``create_fake_repo`` and ``create_git_repo`` to match the verb-prefix naming convention, and use ``@pytest.mark.usefixtures`` for tests that only need the side-effect.

airflow-ctl talks to Airflow via the API and has no @provide_session callsites, so scanning it is wasted work and misleading in the help text. The .pre-commit-config.yaml files pattern already only matches airflow-core|providers, so this just brings the script's own --all-files/--generate scope and docs in line.

jscheffl

LGTM!

boring-cyborgBot added area:dev-tools backport-to-v3-2-test labels May 19, 2026

jason810496 requested a review from Copilot May 19, 2026 04:51

jason810496 self-assigned this May 19, 2026

jason810496 removed the backport-to-v3-2-test label May 19, 2026

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 04:51 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:03

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:03 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:18

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:18 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:24

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:24 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:32

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:32 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from e8fdddb to cccdbc6Compare May 19, 2026 06:12

jason810496 requested a review from Copilot May 19, 2026 06:12

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:12 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 06:26

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:26 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 06:41

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:41 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

jason810496 marked this pull request as ready for review May 19, 2026 07:28

jason810496 added 3 commits May 22, 2026 16:37

Remove unused provide_session test fixture attribute
7c6e452

CI: Fix scripts/ci/prek/known_provide_session_positional.txt
19f2e2a

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from 184add7 to 19f2e2aCompare May 22, 2026 08:39

Lee-W reviewed May 22, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/known_provide_session_positional.txt
Comment thread.pre-commit-config.yaml Outdated

Narrow down the scope to airflow-core|providers
c787076

jason810496 requested a review from Lee-W May 25, 2026 14:20

Lee-W approved these changes May 26, 2026
View reviewed changes

jason810496 mentioned this pull request May 27, 2026
Make session parameter in dag_clear CLI keyword only #67582
Merged

Prab-27 reviewed May 27, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jscheffl approved these changes May 27, 2026
View reviewed changes

jason810496 merged commit 3276dde into apache:mainMay 28, 2026
143 checks passed

This was referenced Jun 3, 2026
Status of testing Providers that were prepared on June 02, 2026 #67957
Closed
Status of testing Providers that were prepared on June 08, 2026 #68225
Closed

jason810496 mentioned this pull request Jul 3, 2026
Consolidate AllowlistManager for prek hooks #69327
Merged
1 task

boring-cyborgBot added area:dev-tools backport-to-v3-2-test labels May 19, 2026

jason810496 requested a review from Copilot May 19, 2026 04:51

jason810496 self-assigned this May 19, 2026

jason810496 removed the backport-to-v3-2-test label May 19, 2026

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 04:51 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:03

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:03 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:18

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:18 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:24

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:24 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:32

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:32 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from e8fdddb to cccdbc6Compare May 19, 2026 06:12

jason810496 requested a review from Copilot May 19, 2026 06:12

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:12 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 06:26

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:26 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 06:41

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:41 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

jason810496 marked this pull request as ready for review May 19, 2026 07:28

jason810496 added 3 commits May 22, 2026 16:37

Remove unused provide_session test fixture attribute
7c6e452

CI: Fix scripts/ci/prek/known_provide_session_positional.txt
19f2e2a

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from 184add7 to 19f2e2aCompare May 22, 2026 08:39

Lee-W reviewed May 22, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/known_provide_session_positional.txt
Comment thread.pre-commit-config.yaml Outdated

Narrow down the scope to airflow-core|providers
c787076

jason810496 requested a review from Lee-W May 25, 2026 14:20

Lee-W approved these changes May 26, 2026
View reviewed changes

jason810496 mentioned this pull request May 27, 2026
Make session parameter in dag_clear CLI keyword only #67582
Merged

Prab-27 reviewed May 27, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jscheffl approved these changes May 27, 2026
View reviewed changes

jason810496 merged commit 3276dde into apache:mainMay 28, 2026
143 checks passed

This was referenced Jun 3, 2026
Status of testing Providers that were prepared on June 02, 2026 #67957
Closed
Status of testing Providers that were prepared on June 08, 2026 #68225
Closed

jason810496 mentioned this pull request Jul 3, 2026
Consolidate AllowlistManager for prek hooks #69327
Merged
1 task

boring-cyborgBot added area:dev-tools backport-to-v3-2-test labels May 19, 2026

jason810496 requested a review from Copilot May 19, 2026 04:51

jason810496 self-assigned this May 19, 2026

jason810496 removed the backport-to-v3-2-test label May 19, 2026

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 04:51 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:03

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:03 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:18

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:18 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:24

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:24 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:32

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:32 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from e8fdddb to cccdbc6Compare May 19, 2026 06:12

jason810496 requested a review from Copilot May 19, 2026 06:12

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:12 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 06:26

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:26 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 06:41

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:41 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

jason810496 marked this pull request as ready for review May 19, 2026 07:28

jason810496 added 3 commits May 22, 2026 16:37

Remove unused provide_session test fixture attribute
7c6e452

CI: Fix scripts/ci/prek/known_provide_session_positional.txt
19f2e2a

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from 184add7 to 19f2e2aCompare May 22, 2026 08:39

Lee-W reviewed May 22, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/known_provide_session_positional.txt
Comment thread.pre-commit-config.yaml Outdated

Narrow down the scope to airflow-core|providers
c787076

jason810496 requested a review from Lee-W May 25, 2026 14:20

Lee-W approved these changes May 26, 2026
View reviewed changes

jason810496 mentioned this pull request May 27, 2026
Make session parameter in dag_clear CLI keyword only #67582
Merged

Prab-27 reviewed May 27, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jscheffl approved these changes May 27, 2026
View reviewed changes

jason810496 merged commit 3276dde into apache:mainMay 28, 2026
143 checks passed

This was referenced Jun 3, 2026
Status of testing Providers that were prepared on June 02, 2026 #67957
Closed
Status of testing Providers that were prepared on June 08, 2026 #68225
Closed

jason810496 mentioned this pull request Jul 3, 2026
Consolidate AllowlistManager for prek hooks #69327
Merged
1 task

boring-cyborgBot added area:dev-tools backport-to-v3-2-test labels May 19, 2026

jason810496 requested a review from Copilot May 19, 2026 04:51

jason810496 self-assigned this May 19, 2026

jason810496 removed the backport-to-v3-2-test label May 19, 2026

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 04:51 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:03

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:03 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:18

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:18 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:24

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:24 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:32

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:32 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from e8fdddb to cccdbc6Compare May 19, 2026 06:12

jason810496 requested a review from Copilot May 19, 2026 06:12

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:12 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 06:26

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:26 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 06:41

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:41 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

jason810496 marked this pull request as ready for review May 19, 2026 07:28

jason810496 added 3 commits May 22, 2026 16:37

Remove unused provide_session test fixture attribute
7c6e452

CI: Fix scripts/ci/prek/known_provide_session_positional.txt
19f2e2a

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from 184add7 to 19f2e2aCompare May 22, 2026 08:39

Lee-W reviewed May 22, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/known_provide_session_positional.txt
Comment thread.pre-commit-config.yaml Outdated

Narrow down the scope to airflow-core|providers
c787076

jason810496 requested a review from Lee-W May 25, 2026 14:20

Lee-W approved these changes May 26, 2026
View reviewed changes

jason810496 mentioned this pull request May 27, 2026
Make session parameter in dag_clear CLI keyword only #67582
Merged

Prab-27 reviewed May 27, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jscheffl approved these changes May 27, 2026
View reviewed changes

jason810496 merged commit 3276dde into apache:mainMay 28, 2026
143 checks passed

This was referenced Jun 3, 2026
Status of testing Providers that were prepared on June 02, 2026 #67957
Closed
Status of testing Providers that were prepared on June 08, 2026 #68225
Closed

jason810496 mentioned this pull request Jul 3, 2026
Consolidate AllowlistManager for prek hooks #69327
Merged
1 task

boring-cyborgBot added area:dev-tools backport-to-v3-2-test labels May 19, 2026

jason810496 requested a review from Copilot May 19, 2026 04:51

jason810496 self-assigned this May 19, 2026

jason810496 removed the backport-to-v3-2-test label May 19, 2026

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 04:51 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:03

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:03 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:18

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:18 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:24

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:24 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:32

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:32 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from e8fdddb to cccdbc6Compare May 19, 2026 06:12

jason810496 requested a review from Copilot May 19, 2026 06:12

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:12 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 06:26

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:26 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 06:41

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:41 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

jason810496 marked this pull request as ready for review May 19, 2026 07:28

jason810496 added 3 commits May 22, 2026 16:37

Remove unused provide_session test fixture attribute
7c6e452

CI: Fix scripts/ci/prek/known_provide_session_positional.txt
19f2e2a

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from 184add7 to 19f2e2aCompare May 22, 2026 08:39

Lee-W reviewed May 22, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/known_provide_session_positional.txt
Comment thread.pre-commit-config.yaml Outdated

Narrow down the scope to airflow-core|providers
c787076

jason810496 requested a review from Lee-W May 25, 2026 14:20

Lee-W approved these changes May 26, 2026
View reviewed changes

jason810496 mentioned this pull request May 27, 2026
Make session parameter in dag_clear CLI keyword only #67582
Merged

Prab-27 reviewed May 27, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jscheffl approved these changes May 27, 2026
View reviewed changes

jason810496 merged commit 3276dde into apache:mainMay 28, 2026
143 checks passed

This was referenced Jun 3, 2026
Status of testing Providers that were prepared on June 02, 2026 #67957
Closed
Status of testing Providers that were prepared on June 08, 2026 #68225
Closed

jason810496 mentioned this pull request Jul 3, 2026
Consolidate AllowlistManager for prek hooks #69327
Merged
1 task

boring-cyborgBot added area:dev-tools backport-to-v3-2-test labels May 19, 2026

jason810496 requested a review from Copilot May 19, 2026 04:51

jason810496 self-assigned this May 19, 2026

jason810496 removed the backport-to-v3-2-test label May 19, 2026

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 04:51 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:03

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:03 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:18

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:18 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:24

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:24 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:32

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:32 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from e8fdddb to cccdbc6Compare May 19, 2026 06:12

jason810496 requested a review from Copilot May 19, 2026 06:12

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:12 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 06:26

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:26 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 06:41

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:41 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

jason810496 marked this pull request as ready for review May 19, 2026 07:28

jason810496 added 3 commits May 22, 2026 16:37

Remove unused provide_session test fixture attribute
7c6e452

CI: Fix scripts/ci/prek/known_provide_session_positional.txt
19f2e2a

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from 184add7 to 19f2e2aCompare May 22, 2026 08:39

Lee-W reviewed May 22, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/known_provide_session_positional.txt
Comment thread.pre-commit-config.yaml Outdated

Narrow down the scope to airflow-core|providers
c787076

jason810496 requested a review from Lee-W May 25, 2026 14:20

Lee-W approved these changes May 26, 2026
View reviewed changes

jason810496 mentioned this pull request May 27, 2026
Make session parameter in dag_clear CLI keyword only #67582
Merged

Prab-27 reviewed May 27, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jscheffl approved these changes May 27, 2026
View reviewed changes

jason810496 merged commit 3276dde into apache:mainMay 28, 2026
143 checks passed

This was referenced Jun 3, 2026
Status of testing Providers that were prepared on June 02, 2026 #67957
Closed
Status of testing Providers that were prepared on June 08, 2026 #68225
Closed

jason810496 mentioned this pull request Jul 3, 2026
Consolidate AllowlistManager for prek hooks #69327
Merged
1 task

boring-cyborgBot added area:dev-tools backport-to-v3-2-test labels May 19, 2026

jason810496 requested a review from Copilot May 19, 2026 04:51

jason810496 self-assigned this May 19, 2026

jason810496 removed the backport-to-v3-2-test label May 19, 2026

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 04:51 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:03

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:03 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:18

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:18 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:24

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:24 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:32

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:32 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from e8fdddb to cccdbc6Compare May 19, 2026 06:12

jason810496 requested a review from Copilot May 19, 2026 06:12

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:12 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 06:26

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:26 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 06:41

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:41 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

jason810496 marked this pull request as ready for review May 19, 2026 07:28

jason810496 added 3 commits May 22, 2026 16:37

Remove unused provide_session test fixture attribute
7c6e452

CI: Fix scripts/ci/prek/known_provide_session_positional.txt
19f2e2a

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from 184add7 to 19f2e2aCompare May 22, 2026 08:39

Lee-W reviewed May 22, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/known_provide_session_positional.txt
Comment thread.pre-commit-config.yaml Outdated

Narrow down the scope to airflow-core|providers
c787076

jason810496 requested a review from Lee-W May 25, 2026 14:20

Lee-W approved these changes May 26, 2026
View reviewed changes

jason810496 mentioned this pull request May 27, 2026
Make session parameter in dag_clear CLI keyword only #67582
Merged

Prab-27 reviewed May 27, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jscheffl approved these changes May 27, 2026
View reviewed changes

jason810496 merged commit 3276dde into apache:mainMay 28, 2026
143 checks passed

This was referenced Jun 3, 2026
Status of testing Providers that were prepared on June 02, 2026 #67957
Closed
Status of testing Providers that were prepared on June 08, 2026 #68225
Closed

jason810496 mentioned this pull request Jul 3, 2026
Consolidate AllowlistManager for prek hooks #69327
Merged
1 task

boring-cyborgBot added area:dev-tools backport-to-v3-2-test labels May 19, 2026

jason810496 requested a review from Copilot May 19, 2026 04:51

jason810496 self-assigned this May 19, 2026

jason810496 removed the backport-to-v3-2-test label May 19, 2026

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 04:51 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:03

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:03 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:18

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:18 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 05:24

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:24 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 05:32

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 05:32 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from e8fdddb to cccdbc6Compare May 19, 2026 06:12

jason810496 requested a review from Copilot May 19, 2026 06:12

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:12 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py Outdated

jason810496 requested a review from Copilot May 19, 2026 06:26

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:26 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/tests/ci/prek/test_check_provide_session_kwargs.py

jason810496 requested a review from Copilot May 19, 2026 06:41

Copilotstarted reviewing on behalf of jason810496 May 19, 2026 06:41 View session

CopilotAI reviewed May 19, 2026
View reviewed changes

jason810496 marked this pull request as ready for review May 19, 2026 07:28

jason810496 added 3 commits May 22, 2026 16:37

Remove unused provide_session test fixture attribute
7c6e452

CI: Fix scripts/ci/prek/known_provide_session_positional.txt
19f2e2a

jason810496 force-pushed the prek-hook-provide-session-kwargs branch from 184add7 to 19f2e2aCompare May 22, 2026 08:39

Lee-W reviewed May 22, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py
Comment threadscripts/ci/prek/known_provide_session_positional.txt
Comment thread.pre-commit-config.yaml Outdated

Narrow down the scope to airflow-core|providers
c787076

jason810496 requested a review from Lee-W May 25, 2026 14:20

Lee-W approved these changes May 26, 2026
View reviewed changes

jason810496 mentioned this pull request May 27, 2026
Make session parameter in dag_clear CLI keyword only #67582
Merged

Prab-27 reviewed May 27, 2026
View reviewed changes

Comment threadscripts/ci/prek/check_provide_session_kwargs.py Outdated

jscheffl approved these changes May 27, 2026
View reviewed changes

jason810496 merged commit 3276dde into apache:mainMay 28, 2026
143 checks passed

This was referenced Jun 3, 2026
Status of testing Providers that were prepared on June 02, 2026 #67957
Closed
Status of testing Providers that were prepared on June 08, 2026 #68225
Closed

jason810496 mentioned this pull request Jul 3, 2026
Consolidate AllowlistManager for prek hooks #69327
Merged
1 task

Uh oh!

Conversation

jason810496 commented May 19, 2026

Why

What

Was generative AI tooling used to co-author this PR?

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lee-W left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jscheffl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development