Skip to content

Restore Monaco find widget in Dag Code view - #67391

Merged
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview
May 26, 2026
Merged

Restore Monaco find widget in Dag Code view#67391
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview

Conversation

@choo121600

@choo121600choo121600 commented May 23, 2026

Copy link
Copy Markdown
Member

Cmd/Ctrl+F in the Dag Code view opened the browser's native find bar instead of Monaco's find widget, and the widget icons rendered incorrectly in DEV_MODE=true.

Root cause

  • configureMonaco.ts imported only editor.api, which does not include
    the standalone find contribution or codicon font styles.

Fix

  • Explicitly import findController in
    configureMonaco.ts.

Before

image

After

image

part of: #67359


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

opus 4.7


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 23, 2026
@choo121600choo121600 linked an issue May 24, 2026 that may be closed by this pull request
2 tasks
@bbovenzi

Copy link
Copy Markdown
Contributor

Did you remove the sever.origin changes?

Also, we need to rebase

@choo121600

Copy link
Copy Markdown
MemberAuthor

Did you remove the sever.origin changes?

That part was already resolved by. #67316 during a rebase, so it disappeared afterward.
I'll update the PR description and rebase again ;)

@choo121600
choo121600force-pushed the fix/find-widget-in-codeview branch from 2713e53 to 8850a34CompareMay 26, 2026 18:53
@choo121600
choo121600 merged commit e56da19 into apache:mainMay 26, 2026
83 checks passed
@choo121600

Copy link
Copy Markdown
MemberAuthor

Thanks :)

@github-actionsgithub-actionsBot added this to the Airflow 3.2.3 milestone May 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.3 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
pierrejeambrun pushed a commit that referenced this pull request May 27, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 29, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve dag code readability on Airflow UI

3 participants

@choo121600@bbovenzi@vatsrahul1001
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Restore Monaco find widget in Dag Code view by choo121600 · Pull Request #67391 · apache/airflow · GitHub
Skip to content

Restore Monaco find widget in Dag Code view - #67391

Merged
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview
May 26, 2026
Merged

Restore Monaco find widget in Dag Code view#67391
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview

Conversation

@choo121600

@choo121600choo121600 commented May 23, 2026

Copy link
Copy Markdown
Member

Cmd/Ctrl+F in the Dag Code view opened the browser's native find bar instead of Monaco's find widget, and the widget icons rendered incorrectly in DEV_MODE=true.

Root cause

  • configureMonaco.ts imported only editor.api, which does not include
    the standalone find contribution or codicon font styles.

Fix

  • Explicitly import findController in
    configureMonaco.ts.

Before

image

After

image

part of: #67359


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

opus 4.7


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 23, 2026
@choo121600choo121600 linked an issue May 24, 2026 that may be closed by this pull request
2 tasks
@bbovenzi

Copy link
Copy Markdown
Contributor

Did you remove the sever.origin changes?

Also, we need to rebase

@choo121600

Copy link
Copy Markdown
MemberAuthor

Did you remove the sever.origin changes?

That part was already resolved by. #67316 during a rebase, so it disappeared afterward.
I'll update the PR description and rebase again ;)

@choo121600
choo121600force-pushed the fix/find-widget-in-codeview branch from 2713e53 to 8850a34CompareMay 26, 2026 18:53
@choo121600
choo121600 merged commit e56da19 into apache:mainMay 26, 2026
83 checks passed
@choo121600

Copy link
Copy Markdown
MemberAuthor

Thanks :)

@github-actionsgithub-actionsBot added this to the Airflow 3.2.3 milestone May 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.3 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
pierrejeambrun pushed a commit that referenced this pull request May 27, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 29, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve dag code readability on Airflow UI

3 participants

@choo121600@bbovenzi@vatsrahul1001
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Restore Monaco find widget in Dag Code view by choo121600 · Pull Request #67391 · apache/airflow · GitHub
Skip to content

Restore Monaco find widget in Dag Code view - #67391

Merged
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview
May 26, 2026
Merged

Restore Monaco find widget in Dag Code view#67391
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview

Conversation

@choo121600

@choo121600choo121600 commented May 23, 2026

Copy link
Copy Markdown
Member

Cmd/Ctrl+F in the Dag Code view opened the browser's native find bar instead of Monaco's find widget, and the widget icons rendered incorrectly in DEV_MODE=true.

Root cause

  • configureMonaco.ts imported only editor.api, which does not include
    the standalone find contribution or codicon font styles.

Fix

  • Explicitly import findController in
    configureMonaco.ts.

Before

image

After

image

part of: #67359


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

opus 4.7


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 23, 2026
@choo121600choo121600 linked an issue May 24, 2026 that may be closed by this pull request
2 tasks
@bbovenzi

Copy link
Copy Markdown
Contributor

Did you remove the sever.origin changes?

Also, we need to rebase

@choo121600

Copy link
Copy Markdown
MemberAuthor

Did you remove the sever.origin changes?

That part was already resolved by. #67316 during a rebase, so it disappeared afterward.
I'll update the PR description and rebase again ;)

@choo121600
choo121600force-pushed the fix/find-widget-in-codeview branch from 2713e53 to 8850a34CompareMay 26, 2026 18:53
@choo121600
choo121600 merged commit e56da19 into apache:mainMay 26, 2026
83 checks passed
@choo121600

Copy link
Copy Markdown
MemberAuthor

Thanks :)

@github-actionsgithub-actionsBot added this to the Airflow 3.2.3 milestone May 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.3 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
pierrejeambrun pushed a commit that referenced this pull request May 27, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 29, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve dag code readability on Airflow UI

3 participants

@choo121600@bbovenzi@vatsrahul1001
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Restore Monaco find widget in Dag Code view by choo121600 · Pull Request #67391 · apache/airflow · GitHub
Skip to content

Restore Monaco find widget in Dag Code view - #67391

Merged
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview
May 26, 2026
Merged

Restore Monaco find widget in Dag Code view#67391
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview

Conversation

@choo121600

@choo121600choo121600 commented May 23, 2026

Copy link
Copy Markdown
Member

Cmd/Ctrl+F in the Dag Code view opened the browser's native find bar instead of Monaco's find widget, and the widget icons rendered incorrectly in DEV_MODE=true.

Root cause

  • configureMonaco.ts imported only editor.api, which does not include
    the standalone find contribution or codicon font styles.

Fix

  • Explicitly import findController in
    configureMonaco.ts.

Before

image

After

image

part of: #67359


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

opus 4.7


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 23, 2026
@choo121600choo121600 linked an issue May 24, 2026 that may be closed by this pull request
2 tasks
@bbovenzi

Copy link
Copy Markdown
Contributor

Did you remove the sever.origin changes?

Also, we need to rebase

@choo121600

Copy link
Copy Markdown
MemberAuthor

Did you remove the sever.origin changes?

That part was already resolved by. #67316 during a rebase, so it disappeared afterward.
I'll update the PR description and rebase again ;)

@choo121600
choo121600force-pushed the fix/find-widget-in-codeview branch from 2713e53 to 8850a34CompareMay 26, 2026 18:53
@choo121600
choo121600 merged commit e56da19 into apache:mainMay 26, 2026
83 checks passed
@choo121600

Copy link
Copy Markdown
MemberAuthor

Thanks :)

@github-actionsgithub-actionsBot added this to the Airflow 3.2.3 milestone May 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.3 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
pierrejeambrun pushed a commit that referenced this pull request May 27, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 29, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve dag code readability on Airflow UI

3 participants

@choo121600@bbovenzi@vatsrahul1001
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Restore Monaco find widget in Dag Code view by choo121600 · Pull Request #67391 · apache/airflow · GitHub
Skip to content

Restore Monaco find widget in Dag Code view - #67391

Merged
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview
May 26, 2026
Merged

Restore Monaco find widget in Dag Code view#67391
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview

Conversation

@choo121600

@choo121600choo121600 commented May 23, 2026

Copy link
Copy Markdown
Member

Cmd/Ctrl+F in the Dag Code view opened the browser's native find bar instead of Monaco's find widget, and the widget icons rendered incorrectly in DEV_MODE=true.

Root cause

  • configureMonaco.ts imported only editor.api, which does not include
    the standalone find contribution or codicon font styles.

Fix

  • Explicitly import findController in
    configureMonaco.ts.

Before

image

After

image

part of: #67359


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

opus 4.7


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 23, 2026
@choo121600choo121600 linked an issue May 24, 2026 that may be closed by this pull request
2 tasks
@bbovenzi

Copy link
Copy Markdown
Contributor

Did you remove the sever.origin changes?

Also, we need to rebase

@choo121600

Copy link
Copy Markdown
MemberAuthor

Did you remove the sever.origin changes?

That part was already resolved by. #67316 during a rebase, so it disappeared afterward.
I'll update the PR description and rebase again ;)

@choo121600
choo121600force-pushed the fix/find-widget-in-codeview branch from 2713e53 to 8850a34CompareMay 26, 2026 18:53
@choo121600
choo121600 merged commit e56da19 into apache:mainMay 26, 2026
83 checks passed
@choo121600

Copy link
Copy Markdown
MemberAuthor

Thanks :)

@github-actionsgithub-actionsBot added this to the Airflow 3.2.3 milestone May 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.3 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
pierrejeambrun pushed a commit that referenced this pull request May 27, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 29, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve dag code readability on Airflow UI

3 participants

@choo121600@bbovenzi@vatsrahul1001
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Restore Monaco find widget in Dag Code view by choo121600 · Pull Request #67391 · apache/airflow · GitHub
Skip to content

Restore Monaco find widget in Dag Code view - #67391

Merged
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview
May 26, 2026
Merged

Restore Monaco find widget in Dag Code view#67391
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview

Conversation

@choo121600

@choo121600choo121600 commented May 23, 2026

Copy link
Copy Markdown
Member

Cmd/Ctrl+F in the Dag Code view opened the browser's native find bar instead of Monaco's find widget, and the widget icons rendered incorrectly in DEV_MODE=true.

Root cause

  • configureMonaco.ts imported only editor.api, which does not include
    the standalone find contribution or codicon font styles.

Fix

  • Explicitly import findController in
    configureMonaco.ts.

Before

image

After

image

part of: #67359


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

opus 4.7


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 23, 2026
@choo121600choo121600 linked an issue May 24, 2026 that may be closed by this pull request
2 tasks
@bbovenzi

Copy link
Copy Markdown
Contributor

Did you remove the sever.origin changes?

Also, we need to rebase

@choo121600

Copy link
Copy Markdown
MemberAuthor

Did you remove the sever.origin changes?

That part was already resolved by. #67316 during a rebase, so it disappeared afterward.
I'll update the PR description and rebase again ;)

@choo121600
choo121600force-pushed the fix/find-widget-in-codeview branch from 2713e53 to 8850a34CompareMay 26, 2026 18:53
@choo121600
choo121600 merged commit e56da19 into apache:mainMay 26, 2026
83 checks passed
@choo121600

Copy link
Copy Markdown
MemberAuthor

Thanks :)

@github-actionsgithub-actionsBot added this to the Airflow 3.2.3 milestone May 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.3 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
pierrejeambrun pushed a commit that referenced this pull request May 27, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 29, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve dag code readability on Airflow UI

3 participants

@choo121600@bbovenzi@vatsrahul1001
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Restore Monaco find widget in Dag Code view by choo121600 · Pull Request #67391 · apache/airflow · GitHub
Skip to content

Restore Monaco find widget in Dag Code view - #67391

Merged
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview
May 26, 2026
Merged

Restore Monaco find widget in Dag Code view#67391
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview

Conversation

@choo121600

@choo121600choo121600 commented May 23, 2026

Copy link
Copy Markdown
Member

Cmd/Ctrl+F in the Dag Code view opened the browser's native find bar instead of Monaco's find widget, and the widget icons rendered incorrectly in DEV_MODE=true.

Root cause

  • configureMonaco.ts imported only editor.api, which does not include
    the standalone find contribution or codicon font styles.

Fix

  • Explicitly import findController in
    configureMonaco.ts.

Before

image

After

image

part of: #67359


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

opus 4.7


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 23, 2026
@choo121600choo121600 linked an issue May 24, 2026 that may be closed by this pull request
2 tasks
@bbovenzi

Copy link
Copy Markdown
Contributor

Did you remove the sever.origin changes?

Also, we need to rebase

@choo121600

Copy link
Copy Markdown
MemberAuthor

Did you remove the sever.origin changes?

That part was already resolved by. #67316 during a rebase, so it disappeared afterward.
I'll update the PR description and rebase again ;)

@choo121600
choo121600force-pushed the fix/find-widget-in-codeview branch from 2713e53 to 8850a34CompareMay 26, 2026 18:53
@choo121600
choo121600 merged commit e56da19 into apache:mainMay 26, 2026
83 checks passed
@choo121600

Copy link
Copy Markdown
MemberAuthor

Thanks :)

@github-actionsgithub-actionsBot added this to the Airflow 3.2.3 milestone May 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.3 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
pierrejeambrun pushed a commit that referenced this pull request May 27, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 29, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve dag code readability on Airflow UI

3 participants

@choo121600@bbovenzi@vatsrahul1001
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Restore Monaco find widget in Dag Code view by choo121600 · Pull Request #67391 · apache/airflow · GitHub
Skip to content

Restore Monaco find widget in Dag Code view - #67391

Merged
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview
May 26, 2026
Merged

Restore Monaco find widget in Dag Code view#67391
choo121600 merged 1 commit into
apache:mainfrom
choo121600:fix/find-widget-in-codeview

Conversation

@choo121600

@choo121600choo121600 commented May 23, 2026

Copy link
Copy Markdown
Member

Cmd/Ctrl+F in the Dag Code view opened the browser's native find bar instead of Monaco's find widget, and the widget icons rendered incorrectly in DEV_MODE=true.

Root cause

  • configureMonaco.ts imported only editor.api, which does not include
    the standalone find contribution or codicon font styles.

Fix

  • Explicitly import findController in
    configureMonaco.ts.

Before

image

After

image

part of: #67359


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

opus 4.7


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborgboring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label May 23, 2026
@choo121600choo121600 linked an issue May 24, 2026 that may be closed by this pull request
2 tasks
@bbovenzi

Copy link
Copy Markdown
Contributor

Did you remove the sever.origin changes?

Also, we need to rebase

@choo121600

Copy link
Copy Markdown
MemberAuthor

Did you remove the sever.origin changes?

That part was already resolved by. #67316 during a rebase, so it disappeared afterward.
I'll update the PR description and rebase again ;)

@choo121600
choo121600force-pushed the fix/find-widget-in-codeview branch from 2713e53 to 8850a34CompareMay 26, 2026 18:53
@choo121600
choo121600 merged commit e56da19 into apache:mainMay 26, 2026
83 checks passed
@choo121600

Copy link
Copy Markdown
MemberAuthor

Thanks :)

@github-actionsgithub-actionsBot added this to the Airflow 3.2.3 milestone May 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.3 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

StatusBranchResult
v3-2-testPR Link

github-actionsBot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request May 26, 2026
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
pierrejeambrun pushed a commit that referenced this pull request May 27, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 29, 2026
)
(cherry picked from commit e56da19)
Co-authored-by: Yeonguk Choo <choo121600@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UIRelated to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve dag code readability on Airflow UI

3 participants

@choo121600@bbovenzi@vatsrahul1001