Uh oh!
There was an error while loading. Please reload this page.
API: Return 400 instead of 500 from materialize_asset on invalid input - #67445
Merged
jason810496 merged 1 commit intoMay 26, 2026
Merged
Conversation
dkranchii
requested review from
bugraoz93, choo121600, ephraimbuddy, jason810496, pierrejeambrun, rawwar and shubhamraj-git
as code ownersMay 24, 2026 22:02
…idation input The materialize_asset POST endpoint passed user input (dag_run_id, logical_date/data_interval pairing, partition_key) straight through to MaterializeAssetBody.validate_context() and dag.create_dagrun(), which raise ValueError / ParamValidationError on invalid input (e.g. dag_run_id containing '..', invalid partition_key type, logical_date/data_interval mismatch). Those exceptions escaped uncaught and were returned as 500 Internal Server Error, even though the route's OpenAPI spec already documents 400 for this case. Wrap the validate_context / create_dagrun calls in try/except and re-raise as HTTPException(400) with the validator's message in the detail, matching the sibling pattern in dag_run.trigger_dag_run. Regression test asserts dag_run_id='bad..id' returns 400, not 500.
dkranchiiforce-pushed
the
fix/materialize-asset-validation-400
branch
from
May 24, 2026 22:08
4461546 to
3353f9dComparejason810496
approved these changes
May 26, 2026
Member
There was a problem hiding this comment.
Nice!
Nice to see the #67221 agent rule did catch the violation.
Contributor
Backport failed to create: v3-2-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 0120ba7 v3-2-testThis should apply the commit to the v3-2-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
jason810496
commented
May 26, 2026
Member
Manual backport: #67526 |
jason810496 pushed a commit
to jason810496/airflow
that referenced
this pull request
May 26, 2026
… invalid validation input (apache#67445) The materialize_asset POST endpoint passed user input (dag_run_id, logical_date/data_interval pairing, partition_key) straight through to MaterializeAssetBody.validate_context() and dag.create_dagrun(), which raise ValueError / ParamValidationError on invalid input (e.g. dag_run_id containing '..', invalid partition_key type, logical_date/data_interval mismatch). Those exceptions escaped uncaught and were returned as 500 Internal Server Error, even though the route's OpenAPI spec already documents 400 for this case. Wrap the validate_context / create_dagrun calls in try/except and re-raise as HTTPException(400) with the validator's message in the detail, matching the sibling pattern in dag_run.trigger_dag_run. Regression test asserts dag_run_id='bad..id' returns 400, not 500. (cherry picked from commit 0120ba7) Co-authored-by: Deepak kumar <deepakkumar@meta.com>
pierrejeambrun pushed a commit
that referenced
this pull request
May 27, 2026
… invalid validation input (#67445) (#67526) The materialize_asset POST endpoint passed user input (dag_run_id, logical_date/data_interval pairing, partition_key) straight through to MaterializeAssetBody.validate_context() and dag.create_dagrun(), which raise ValueError / ParamValidationError on invalid input (e.g. dag_run_id containing '..', invalid partition_key type, logical_date/data_interval mismatch). Those exceptions escaped uncaught and were returned as 500 Internal Server Error, even though the route's OpenAPI spec already documents 400 for this case. Wrap the validate_context / create_dagrun calls in try/except and re-raise as HTTPException(400) with the validator's message in the detail, matching the sibling pattern in dag_run.trigger_dag_run. Regression test asserts dag_run_id='bad..id' returns 400, not 500. (cherry picked from commit 0120ba7) Co-authored-by: Deepak kumar <deepakkumar@meta.com>
vatsrahul1001 pushed a commit
that referenced
this pull request
May 29, 2026
… invalid validation input (#67445) (#67526) The materialize_asset POST endpoint passed user input (dag_run_id, logical_date/data_interval pairing, partition_key) straight through to MaterializeAssetBody.validate_context() and dag.create_dagrun(), which raise ValueError / ParamValidationError on invalid input (e.g. dag_run_id containing '..', invalid partition_key type, logical_date/data_interval mismatch). Those exceptions escaped uncaught and were returned as 500 Internal Server Error, even though the route's OpenAPI spec already documents 400 for this case. Wrap the validate_context / create_dagrun calls in try/except and re-raise as HTTPException(400) with the validator's message in the detail, matching the sibling pattern in dag_run.trigger_dag_run. Regression test asserts dag_run_id='bad..id' returns 400, not 500. (cherry picked from commit 0120ba7) Co-authored-by: Deepak kumar <deepakkumar@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
POST /assets/{asset_id}/materializeendpoint passed user input (dag_run_id,logical_date/data_intervalpairing,partition_key) straight through toMaterializeAssetBody.validate_context()anddag.create_dagrun(). Those raiseValueError/ParamValidationErroron invalid input — e.g.dag_run_idcontaining..(path-traversal guard inDagRun.validate_run_id),logical_dateset with nodata_interval, or apartition_keyof the wrong type. The exceptions escaped uncaught and were returned as 500 Internal Server Error, even though the route's OpenAPI spec already documents 400 for this case.This wraps the
validate_context/create_dagruncalls in atry/except (ParamValidationError, ValueError)and re-raises asHTTPException(400)with the validator's message in thedetail. Mirrors the established pattern in the sibling endpointairflow.api_fastapi.core_api.routes.public.dag_run.trigger_dag_run.Reproduction (before)
After
Tests
Adds
TestPostAssetMaterialize::test_should_respond_400_on_invalid_dag_run_idasserting the endpoint returns 400 with the validator's message. The test fails (returns 500) on the unpatched code.Related
AGENTS.mdrule added in AGENTS.md: require translating domain-layer exceptions toHTTPExceptionat FastAPI route boundaries #67221: "Translate domain-layer exceptions to HTTPException at FastAPI route boundaries."airflow.api_fastapi.core_api.routes.public.dag_run.trigger_dag_run.Was generative AI tooling used to co-author this PR?