Skip to content

Guard JavaCoordinator JAR scan against symlink cycles - #67693

Merged
jason810496 merged 2 commits into
apache:mainfrom
jason810496:refactor/coordinator/harden-java-coordinator-discovery
May 31, 2026
Merged

Guard JavaCoordinator JAR scan against symlink cycles#67693
jason810496 merged 2 commits into
apache:mainfrom
jason810496:refactor/coordinator/harden-java-coordinator-discovery

Conversation

@jason810496

@jason810496jason810496 commented May 29, 2026

Copy link
Copy Markdown
Member

Why

Caught by claude during self-review in #67161, we should guard symlink loop or a hardlinked directory under jars_root. Otherwise, the _find_jars will enter infinite recursion loop and OOM.

Was generative AI tooling used to co-author this PR?

@jason810496jason810496 self-assigned this May 29, 2026
@jason810496
jason810496 requested a review from uranusjrMay 29, 2026 08:36
@jason810496jason810496 added the area:coordinator Coordinator: The interface to spawn Lang-SDK subprocesses label May 29, 2026
@jason810496jason810496 moved this from Backlog to In review in Java-SDKMay 29, 2026
@jason810496jason810496 added this to the Airflow 3.3.0 milestone May 29, 2026
uranusjr
uranusjr reviewed May 29, 2026
View reviewed changes
Comment threadtask-sdk/src/airflow/sdk/coordinators/java/coordinator.py Outdated
uranusjr
uranusjr reviewed May 29, 2026
View reviewed changes
Comment threadtask-sdk/src/airflow/sdk/coordinators/java/coordinator.py Outdated
@jason810496
Guard JavaCoordinator JAR scan against symlink cycles
91e2a5c
@jason810496
Iterate JAR directories lazily and log Path directly
ff4c02b
Drop the per-directory list() materialization in the JAR scan in favor of
a lazy iterdir() walk, keeping a small helper so an unreadable directory is
skipped instead of aborting the scan. Pass the Path straight to the debug
log rather than stringifying it, matching the other log calls.
@jason810496
jason810496force-pushed the refactor/coordinator/harden-java-coordinator-discovery branch from 1415782 to ff4c02bCompareMay 30, 2026 10:12
@jason810496
jason810496 merged commit 233d3cb into apache:mainMay 31, 2026
115 checks passed
@github-project-automationgithub-project-automationBot moved this from In review to Done in Java-SDKMay 31, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjruranusjruranusjr left review comments
@kaxilkaxilkaxil approved these changes
@ashbashbAwaiting requested review from ashb
@amoghrajeshamoghrajeshAwaiting requested review from amoghrajesh

Assignees

@jason810496jason810496

Labels

area:coordinatorCoordinator: The interface to spawn Lang-SDK subprocessesarea:task-sdk

Projects

Java-SDK
Status: Done

Milestone

Java SDK 1.0 GA

Development

Successfully merging this pull request may close these issues.

4 participants

@jason810496@uranusjr@kaxil@vatsrahul1001