[v3-2-test] UI: Fix Graph layout for TaskGroup tasks wired to external nodes (#67720) by github-actions[bot] · Pull Request #67830 · apache/airflow

github-actions · 2026-06-01T09:51:34Z

Open @task_group rendered with vertically-stacked internals and edges
crossing the boundary whenever an internal task had a direct dependency
on a node outside the group (an "escape edge" that bypassed the group's
entry/exit interface). Dag execution was unaffected.

Two underlying issues, both in the ELK graph-layout refactor from #65031:

hasUniformExternalConnectivity was too lenient — it fired whenever
externally-connected children separately shared the same external
sources OR the same external targets, instead of the canonical
fan-in/fan-out pattern where every child has the same full
(sources, targets) profile. On mixed-profile groups (entry +
exits), it incorrectly fired and collapsed the author's deliberately-
wired escape edges into a single group-level edge, hiding the intent.
When the optimisation did fire on an open group, rewriteGroupEdges
was tuned for closed groups and dropped the group's internal edges
too, leaving ELK with no internal-layout information for the children
(the visible symptom in 3.2.2 Graph View breaks when TaskGroup outputs connect internal tasks to external downstream tasks #67714).

Fix: tighten hasUniformExternalConnectivity to require the full
profile to match across externally-connected children, and add a
preserveInternal option to rewriteGroupEdges so the canonical
fan-in/fan-out path keeps internals intact.
(cherry picked from commit 55780f2)

Co-authored-by: Rahul Vats 43964496+vatsrahul1001@users.noreply.github.com
Closes: #67714

…l nodes (#67720) Open ``@task_group`` rendered with vertically-stacked internals and edges crossing the boundary whenever an internal task had a direct dependency on a node outside the group (an "escape edge" that bypassed the group's entry/exit interface). Dag execution was unaffected. Two underlying issues, both in the ELK graph-layout refactor from #65031: 1. ``hasUniformExternalConnectivity`` was too lenient — it fired whenever externally-connected children separately shared the same external sources OR the same external targets, instead of the canonical fan-in/fan-out pattern where every child has the same full ``(sources, targets)`` profile. On mixed-profile groups (entry + exits), it incorrectly fired and collapsed the author's deliberately- wired escape edges into a single group-level edge, hiding the intent. 2. When the optimisation did fire on an open group, ``rewriteGroupEdges`` was tuned for closed groups and dropped the group's internal edges too, leaving ELK with no internal-layout information for the children (the visible symptom in #67714). Fix: tighten ``hasUniformExternalConnectivity`` to require the full profile to match across externally-connected children, and add a ``preserveInternal`` option to ``rewriteGroupEdges`` so the canonical fan-in/fan-out path keeps internals intact. (cherry picked from commit 55780f2) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com> Closes: #67714

github-actions · 2026-06-01T09:51:34Z

Open @task_group rendered with vertically-stacked internals and edges
crossing the boundary whenever an internal task had a direct dependency
on a node outside the group (an "escape edge" that bypassed the group's
entry/exit interface). Dag execution was unaffected.

Two underlying issues, both in the ELK graph-layout refactor from #65031:

hasUniformExternalConnectivity was too lenient — it fired whenever
externally-connected children separately shared the same external
sources OR the same external targets, instead of the canonical
fan-in/fan-out pattern where every child has the same full
(sources, targets) profile. On mixed-profile groups (entry +
exits), it incorrectly fired and collapsed the author's deliberately-
wired escape edges into a single group-level edge, hiding the intent.
When the optimisation did fire on an open group, rewriteGroupEdges
was tuned for closed groups and dropped the group's internal edges
too, leaving ELK with no internal-layout information for the children
(the visible symptom in 3.2.2 Graph View breaks when TaskGroup outputs connect internal tasks to external downstream tasks #67714).

Fix: tighten hasUniformExternalConnectivity to require the full
profile to match across externally-connected children, and add a
preserveInternal option to rewriteGroupEdges so the canonical
fan-in/fan-out path keeps internals intact.
(cherry picked from commit 55780f2)

Co-authored-by: Rahul Vats 43964496+vatsrahul1001@users.noreply.github.com
Closes: #67714

…l nodes (#67720) Open ``@task_group`` rendered with vertically-stacked internals and edges crossing the boundary whenever an internal task had a direct dependency on a node outside the group (an "escape edge" that bypassed the group's entry/exit interface). Dag execution was unaffected. Two underlying issues, both in the ELK graph-layout refactor from #65031: 1. ``hasUniformExternalConnectivity`` was too lenient — it fired whenever externally-connected children separately shared the same external sources OR the same external targets, instead of the canonical fan-in/fan-out pattern where every child has the same full ``(sources, targets)`` profile. On mixed-profile groups (entry + exits), it incorrectly fired and collapsed the author's deliberately- wired escape edges into a single group-level edge, hiding the intent. 2. When the optimisation did fire on an open group, ``rewriteGroupEdges`` was tuned for closed groups and dropped the group's internal edges too, leaving ELK with no internal-layout information for the children (the visible symptom in #67714). Fix: tighten ``hasUniformExternalConnectivity`` to require the full profile to match across externally-connected children, and add a ``preserveInternal`` option to ``rewriteGroupEdges`` so the canonical fan-in/fan-out path keeps internals intact. (cherry picked from commit 55780f2) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com> Closes: #67714

github-actions · 2026-06-01T09:51:34Z

Open @task_group rendered with vertically-stacked internals and edges
crossing the boundary whenever an internal task had a direct dependency
on a node outside the group (an "escape edge" that bypassed the group's
entry/exit interface). Dag execution was unaffected.

Two underlying issues, both in the ELK graph-layout refactor from #65031:

hasUniformExternalConnectivity was too lenient — it fired whenever
externally-connected children separately shared the same external
sources OR the same external targets, instead of the canonical
fan-in/fan-out pattern where every child has the same full
(sources, targets) profile. On mixed-profile groups (entry +
exits), it incorrectly fired and collapsed the author's deliberately-
wired escape edges into a single group-level edge, hiding the intent.
When the optimisation did fire on an open group, rewriteGroupEdges
was tuned for closed groups and dropped the group's internal edges
too, leaving ELK with no internal-layout information for the children
(the visible symptom in 3.2.2 Graph View breaks when TaskGroup outputs connect internal tasks to external downstream tasks #67714).

Fix: tighten hasUniformExternalConnectivity to require the full
profile to match across externally-connected children, and add a
preserveInternal option to rewriteGroupEdges so the canonical
fan-in/fan-out path keeps internals intact.
(cherry picked from commit 55780f2)

Co-authored-by: Rahul Vats 43964496+vatsrahul1001@users.noreply.github.com
Closes: #67714

…l nodes (#67720) Open ``@task_group`` rendered with vertically-stacked internals and edges crossing the boundary whenever an internal task had a direct dependency on a node outside the group (an "escape edge" that bypassed the group's entry/exit interface). Dag execution was unaffected. Two underlying issues, both in the ELK graph-layout refactor from #65031: 1. ``hasUniformExternalConnectivity`` was too lenient — it fired whenever externally-connected children separately shared the same external sources OR the same external targets, instead of the canonical fan-in/fan-out pattern where every child has the same full ``(sources, targets)`` profile. On mixed-profile groups (entry + exits), it incorrectly fired and collapsed the author's deliberately- wired escape edges into a single group-level edge, hiding the intent. 2. When the optimisation did fire on an open group, ``rewriteGroupEdges`` was tuned for closed groups and dropped the group's internal edges too, leaving ELK with no internal-layout information for the children (the visible symptom in #67714). Fix: tighten ``hasUniformExternalConnectivity`` to require the full profile to match across externally-connected children, and add a ``preserveInternal`` option to ``rewriteGroupEdges`` so the canonical fan-in/fan-out path keeps internals intact. (cherry picked from commit 55780f2) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com> Closes: #67714

github-actions · 2026-06-01T09:51:34Z

Open @task_group rendered with vertically-stacked internals and edges
crossing the boundary whenever an internal task had a direct dependency
on a node outside the group (an "escape edge" that bypassed the group's
entry/exit interface). Dag execution was unaffected.

Two underlying issues, both in the ELK graph-layout refactor from #65031:

hasUniformExternalConnectivity was too lenient — it fired whenever
externally-connected children separately shared the same external
sources OR the same external targets, instead of the canonical
fan-in/fan-out pattern where every child has the same full
(sources, targets) profile. On mixed-profile groups (entry +
exits), it incorrectly fired and collapsed the author's deliberately-
wired escape edges into a single group-level edge, hiding the intent.
When the optimisation did fire on an open group, rewriteGroupEdges
was tuned for closed groups and dropped the group's internal edges
too, leaving ELK with no internal-layout information for the children
(the visible symptom in 3.2.2 Graph View breaks when TaskGroup outputs connect internal tasks to external downstream tasks #67714).

Fix: tighten hasUniformExternalConnectivity to require the full
profile to match across externally-connected children, and add a
preserveInternal option to rewriteGroupEdges so the canonical
fan-in/fan-out path keeps internals intact.
(cherry picked from commit 55780f2)

Co-authored-by: Rahul Vats 43964496+vatsrahul1001@users.noreply.github.com
Closes: #67714

…l nodes (#67720) Open ``@task_group`` rendered with vertically-stacked internals and edges crossing the boundary whenever an internal task had a direct dependency on a node outside the group (an "escape edge" that bypassed the group's entry/exit interface). Dag execution was unaffected. Two underlying issues, both in the ELK graph-layout refactor from #65031: 1. ``hasUniformExternalConnectivity`` was too lenient — it fired whenever externally-connected children separately shared the same external sources OR the same external targets, instead of the canonical fan-in/fan-out pattern where every child has the same full ``(sources, targets)`` profile. On mixed-profile groups (entry + exits), it incorrectly fired and collapsed the author's deliberately- wired escape edges into a single group-level edge, hiding the intent. 2. When the optimisation did fire on an open group, ``rewriteGroupEdges`` was tuned for closed groups and dropped the group's internal edges too, leaving ELK with no internal-layout information for the children (the visible symptom in #67714). Fix: tighten ``hasUniformExternalConnectivity`` to require the full profile to match across externally-connected children, and add a ``preserveInternal`` option to ``rewriteGroupEdges`` so the canonical fan-in/fan-out path keeps internals intact. (cherry picked from commit 55780f2) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com> Closes: #67714

github-actions · 2026-06-01T09:51:34Z

Open @task_group rendered with vertically-stacked internals and edges
crossing the boundary whenever an internal task had a direct dependency
on a node outside the group (an "escape edge" that bypassed the group's
entry/exit interface). Dag execution was unaffected.

Two underlying issues, both in the ELK graph-layout refactor from #65031:

hasUniformExternalConnectivity was too lenient — it fired whenever
externally-connected children separately shared the same external
sources OR the same external targets, instead of the canonical
fan-in/fan-out pattern where every child has the same full
(sources, targets) profile. On mixed-profile groups (entry +
exits), it incorrectly fired and collapsed the author's deliberately-
wired escape edges into a single group-level edge, hiding the intent.
When the optimisation did fire on an open group, rewriteGroupEdges
was tuned for closed groups and dropped the group's internal edges
too, leaving ELK with no internal-layout information for the children
(the visible symptom in 3.2.2 Graph View breaks when TaskGroup outputs connect internal tasks to external downstream tasks #67714).

Fix: tighten hasUniformExternalConnectivity to require the full
profile to match across externally-connected children, and add a
preserveInternal option to rewriteGroupEdges so the canonical
fan-in/fan-out path keeps internals intact.
(cherry picked from commit 55780f2)

Co-authored-by: Rahul Vats 43964496+vatsrahul1001@users.noreply.github.com
Closes: #67714

…l nodes (#67720) Open ``@task_group`` rendered with vertically-stacked internals and edges crossing the boundary whenever an internal task had a direct dependency on a node outside the group (an "escape edge" that bypassed the group's entry/exit interface). Dag execution was unaffected. Two underlying issues, both in the ELK graph-layout refactor from #65031: 1. ``hasUniformExternalConnectivity`` was too lenient — it fired whenever externally-connected children separately shared the same external sources OR the same external targets, instead of the canonical fan-in/fan-out pattern where every child has the same full ``(sources, targets)`` profile. On mixed-profile groups (entry + exits), it incorrectly fired and collapsed the author's deliberately- wired escape edges into a single group-level edge, hiding the intent. 2. When the optimisation did fire on an open group, ``rewriteGroupEdges`` was tuned for closed groups and dropped the group's internal edges too, leaving ELK with no internal-layout information for the children (the visible symptom in #67714). Fix: tighten ``hasUniformExternalConnectivity`` to require the full profile to match across externally-connected children, and add a ``preserveInternal`` option to ``rewriteGroupEdges`` so the canonical fan-in/fan-out path keeps internals intact. (cherry picked from commit 55780f2) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com> Closes: #67714

github-actions · 2026-06-01T09:51:34Z

Open @task_group rendered with vertically-stacked internals and edges
crossing the boundary whenever an internal task had a direct dependency
on a node outside the group (an "escape edge" that bypassed the group's
entry/exit interface). Dag execution was unaffected.

Two underlying issues, both in the ELK graph-layout refactor from #65031:

hasUniformExternalConnectivity was too lenient — it fired whenever
externally-connected children separately shared the same external
sources OR the same external targets, instead of the canonical
fan-in/fan-out pattern where every child has the same full
(sources, targets) profile. On mixed-profile groups (entry +
exits), it incorrectly fired and collapsed the author's deliberately-
wired escape edges into a single group-level edge, hiding the intent.
When the optimisation did fire on an open group, rewriteGroupEdges
was tuned for closed groups and dropped the group's internal edges
too, leaving ELK with no internal-layout information for the children
(the visible symptom in 3.2.2 Graph View breaks when TaskGroup outputs connect internal tasks to external downstream tasks #67714).

Fix: tighten hasUniformExternalConnectivity to require the full
profile to match across externally-connected children, and add a
preserveInternal option to rewriteGroupEdges so the canonical
fan-in/fan-out path keeps internals intact.
(cherry picked from commit 55780f2)

Co-authored-by: Rahul Vats 43964496+vatsrahul1001@users.noreply.github.com
Closes: #67714

…l nodes (#67720) Open ``@task_group`` rendered with vertically-stacked internals and edges crossing the boundary whenever an internal task had a direct dependency on a node outside the group (an "escape edge" that bypassed the group's entry/exit interface). Dag execution was unaffected. Two underlying issues, both in the ELK graph-layout refactor from #65031: 1. ``hasUniformExternalConnectivity`` was too lenient — it fired whenever externally-connected children separately shared the same external sources OR the same external targets, instead of the canonical fan-in/fan-out pattern where every child has the same full ``(sources, targets)`` profile. On mixed-profile groups (entry + exits), it incorrectly fired and collapsed the author's deliberately- wired escape edges into a single group-level edge, hiding the intent. 2. When the optimisation did fire on an open group, ``rewriteGroupEdges`` was tuned for closed groups and dropped the group's internal edges too, leaving ELK with no internal-layout information for the children (the visible symptom in #67714). Fix: tighten ``hasUniformExternalConnectivity`` to require the full profile to match across externally-connected children, and add a ``preserveInternal`` option to ``rewriteGroupEdges`` so the canonical fan-in/fan-out path keeps internals intact. (cherry picked from commit 55780f2) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com> Closes: #67714

github-actions · 2026-06-01T09:51:34Z

Open @task_group rendered with vertically-stacked internals and edges
crossing the boundary whenever an internal task had a direct dependency
on a node outside the group (an "escape edge" that bypassed the group's
entry/exit interface). Dag execution was unaffected.

Two underlying issues, both in the ELK graph-layout refactor from #65031:

hasUniformExternalConnectivity was too lenient — it fired whenever
externally-connected children separately shared the same external
sources OR the same external targets, instead of the canonical
fan-in/fan-out pattern where every child has the same full
(sources, targets) profile. On mixed-profile groups (entry +
exits), it incorrectly fired and collapsed the author's deliberately-
wired escape edges into a single group-level edge, hiding the intent.
When the optimisation did fire on an open group, rewriteGroupEdges
was tuned for closed groups and dropped the group's internal edges
too, leaving ELK with no internal-layout information for the children
(the visible symptom in 3.2.2 Graph View breaks when TaskGroup outputs connect internal tasks to external downstream tasks #67714).

Fix: tighten hasUniformExternalConnectivity to require the full
profile to match across externally-connected children, and add a
preserveInternal option to rewriteGroupEdges so the canonical
fan-in/fan-out path keeps internals intact.
(cherry picked from commit 55780f2)

Co-authored-by: Rahul Vats 43964496+vatsrahul1001@users.noreply.github.com
Closes: #67714

…l nodes (#67720) Open ``@task_group`` rendered with vertically-stacked internals and edges crossing the boundary whenever an internal task had a direct dependency on a node outside the group (an "escape edge" that bypassed the group's entry/exit interface). Dag execution was unaffected. Two underlying issues, both in the ELK graph-layout refactor from #65031: 1. ``hasUniformExternalConnectivity`` was too lenient — it fired whenever externally-connected children separately shared the same external sources OR the same external targets, instead of the canonical fan-in/fan-out pattern where every child has the same full ``(sources, targets)`` profile. On mixed-profile groups (entry + exits), it incorrectly fired and collapsed the author's deliberately- wired escape edges into a single group-level edge, hiding the intent. 2. When the optimisation did fire on an open group, ``rewriteGroupEdges`` was tuned for closed groups and dropped the group's internal edges too, leaving ELK with no internal-layout information for the children (the visible symptom in #67714). Fix: tighten ``hasUniformExternalConnectivity`` to require the full profile to match across externally-connected children, and add a ``preserveInternal`` option to ``rewriteGroupEdges`` so the canonical fan-in/fan-out path keeps internals intact. (cherry picked from commit 55780f2) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com> Closes: #67714

github-actions · 2026-06-01T09:51:34Z

Open @task_group rendered with vertically-stacked internals and edges
crossing the boundary whenever an internal task had a direct dependency
on a node outside the group (an "escape edge" that bypassed the group's
entry/exit interface). Dag execution was unaffected.

Two underlying issues, both in the ELK graph-layout refactor from #65031:

hasUniformExternalConnectivity was too lenient — it fired whenever
externally-connected children separately shared the same external
sources OR the same external targets, instead of the canonical
fan-in/fan-out pattern where every child has the same full
(sources, targets) profile. On mixed-profile groups (entry +
exits), it incorrectly fired and collapsed the author's deliberately-
wired escape edges into a single group-level edge, hiding the intent.
When the optimisation did fire on an open group, rewriteGroupEdges
was tuned for closed groups and dropped the group's internal edges
too, leaving ELK with no internal-layout information for the children
(the visible symptom in 3.2.2 Graph View breaks when TaskGroup outputs connect internal tasks to external downstream tasks #67714).

Fix: tighten hasUniformExternalConnectivity to require the full
profile to match across externally-connected children, and add a
preserveInternal option to rewriteGroupEdges so the canonical
fan-in/fan-out path keeps internals intact.
(cherry picked from commit 55780f2)

Co-authored-by: Rahul Vats 43964496+vatsrahul1001@users.noreply.github.com
Closes: #67714

…l nodes (#67720) Open ``@task_group`` rendered with vertically-stacked internals and edges crossing the boundary whenever an internal task had a direct dependency on a node outside the group (an "escape edge" that bypassed the group's entry/exit interface). Dag execution was unaffected. Two underlying issues, both in the ELK graph-layout refactor from #65031: 1. ``hasUniformExternalConnectivity`` was too lenient — it fired whenever externally-connected children separately shared the same external sources OR the same external targets, instead of the canonical fan-in/fan-out pattern where every child has the same full ``(sources, targets)`` profile. On mixed-profile groups (entry + exits), it incorrectly fired and collapsed the author's deliberately- wired escape edges into a single group-level edge, hiding the intent. 2. When the optimisation did fire on an open group, ``rewriteGroupEdges`` was tuned for closed groups and dropped the group's internal edges too, leaving ELK with no internal-layout information for the children (the visible symptom in #67714). Fix: tighten ``hasUniformExternalConnectivity`` to require the full profile to match across externally-connected children, and add a ``preserveInternal`` option to ``rewriteGroupEdges`` so the canonical fan-in/fan-out path keeps internals intact. (cherry picked from commit 55780f2) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com> Closes: #67714

github-actionsBot mentioned this pull request Jun 1, 2026
UI: Fix Graph layout for TaskGroup tasks wired to external nodes #67720
Merged
1 task

boring-cyborgBot added the area:UI Related to UI/UX. For Frontend Developers. label Jun 1, 2026

pierrejeambrun marked this pull request as ready for review June 1, 2026 09:52

pierrejeambrun requested review from bbovenzi, choo121600, guan404ming, pierrejeambrun, ryanahamilton, shubhamraj-git and vatsrahul1001 as code owners June 1, 2026 09:52

vatsrahul1001 approved these changes Jun 1, 2026
View reviewed changes

pierrejeambrun merged commit 0fa7da1 into v3-2-testJun 1, 2026
212 of 214 checks passed

pierrejeambrun deleted the backport-55780f2-v3-2-test branch June 1, 2026 12:55