Skip to content

Align Trigger DAG params in grid layout#67905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Codingaditya17 wants to merge 1 commit into from
Closed

Align Trigger DAG params in grid layout #67905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldRow.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import { Field, Stack } from "@chakra-ui/react";
import { Field, Grid, Stack } from "@chakra-ui/react";
import { useState } from "react";
import { useTranslation } from "react-i18next";

Expand DownExpand Up@@ -58,25 +58,25 @@ export const FieldRow = ({
};

return (
<Field.Root invalid={!isValid} orientation="horizontal" required={isRequired(param)}>
<Stack>
<Field.Label fontSize="md" style={{ flexBasis: "30%" }}>
<Field.Root invalid={!isValid} required={isRequired(param)}>
<Grid alignItems="start" gap={4} templateColumns={{ base: "1fr", md: "minmax(0, 30%) minmax(0, 70%)" }}>
<Field.Label fontSize="md" minWidth={0} overflowWrap="anywhere">
{param.schema.title ?? name} <Field.RequiredIndicator />
</Field.Label>
</Stack>
<Stack css={{ flexBasis: "70%" }}>
<FieldSelector name={name} namespace={namespace} onUpdate={onUpdate} />
{param.description === null ? (
param.schema.description_md === undefined ? undefined : (
<Field.HelperText>
<ReactMarkdown>{param.schema.description_md}</ReactMarkdown>
</Field.HelperText>
)
) : (
<Field.HelperText>{param.description}</Field.HelperText>
)}
{isValid ? undefined : <Field.ErrorText>{String(error)}</Field.ErrorText>}
</Stack>
<Stack minWidth={0}>
<FieldSelector name={name} namespace={namespace} onUpdate={onUpdate} />
{param.description === null ? (
param.schema.description_md === undefined ? undefined : (
<Field.HelperText>
<ReactMarkdown>{param.schema.description_md}</ReactMarkdown>
</Field.HelperText>
)
) : (
<Field.HelperText>{param.description}</Field.HelperText>
)}
{isValid ? undefined : <Field.ErrorText>{String(error)}</Field.ErrorText>}
</Stack>
</Grid>
</Field.Root>
);
};
Loading