fix: guard the to.finish stats emission

[TimotheBarbe]

Description

Fix UnboundLocalError: cannot access local variable 'state' where it is not associated with a value

related: #63089

When an except handler in run() raises before binding state (e.g. _handle_trigger_dag_run re-raising a 404 for a missing target DAG), the finally block dereferenced the unbound state, raising UnboundLocalError and hiding the original error. Default state to None and guard the ti.finish stats emission so the real exception propagates

---

Was generative AI tooling used to co-author this PR?

• Yes (please specify the tool below)

draft [Claude] following the guidelines

---

• Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
• For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
• When adding dependency, check compliance with the ASF 3rd Party License Policy.
• For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[jscheffl]

Ups, static checks fail. Can you run prek run -a mypy-task-sdk and fix the issue?

[TimotheBarbe]

@jscheffl thanks, it's done

[Copilot]

Pull request overview

This PR fixes an exception-masking bug in the Task SDK task runner where the finally block could raise UnboundLocalError when state was never bound due to an exception raised inside an except handler, obscuring the original failure (e.g. TriggerDagRun paths).

Changes:

• Default state to None in run() and guard ti.finish stats emission on state being set.
• Avoid dereferencing state.value in the “failed to report terminal state” log path when state is unset.
• Add a regression test ensuring the original exception is re-raised (not masked by UnboundLocalError).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
task-sdk/src/airflow/sdk/execution_time/task_runner.py	Makes run() resilient to unset state in finally to prevent masking the original exception.
task-sdk/tests/task_sdk/execution_time/test_task_runner.py	Adds a regression test for the “exception handler raises before binding state” scenario.

Comments suppressed due to low confidence (1)

task-sdk/src/airflow/sdk/execution_time/task_runner.py:1554

• state is now annotated as TaskInstanceState | None, but the function still returns tuple[TaskInstanceState, ...]. This will likely fail mypy because return state, msg, error is returning an Optional. Add an assert state is not None just before assigning/returning state to keep the runtime behavior unchanged while satisfying the type checker.

 state=state.value if state is not None else None,
)
# Fail closed for FAILED / UP_FOR_RETRY: when the supervisor
# never receives the terminal-state message, exiting 0 would
# let the supervisor's final_state property default to

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[github-actions]

Backport failed to create: v3-2-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
❌	v3-2-test

You can attempt to backport this manually by running:

cherry_picker 7e55559 v3-2-test

This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

[TimotheBarbe]

Description

Fix UnboundLocalError: cannot access local variable 'state' where it is not associated with a value

related: #63089

When an except handler in run() raises before binding state (e.g. _handle_trigger_dag_run re-raising a 404 for a missing target DAG), the finally block dereferenced the unbound state, raising UnboundLocalError and hiding the original error. Default state to None and guard the ti.finish stats emission so the real exception propagates

---

Was generative AI tooling used to co-author this PR?

• Yes (please specify the tool below)

draft [Claude] following the guidelines

---

• Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
• For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
• When adding dependency, check compliance with the ASF 3rd Party License Policy.
• For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[jscheffl]

Ups, static checks fail. Can you run prek run -a mypy-task-sdk and fix the issue?

[TimotheBarbe]

@jscheffl thanks, it's done

[Copilot]

Pull request overview

This PR fixes an exception-masking bug in the Task SDK task runner where the finally block could raise UnboundLocalError when state was never bound due to an exception raised inside an except handler, obscuring the original failure (e.g. TriggerDagRun paths).

Changes:

• Default state to None in run() and guard ti.finish stats emission on state being set.
• Avoid dereferencing state.value in the “failed to report terminal state” log path when state is unset.
• Add a regression test ensuring the original exception is re-raised (not masked by UnboundLocalError).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
task-sdk/src/airflow/sdk/execution_time/task_runner.py	Makes run() resilient to unset state in finally to prevent masking the original exception.
task-sdk/tests/task_sdk/execution_time/test_task_runner.py	Adds a regression test for the “exception handler raises before binding state” scenario.

Comments suppressed due to low confidence (1)

task-sdk/src/airflow/sdk/execution_time/task_runner.py:1554

• state is now annotated as TaskInstanceState | None, but the function still returns tuple[TaskInstanceState, ...]. This will likely fail mypy because return state, msg, error is returning an Optional. Add an assert state is not None just before assigning/returning state to keep the runtime behavior unchanged while satisfying the type checker.

 state=state.value if state is not None else None,
)
# Fail closed for FAILED / UP_FOR_RETRY: when the supervisor
# never receives the terminal-state message, exiting 0 would
# let the supervisor's final_state property default to

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[github-actions]

Backport failed to create: v3-2-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
❌	v3-2-test

You can attempt to backport this manually by running:

cherry_picker 7e55559 v3-2-test

This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

[TimotheBarbe]

Description

Fix UnboundLocalError: cannot access local variable 'state' where it is not associated with a value

related: #63089

When an except handler in run() raises before binding state (e.g. _handle_trigger_dag_run re-raising a 404 for a missing target DAG), the finally block dereferenced the unbound state, raising UnboundLocalError and hiding the original error. Default state to None and guard the ti.finish stats emission so the real exception propagates

---

Was generative AI tooling used to co-author this PR?

• Yes (please specify the tool below)

draft [Claude] following the guidelines

---

• Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
• For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
• When adding dependency, check compliance with the ASF 3rd Party License Policy.
• For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[jscheffl]

Ups, static checks fail. Can you run prek run -a mypy-task-sdk and fix the issue?

[TimotheBarbe]

@jscheffl thanks, it's done

[Copilot]

Pull request overview

This PR fixes an exception-masking bug in the Task SDK task runner where the finally block could raise UnboundLocalError when state was never bound due to an exception raised inside an except handler, obscuring the original failure (e.g. TriggerDagRun paths).

Changes:

• Default state to None in run() and guard ti.finish stats emission on state being set.
• Avoid dereferencing state.value in the “failed to report terminal state” log path when state is unset.
• Add a regression test ensuring the original exception is re-raised (not masked by UnboundLocalError).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
task-sdk/src/airflow/sdk/execution_time/task_runner.py	Makes run() resilient to unset state in finally to prevent masking the original exception.
task-sdk/tests/task_sdk/execution_time/test_task_runner.py	Adds a regression test for the “exception handler raises before binding state” scenario.

Comments suppressed due to low confidence (1)

task-sdk/src/airflow/sdk/execution_time/task_runner.py:1554

• state is now annotated as TaskInstanceState | None, but the function still returns tuple[TaskInstanceState, ...]. This will likely fail mypy because return state, msg, error is returning an Optional. Add an assert state is not None just before assigning/returning state to keep the runtime behavior unchanged while satisfying the type checker.

 state=state.value if state is not None else None,
)
# Fail closed for FAILED / UP_FOR_RETRY: when the supervisor
# never receives the terminal-state message, exiting 0 would
# let the supervisor's final_state property default to

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[github-actions]

Backport failed to create: v3-2-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
❌	v3-2-test

You can attempt to backport this manually by running:

cherry_picker 7e55559 v3-2-test

This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

[TimotheBarbe]

Description

Fix UnboundLocalError: cannot access local variable 'state' where it is not associated with a value

related: #63089

When an except handler in run() raises before binding state (e.g. _handle_trigger_dag_run re-raising a 404 for a missing target DAG), the finally block dereferenced the unbound state, raising UnboundLocalError and hiding the original error. Default state to None and guard the ti.finish stats emission so the real exception propagates

---

Was generative AI tooling used to co-author this PR?

• Yes (please specify the tool below)

draft [Claude] following the guidelines

---

• Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
• For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
• When adding dependency, check compliance with the ASF 3rd Party License Policy.
• For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[jscheffl]

Ups, static checks fail. Can you run prek run -a mypy-task-sdk and fix the issue?

[TimotheBarbe]

@jscheffl thanks, it's done

[Copilot]

Pull request overview

This PR fixes an exception-masking bug in the Task SDK task runner where the finally block could raise UnboundLocalError when state was never bound due to an exception raised inside an except handler, obscuring the original failure (e.g. TriggerDagRun paths).

Changes:

• Default state to None in run() and guard ti.finish stats emission on state being set.
• Avoid dereferencing state.value in the “failed to report terminal state” log path when state is unset.
• Add a regression test ensuring the original exception is re-raised (not masked by UnboundLocalError).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
task-sdk/src/airflow/sdk/execution_time/task_runner.py	Makes run() resilient to unset state in finally to prevent masking the original exception.
task-sdk/tests/task_sdk/execution_time/test_task_runner.py	Adds a regression test for the “exception handler raises before binding state” scenario.

Comments suppressed due to low confidence (1)

task-sdk/src/airflow/sdk/execution_time/task_runner.py:1554

• state is now annotated as TaskInstanceState | None, but the function still returns tuple[TaskInstanceState, ...]. This will likely fail mypy because return state, msg, error is returning an Optional. Add an assert state is not None just before assigning/returning state to keep the runtime behavior unchanged while satisfying the type checker.

 state=state.value if state is not None else None,
)
# Fail closed for FAILED / UP_FOR_RETRY: when the supervisor
# never receives the terminal-state message, exiting 0 would
# let the supervisor's final_state property default to

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[github-actions]

Backport failed to create: v3-2-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
❌	v3-2-test

You can attempt to backport this manually by running:

cherry_picker 7e55559 v3-2-test

This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

[TimotheBarbe]

Description

Fix UnboundLocalError: cannot access local variable 'state' where it is not associated with a value

related: #63089

When an except handler in run() raises before binding state (e.g. _handle_trigger_dag_run re-raising a 404 for a missing target DAG), the finally block dereferenced the unbound state, raising UnboundLocalError and hiding the original error. Default state to None and guard the ti.finish stats emission so the real exception propagates

---

Was generative AI tooling used to co-author this PR?

• Yes (please specify the tool below)

draft [Claude] following the guidelines

---

• Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
• For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
• When adding dependency, check compliance with the ASF 3rd Party License Policy.
• For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[jscheffl]

Ups, static checks fail. Can you run prek run -a mypy-task-sdk and fix the issue?

[TimotheBarbe]

@jscheffl thanks, it's done

[Copilot]

Pull request overview

This PR fixes an exception-masking bug in the Task SDK task runner where the finally block could raise UnboundLocalError when state was never bound due to an exception raised inside an except handler, obscuring the original failure (e.g. TriggerDagRun paths).

Changes:

• Default state to None in run() and guard ti.finish stats emission on state being set.
• Avoid dereferencing state.value in the “failed to report terminal state” log path when state is unset.
• Add a regression test ensuring the original exception is re-raised (not masked by UnboundLocalError).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
task-sdk/src/airflow/sdk/execution_time/task_runner.py	Makes run() resilient to unset state in finally to prevent masking the original exception.
task-sdk/tests/task_sdk/execution_time/test_task_runner.py	Adds a regression test for the “exception handler raises before binding state” scenario.

Comments suppressed due to low confidence (1)

task-sdk/src/airflow/sdk/execution_time/task_runner.py:1554

• state is now annotated as TaskInstanceState | None, but the function still returns tuple[TaskInstanceState, ...]. This will likely fail mypy because return state, msg, error is returning an Optional. Add an assert state is not None just before assigning/returning state to keep the runtime behavior unchanged while satisfying the type checker.

 state=state.value if state is not None else None,
)
# Fail closed for FAILED / UP_FOR_RETRY: when the supervisor
# never receives the terminal-state message, exiting 0 would
# let the supervisor's final_state property default to

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[github-actions]

Backport failed to create: v3-2-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
❌	v3-2-test

You can attempt to backport this manually by running:

cherry_picker 7e55559 v3-2-test

This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

[TimotheBarbe]

Description

Fix UnboundLocalError: cannot access local variable 'state' where it is not associated with a value

related: #63089

When an except handler in run() raises before binding state (e.g. _handle_trigger_dag_run re-raising a 404 for a missing target DAG), the finally block dereferenced the unbound state, raising UnboundLocalError and hiding the original error. Default state to None and guard the ti.finish stats emission so the real exception propagates

---

Was generative AI tooling used to co-author this PR?

• Yes (please specify the tool below)

draft [Claude] following the guidelines

---

• Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
• For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
• When adding dependency, check compliance with the ASF 3rd Party License Policy.
• For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[jscheffl]

Ups, static checks fail. Can you run prek run -a mypy-task-sdk and fix the issue?

[TimotheBarbe]

@jscheffl thanks, it's done

[Copilot]

Pull request overview

This PR fixes an exception-masking bug in the Task SDK task runner where the finally block could raise UnboundLocalError when state was never bound due to an exception raised inside an except handler, obscuring the original failure (e.g. TriggerDagRun paths).

Changes:

• Default state to None in run() and guard ti.finish stats emission on state being set.
• Avoid dereferencing state.value in the “failed to report terminal state” log path when state is unset.
• Add a regression test ensuring the original exception is re-raised (not masked by UnboundLocalError).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
task-sdk/src/airflow/sdk/execution_time/task_runner.py	Makes run() resilient to unset state in finally to prevent masking the original exception.
task-sdk/tests/task_sdk/execution_time/test_task_runner.py	Adds a regression test for the “exception handler raises before binding state” scenario.

Comments suppressed due to low confidence (1)

task-sdk/src/airflow/sdk/execution_time/task_runner.py:1554

• state is now annotated as TaskInstanceState | None, but the function still returns tuple[TaskInstanceState, ...]. This will likely fail mypy because return state, msg, error is returning an Optional. Add an assert state is not None just before assigning/returning state to keep the runtime behavior unchanged while satisfying the type checker.

 state=state.value if state is not None else None,
)
# Fail closed for FAILED / UP_FOR_RETRY: when the supervisor
# never receives the terminal-state message, exiting 0 would
# let the supervisor's final_state property default to

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[github-actions]

Backport failed to create: v3-2-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
❌	v3-2-test

You can attempt to backport this manually by running:

cherry_picker 7e55559 v3-2-test

This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

[TimotheBarbe]

Description

Fix UnboundLocalError: cannot access local variable 'state' where it is not associated with a value

related: #63089

When an except handler in run() raises before binding state (e.g. _handle_trigger_dag_run re-raising a 404 for a missing target DAG), the finally block dereferenced the unbound state, raising UnboundLocalError and hiding the original error. Default state to None and guard the ti.finish stats emission so the real exception propagates

---

Was generative AI tooling used to co-author this PR?

• Yes (please specify the tool below)

draft [Claude] following the guidelines

---

• Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
• For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
• When adding dependency, check compliance with the ASF 3rd Party License Policy.
• For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[jscheffl]

Ups, static checks fail. Can you run prek run -a mypy-task-sdk and fix the issue?

[TimotheBarbe]

@jscheffl thanks, it's done

[Copilot]

Pull request overview

This PR fixes an exception-masking bug in the Task SDK task runner where the finally block could raise UnboundLocalError when state was never bound due to an exception raised inside an except handler, obscuring the original failure (e.g. TriggerDagRun paths).

Changes:

• Default state to None in run() and guard ti.finish stats emission on state being set.
• Avoid dereferencing state.value in the “failed to report terminal state” log path when state is unset.
• Add a regression test ensuring the original exception is re-raised (not masked by UnboundLocalError).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
task-sdk/src/airflow/sdk/execution_time/task_runner.py	Makes run() resilient to unset state in finally to prevent masking the original exception.
task-sdk/tests/task_sdk/execution_time/test_task_runner.py	Adds a regression test for the “exception handler raises before binding state” scenario.

Comments suppressed due to low confidence (1)

task-sdk/src/airflow/sdk/execution_time/task_runner.py:1554

• state is now annotated as TaskInstanceState | None, but the function still returns tuple[TaskInstanceState, ...]. This will likely fail mypy because return state, msg, error is returning an Optional. Add an assert state is not None just before assigning/returning state to keep the runtime behavior unchanged while satisfying the type checker.

 state=state.value if state is not None else None,
)
# Fail closed for FAILED / UP_FOR_RETRY: when the supervisor
# never receives the terminal-state message, exiting 0 would
# let the supervisor's final_state property default to

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[github-actions]

Backport failed to create: v3-2-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
❌	v3-2-test

You can attempt to backport this manually by running:

cherry_picker 7e55559 v3-2-test

This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

[TimotheBarbe]

Description

Fix UnboundLocalError: cannot access local variable 'state' where it is not associated with a value

related: #63089

When an except handler in run() raises before binding state (e.g. _handle_trigger_dag_run re-raising a 404 for a missing target DAG), the finally block dereferenced the unbound state, raising UnboundLocalError and hiding the original error. Default state to None and guard the ti.finish stats emission so the real exception propagates

---

Was generative AI tooling used to co-author this PR?

• Yes (please specify the tool below)

draft [Claude] following the guidelines

---

• Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
• For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
• When adding dependency, check compliance with the ASF 3rd Party License Policy.
• For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[jscheffl]

Ups, static checks fail. Can you run prek run -a mypy-task-sdk and fix the issue?

[TimotheBarbe]

@jscheffl thanks, it's done

[Copilot]

Pull request overview

This PR fixes an exception-masking bug in the Task SDK task runner where the finally block could raise UnboundLocalError when state was never bound due to an exception raised inside an except handler, obscuring the original failure (e.g. TriggerDagRun paths).

Changes:

• Default state to None in run() and guard ti.finish stats emission on state being set.
• Avoid dereferencing state.value in the “failed to report terminal state” log path when state is unset.
• Add a regression test ensuring the original exception is re-raised (not masked by UnboundLocalError).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
task-sdk/src/airflow/sdk/execution_time/task_runner.py	Makes run() resilient to unset state in finally to prevent masking the original exception.
task-sdk/tests/task_sdk/execution_time/test_task_runner.py	Adds a regression test for the “exception handler raises before binding state” scenario.

Comments suppressed due to low confidence (1)

task-sdk/src/airflow/sdk/execution_time/task_runner.py:1554

• state is now annotated as TaskInstanceState | None, but the function still returns tuple[TaskInstanceState, ...]. This will likely fail mypy because return state, msg, error is returning an Optional. Add an assert state is not None just before assigning/returning state to keep the runtime behavior unchanged while satisfying the type checker.

 state=state.value if state is not None else None,
)
# Fail closed for FAILED / UP_FOR_RETRY: when the supervisor
# never receives the terminal-state message, exiting 0 would
# let the supervisor's final_state property default to

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[github-actions]

Backport failed to create: v3-2-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status	Branch	Result
❌	v3-2-test

You can attempt to backport this manually by running:

cherry_picker 7e55559 v3-2-test

This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.